Re: r329300 - Disable -fmerge-all-constants as default.

2018-04-05 Thread Richard Smith via cfe-commits
MipsFastISel::fastLowerArguments looks very broken and is likely the culprit here: const ArrayRef GPR32ArgRegs = {Mips::A0, Mips::A1, Mips::A2, Mips::A3}; const ArrayRef FGR32ArgRegs = {Mips::F12, Mips::F14}; const ArrayRef AFGR64ArgRegs = {Mips::D

Re: r329300 - Disable -fmerge-all-constants as default.

2018-04-05 Thread Manoj Gupta via cfe-commits
Thanks Richard, I was wondering how a Clang change can break the Backend tests given that the tests are all pre-checked IR files. Failing Tests (7): LLVM :: CodeGen/Mips/Fast-ISel/fastalloca.ll LLVM :: CodeGen/Mips/Fast-ISel/fastcc-miss.ll LLVM :: CodeGen/Mips/Fast-ISel/memtest1.ll

r329352 - Add a couple more tests for DR372.

2018-04-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Thu Apr 5 14:49:20 2018 New Revision: 329352 URL: http://llvm.org/viewvc/llvm-project?rev=329352&view=rev Log: Add a couple more tests for DR372. Modified: cfe/trunk/test/CXX/drs/dr3xx.cpp Modified: cfe/trunk/test/CXX/drs/dr3xx.cpp URL: http://llvm.org/viewvc/llvm-proj

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

2018-04-05 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:3250-3251 - mangleType(T->getBaseType()); + for (auto Ty : T->getArgs()) +mangleType(Ty); } EricWF wrote: > rsmith wrote: > > We need manglings to be self-delimiting, and we can't tell w

r329357 - [Sema] Revert r329346 because of memory sanitizer failures.

2018-04-05 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Thu Apr 5 15:15:42 2018 New Revision: 329357 URL: http://llvm.org/viewvc/llvm-project?rev=329357&view=rev Log: [Sema] Revert r329346 because of memory sanitizer failures. Modified: cfe/trunk/include/clang/Sema/DeclSpec.h cfe/trunk/include/clang/Sema/SemaFixItU

r329361 - Fix test added in r329301 to work properly with Windows paths.

2018-04-05 Thread Douglas Yung via cfe-commits
Author: dyung Date: Thu Apr 5 15:58:14 2018 New Revision: 329361 URL: http://llvm.org/viewvc/llvm-project?rev=329361&view=rev Log: Fix test added in r329301 to work properly with Windows paths. Modified: cfe/trunk/test/ASTMerge/struct/test.c Modified: cfe/trunk/test/ASTMerge/struct/test.c U

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

2018-04-05 Thread Eli Friedman via Phabricator via cfe-commits
efriedma updated this revision to Diff 141237. efriedma added a comment. Compute arch used passed-in CPU, not the global arch. Repository: rC Clang https://reviews.llvm.org/D45240 Files: lib/Basic/Targets/ARM.cpp test/CodeGen/arm-long-calls.c test/CodeGen/arm-no-movt.c test/CodeGen/a

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

2018-04-05 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D40983#1059087, @arphaman wrote: > In https://reviews.llvm.org/D40983#968796, @bruno wrote: > > > Makes sense, LGTM. > > > > Should we add documentation explaining how to use this? I'm fine if it > > comes in a follow up commit. > > > Sorry,

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

2018-04-05 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D40983#968796, @bruno wrote: > Makes sense, LGTM. > > Should we add documentation explaining how to use this? I'm fine if it comes > in a follow up commit. Sorry, just got time to get back to this now. Thanks for the review! I'll add a doc

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

2018-04-05 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 141248. saar.raz added a comment. Adjusted to piecewise substitution. - Constraint satisfaction will no longer happen for depenent CSEs (was originally needed for normalization, but not worth the trouble with the new piecewise substitution and the fact tha

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

2018-04-05 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC329366: CMake option to allow enabling experimental new pass manager by default (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44330?vs=137844&id=141249#toc Rep

r329366 - CMake option to allow enabling experimental new pass manager by default

2018-04-05 Thread Petr Hosek via cfe-commits
Author: phosek Date: Thu Apr 5 17:53:00 2018 New Revision: 329366 URL: http://llvm.org/viewvc/llvm-project?rev=329366&view=rev Log: CMake option to allow enabling experimental new pass manager by default This CMake flag allows setting the default value for the -f[no]-experimental-new-pass-manage

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

2018-04-05 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. I think the tests are already broken in Gentoo when clang is installed in /usr/bin even without this patch. The tests only work if clang binary is not installed in /usr/bin. RootCause is the existing lines in Gnu.cpp: // Then look for gcc installed alongs

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

2018-04-05 Thread Eli Friedman via Phabricator via cfe-commits
efriedma updated this revision to Diff 141255. efriedma added a comment. Get rid of the test changes. They were broken in multiple ways, and weren't really useful anyway because the targets where you would want to use this can't run the libcxx testsuite anyway (because they don't have an operat

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

2018-04-05 Thread Weiming Zhao via Phabricator via cfe-commits
weimingz added a comment. Thanks Eli! Repository: rCXX libc++ https://reviews.llvm.org/D41316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-05 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris updated this revision to Diff 141265. dberris added a comment. - fixup: Rebase, and re-do OpenBSD specific changes https://reviews.llvm.org/D45243 Files: clang/include/clang/Driver/XRayArgs.h clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h cla

r329372 - [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-05 Thread Dean Michael Berris via cfe-commits
Author: dberris Date: Thu Apr 5 20:53:04 2018 New Revision: 329372 URL: http://llvm.org/viewvc/llvm-project?rev=329372&view=rev Log: [XRay][clang] Consolidate runtime and link-time flag processing (NFC) Summary: This change fixes http://llvm.org/PR36985 to define a single place in CommonArgs.{h,

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-05 Thread Dean Michael Berris via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329372: [XRay][clang] Consolidate runtime and link-time flag processing (NFC) (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[PATCH] D45354: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

2018-04-05 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris created this revision. dberris added reviewers: eizan, echristo, chandlerc. This change introduces `-fxray-link-deps` and `-fnoxray-link-deps`. The `-fnoxray-link-deps` allows for directly controlling which specific XRay runtime to link. The default is for clang to link the XRay runtime th

[libcxx] r329375 - Mark as "In progress"

2018-04-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Thu Apr 5 21:43:27 2018 New Revision: 329375 URL: http://llvm.org/viewvc/llvm-project?rev=329375&view=rev Log: Mark as "In progress" Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.org/viewvc/llvm-project/l

r329376 - [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

2018-04-05 Thread Dean Michael Berris via cfe-commits
Author: dberris Date: Thu Apr 5 22:28:54 2018 New Revision: 329376 URL: http://llvm.org/viewvc/llvm-project?rev=329376&view=rev Log: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly Summary: This change introduces `-fxray-link-deps` and `-fnoxray-link-deps`. The `-fnoxray-

[PATCH] D45354: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

2018-04-05 Thread Dean Michael Berris via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329376: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r329378 - [XRay][clang] Only run driver test for Linux and FreeBSD

2018-04-05 Thread Dean Michael Berris via cfe-commits
Author: dberris Date: Thu Apr 5 23:09:57 2018 New Revision: 329378 URL: http://llvm.org/viewvc/llvm-project?rev=329378&view=rev Log: [XRay][clang] Only run driver test for Linux and FreeBSD This is a follow-up to D45354, which we should have only been running on Linux and FreeBSD for specific ta

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

2018-04-05 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Please read: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options In this case in particular, I would be very interested in a style guide that defines how Allman brace style and lambdas work together. IMO, it has so many corner ca

<    1   2