[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

2018-04-04 Thread Michał Górny via Phabricator via cfe-commits
mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: lib/Driver/ToolChains/Gnu.cpp:2284 +// Test the path based on the version in /etc/env.d/gcc/config-{tuple}. +GentooScanPaths.push_ba

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

2018-04-04 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Agree, this is a real mess. This change looks good to me. Was only wondering, we are only testing target features +v7 and +v8, but do we now also need to check the others, like +v

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Do the unit tests have same outcome with these changes ? Otherwise, appreciate the simplification. https://reviews.llvm.org/D45243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D45056: [X86] Split up -march=icelake to -client & -server

2018-04-04 Thread Gabor Buella via Phabricator via cfe-commits
GBuella updated this revision to Diff 140911. GBuella added a comment. Fixed the arch macro tests. https://reviews.llvm.org/D45056 Files: include/clang/Basic/X86Target.def lib/Basic/Targets/X86.cpp test/Driver/x86-march.c test/Frontend/x86-target-cpu.c test/Misc/target-invalid-cpu-not

[PATCH] D44727: [RISCV] Extend getTargetDefines for RISCVTargetInfo

2018-04-04 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added a comment. Hi Eli: Thanks your advise, I've checked those marco are match with GCC :) Repository: rC Clang https://reviews.llvm.org/D44727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D44727: [RISCV] Extend getTargetDefines for RISCVTargetInfo

2018-04-04 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng updated this revision to Diff 140913. kito-cheng added a comment. Changes: - Add testcase for TargetFeature: riscv, riscv32 and riscv64 Repository: rC Clang https://reviews.llvm.org/D44727 Files: lib/Basic/Targets/RISCV.cpp lib/Basic/Targets/RISCV.h test/Modules/Inputs/modu

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

2018-04-04 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. Ping. Repository: rCXX libc++ https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

2018-04-04 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I would modify the comment to mention that LLVM's configuration may already be adding `libatomic` Repository: rCXX libc++ https://reviews.llvm.org/D43509

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

2018-04-04 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang https://reviews.llvm.org/D42034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

2018-04-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a reviewer: rengolin. fhahn added a comment. Thanks for looking into this Eli! Adding the architecture version as target feature looks good to me. Comment at: lib/Basic/Targets/ARM.cpp:342 + // rely on the target triple. + switch (ArchKind) { + case llvm::ARM::A

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/experimental/coroutine:288 + +coroutine_handle() { + this->__handle_ = __builtin_coro_noop(); Can `__builtin_coro_noop` produce a constant expression? https://reviews.llvm.org/D45121

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

2018-04-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. We also add thumb-mode to the target features, for a similar reason, allowing mixed Thumb/Arm codegen with LTO. Repository: rC Clang https://reviews.llvm.org/D45240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

r329161 - As we don't use minor version anymore, let's remove it from the release notes too

2018-04-04 Thread Sylvestre Ledru via cfe-commits
Author: sylvestre Date: Wed Apr 4 02:38:22 2018 New Revision: 329161 URL: http://llvm.org/viewvc/llvm-project?rev=329161&view=rev Log: As we don't use minor version anymore, let's remove it from the release notes too Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/Releas

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

2018-04-04 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:412 +llvm::raw_string_ostream OS(Message); +OS << "method not found (" << Method << ")"; +replyError(ErrorCode::MethodNotFound, OS.str()); simark wrote: > simark wrote: > > il

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

2018-04-04 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:96 +// Sort input for determinism (index is used as a tiebreaker). +llvm::sort(OriginalPaths.begin(), OriginalPaths.end()); +for (size_t I = 0; I < Filenames.size(); ++I)

[libcxx] r329167 - [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

2018-04-04 Thread Simon Dardis via cfe-commits
Author: sdardis Date: Wed Apr 4 04:05:03 2018 New Revision: 329167 URL: http://llvm.org/viewvc/llvm-project?rev=329167&view=rev Log: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring When libcxx is built in tree for a host which requires libatomic, LLVM

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

2018-04-04 Thread Simon Dardis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329167: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when… (authored by sdardis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

2018-04-04 Thread Simon Dardis via Phabricator via cfe-commits
sdardis added a comment. Thanks for the review. Repository: rL LLVM https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44921: [PowerPC] Option for secure plt mode

2018-04-04 Thread Strahinja Petrovic via Phabricator via cfe-commits
spetrovic added a comment. -mbss-plt is currently default in LLVM, once secure plt support is finished we can set secure plt as default in LLVM, but not for now. https://reviews.llvm.org/D44921 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

2018-04-04 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 140934. lebedev.ri added a comment. Based on IRC disscussion, try to update the patch. The main problem is that gcc does not silence the warning produced by these attributes via `(void)` cast, unless it's `[[nodiscard]]` attribute :/ https://godbolt.org/g/

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

2018-04-04 Thread Tomasz Krupa via Phabricator via cfe-commits
tkrupa marked 4 inline comments as done. tkrupa added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8901 } - + case X86::BI__builtin_ia32_sqrtsd_round_mask: + case X86::BI__builtin_ia32_sqrtss_round_mask: { craig.topper wrote: > What about __builtin

r329170 - Make helpers static. NFC.

2018-04-04 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Wed Apr 4 04:45:11 2018 New Revision: 329170 URL: http://llvm.org/viewvc/llvm-project?rev=329170&view=rev Log: Make helpers static. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp cfe/trunk/lib/StaticAnalyzer/Core/WorkList.cpp Modified: cfe/tru

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

2018-04-04 Thread Tomasz Krupa via Phabricator via cfe-commits
tkrupa updated this revision to Diff 140937. tkrupa added a comment. I did the suggested corrections and improved the tests. Repository: rC Clang https://reviews.llvm.org/D41168 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-builtins.c test/CodeGen/avx512f-builtins.c test/CodeGen/

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-04 Thread Gabor Buella via Phabricator via cfe-commits
GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45254 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

2018-04-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 140941. sammccall marked 3 inline comments as done. sammccall added a comment. Address comments, except cross-language flag transfer which needs more thought. Repository: rC Clang https://reviews.llvm.org/D45006 Files: include/clang/Tooling/Compilati

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

2018-04-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: lib/Tooling/InterpolatingCompilationDatabase.cpp:308 + llvm::sys::path::extension(Filename).substr(1)); + if (OldLang && NewLang != OldLang) { +Base.CommandLine.push_back("-x"); ilya-biryukov

[PATCH] D45255: [CodeGen] Add an option to suppress output of llvm.ident

2018-04-04 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added a reviewer: faisalv. Herald added subscribers: JDevlieghere, aprantl. By default Clang outputs its version (including git commit hash, in case of trunk builds) into object and assembly files. It might be useful to have an option to disable this, especiall

[PATCH] D45257: [X86] Introduce cldemote intrinsic

2018-04-04 Thread Gabor Buella via Phabricator via cfe-commits
GBuella created this revision. GBuella added reviewers: craig.topper, zvi. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D45257 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/

[PATCH] D45126: Xray, OpenBSD support

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Just realised he s not active since February, hopes it will make it somehow :-) https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D45126: Xray, OpenBSD support

2018-04-04 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris added a comment. Do you need to have someone land this for you, or can you land it yourself? If @brad isn't able to get to it anytime soon, then I'm happy for this to land either way. https://reviews.llvm.org/D45126 ___ cfe-commits mailing

[PATCH] D45126: Xray, OpenBSD support

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Yes I can t land anything myself :-) thanks ! https://reviews.llvm.org/D45126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-04 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris added a comment. In https://reviews.llvm.org/D45243#1056549, @devnexen wrote: > Do the unit tests have same outcome with these changes ? Otherwise, > appreciate the simplification. Yes, locally, `ninja check-all` on Linux works just fine for me. No idea whether this will be the case f

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

2018-04-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. That's good enough for me the changes look neat. We ll see what others think. https://reviews.llvm.org/D45243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D45165: Use llvm::sys::fs::real_path() in clang.

2018-04-04 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. bruno: ping https://reviews.llvm.org/D45165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r329182 - [clang-tidy] Rename -warnings-as-errors tests. NFC.

2018-04-04 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Wed Apr 4 05:40:00 2018 New Revision: 329182 URL: http://llvm.org/viewvc/llvm-project?rev=329182&view=rev Log: [clang-tidy] Rename -warnings-as-errors tests. NFC. The tests will be more discoverable with proper names. Added: clang-tools-extra/trunk/test/clang-tidy/warni

[PATCH] D41217: [Concepts] Concept Specialization Expressions

2018-04-04 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 140948. saar.raz added a comment. - Switched to piecewise substitution of atomic constraints when evaluating constraint expressions - Added tests for piecewise substitution behavior - Removed some redundant parentheses Repository: rC Clang https://revie

r329183 - [XRay][clang] Allow clang to build XRay instrumented binaries in OpenBSD

2018-04-04 Thread Dean Michael Berris via cfe-commits
Author: dberris Date: Wed Apr 4 05:47:49 2018 New Revision: 329183 URL: http://llvm.org/viewvc/llvm-project?rev=329183&view=rev Log: [XRay][clang] Allow clang to build XRay instrumented binaries in OpenBSD Summary: This patch was originally reviewed in D45126. It enables clang to add the XRay ru

[PATCH] D45126: Xray, OpenBSD support

2018-04-04 Thread Dean Michael Berris via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC329183: [XRay][clang] Allow clang to build XRay instrumented binaries in OpenBSD (authored by dberris, committed by ). Repository: rC Clang https://reviews.llvm.org/D45126 Files: lib/Driver/ToolChai

[PATCH] D44226: [clangd] Add -log-lsp-to-stderr option

2018-04-04 Thread Simon Marchi via Phabricator via cfe-commits
simark added inline comments. Comment at: clangd/ClangdLSPServer.cpp:412 +llvm::raw_string_ostream OS(Message); +OS << "method not found (" << Method << ")"; +replyError(ErrorCode::MethodNotFound, OS.str()); ilya-biryukov wrote: > simark wrote: > > si

[libcxx] r329194 - [libcxx][test] Improve assert message

2018-04-04 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Apr 4 06:31:39 2018 New Revision: 329194 URL: http://llvm.org/viewvc/llvm-project?rev=329194&view=rev Log: [libcxx][test] Improve assert message Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.funcs/fs.op.proximate/proximate.pass.cpp Modified: libcx

[PATCH] D44976: Change DEBUG() macro to LLVM_DEBUG() in clang-tools-extra

2018-04-04 Thread Nicola Zaghen via Phabricator via cfe-commits
Nicola added a comment. Ping? I'm not sure who to add as reviewers as it's generic change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D44975: Change DEBUG() macro to LLVM_DEBUG()

2018-04-04 Thread Nicola Zaghen via Phabricator via cfe-commits
Nicola added a comment. Ping? I'm not sure who to add as reviewers as it's generic change. Repository: rC Clang https://reviews.llvm.org/D44975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

2018-04-04 Thread Ben Craig via Phabricator via cfe-commits
bcraig added a comment. In https://reviews.llvm.org/D32411#1056381, @EricWF wrote: > I spoke to STL on the MSVC team a while ago, and he stated that if we > produced a paper describing why we need `#include_next` and the rational > behind it, and they would pass that on to the front-end team. T

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov marked 2 inline comments as done. GorNishanov added inline comments. Comment at: include/experimental/coroutine:294 + +inline _LIBCPP_ALWAYS_INLINE +noop_coroutine_handle noop_coroutine() _NOEXCEPT { lewissbaker wrote: > EricWF wrote: > > This should

[PATCH] D45258: [clang-tidy] Return non-zero exit code for clang errors.

2018-04-04 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh created this revision. alexfh added a reviewer: ilya-biryukov. Herald added subscribers: xazax.hun, klimek. Updated tests broken by this change. Fixes https://bugs.llvm.org/show_bug.cgi?id=27628 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45258 Files: clang-tidy/too

[libcxx] r329199 - [libcxx][test] Fix fs::proximate tests on platforms where /net exists.

2018-04-04 Thread Jan Korous via cfe-commits
Author: jkorous Date: Wed Apr 4 07:23:51 2018 New Revision: 329199 URL: http://llvm.org/viewvc/llvm-project?rev=329199&view=rev Log: [libcxx][test] Fix fs::proximate tests on platforms where /net exists. Following Eric's patch. Modified: libcxx/trunk/test/std/experimental/filesystem/fs.op.

[PATCH] D45237: [RISCV] Fix logic check if frame pointer should be used

2018-04-04 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. Could you please add a test, perhaps to test/Driver/frame-pointer.c? My understanding is that in general there is a desire for codegen to remain the same or as close as possible whether it's a -g build or not, so I think disabling fp elimination for debug builds wouldn't be

[PATCH] D44727: [RISCV] Extend getTargetDefines for RISCVTargetInfo

2018-04-04 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. Thanks Eli for the info on hasFeature. I think the only thing now missing is test coverage for the defines. Comment at: lib/Basic/Targets/RISCV.cpp:53-73 + if (HasM) { +Builder.defineMacro("__riscv_mul"); +Builder.defineMacro("__riscv_div"); +

[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

2018-04-04 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: include/clang/Format/Format.h:1676 + /// \brief A vector of macros that should be interpreted as macros expanding + /// to a string literal encoding prefix instead of as function calls. "A list of macro names"?

[PATCH] D44727: [RISCV] Extend getTargetDefines for RISCVTargetInfo

2018-04-04 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng updated this revision to Diff 140959. kito-cheng added a comment. Changes: - Reorder marco define into canonical order which specified in ISA manual. - Add missing test for marco. Repository: rC Clang https://reviews.llvm.org/D44727 Files: lib/Basic/Targets/RISCV.cpp lib/Basi

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added a subscriber: STL_MSFT. CaseyCarter added inline comments. Comment at: include/experimental/coroutine:268 +: public coroutine_handle<> { + using _Base = coroutine_handle<>; + using _Promise = noop_coroutine_promise; This file can't seem to

[PATCH] D45185: [clang-format] Support lightweight Objective-C generics

2018-04-04 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton updated this revision to Diff 140968. benhamilton marked 3 inline comments as done. benhamilton added a comment. - @djasper fixes Repository: rC Clang https://reviews.llvm.org/D45185 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestObjC.cpp Index: unitte

[PATCH] D45185: [clang-format] Support lightweight Objective-C generics

2018-04-04 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton added a comment. Thanks, fixed! Comment at: lib/Format/UnwrappedLineParser.cpp:2135 +nextToken(); +if (FormatTok->Tok.is(tok::less)) + NumOpenAngles++; djasper wrote: > The UnwrappedLineParser is very much about error recovery. Implemen

[PATCH] D44727: [RISCV] Extend getTargetDefines for RISCVTargetInfo

2018-04-04 Thread Alex Bradbury via Phabricator via cfe-commits
asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me. Comment at: lib/Basic/Targets/RISCV.cpp:62-70 + if (HasD) +Builder.defineMacro("__riscv_flen", "64"); + else if (HasF) +Builder.defineMacro

[PATCH] D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly

2018-04-04 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton marked an inline comment as done. benhamilton added a comment. Any more comments on this one, folks? I'd love to land this fix. Repository: rC Clang https://reviews.llvm.org/D44996 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly

2018-04-04 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak accepted this revision. jolesiak added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D44996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

2018-04-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: include/clang/Basic/Cuda.h:61 + GFX900, + GFX902, LAST, yaxunl wrote: > rjmccall wrote: > > Does this actually have anything to do with HIP? You have a lot of changes > > in this patch which seem to just be about

[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

2018-04-04 Thread Mikhail Dvoretckii via Phabricator via cfe-commits
mike.dvoretsky updated this revision to Diff 140972. mike.dvoretsky edited the summary of this revision. mike.dvoretsky added a comment. On suggestion from @craig.topper moved all lowering to CGBuiltin.cpp with no new builtins added. Instead the existing builtins are lowered if their immediate v

LLVM buildmaster will be updated and restarted tonight

2018-04-04 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

2018-04-04 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:73 +// 'typedef'ed grand-parent classes. +// Adopted from https://stackoverflow.com/a/23081770/107308

[PATCH] D45257: [X86] Introduce cldemote intrinsic

2018-04-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: include/clang/Driver/Options.td:2583 def mno_clzero : Flag<["-"], "mno-clzero">, Group; +def mcldemote : Flag<["-"], "mcldemote">, Group; +def mno_cldemote : Flag<["-"], "mno-cldemote">, Group; This should be above

[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

2018-04-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. What about rndscaless/rndscalesd? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8307 +Dst = Ops[0]; +Mask = llvm::ConstantInt::get(CGF.Builder.getInt32Ty(), 1); + } else { I'm not sure we should even try to emit a mask for t

[PATCH] D45254: [X86][WAITPKG] WaitPKG intrinsics

2018-04-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D45254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov updated this revision to Diff 140983. GorNishanov marked 2 inline comments as done. GorNishanov added a comment. - static_cast instead of reintrepret_cast in promise() - 2 spaces indent in added code (the rest of the file stayed as is) - added static_assert to check for done-ness and c

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov marked 11 inline comments as done. GorNishanov added inline comments. Comment at: include/experimental/coroutine:275 +return *reinterpret_cast<_Promise*>( +__builtin_coro_promise(this->__handle_, __alignof(_Promise), false)); +} --

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

2018-04-04 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added inline comments. Comment at: include/clang/Basic/Cuda.h:61 + GFX900, + GFX902, LAST, rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > Does this actually have anything to do with HIP? You have a lot of > > > changes in this patch whi

[PATCH] D45056: [X86] Split up -march=icelake to -client & -server

2018-04-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D45056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D41168: [X86] Lowering X86 avx512 sqrt intrinsics to IR

2018-04-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

2018-04-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: include/clang/Basic/Cuda.h:61 + GFX900, + GFX902, LAST, Hahnfeld wrote: > rjmccall wrote: > > yaxunl wrote: > > > rjmccall wrote: > > > > Does this actually have anything to d

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/experimental/coroutine:294 + +inline _LIBCPP_ALWAYS_INLINE +noop_coroutine_handle noop_coroutine() _NOEXCEPT { GorNishanov wrote: > lewissbaker wrote: > > EricWF wrote: > > > This should just be `_LIBCPP_INLINE_VI

[PATCH] D45269: [CMake] Support for monorepo layout

2018-04-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: EricWF, beanz. Herald added subscribers: cfe-commits, christof, mgorny. Support finding libcxx and libunwind sources in monorepo style layout. Repository: rCXXA libc++abi https://reviews.llvm.org/D45269 Files: libcxxabi/CMakeLists.txt

[PATCH] D45179: [libc++] Add _LIBCPP_FORCE_NODISCARD define to force-enable nodiscard in pre-C++17

2018-04-04 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. In https://reviews.llvm.org/D45179#1056706, @lebedev.ri wrote: > gcc does not silence the warning produced by > these attributes via `(void)` cast, unless it's `[[nodiscard]]` attribute :/ > [...] So until they fix that (they will fix that right? :)), > we can only

[PATCH] D45270: [CMake] Support for monorepo layout

2018-04-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: EricWF, beanz, jroelofs. Herald added subscribers: cfe-commits, christof, mgorny. Support finding libcxx sources in monorepo style layout. Repository: rUNW libunwind https://reviews.llvm.org/D45270 Files: libunwind/CMakeLists.txt Inde

[libcxxabi] r329208 - [CMake] Support for monorepo layout

2018-04-04 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Apr 4 10:40:59 2018 New Revision: 329208 URL: http://llvm.org/viewvc/llvm-project?rev=329208&view=rev Log: [CMake] Support for monorepo layout Support finding libcxx and libunwind sources in monorepo style layout. Differential Revision: https://reviews.llvm.org/D45269

[PATCH] D45269: [CMake] Support for monorepo layout

2018-04-04 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329208: [CMake] Support for monorepo layout (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45269?vs=140989&id=140992#toc

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

2018-04-04 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/readability/UnnecessaryIntermediateVarCheck.h:27 +// Matches the next statement within the parent statement sequence. +AST_MATCHER_P(Stmt

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter accepted this revision. CaseyCarter added inline comments. Comment at: include/experimental/coroutine:288 + +coroutine_handle() { + this->__handle_ = __builtin_coro_noop(); EricWF wrote: > GorNishanov wrote: > > CaseyCarter wrote: > > > Casey

[libunwind] r329212 - [CMake] Support for monorepo layout

2018-04-04 Thread Petr Hosek via cfe-commits
Author: phosek Date: Wed Apr 4 10:57:15 2018 New Revision: 329212 URL: http://llvm.org/viewvc/llvm-project?rev=329212&view=rev Log: [CMake] Support for monorepo layout Support finding libcxx sources in monorepo style layout. Differential Revision: https://reviews.llvm.org/D45270 Modified:

[PATCH] D45270: [CMake] Support for monorepo layout

2018-04-04 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL329212: [CMake] Support for monorepo layout (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D45270?vs=140990&id=140998#toc

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

2018-04-04 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington updated this revision to Diff 141001. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Handle this in ExprConstant instead of in Sema. https://reviews.llvm.org/D45194 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/cxx1z-constexpr-l

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

2018-04-04 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:12886 if (!IsInstantiation && FD && FD->isConstexpr() && !FD->isInvalidDecl() && +!isLambdaCallOperator(FD) && (!CheckConstexprFunctionDecl(FD) || faisalv wrote:

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov marked an inline comment as done. GorNishanov added inline comments. Comment at: include/experimental/coroutine:294 + +inline _LIBCPP_ALWAYS_INLINE +noop_coroutine_handle noop_coroutine() _NOEXCEPT { EricWF wrote: > GorNishanov wrote: > > lewissbaker

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added inline comments. Comment at: include/experimental/coroutine:294 + +inline _LIBCPP_ALWAYS_INLINE +noop_coroutine_handle noop_coroutine() _NOEXCEPT { GorNishanov wrote: > EricWF wrote: > > GorNishanov wrote: > > > lewissbaker wrote: > > > > EricWF wrot

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

2018-04-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:1435 /// extended by a local reference with the given initializer. static QualType getReferenceInitTemporaryType(ASTContext &Context, const Expr *Init, rs

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov updated this revision to Diff 141010. GorNishanov added a comment. - s/_LIBCPP_ALWAYS_INLINE/_LIBCPP_INLINE_VISIBILITY throughout - Added _LIBCPP_INLINE_VISIBILITY to noop_coroutine constructor @EricWF , good to go? https://reviews.llvm.org/D45121 Files: include/experimental/co

[PATCH] D45277: [CUDA] Add amdgpu sub archs

2018-04-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl, jholewinski. This patch is separated from https://reviews.llvm.org/D45212. Patch by Greg Rodgers. Revised and lit tests added by Yaxun Liu. https://re

[PATCH] D44580: Sema: allow comparison between blocks & block-compatible objc types

2018-04-04 Thread Dustin L. Howett via Phabricator via cfe-commits
DHowett-MSFT added a comment. Thank you for the review! I don't have the means to check this in myself. Repository: rC Clang https://reviews.llvm.org/D44580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D45121: [coroutines] Add noop_coroutine to

2018-04-04 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. Yeah, LGTM. https://reviews.llvm.org/D45121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45178: Fixes errors caused by https://reviews.llvm.org/D44960

2018-04-04 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a comment. I'd like to test this out a bit more. Could you wait one more day? Repository: rC Clang https://reviews.llvm.org/D45178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D45277: [CUDA] Add amdgpu sub archs

2018-04-04 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks for splitting the patch up. LGTM. https://reviews.llvm.org/D45277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D44765: PR36643 Make clang-format support more generic TMarcos

2018-04-04 Thread Teodor Petrov via Phabricator via cfe-commits
obfuscated marked 3 inline comments as done. obfuscated added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:371 FormatToken *Macro = Tokens[Tokens.size() - 4]; - if (Macro->TokenText != "_T") + if (std::find(Style.TMacros.begin(), Style.TMacros.end(), Macro->T

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

2018-04-04 Thread Faisal Vali via Phabricator via cfe-commits
faisalv added a comment. Thanks Erik! Comment at: clang/lib/AST/ExprConstant.cpp:4312 + } else if (MD && isLambdaCallOperator(MD) + && !Info.checkingPotentialConstantExpression()) { // We're in a lambda; determine the lambda capture field maps. ---

[PATCH] D45178: Fixes errors caused by https://reviews.llvm.org/D44960

2018-04-04 Thread Vedant Kumar via Phabricator via cfe-commits
vsk accepted this revision. vsk added a comment. Lgtm, thank you. If you don't have commit access, let us know, and somebody will commit this on your behalf. Repository: rC Clang https://reviews.llvm.org/D45178 ___ cfe-commits mailing list cfe-

[PATCH] D45178: Fixes errors caused by https://reviews.llvm.org/D44960

2018-04-04 Thread Max Moroz via Phabricator via cfe-commits
Dor1s added a comment. Thanks a lot, Vedant! No worries, I'll commit it on behalf of Yuke @liaoyuke Repository: rC Clang https://reviews.llvm.org/D45178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

2018-04-04 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta updated this revision to Diff 141019. manojgupta added a comment. Address requested changes. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h Index: lib/Driver/ToolChains/Gnu.h ==

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

2018-04-04 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta marked 3 inline comments as done. manojgupta added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:2303 + std::pair GentooLibs = ConfLine.split(':'); + GentooScanPaths.push_back(GentooLibs.first.str()); + if (!GentooLib

[PATCH] D45257: [X86] Introduce cldemote intrinsic

2018-04-04 Thread Gabor Buella via Phabricator via cfe-commits
GBuella updated this revision to Diff 141021. https://reviews.llvm.org/D45257 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h lib/Headers/CMakeLists.txt lib/Headers/cldemoteintrin.h lib/Headers/cpuid.h li

[PATCH] D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960

2018-04-04 Thread Max Moroz via Phabricator via cfe-commits
Dor1s updated this revision to Diff 141026. Dor1s added a comment. Resolve merge conflicts and fix whitespaces. Repository: rC Clang https://reviews.llvm.org/D45178 Files: lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSystemTest.cpp Index: unittests/Basic/VirtualFileSystem

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

2018-04-04 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. The only think that links against libxml2 is c-index-test. Surely nobody cares about installing c-index-test on some other machine that lacks the local version of libxml2. What's the use case for this to justify the complexity of interacting with LLVM's configuration option

[PATCH] D45257: [X86] Introduce cldemote intrinsic

2018-04-04 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D45257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

  1   2   >