Aw, rats. I put it under -Wignored-pragmas rather than
-Wunsupported-pragmas, because I was looking at #pragma intrinsic.
I'll take a look at this again tomorrow.
On Wed, Mar 21, 2018 at 5:18 PM, Nico Weber via cfe-commits
wrote:
> From the bot changes, it seems that -Wunknown-pragma doesn't dis
yaxunl updated this revision to Diff 139359.
yaxunl added a comment.
Upload diff with full context.
https://reviews.llvm.org/D44747
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCUDA/kernel-amdgcn.cu
Index: test/CodeGenCUDA/kernel-amdgcn.cu
=
yaxunl added a comment.
In https://reviews.llvm.org/D44747#1044893, @rjmccall wrote:
> Is there a reason for this to be done as a special case in IRGen instead of
> just implicitly applying the calling convention in Sema?
The calling convention is not used in Sema, therefore it seems simpler t
Wizard added a comment.
Why do we only detect system framework? I think any #import could indicate ObjC
header.
Repository:
rC Clang
https://reviews.llvm.org/D44634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
EricWF marked an inline comment as done.
EricWF added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:1947-1948
+const auto *Record = ArgTy->getAsCXXRecordDecl();
+if (CGM.getCodeGenOpts().StrictVTablePointers && Record &&
+Record->isDynamicClass())
+
bob.wilson added a comment.
Sorry that I missed your earlier comment about this. The confusion could only
arise in the context of a tool (like a compiler) that is being used for
cross-compilation. That is a small fraction of the audience for Clang, and we
should design this in a way that makes
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
This is assertion removal. The assertion was saying that a function's return
value is always a temporary object - which is not true when copy
Ah! Hm, maybe that's the better group for this anyway? Not sure.
On Wed, Mar 21, 2018, 9:03 PM Hans Wennborg wrote:
> Aw, rats. I put it under -Wignored-pragmas rather than
> -Wunsupported-pragmas, because I was looking at #pragma intrinsic.
>
> I'll take a look at this again tomorrow.
>
> On We
EricWF marked 2 inline comments as done.
EricWF added inline comments.
Comment at: test/CodeGenCXX/builtin-launder.cpp:93-96
+/// The test cases in this namespace technically need to be laundered according
+/// to the language in the standard (ie they have const or reference
sub
EricWF updated this revision to Diff 139363.
EricWF marked an inline comment as done.
EricWF added a comment.
- Launder types with subobjects of dynamic class type.
- Improve diagnostic selection using `llvm::Optional`.
- Add comment about LTO ABI concerns to test file.
- Merge with master.
http
#import is perfectly legal in C and C++, it's just not commonly used.
On Wed, Mar 21, 2018, 14:27 Yan Zhang via Phabricator <
revi...@reviews.llvm.org> wrote:
> Wizard added a comment.
>
> Why do we only detect system framework? I think any #import could indicate
> ObjC header.
>
>
> Repository:
Not sure either, but I think the ignored warning is used for pragmas
that clang fails to parse, so maybe unsupported is better.
On Wed, Mar 21, 2018 at 9:33 PM, Nico Weber wrote:
> Ah! Hm, maybe that's the better group for this anyway? Not sure.
>
> On Wed, Mar 21, 2018, 9:03 PM Hans Wennborg wr
Wizard added a comment.
For some ObjC headers it uses #import to import other headers instead of system
framework, so I think we should also detect #import "*.h" as well.
The only usage of #import in C++ is to import type library, which won't have
suffix of ".h".
Repository:
rC Clang
http
eugenis added a comment.
This was fixed in https://reviews.llvm.org/D44655
https://reviews.llvm.org/D44645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jkorous
Date: Wed Mar 21 14:04:10 2018
New Revision: 328149
URL: http://llvm.org/viewvc/llvm-project?rev=328149&view=rev
Log:
[clangd][nfc] Correct header name in comment
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
Modified: clang-tools-extra/trunk/clangd/index/Index.h
URL
vsapsai updated this revision to Diff 139369.
vsapsai edited the summary of this revision.
vsapsai added a comment.
- Implement the same functionality for C++98 and C++03.
- Use `DoNotOptimize` instead of `asm`.
Didn't move the tests as the standard doesn't require assignment operator to be
reent
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:480
}
+ CC = dyn_cast(
+ RTCElem->getConstructionContext());
I'm a bit confused as to what is going on here; maybe a short comment would be
helpful?
W
Ericson2314 added a comment.
In https://reviews.llvm.org/D44753#1044935, @bob.wilson wrote:
> Sorry that I missed your earlier comment about this. The confusion could only
> arise in the context of a tool (like a compiler) that is being used for
> cross-compilation. That is a small fraction of
mclow.lists added a comment.
A few small comments...
Comment at: libcxx/include/functional:1821
{
-if ((void *)__f_ == &__buf_)
-__f_->destroy();
-else if (__f_)
-__f_->destroy_deallocate();
-__f_ = 0;
+function::operator=(nullptr);
if (__f
Author: juliehockett
Date: Wed Mar 21 14:21:45 2018
New Revision: 328150
URL: http://llvm.org/viewvc/llvm-project?rev=328150&view=rev
Log:
[clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework"
Fixing the the failing Windows tests.
Added:
clang-tools-extra/trunk/clang-doc/Bitcod
Author: vsapsai
Date: Wed Mar 21 14:28:54 2018
New Revision: 328153
URL: http://llvm.org/viewvc/llvm-project?rev=328153&view=rev
Log:
[Modules] Fix creating fake definition data for lambdas.
During reading C++ definition data for lambda we can access
CXXRecordDecl representing lambda before we fi
steven_wu added a comment.
I disagree. I think "target" is the correct name, even for cross compiling. For
something compiled with -target foo, we are consistent calling it "target"
during compile time. It only becomes appropriate to call it "host" during the
runtime of the executable. There is
This revision was automatically updated to reflect the committed changes.
Closed by commit rC328153: [Modules] Fix creating fake definition data for
lambdas. (authored by vsapsai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43494?vs=138059&id=139372#toc
Repository:
rC
Ericson2314 added a comment.
One that that might make my position clearer is to substitute the name "build",
"host", and "target" for "build", "run", and "emit". [A colleague of mine
proposed these alternative names and I do think they are vastly more human
friendly.]
Then if we write
int m
rjmccall added a comment.
In https://reviews.llvm.org/D44747#1044916, @yaxunl wrote:
> In https://reviews.llvm.org/D44747#1044893, @rjmccall wrote:
>
> > Is there a reason for this to be done as a special case in IRGen instead of
> > just implicitly applying the calling convention in Sema?
>
>
>
Ericson2314 added a comment.
@steven_wu but what you say is directly contradicted by the GHC example. I'm
sure I could fine a GCC example too where some macro with "target" is in the
name affects the target of the compiler being built. In the vast majority of
programs, no more than one platform
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D44710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steven_wu added a comment.
It is not about matching command line name to builtin marco name. "target" is
the platform we are compiling for, whether it is host or device or something
else. It is a different concept when you talking about cross-compiling, which
"target" is strictly not host and "
Author: tra
Date: Wed Mar 21 14:55:02 2018
New Revision: 328158
URL: http://llvm.org/viewvc/llvm-project?rev=328158&view=rev
Log:
[NVPTX] Make tensor shape part of WMMA intrinsic's name.
This is needed for the upcoming implementation of the
new 8x32x16 and 32x8x16 variants of WMMA instructions
in
NoQ updated this revision to Diff 139378.
NoQ added a comment.
Add a comment for the confusing part.
https://reviews.llvm.org/D44755
Files:
lib/StaticAnalyzer/Core/ExprEngine.cpp
lib/StaticAnalyzer/Core/ExprEngineCXX.cpp
test/Analysis/lifetime-extension.cpp
test/Analysis/temporaries.cpp
Ericson2314 added a comment.
> I'm sure I could fine a GCC example
FWIW
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/aarch64/aarch64.c vs
https://github.com/gcc-mirror/gcc/blob/master/gcc/common/config/aarch64/aarch64-common.c
@steven_wu
> It is not about matching command line na
Author: tra
Date: Wed Mar 21 15:22:59 2018
New Revision: 328161
URL: http://llvm.org/viewvc/llvm-project?rev=328161&view=rev
Log:
[CUDA] Disable LTO for device-side compilations.
This fixes host-side LTO during CUDA compilation. Before, LTO
pipeline construction was clashing with CUDA pipeline co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328161: [CUDA] Disable LTO for device-side compilations.
(authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D44691?vs=139151&id=
Author: dblaikie
Date: Wed Mar 21 15:34:27 2018
New Revision: 328166
URL: http://llvm.org/viewvc/llvm-project?rev=328166&view=rev
Log:
Fix for LLVM change (Transforms/Utils/Local.h -> Analysis/Utils/Local.h)
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cp
vsapsai added inline comments.
Comment at: libcxx/include/functional:1722-1733
if (__f.__f_ == 0)
__f_ = 0;
else if ((void *)__f.__f_ == &__f.__buf_)
{
__f_ = __as_base(&__buf_);
__f.__f_->__clone(__f_);
}
Here is th
steven_wu added a comment.
I am not trying to discuss which english word is best here. My point is simply:
1. macros are evaluated during compile time
2. "host"means either the platform you compiled on during compile time or the
platform you run on during the runtime
3. __is_host_* is not a good
mclow.lists added a comment.
I'm going to stop here, because all the things I've noted are ticky-tack;
formatting and minor changes.
More substantial comments coming soon.
Comment at: libcxx/include/experimental/simd:40
+template inline constexpr bool is_abi_tag_v = is_abi_ta
hubert.reinterpretcast added inline comments.
Comment at: lib/AST/ExprCXX.cpp:1478
+ {
+// We do not want error diagnostics escaping here.
+Sema::SFINAETrap Trap(S);
saar.raz wrote:
> hubert.reinterpretcast wrote:
> > saar.raz wrote:
> > > faisalv wrote:
rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.
Looks good. Ready to commit.
https://reviews.llvm.org/D43737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
eugenis added inline comments.
Comment at: lib/Driver/SanitizerArgs.cpp:33
NotAllowedWithMinimalRuntime = Vptr,
- RequiresPIE = DataFlow | Scudo,
+ RequiresPIE = DataFlow | HWAddress | Scudo,
NeedsUnwindTables = Address | HWAddress | Thread | Memory | DataFlow,
--
NoQ updated this revision to Diff 139389.
NoQ added a comment.
I'd rather keep the helper method within the class. This allows us to keep
constructors private, which is something i forgot to do originally.
https://reviews.llvm.org/D44725
Files:
include/clang/Analysis/ConstructionContext.h
ro added a comment.
ping^3
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.
LGTM, but would actually make even more sense as a static function for the
allocator.
E.g. we have `llvm::make_shared<>()`, so we could also have
`Allocator::make_obj<...>(
Ericson2314 added a comment.
@steven_wu Maybe there is something outside of "build" "host" or "target" that
won't suffer from these problems of vantage point? `__will_be_built_for_*` for
a very lengthy example, but hopefully something shorter too?
Repository:
rC Clang
https://reviews.llvm.o
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:669
+
+#if _LIBCPP_STD_VER > 14 && !defined(_LIBCPP_HAS_NO_VARIABLE_TEMPLATES)
+template
mclow.lists wrote:
> Isn't the parallelism TS based on C++17?
>
I intended to have a C++11 (and
timshen updated this revision to Diff 139393.
timshen marked 7 inline comments as done.
timshen added a comment.
Address comments.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.p
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp:17
};
extern A x; // expected-error {{requires an initializer}}
+static A y;
---
NoQ added a comment.
> E.g. we have `llvm::make_shared<>()`, so we could also have
> `Allocator::make_obj<...>(...)`
I like your thinking, but that'd require me to make the allocator my friend
class (:
https://reviews.llvm.org/D44725
___
cfe-comm
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
`CXXCtorInitializer`-based constructors are apparently also affected by the
C++17 mandatory copy elision, like variable constructors and retu
malaperle created this revision.
Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple,
ilya-biryukov, klimek.
This mitigates a possible issue in tests that print objects on failure. It is
possible that there will be two different instantiations of the printer template
for a given
obfuscated created this revision.
obfuscated added a reviewer: krasimir.
Herald added a subscriber: klimek.
This patch changes the check for _T to detect TMarcos with a more generic check.
This makes it possible to format wxWidgets projects (where wxT is used a lot)
correctly.
Patch by Teodor Pe
compnerd added a comment.
I may be a bit biased but I agree with @bob.wilson and @steven_wu. The current
names are better from the user’s perspective. GCC’s build is a very bad
example as it has runtime components built as part of it (libgcc). When
building any code, even in a Canadian cross
Author: eugenezelenko
Date: Wed Mar 21 17:53:26 2018
New Revision: 328171
URL: http://llvm.org/viewvc/llvm-project?rev=328171&view=rev
Log:
[Frontend] Fix some Clang-tidy modernize and Include What You Use warnings;
other minor fixes (NFC).
Modified:
cfe/trunk/include/clang/Frontend/ASTUnit.
rsmith added a comment.
@fedor.sergeev Can you review this for correctness? Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D41240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: juliehockett
Date: Wed Mar 21 19:05:51 2018
New Revision: 328172
URL: http://llvm.org/viewvc/llvm-project?rev=328172&view=rev
Log:
Revert "[clang-doc] Reland "[clang-doc] Setup clang-doc frontend framework""
This reverts commit r328150 until we can fix the test that are failing
on the Win
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328173: Improve -Winfinite-recursion (authored by CodaFi,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D43737?vs=139325&id=139408#toc
Repos
Author: benhamilton
Date: Wed Mar 21 20:23:53 2018
New Revision: 328174
URL: http://llvm.org/viewvc/llvm-project?rev=328174&view=rev
Log:
[clang-format] Don't insert space between r_paren and 'new' in ObjC decl
Summary:
Previously, clang-format would insert a space between
the closing parenthesis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328174: [clang-format] Don't insert space between
r_paren and 'new' in ObjC decl (authored by benhamilton, committed by
).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
benhamilton updated this revision to Diff 139410.
benhamilton marked an inline comment as done.
benhamilton added a comment.
Remove assert
Repository:
rC Clang
https://reviews.llvm.org/D44632
Files:
lib/Format/Format.cpp
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTes
Author: benhamilton
Date: Wed Mar 21 20:25:22 2018
New Revision: 328175
URL: http://llvm.org/viewvc/llvm-project?rev=328175&view=rev
Log:
[clang-format] Add a few more Core Graphics identifiers to ObjC heuristic
Summary:
We received reports of the Objective-C style guesser getting a false
negativ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL328175: [clang-format] Add a few more Core Graphics
identifiers to ObjC heuristic (authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.
dcoughlin accepted this revision.
dcoughlin added a comment.
LGTM. I really appreciate the extra documentation you've added, too.
https://reviews.llvm.org/D44597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: codafi
Date: Wed Mar 21 20:16:23 2018
New Revision: 328173
URL: http://llvm.org/viewvc/llvm-project?rev=328173&view=rev
Log:
Improve -Winfinite-recursion
Summary: Rewrites -Winfinite-recursion to remove the state dictionary and
explore paths in loops - especially infinite loops. The new
Author: ericwf
Date: Wed Mar 21 21:42:56 2018
New Revision: 328180
URL: http://llvm.org/viewvc/llvm-project?rev=328180&view=rev
Log:
Fix PR22634 - std::allocator doesn't respect over-aligned types.
This patch fixes std::allocator, and more specifically, all users
of __libcpp_allocate and __libcpp
dpayne added a comment.
I'll make sure to do the full diff in the future. I did that for the first
patch but forgot to do it in the follow up patch, I won't make that mistake in
the future.
I do not have commit access so I cannot merge myself. When you have the time
could you merge this change
Author: ericwf
Date: Wed Mar 21 22:44:48 2018
New Revision: 328182
URL: http://llvm.org/viewvc/llvm-project?rev=328182&view=rev
Log:
Fix dynarray test failures after changing __libcpp_allocate/deallocate
Modified:
libcxx/trunk/include/experimental/dynarray
Modified: libcxx/trunk/include/expe
Author: ericwf
Date: Wed Mar 21 23:21:07 2018
New Revision: 328185
URL: http://llvm.org/viewvc/llvm-project?rev=328185&view=rev
Log:
Correct TEST_HAS_NO_ALIGNED_ALLOCATION macro definition
Modified:
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/test/support/test_macros.h
URL
101 - 167 of 167 matches
Mail list logo
