[PATCH] D44606: [analyzer] Fix the crash in `IteratorChecker.cpp` when `SymbolConjured` has a null Stmt.

MTC created this revision. MTC added reviewers: NoQ, baloghadamsoftware, szepet, dcoughlin. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, xazax.hun. Herald added a reviewer: george.karpenkov. When the loop has a null terminator statement and sets `widen-loops=true`, `invalidateRegio

[PATCH] D44605: [Driver] Default to DWARF 5 for Fuchsia

mcgrathr added a comment. We aren't actually using DWARF 5 yet AFAICT. Our builds don't pass -gdwarf-5. So I'm not sure we have yet verified that all the DWARF-consuming tools people are using with Fuchsia binaries can handle all of DWARF 5 (which has several major format changes). I'd certa

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Hm, or possibly you could just pass the triple to clang? Repository: rL LLVM https://reviews.llvm.org/D41102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

JonasToth added inline comments. Comment at: docs/ReleaseNotes.rst:125 + + Flags functions exceeding this number of variables declared in the body. + I would rephrase this a little to: ``` Flags function bodies exceeding this number of declared variables. ```

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri updated this revision to Diff 138844. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. Address jonastoth's review notes. - Properly support C++17 structured bindings. - A few more tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44602 Fil

r327790 - [dsymutil] Rename llvm-dsymutil -> dsymutil

Author: jdevlieghere Date: Sun Mar 18 04:38:41 2018 New Revision: 327790 URL: http://llvm.org/viewvc/llvm-project?rev=327790&view=rev Log: [dsymutil] Rename llvm-dsymutil -> dsymutil Now that almost all functionality of Apple's dsymutil has been upstreamed, the open source variant can be used as

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

JonasToth added a comment. Looks fine to me, but Aaron or someone else must accept :) Just out of curiosity: The decomposition visit is for structured binding and the binding visit for range based for? Are there other places where binding occurs? For example in some template stuff? Just asking

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

lebedev.ri added a comment. In https://reviews.llvm.org/D44602#1041153, @JonasToth wrote: > Looks fine to me, but Aaron or someone else must accept :) Thanks for review! In https://reviews.llvm.org/D44602#1041153, @JonasToth wrote: > Just out of curiosity: The decomposition visit is for struc

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

JonasToth added a comment. > The comment i added is actually wrong. > The range-based for just works anyway. > The VisitBindingDecl() is needed to get all the 'variables' declared in > structured binding. > But as you can see in https://godbolt.org/g/be6Juf, the BindingDecl's are > wrapped in

[PATCH] D44602: [clang-tidy] readability-function-size: add VariableThreshold param.

JonasToth added inline comments. Comment at: docs/ReleaseNotes.rst:125 + + Flags functions exceeding this number of variables declared in the body. + lebedev.ri wrote: > JonasToth wrote: > > I would rephrase this a little to: > > > > ``` > > Flags function bod

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth added a subscriber: rsmith. JonasToth added a comment. Good news: The stack overflow seems to be fixed, by the patch r326624 from @rsmith (Thank you very much!). Bad news: The check does not do its job anymore I try to fix the functionality problems. Repository: rCTE Clang Tool

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

marcan created this revision. marcan added reviewers: sepavloff, echristo. Herald added a subscriber: cfe-commits. Doing an `.insert()` can potentially invalidate iterators by reallocating the vector's storage. When all the stars align just right, this causes segfaults or glibc aborts. Fix this

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

lebedev.ri added a comment. Tests? Repository: rC Clang https://reviews.llvm.org/D44607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r327738 - [MS] Don't escape MS C++ names with \01

Yes: https://reviews.llvm.org/D7775 This side is very mechanical, so I did not send it for review. On Sun, Mar 18, 2018, 3:54 AM Nico Weber wrote: > Was this discussed or reviewed somewhere? (It looks like a good change to > me, I'm just wondering if there was something that triggered this and

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth updated this revision to Diff 138849. JonasToth added a comment. - get the check working again - enable the big test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40737 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth updated this revision to Diff 138850. JonasToth added a comment. - reorder check in release notes to get it in alphabetical order Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40737 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp cla

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth added a comment. I think the check is ready to land. I did check run it over LLVM and found some interesting code parts that could benefit. I extracted all the warnings and sorted them into the categories `missing default/covered codepath(uncovered.txt)`, `better use if/else(better_if

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth updated this revision to Diff 138851. JonasToth added a comment. - remove spurious debug iostream Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40737 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/MultiwayPathsCover

[PATCH] D44607: Recompute invalidated iterator in insertTargetAndModeArgs

marcan added a comment. I'm not sure how to test this. Getting the bug to manifest involves all of having a lot of command line arguments, getting unlucky with the way SmallVectorImpl decides to allocate, and getting unlucky with the glibc allocator deciding to move the data block on realloc (o

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138858. zinovy.nis edited the summary of this revision. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCh

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked 5 inline comments as done. zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:113 + int virt_1() override { return A::virt_1(); } + // CHECK-MESSAGES: :[[@LINE-1]]:34: warning: qualified function name A::virt_1 refe

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis marked 6 inline comments as done. zinovy.nis added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:128 + diag(Member->getQualifierLoc().getSourceRange().getBegin(), + "'%0' is a grand-parent's method, not parent's. Did you mea

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

Wawha created this revision. Herald added subscribers: cfe-commits, klimek. This is a patch to fix the problem identify by this bug: https://bugs.llvm.org/show_bug.cgi?id=27640. When formatting this code with option "BreakBeforeBraces: Allman", the lambda body are not put entirely on new lines

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

lebedev.ri added a comment. Please always upload all patches with full context (`-U99`) Repository: rC Clang https://reviews.llvm.org/D44609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

lebedev.ri added a comment. Also, tests? Repository: rC Clang https://reviews.llvm.org/D44609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. @rtrieu ping! I've rebased this on the pure refactoring you committed for me last week. Repository: rC Clang https://reviews.llvm.org/D43322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

Wawha updated this revision to Diff 138859. Wawha added a comment. I upload the full context for these files. Repository: rC Clang https://reviews.llvm.org/D44609 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.

[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

Wawha added a comment. In https://reviews.llvm.org/D44609#1041260, @lebedev.ri wrote: > Also, tests? Sorry, the test files was missing with the first patch. I make mistake using svn... I create the new patch with git, it's easier for me. There is 4 small tests inside unittests/Format/FormatTes

[libcxx] r327806 - Updated C++2a status with changes from Jacksonville WG21 meeting

Author: marshall Date: Sun Mar 18 12:29:21 2018 New Revision: 327806 URL: http://llvm.org/viewvc/llvm-project?rev=327806&view=rev Log: Updated C++2a status with changes from Jacksonville WG21 meeting Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html U

[PATCH] D38216: [C++17] Fix class template argument deduction for default constructors without an initializer

Rakete updated this revision to Diff 138862. Rakete added a comment. @lichray Ok done :) Thanks for reviewing https://reviews.llvm.org/D38216 Files: lib/Sema/SemaDecl.cpp test/CXX/dcl.dcl/dcl.spec/dcl.type/dcl.type.class.deduct/p1.cpp test/Parser/cxx1z-class-template-argument-dedu

Re: r327738 - [MS] Don't escape MS C++ names with \01

Awesome, thanks! On Sun, Mar 18, 2018, 3:05 PM Reid Kleckner wrote: > Yes: https://reviews.llvm.org/D7775 > > This side is very mechanical, so I did not send it for review. > > > On Sun, Mar 18, 2018, 3:54 AM Nico Weber wrote: > >> Was this discussed or reviewed somewhere? (It looks like a good

[PATCH] D44580: Sema: allow comparison between blocks & block-compatible objc types

DHowett-MSFT planned changes to this revision. DHowett-MSFT marked an inline comment as done. DHowett-MSFT added inline comments. Comment at: lib/Sema/SemaExpr.cpp:7749 +// id (or strictly compatible object type) -> T^ +if (getLangOpts().ObjC1 && RHSType->isBlockCompatib

[PATCH] D44580: Sema: allow comparison between blocks & block-compatible objc types

DHowett-MSFT updated this revision to Diff 138868. DHowett-MSFT marked an inline comment as done. DHowett-MSFT added a comment. Backed out changes to block type assignment. Repository: rC Clang https://reviews.llvm.org/D44580 Files: lib/Sema/SemaExpr.cpp test/SemaObjC/block-compare.mm

[PATCH] D44616: Update existed CodeGen TBAA tests

DanilM created this revision. DanilM added reviewers: hfinkel, kosarev. Herald added a subscriber: cfe-commits. Just added testing of the new TBAA format to existed tests for old TBAA. Repository: rC Clang https://reviews.llvm.org/D44616 Files: test/CodeGen/tbaa-base.cpp test/CodeGen/tba

[libclc] r327818 - remainder: Port from amd builtins

Author: jvesely Date: Sun Mar 18 18:01:10 2018 New Revision: 327818 URL: http://llvm.org/viewvc/llvm-project?rev=327818&view=rev Log: remainder: Port from amd builtins Mostly ported from amd_builtins, uses only denormal path for fp32. Passes CTS on carrizo and turks Reviewer: Aaron Watry Signed

[PATCH] D44617: [Transforms] Keep TBAA tags in SimplifyCFG transformations

DanilM created this revision. DanilM added reviewers: hfinkel, rjmccall, kosarev. Herald added a subscriber: cfe-commits. If SimplifyCFG attaches one block to another it removes all metadata from instructions of a block that should be attached because it can be depended on conditions that are ch

[PATCH] D39050: Add index-while-building support to Clang

malaperle added a comment. In https://reviews.llvm.org/D39050#1040501, @akyrtzi wrote: > > That would be good. How would one go about asking Clang to generate this > > extra information? Would a Clang Plugin be suitable for this? > > That's an interesting idea that we could explore, but I don't

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

smeenai created this revision. smeenai added reviewers: rnk, rsmith. EmitInlinedInheritingCXXConstructorCall may result in a CallBaseDtor cleanup being pushed. That cleanup would then be popped when the CGF's CurCodeDecl no longer points to the method which triggered the cleanup, leading to a fail

[PATCH] D44619: [CodeGen] Add cleanup scope to EmitInlinedInheritingCXXConstructorCall

smeenai added a comment. Argh, this fixes my test case, but causes failures in some other ones. Back to the drawing board, I guess. Repository: rC Clang https://reviews.llvm.org/D44619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http