[PATCH] D41284: [Concepts] Associated constraints infrastructure.

saar.raz updated this revision to Diff 138500. saar.raz added a comment. Fixed reference to TemplateParams member in assertion. Repository: rC Clang https://reviews.llvm.org/D41284 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/Sema/Sema.h

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 138501. saar.raz added a comment. Adjusted to changes in https://reviews.llvm.org/D41217 Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h

[clang-tools-extra] r327606 - [clang-tidy] rename_check.py {misc, bugprone}-macro-parentheses

Author: alexfh Date: Thu Mar 15 01:25:39 2018 New Revision: 327606 URL: http://llvm.org/viewvc/llvm-project?rev=327606&view=rev Log: [clang-tidy] rename_check.py {misc,bugprone}-macro-parentheses Added: clang-tools-extra/trunk/clang-tidy/bugprone/MacroParenthesesCheck.cpp - copied, chan

[PATCH] D44508: Remove unnecessary include from Driver.cpp

yamaguchi created this revision. yamaguchi added a reviewer: dlj. Herald added a subscriber: llvm-commits. Clang compiles and test passes without these includes. Repository: rL LLVM https://reviews.llvm.org/D44508 Files: clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp

[clang-tools-extra] r327609 - Fixed filename in a comment. NFC

Author: alexfh Date: Thu Mar 15 01:26:58 2018 New Revision: 327609 URL: http://llvm.org/viewvc/llvm-project?rev=327609&view=rev Log: Fixed filename in a comment. NFC Modified: clang-tools-extra/trunk/clang-tidy/bugprone/IncorrectRoundingsCheck.h Modified: clang-tools-extra/trunk/clang-tidy/b

[clang-tools-extra] r327608 - [clang-tidy] rename_check.py misc-sizeof-container bugprone-sizeof-container

Author: alexfh Date: Thu Mar 15 01:26:47 2018 New Revision: 327608 URL: http://llvm.org/viewvc/llvm-project?rev=327608&view=rev Log: [clang-tidy] rename_check.py misc-sizeof-container bugprone-sizeof-container Added: clang-tools-extra/trunk/clang-tidy/bugprone/SizeofContainerCheck.cpp -

[clang-tools-extra] r327607 - [clang-tidy] rename_check.py misc-sizeof-expression bugprone-sizeof-expression

Author: alexfh Date: Thu Mar 15 01:26:19 2018 New Revision: 327607 URL: http://llvm.org/viewvc/llvm-project?rev=327607&view=rev Log: [clang-tidy] rename_check.py misc-sizeof-expression bugprone-sizeof-expression Added: clang-tools-extra/trunk/clang-tidy/bugprone/SizeofExpressionCheck.cpp

[clang-tools-extra] r327610 - [clang-tidy] rename_check.py misc-unused-raii bugprone-unused-raii --check_class_name=UnusedRAIICheck

Author: alexfh Date: Thu Mar 15 01:27:42 2018 New Revision: 327610 URL: http://llvm.org/viewvc/llvm-project?rev=327610&view=rev Log: [clang-tidy] rename_check.py misc-unused-raii bugprone-unused-raii --check_class_name=UnusedRAIICheck Added: clang-tools-extra/trunk/clang-tidy/bugprone/Unused

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

alexfh added a comment. In https://reviews.llvm.org/D41655#1037552, @khuttun wrote: > In https://reviews.llvm.org/D41655#1037234, @alexfh wrote: > > > Do you need help committing the patch? > > > Yes please, I don't have commit access to the repo. The patch doesn't apply cleanly. Please rebase

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule updated this revision to Diff 138504. jdemeule added a comment. Update after review. Add tests to check identical insertions and order dependent insertions. https://reviews.llvm.org/D43764 Files: clang-apply-replacements/include/clang-apply-replacements/Tooling/ApplyReplacements.h

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. > I think all requested modifications were done. Next time, please consider marking all the review comments done in phabricator, so that reviewers can see it obviously. https://review

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 138505. saar.raz added a comment. Fixed SpecializedConcept reference to NamedConcept. Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h in

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 138509. saar.raz added a comment. Fixed another SpecializedConcept reference to NamedConcept. Repository: rC Clang https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sem

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

lebedev.ri added a comment. In https://reviews.llvm.org/D43322#1037889, @Quuxplusone wrote: > The backward-compatibility-concerned diagnostic, > `-Wreturn-std-move-in-c++11`, is *not* appropriate for `-Wmove`; Have you evaluated possibility of adding `-Wreturn-std-move-in-c++11` to one of `CX

r327618 - More warnings when double truncation to float: compound assignment is supported now.

Author: avt77 Date: Thu Mar 15 03:03:35 2018 New Revision: 327618 URL: http://llvm.org/viewvc/llvm-project?rev=327618&view=rev Log: More warnings when double truncation to float: compound assignment is supported now. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trun

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

ioeric added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:353 +const FileEntry *Entry = FileAndReplacements.first; +ReplacementsToAtomicChanges DeduplicatedChanges(SM, Entry); +for (const auto &R : FileAndReplacements.second)

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

SimeonEhrig added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. tra wrote: > SimeonEhrig wrote:

[PATCH] D44512: [AAch64] Tests for ACLE FP16 macros

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: samparker, olista01, evandro, az. Herald added subscribers: kristof.beyls, javed.absar. This adds some missing tests for the AArch64 FP16 macros. https://reviews.llvm.org/D44512 Files: test/Preprocessor/aarch64-target-features.

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:353 +const FileEntry *Entry = FileAndReplacements.first; +ReplacementsToAtomicChanges DeduplicatedChanges(SM, Entry); +for (const auto &R : FileAndReplacements.secon

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

ioeric added inline comments. Comment at: clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:353 +const FileEntry *Entry = FileAndReplacements.first; +ReplacementsToAtomicChanges DeduplicatedChanges(SM, Entry); +for (const auto &R : FileAndReplacements.second)

[PATCH] D43821: [SemaCXX] _Pragma("clang optimize off") not affecting lambda.

CarlosAlbertoEnciso added a comment. Ping. Thanks Repository: rC Clang https://reviews.llvm.org/D43821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

alexfh added a comment. In https://reviews.llvm.org/D23130#1037256, @bkramer wrote: > I'd like to, but I don't know when I find time to rebase this thing after > more than a year of waiting for review. Sorry, it was just lost ¯\_(ツ)_/¯. I may be relying on pings from the other side too much.

[PATCH] D44512: [AAch64] Tests for ACLE FP16 macros

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. These look right to me. https://reviews.llvm.org/D44512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D44352: [Concepts] Constrained template parameters

saar.raz updated this revision to Diff 138537. saar.raz added a comment. Fixed test. Repository: rC Clang https://reviews.llvm.org/D44352 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/TemplateBase.h include/clang/Basic/DiagnosticPar

[PATCH] D44512: [AAch64] Tests for ACLE FP16 macros

SjoerdMeijer added a comment. Thanks for reviewing! https://reviews.llvm.org/D44512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r327623 - [AAch64] Tests for ACLE FP16 macros

Author: sjoerdmeijer Date: Thu Mar 15 06:36:30 2018 New Revision: 327623 URL: http://llvm.org/viewvc/llvm-project?rev=327623&view=rev Log: [AAch64] Tests for ACLE FP16 macros This adds some missing tests for the AArch64 FP16 macros. Differential Revision: https://reviews.llvm.org/D44512 Modifie

[PATCH] D44512: [AAch64] Tests for ACLE FP16 macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL327623: [AAch64] Tests for ACLE FP16 macros (authored by SjoerdMeijer, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D44512?vs=138521&id=1385

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

alexfh added a comment. It looks like some existing tests could benefit from this: $ grep -R -l 'note: ' test/clang-tidy/ test/clang-tidy/bugprone-forward-declaration-namespace.cpp test/clang-tidy/llvm-twine-local.cpp test/clang-tidy/overlapping.cpp test/clang-tidy/google-readability-ne

[PATCH] D44517: [change-namespace] Don't match a function call/ref multiple times.

ioeric created this revision. ioeric added a reviewer: hokein. Herald added subscribers: cfe-commits, klimek. Previously, the matcher matches a function call/ref multiple times, one for each decl ancestor. This might cause problems. For example, in the following case, `func()` would be matched onc

[PATCH] D44517: [change-namespace] Don't match a function call/ref multiple times.

ioeric updated this revision to Diff 138550. ioeric added a comment. - small fix. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44517 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeN

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:495 +llvm::Optional ClangdLSPServer::getDocument(PathRef File) { + llvm::Optional Contents = DraftMgr.getDraft(File); + if (!Contents) This function is equivalent to `return DraftMgr.ge

[PATCH] D44517: [change-namespace] Don't match a function call/ref multiple times.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[clang-tools-extra] r327629 - [change-namespace] Don't match a function call/ref multiple times.

Author: ioeric Date: Thu Mar 15 07:45:02 2018 New Revision: 327629 URL: http://llvm.org/viewvc/llvm-project?rev=327629&view=rev Log: [change-namespace] Don't match a function call/ref multiple times. Summary: Previously, the matcher matches a function call/ref multiple times, one for each decl an

[PATCH] D44517: [change-namespace] Don't match a function call/ref multiple times.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE327629: [change-namespace] Don't match a function call/ref multiple times. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D44517?vs=138550&id=138556#toc Reposi

[PATCH] D44517: [change-namespace] Don't match a function call/ref multiple times.

This revision was automatically updated to reflect the committed changes. Closed by commit rL327629: [change-namespace] Don't match a function call/ref multiple times. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44

[PATCH] D44231: [clang-tidy] Check for sizeof that call functions

pfultz2 added a comment. So I've updated the documentation on this. Are there any other updates needed for this to get it merged in? https://reviews.llvm.org/D44231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

r327634 - Recommit r326946 after reducing CallArgList memory footprint

Author: yaxunl Date: Thu Mar 15 08:25:19 2018 New Revision: 327634 URL: http://llvm.org/viewvc/llvm-project?rev=327634&view=rev Log: Recommit r326946 after reducing CallArgList memory footprint Added: cfe/trunk/test/CodeGenCXX/amdgcn-func-arg.cpp Modified: cfe/trunk/lib/CodeGen/CGAtomic.c

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark updated this revision to Diff 138569. simark marked 6 inline comments as done. simark added a comment. Changes based on review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44408 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServ

r327636 - [OPENMP] Codegen for `omp declare target` construct.

Author: abataev Date: Thu Mar 15 08:47:20 2018 New Revision: 327636 URL: http://llvm.org/viewvc/llvm-project?rev=327636&view=rev Log: [OPENMP] Codegen for `omp declare target` construct. Added initial codegen for device side of declarations inside `omp declare target` construct + codegen for impl

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.h:78 + /// Calls forceReparse() on all currently opened files. + /// As a result, this method may be very expensive. NIT: there is no `forceReparse()` anymore, maybe remove its mention fr

[PATCH] D34796: upporting -f(no)-reorder-functions flag, clang side change

davidxl added inline comments. Comment at: docs/ClangCommandLineReference.rst:1750 + +Add section prefixes for hot/cold functions + prefix or suffix? Or just leave the details out (also consider the interaction with -ffunction-sections)? Consider documenting:

[PATCH] D44408: Move DraftMgr from ClangdServer to ClangdLSPServer

simark updated this revision to Diff 138581. simark marked 2 inline comments as done. simark added a comment. Address latest review comments. Also, update the comments in DraftStore.{h,cpp} that were outdated. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44408 Files: clang

[PATCH] D44435: Add the module name to __cuda_module_ctor and __cuda_module_dtor for unique function names

tra added inline comments. Comment at: unittests/CodeGen/IncrementalProcessingTest.cpp:176-178 + +// In CUDA incremental processing, a CUDA ctor or dtor will be generated for +// every statement if a fatbinary file exists. SimeonEhrig wrote: > tra wrote: > > Sim

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values for ARM

simpal01 added a comment. @erichkeane Could you please tell me why this was done only for -cc1 and if there is any plan to add this to the driver in general ? Repository: rL LLVM https://reviews.llvm.org/D42978 ___ cfe-commits mailing list cfe-c

r327654 - [OPENMP, NVPTX] Improve globalization of the variables captured by value.

Author: abataev Date: Thu Mar 15 11:10:54 2018 New Revision: 327654 URL: http://llvm.org/viewvc/llvm-project?rev=327654&view=rev Log: [OPENMP, NVPTX] Improve globalization of the variables captured by value. If the variable is captured by value and the corresponding parameter in the outlined func

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:388 def PessimizingMove : DiagGroup<"pessimizing-move">; +def ReturnStdMoveInCXX11 : DiagGroup<"return-std-move-in-c++11">; +def ReturnStdMove : DiagGroup<"return-std-move">;

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 138594. Quuxplusone added a comment. Rebase on master, now that the refactoring https://reviews.llvm.org/D43898 has been pushed (thanks @rtrieu!) Repository: rC Clang https://reviews.llvm.org/D43322 Files: include/clang/Basic/DiagnosticGroups.td

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

rnk added a comment. In https://reviews.llvm.org/D43184#1038396, @mstorsjo wrote: > (Accidentally pressed submit too soon) > > This was my conclusion at some point as well - but there's also a few issues > with that approach which makes me quite hesitant: > > - doing fixups in the code segment r

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun updated this revision to Diff 138595. khuttun added a comment. Rebased https://reviews.llvm.org/D41655 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/UnusedReturnValueCheck.cpp clang-tidy/bugprone/UnusedReturnValueCheck.h

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138596. zinovy.nis marked 10 inline comments as done. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallChec

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138597. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added inline comments. Comment at: clang-tidy/bugprone/ParentVirtualCallCheck.cpp:128 + diag(Member->getQualifierLoc().getSourceRange().getBegin(), + "'%0' is a grand-parent's method, not parent's. Did you mean %1?") + << CalleeName << ParentsStr; -

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138598. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138599. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 138601. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/ParentVirtualCallCheck.cpp clang-tidy/bugprone/ParentVirtualCallC

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis added inline comments. Comment at: test/clang-tidy/bugprone-parent-virtual-call.cpp:127 +// Just to instantiate DF. +int bar() { return (new DF())->virt_1(); } aaron.ballman wrote: > What should happen in this case? > ``` > struct Base { > virtual vo

[PATCH] D44533: [AMDGPU] Fix codegen for inline assembly

yaxunl created this revision. yaxunl added reviewers: arsenm, rampitec, b-sumner. Herald added subscribers: eraman, t-tye, tpr, dstuttard, nhaehnle, wdng, kzhuravl. Need to override convertConstraint to recognise amdgpu specific register names. https://reviews.llvm.org/D44533 Files: lib/Basi

[PATCH] D44534: Fix codegen for structured binding binding in conditions

Rakete created this revision. Rakete added reviewers: lichray, rsmith. Rakete added a project: clang. The codegen for conditions assumes that a normal variable declaration is used in a condition, but this is not the case when a structured binding is used. This fixes PR36747

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

mstorsjo added a comment. In https://reviews.llvm.org/D43184#1039278, @rnk wrote: > In https://reviews.llvm.org/D43184#1038396, @mstorsjo wrote: > > > (Accidentally pressed submit too soon) > > > > This was my conclusion at some point as well - but there's also a few > > issues with that approac

[PATCH] D44536: Avoid segfault when destructor is not yet known

dim created this revision. dim added reviewers: rjmccall, rsmith, majnemer, efriedma. In some cases, a class type can have a definition, but its destructor may not yet be known. In that case, a segfault can occur in `EmitObjectDelete`. Avoid it by checking the return value of `CXXRecordDecl::get

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

rnk added a comment. In https://reviews.llvm.org/D43184#1039354, @mstorsjo wrote: > Ok - I'll put it on the backburner, and maybe see if I'd try implementing the > linker part of fixing unannotated data imports at some point. I'm not sure that's feasible. At least for x86, global addresses can

[PATCH] D44536: Avoid segfault when destructor is not yet known

rjmccall added a comment. I'm not sure it's supposed to be a valid state to get into IRGen with a non-trivial destructor that isn't yet declared. Richard? Repository: rC Clang https://reviews.llvm.org/D44536 ___ cfe-commits mailing list cfe-com

[PATCH] D44536: Avoid segfault when destructor is not yet known

dim added a comment. In https://reviews.llvm.org/D44536#1039420, @rjmccall wrote: > I'm not sure it's supposed to be a valid state to get into IRGen with a > non-trivial destructor that isn't yet declared. Richard? As a side note, clang also emits a warning about it (but then crashes :) ):

[PATCH] D44536: Avoid segfault when destructor is not yet known

rjmccall added a comment. Hmm. Sema is lazy about actually creating implicit destructor declarations, but it's supposed to only do it whenever the destructor is actually used for something. I suspect that Sema just thinks that nothing is using c::~c, because the only thing that does use it is

[PATCH] D44536: Avoid segfault when destructor is not yet known

rjmccall added a comment. In https://reviews.llvm.org/D44536#1039428, @rjmccall wrote: > Hmm. Sema is lazy about actually creating implicit destructor declarations, > but it's supposed to only do it whenever the destructor is actually used for > something. I suspect that Sema just thinks that

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

QF5690 created this revision. QF5690 added a reviewer: rsmith. QF5690 added a project: clang. Herald added a subscriber: cfe-commits. There is a problem, that `assign` attribute very often getting out of attention. For example, consider this code: @property(nonatomic, strong, readonly, nullabl

[PATCH] D43184: [WIP] [ItaniunCXXABI] Add an option for loading the type info vtable with dllimport

mstorsjo added a comment. In https://reviews.llvm.org/D43184#1039385, @rnk wrote: > In https://reviews.llvm.org/D43184#1039354, @mstorsjo wrote: > > > Ok - I'll put it on the backburner, and maybe see if I'd try implementing > > the linker part of fixing unannotated data imports at some point. >

[PATCH] D44541: [OpenMP][Clang] Move device global stack init before master-workers split

gtbercea created this revision. gtbercea added reviewers: ABataev, carlo.bertolli, grokos, caomhin. Herald added subscribers: cfe-commits, guansong, jholewinski. This patch moves the call to the stack init data sharing function before the splitting of threads into master and workers. This ensures

[PATCH] D44508: Remove unnecessary include from Driver.cpp

marsupial added a comment. Shouldn't the Translation Unit be responsible for knowing what it needs rather than hoping it's already been used somewhere up the chain. Perhaps std::unique_ptr and std::make_pair are too low level and one can assume, but https://reviews.llvm.org/D44509 seems like a p

[PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

rjmccall added a comment. I think this is okay. We can review further if we see other problems. https://reviews.llvm.org/D17893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r327593 - [CFG] Allow CallExpr's to be looked up in CFG's

Thank you for fixing this one! I must have missed it. On 14/03/2018 5:09 PM, Richard Trieu via cfe-commits wrote: Author: rtrieu Date: Wed Mar 14 17:09:26 2018 New Revision: 327593 URL: http://llvm.org/viewvc/llvm-project?rev=327593&view=rev Log: [CFG] Allow CallExpr's to be looked up in CFG's

r327687 - [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Thu Mar 15 17:37:51 2018 New Revision: 327687 URL: http://llvm.org/viewvc/llvm-project?rev=327687&view=rev Log: [Analysis] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Analysis/Analyses

[PATCH] D44505: [MS] Always use base dtors in place of complete/vbase dtors when possible

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D44505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[libcxxabi] r327690 - [demangler] Support for s in generic lambdas.

Author: epilk Date: Thu Mar 15 20:06:30 2018 New Revision: 327690 URL: http://llvm.org/viewvc/llvm-project?rev=327690&view=rev Log: [demangler] Support for s in generic lambdas. These s refer to "artifical" s that don't appear in the mangled name, so we just print them as "auto". Modified: l

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

modocache created this revision. modocache added reviewers: GorNishanov, eric_niebler, lewissbaker. Herald added a subscriber: EricWF. https://reviews.llvm.org/rL325291 implemented Coroutines TS N4723 section [dcl.fct.def.coroutine]/7, but it performed lookup of allocator functions within both the