[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

rjmccall added inline comments. Comment at: include/clang/AST/Expr.h:875 + /// is set to true. + bool IsUnique = false; + Humor me and pack this in the bitfields in Stmt, please. :) Comment at: include/clang/AST/Expr.h:932 + void setIsUniq

[PATCH] D39562: [CodeGen][ObjC] Fix an assertion failure caused by copy elision

rjmccall added a comment. Oh, and you need to serialize this bit. https://reviews.llvm.org/D39562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. As this will land in clang 7, can you add a note to the release notes that this breaks backwards compatibility for this interface (can be another commit)? Also, we should point out that

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

MTC updated this revision to Diff 136901. MTC added a comment. - If the operand of the ++ operator is of type `_Bool`, also set to true. - Add test file `_Bool-increment-decement.c`. Repository: rC Clang https://reviews.llvm.org/D43741 Files: include/clang/StaticAnalyzer/Core/PathSensiti

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

MTC added a comment. Thank you for your review, @NoQ! - `isBooleanType()` is used to check `_Bool` in C99/C11 and `bool` in C++. For `_Bool` , there is the same overflow problem. - In C++98/C++11/C++14, for `++bool` and `bool+`, both sets true directly. - In C++, `--bool` and `bool--` is illeag

r326645 - Better OpenBSD frontend support

Author: kamil Date: Sat Mar 3 03:47:27 2018 New Revision: 326645 URL: http://llvm.org/viewvc/llvm-project?rev=326645&view=rev Log: Better OpenBSD frontend support Summary: - Like other *BSD, conditioning certain flags to pass - To prepare future OpenBSD sanitisers. Patch by: David CARLIER Revi

[PATCH] D43818: Better OpenBSD frontend support

This revision was automatically updated to reflect the committed changes. Closed by commit rL326645: Better OpenBSD frontend support (authored by kamil, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43818?vs=136804&id=136903#toc Rep

r326648 - OpenBSD Driver basic sanitiser support

Author: kamil Date: Sat Mar 3 03:52:52 2018 New Revision: 326648 URL: http://llvm.org/viewvc/llvm-project?rev=326648&view=rev Log: OpenBSD Driver basic sanitiser support Summary: Basic support of Sanitiser to follow-up ubsan support in compiler-rt. Needs to use lld instead of base ld to be fully

[PATCH] D43961: OpenBSD Driver basic sanitiser support

This revision was automatically updated to reflect the committed changes. Closed by commit rC326648: OpenBSD Driver basic sanitiser support (authored by kamil, committed by ). Repository: rC Clang https://reviews.llvm.org/D43961 Files: lib/Driver/ToolChains/OpenBSD.cpp lib/Driver/ToolChai

r326652 - Disable tests of -fsanitize on OpenBSD

Author: kamil Date: Sat Mar 3 04:28:54 2018 New Revision: 326652 URL: http://llvm.org/viewvc/llvm-project?rev=326652&view=rev Log: Disable tests of -fsanitize on OpenBSD This causes failures on buildbots: /export/users/atombot/llvm/clang-atom-d525-fedora-rel/llvm/tools/clang/test/Driver/fsanitiz

[PATCH] D43961: OpenBSD Driver basic sanitiser support

krytarowski added a comment. http://llvm.org/viewvc/llvm-project?revision=326652&view=revision /export/users/atombot/llvm/clang-atom-d525-fedora-rel/stage1/bin/clang -target x86_64-linux-gnu -fsanitize=hwaddress /export/users/atombot/llvm/clang-atom-d525-fedora-rel/llvm/tools/clang/test/Drive

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen created this revision. devnexen added a reviewer: krytarowski. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. OpenBSD supporting only UBsan unsupported this particular test Repository: rC Clang https://reviews.llvm.org/D44069 Files:

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

krytarowski added a comment. This is not breaking (only?) on OpenBSD, but the triple is breaking all tested platforms. Please support it properly. Repository: rC Clang https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. In https://reviews.llvm.org/D44069#1026551, @krytarowski wrote: > This is not breaking (only?) on OpenBSD, but the triple is breaking all > tested platforms. > Please support it properly. What needs to be done ? I mean I have all OpenBSD compiler-rt code in my side

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

krytarowski added a comment. Revert: http://llvm.org/viewvc/llvm-project?revision=326652&view=revision And fix. Repository: rC Clang https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 136919. devnexen added a comment. - Only Asan is not working under OpenBSD - unknown-arg test fails under OpenBSD https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c test/Driver/unknown-arg.c Index: test/Driver/unknown-arg.c ==

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen added a comment. In https://reviews.llvm.org/D44069#1026563, @krytarowski wrote: > Revert: http://llvm.org/viewvc/llvm-project?revision=326652&view=revision > > And fix. I launched llvm-lit to the whole directory and this is the fixes. https://reviews.llvm.org/D44069 _

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

krytarowski added a comment. Please mark ubsan as supported now. https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

devnexen updated this revision to Diff 136924. devnexen added a comment. Enable UBsan test https://reviews.llvm.org/D44069 Files: test/Driver/fsanitize.c test/Driver/unknown-arg.c Index: test/Driver/unknown-arg.c === --- test

[PATCH] D43750: Allow writing calling convention attributes on function types

aaron.ballman added a comment. Ping https://reviews.llvm.org/D43750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44069: Test Driver sanitise, unsupported on OpenBSD

davide added a comment. Apologies, but this is not an area I'm particularly familiar with. So, I'm resigning, but @filcab / @vsk can probably comment. https://reviews.llvm.org/D44069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: r326622 - Don't claim that va_start has special semantic checks

The 't' was there because __builtin_va_start and __va_start had them, but those do in fact have custom sema checking so copying that was in fact incorrect. Thanks for fixing my bugs! On Fri, Mar 2, 2018 at 4:41 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk >

r326665 - Create a subject list for the `used` attribute rather than use custom checking logic.

Author: aaronballman Date: Sat Mar 3 13:02:09 2018 New Revision: 326665 URL: http://llvm.org/viewvc/llvm-project?rev=326665&view=rev Log: Create a subject list for the `used` attribute rather than use custom checking logic. This changes the diagnostic wording somewhat, but otherwise intends no

Re: r326665 - Create a subject list for the `used` attribute rather than use custom checking logic.

Is it easy to mention variables first in the diag? That's probably the most common subject for this attribute. (If it's not easy, nevermind -- definitely a polish thing.) On Sat, Mar 3, 2018, 4:04 PM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date:

[PATCH] D39159: [analyzer] Improves the logic of GenericTaintChecker identifying stdin.

MTC updated this revision to Diff 136934. MTC set the repository for this revision to rC Clang. MTC added a comment. Herald added subscribers: cfe-commits, a.sidorin. Herald added a reviewer: george.karpenkov. Update the `taint-generic.c` to test both `stdin` declaration variants. Repository:

[PATCH] D39159: [analyzer] Improves the logic of GenericTaintChecker identifying stdin.

MTC added a comment. @NoQ, Very sorry, I've forgotten about this patch, it has now been updated. Repository: rC Clang https://reviews.llvm.org/D39159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li