[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017918, @lebedev.ri wrote: > Is there some (internal to `BitstreamWriter`) logic that would 'assert()' if > trying to output some recordid > which is, according to the `BLOCKINFO_BLOCK`, should not be there? > E.g. outputting `V

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136010. juliehockett marked 10 inline comments as done. juliehockett added a comment. 1. Moved the serialization logic out of the Mapper class and into its own namespace 2. Updated tests 3. Addressing comments https://reviews.llvm.org/D41102 Files:

r326155 - [analyzer] Logging test quickfix.

Author: george.karpenkov Date: Mon Feb 26 17:13:28 2018 New Revision: 326155 URL: http://llvm.org/viewvc/llvm-project?rev=326155&view=rev Log: [analyzer] Logging test quickfix. Modified: cfe/trunk/test/Analysis/region_store_overflow.c Modified: cfe/trunk/test/Analysis/region_store_overflow.c

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists added a comment. I can certainly make them all the same. https://reviews.llvm.org/D43773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists added a comment. > Is there a subtle reason for this inconsistency that I'm not seeing? I suspect that it's because they were written at different times. (When I say 'written at different times', I mean I adapted the existing `op==` for the containers - not that this new code was wri

r326156 - [analyzer] Logging test typo quickfix.

Author: george.karpenkov Date: Mon Feb 26 17:31:06 2018 New Revision: 326156 URL: http://llvm.org/viewvc/llvm-project?rev=326156&view=rev Log: [analyzer] Logging test typo quickfix. Modified: cfe/trunk/test/Analysis/region_store_overflow.c Modified: cfe/trunk/test/Analysis/region_store_overf

r326157 - [analyzer] Switch the default exploration strategy to priority queue based on coverage

Author: george.karpenkov Date: Mon Feb 26 17:31:56 2018 New Revision: 326157 URL: http://llvm.org/viewvc/llvm-project?rev=326157&view=rev Log: [analyzer] Switch the default exploration strategy to priority queue based on coverage After the investigation it seems safe to flip the switch. Differe

[PATCH] D43782: [analyzer] Switch the default exploration strategy to priority queue based on coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rC326157: [analyzer] Switch the default exploration strategy to priority queue based on… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https:

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, beanz. Herald added subscribers: cfe-commits, christof, mgorny. When the generated __config file is being used, it is currently only copied during installation process. However, that means that the file that gets copied int

[PATCH] D43798: [analyzer] UndefinedAssignment: Fix warning message on implicit copy/move constructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. When a class forgets to initialize a field in the constructor, and then gets copied around, a warning is emitted that the value assigned to a

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ updated this revision to Diff 136020. NoQ added a comment. Address comments. https://reviews.llvm.org/D43791 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/NewDelete-atomics.cpp Index: test/Analysis/NewDelete-atomics.cpp =

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2847 + + AtomicExpr::AtomicOp Op = AE->getOp(); + if (Op != AtomicExpr::AO__c11_atomic_fetch_add && george.karpenkov wrote: > IMO would be slightly easier to read with logic re

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 136019. jdenny marked 8 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. This revision should address all issues raised. https://reviews.llvm.org/D43248 Files: include/clang/AST/Attr.h include/clang/Basic/Attr.

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: include/clang/AST/Attr.h:210-212 + unsigned Idx; + bool HasThis; + bool IsValid; aaron.ballman wrote: > I think it might be best to mash these together using bit-fields: > ``` > unsigned Idx : 30; > unsigned HasThis :

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2899 + // to find out if a likely-false-positive suppression should kick in. + for (const LocationContext *LC = CurrentLC; LC; LC = LC->getParent()) { +if (isa(LC->

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2899 + // to find out if a likely-false-positive suppression should kick in. + for (const LocationContext *LC = CurrentLC; LC; LC = LC->getParent()) { +if (isa(LC->getDecl())) {

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. OK I would still appreciate a comment on why you expect fetch_add and friends in the lowest destructor in the stack. https://reviews.llvm.org/D43791 ___

r326165 - [analyzer] Fix an uninitialized field.

Author: dergachev Date: Mon Feb 26 18:53:30 2018 New Revision: 326165 URL: http://llvm.org/viewvc/llvm-project?rev=326165&view=rev Log: [analyzer] Fix an uninitialized field. Found by the analyzer! Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/FunctionSummary.h Modifie

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326164: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on… (authored by ikudrin, committed by ). Changed prior to commit: https://reviews.llvm.org/D43621?vs=135888&id=136026#

[PATCH] D43798: [analyzer] UndefinedAssignment: Fix warning message on implicit copy/move constructors.

NoQ added a comment. See also https://reviews.llvm.org/rC326165. Repository: rC Clang https://reviews.llvm.org/D43798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43800: [ASTMatchers] Allow file-based narrowing matches to work with NestedNameSpecifierLocs.

dlj created this revision. dlj added a reviewer: rsmith. Herald added subscribers: sanjoy, klimek. The narrowing matchers isExpansionInMainFile, isExpansionInSystemHeader, and isExpansionInFileMatching work for TypeLocs, but not NestedNameSpecifierLocs. This changes the matchers to use getSourceRa

[PATCH] D43804: [analyzer] Enable cfg-temporary-dtors by default?

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Final results are still being baked on my end, but by putting this on review i'm trying to say that i believe i managed to fix the biggest pr

[PATCH] D43805: Optionally use nameless IR types

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall. Type in the LLVM IR may have names but only for the purpose of human readability (see discussions in https://reviews.llvm.org/D40567, http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20171127/210816.html and http:

[PATCH] D40567: Always show template parameters in IR type names

sepavloff abandoned this revision. sepavloff added a comment. The feedback here, in https://reviews.llvm.org/D40508 and in the mail list (http://lists.llvm.org/pipermail/llvm-dev/2017-December/119585.html) demonstrates that this is a wrong direction. Part of this patch is used in https://reviews

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff abandoned this revision. sepavloff added a comment. Using llvm type names is considered a wrong direction. https://reviews.llvm.org/D40508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r326168 - Attempt to fix greendragon bot after r326141

Author: anemet Date: Mon Feb 26 20:49:26 2018 New Revision: 326168 URL: http://llvm.org/viewvc/llvm-project?rev=326168&view=rev Log: Attempt to fix greendragon bot after r326141 Modified: cfe/trunk/test/Driver/codeview-column-info.c Modified: cfe/trunk/test/Driver/codeview-column-info.c URL:

Re: r326168 - Attempt to fix greendragon bot after r326141

This seems bogus to me. CodeView can be generated on any build platform; it just needs the correct triple, which Reid added in r326144. From: cfe-commits on behalf of Adam Nemet via cfe-commits Reply-To: Adam Nemet Date: Monday, February 26, 2018 at 8:51 PM To: "cfe-commits@lists.llvm.org" S

Re: r326168 - Attempt to fix greendragon bot after r326141

I don’t think we can deal with the slash options: clang-7.0: warning: '/Users/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c' treated as the '/U' option [-Wslash-u-filename] clang-7.0: note: Use '--' to treat s

Re: r326168 - Attempt to fix greendragon bot after r326141

Could you point me to the specific bot that was failing? I've dealt with that problem before, and it shouldn't be hard to fix, but I wanna monitor the bot after the fix to make sure it stays green. From: on behalf of Adam Nemet Date: Monday, February 26, 2018 at 9:30 PM To: Shoaib Meenai Cc:

Re: r326168 - Attempt to fix greendragon bot after r326141

This is the bot with the failure: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/46794/#showFailuresLink But to make matters worse, greendragon is experience some difficulty fetc

Re: r326168 - Attempt to fix greendragon bot after r326141

Ah, that should be sufficient. > On Feb 26, 2018, at 9:44 PM, Shoaib Meenai wrote: > > Thanks. I'm building on macOS locally to confirm the original problem and my > fix. > > From: on behalf of Adam Nemet > Date: Monday, February 26, 2018 at 9:42 PM > To: Shoaib Meenai > Cc: "cfe-commits@l

Re: r326168 - Attempt to fix greendragon bot after r326141

Thanks. I'm building on macOS locally to confirm the original problem and my fix. From: on behalf of Adam Nemet Date: Monday, February 26, 2018 at 9:42 PM To: Shoaib Meenai Cc: "cfe-commits@lists.llvm.org" , Reid Kleckner , Zachary Turner Subject: Re: r326168 - Attempt to fix greendragon bot

Re: r326168 - Attempt to fix greendragon bot after r326141

I already reverted this a long time ago, but if Shoaib has a proper fix that would be great On Mon, Feb 26, 2018 at 9:45 PM Adam Nemet wrote: > Ah, that should be sufficient. > > > On Feb 26, 2018, at 9:44 PM, Shoaib Meenai wrote: > > Thanks. I'm building on macOS locally to confirm the original

Re: r326168 - Attempt to fix greendragon bot after r326141

What did you revert? > On Feb 26, 2018, at 9:46 PM, Zachary Turner wrote: > > I already reverted this a long time ago, but if Shoaib has a proper fix that > would be great > On Mon, Feb 26, 2018 at 9:45 PM Adam Nemet > wrote: > Ah, that should be sufficient. > > >>

Re: r326168 - Attempt to fix greendragon bot after r326141

Reid re-committed r326141 this morning (and followed up with r326144), and I don't think either of those have been reverted? From: Zachary Turner Date: Monday, February 26, 2018 at 9:47 PM To: Adam Nemet Cc: Shoaib Meenai , "cfe-commits@lists.llvm.org" , Reid Kleckner Subject: Re: r326168 - A

Re: r326168 - Attempt to fix greendragon bot after r326141

Yep. > On Feb 26, 2018, at 9:50 PM, Shoaib Meenai wrote: > > Reid re-committed r326141 this morning (and followed up with r326144), and I > don't think either of those have been reverted? > > From: Zachary Turner > Date: Monday, February 26, 2018 at 9:47 PM > To: Adam Nemet > Cc: Shoaib Mee

[PATCH] D43303: [Format] Fix for bug 35641

kadircet added a comment. ping Repository: rC Clang https://reviews.llvm.org/D43303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326171 - [Driver] Fix codeview-column-info on macOS

Author: smeenai Date: Mon Feb 26 22:04:23 2018 New Revision: 326171 URL: http://llvm.org/viewvc/llvm-project?rev=326171&view=rev Log: [Driver] Fix codeview-column-info on macOS macOS home directory paths begin with /Users, and clang-cl interprets the /U portion as a macro undefine rather than a p

Re: r326168 - Attempt to fix greendragon bot after r326141

r326171 works locally. I'll keep an eye on the bots. From: on behalf of Adam Nemet Date: Monday, February 26, 2018 at 9:51 PM To: Shoaib Meenai Cc: Zachary Turner , "cfe-commits@lists.llvm.org" , Reid Kleckner Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 Yep. On Feb

Re: r326168 - Attempt to fix greendragon bot after r326141

Interesting, thanks for the fix. > On Feb 26, 2018, at 10:06 PM, Shoaib Meenai wrote: > > r326171 works locally. I'll keep an eye on the bots. > > From: mailto:ane...@apple.com>> on behalf of Adam Nemet > mailto:ane...@apple.com>> > Date: Monday, February 26, 2018 at 9:51 PM > To: Shoaib Meen

Re: r326168 - Attempt to fix greendragon bot after r326141

BTW, I think that the LLVM bots have trouble accessing subversion too. I already let Galina know. > On Feb 26, 2018, at 10:06 PM, Shoaib Meenai wrote: > > r326171 works locally. I'll keep an eye on the bots. > > From: on behalf of Adam Nemet > Date: Monday, February 26, 2018 at 9:51 PM > T

Re: r326168 - Attempt to fix greendragon bot after r326141

Never mind, I didn’t realize Reid resubmitted my cl after I reverted it. In fact, I reverted it because of this greendragon failure which I wasn’t sure how to fix at the time On Mon, Feb 26, 2018 at 10:12 PM Adam Nemet wrote: > BTW, I think that the LLVM bots have trouble accessing subversion too

r326173 - [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

Author: mstorsjo Date: Mon Feb 26 22:27:06 2018 New Revision: 326173 URL: http://llvm.org/viewvc/llvm-project?rev=326173&view=rev Log: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields When targeting GNU/MinGW for i386, the size of the "long double" data type is 12 byte

[PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

This revision was automatically updated to reflect the committed changes. Closed by commit rL326173: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

Re: r326168 - Attempt to fix greendragon bot after r326141

So this doesn’t appear to fix the issue that led to my revert earlier. http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/6760 There’s no slashes in the command line that’s failing. However, this bot doesn’t seem to be updating and hasn’t pulled in this cl yet, but I exp

Re: r326168 - Attempt to fix greendragon bot after r326141

Hmm. Reid had included a fix for compiler-rt in r326141, but that doesn't seem particularly relevant to this failure. In any case, I expect I'll receive emails when that bot is up and running again, and I can take a look then. (It didn't repro locally on Linux for me.) From: Zachary Turner Dat

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

krisb created this revision. Herald added subscribers: cfe-commits, mgorny, klimek. Repository: rC Clang https://reviews.llvm.org/D43809 Files: include/clang/Frontend/CompilerInstance.h lib/CodeGen/CodeGenAction.cpp lib/Frontend/CompilerInstance.cpp unittests/Format/FormatTest.cpp un

[PATCH] D43805: Optionally use nameless IR types

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1735 + HelpText<"Whether to use IR type names (option: none, use)">, + Values<"none,use">; def relocatable_pch : Flag<["-", "--"], "relocatable-pch">, Flags<[CC1Option]>, This is an un

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

krisb updated this revision to Diff 136041. krisb added a comment. Reverted unintentional changes. Repository: rC Clang https://reviews.llvm.org/D43809 Files: include/clang/Frontend/CompilerInstance.h lib/CodeGen/CodeGenAction.cpp lib/Frontend/CompilerInstance.cpp unittests/Frontend/

<    1   2