mzeren-vmw updated this revision to Diff 130487.
mzeren-vmw added a comment.
Documented CommentAlignment enumerators. Documenting them suggested better
enumerator names.
Added tests for multi-line comments, block comments and trailing comments.
Repository:
rC Clang
https://reviews.llvm.org/D
spatel updated this revision to Diff 130488.
spatel added a comment.
Patch updated:
1. Removed comment that didn't add value.
2. Added test with no sanitizing, reduced from PR35909.
https://reviews.llvm.org/D42249
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenCXX/catch-undef-behavior.cpp
te
Author: nico
Date: Thu Jan 18 13:40:27 2018
New Revision: 322901
URL: http://llvm.org/viewvc/llvm-project?rev=322901&view=rev
Log:
Remove TautologicalInRangeCompare from Extra and TautologicalCompare.
This removes the following (already default-off) warnings from -Wextra:
-Wtautological-type-li
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM.
Let me know if you need this committed.
Repository:
rC Clang
https://reviews.llvm.org/D42227
___
cfe-commits mailing list
cfe-commi
MaskRay updated this revision to Diff 130493.
MaskRay added a comment.
More
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
==
etherzhhb added a comment.
Thanks, I will commit tonight. If you want this patch before that, you could
commit it for me.
Repository:
rC Clang
https://reviews.llvm.org/D42227
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
nathawes planned changes to this revision.
nathawes marked 32 inline comments as done.
nathawes added a comment.
@ioeric I should have an updated patch up shortly with your inline comments
addressed + new tests. Thanks again for reviewing!
Comment at: include/clang/Index/Index
Eugene.Zelenko added inline comments.
Comment at: docs/clang-tidy/checks/objc-property-declaration.rst:45
+
+ If set, replaces the default list. (If you want to append to the default
list, set AdditionalAcronyms instead.)
+
Please limit string length to 80 sym
probinson added a comment.
Well, my understanding is that the pragma is a complete no-op even for MSVC,
and is used only as a marker for editors such as Visual Studio's.
So, unconditionally ignoring it would seem to be fine.
https://reviews.llvm.org/D42248
___
nathawes updated this revision to Diff 130496.
nathawes marked 6 inline comments as done.
nathawes added a comment.
- Applied the various refactorings suggested by @ioeric
- Extended c-index-test with a new option to print out the collected unit
indexing data, and
- Added tests for the unit index
tmsriram updated this revision to Diff 130500.
tmsriram added a comment.
METADATA tag changed to "RtLibUseGOT". Also see:
https://reviews.llvm.org/D42224/
https://reviews.llvm.org/D42217
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/noplt.c
Index: test/CodeGen/noplt.c
==
mzeren-vmw marked 2 inline comments as done.
mzeren-vmw added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1756
+ if (Alignment == CA_Preprocessor)
+(*I)->LevelOffset = 1;
} else {
krasimir wrote:
> This feels a bit awkward: we're
Hi Roman,
This commit has caused a regression in LLVM 6 which now triggers
-Wsign-compare for typeof(enum) and typeof(enumConstant). I filed
https://bugs.llvm.org/show_bug.cgi?id=36008. Could you please take a look
at it?
Thanks,
Alex
On 21 October 2017 at 09:44, Roman Lebedev via cfe-commits <
szepet created this revision.
szepet added reviewers: NoQ, dcoughlin, xazax.hun.
Herald added subscribers: dkrupp, a.sidorin, rnkovacs, baloghadamsoftware,
whisperity.
The checker marks the locations where the analyzer creates sinks. However, it
can happen that the sink was created because of a
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D42249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
szepet added inline comments.
Comment at: test/Analysis/loopexit-cfg-output.cpp:912-914
+// CHECK: [B5]
+// CHECK-NEXT: Succs (1): B8
+
NoQ wrote:
> P.S. This is not a regression introduced by your patch, but i'm really
> curious what does this block eve
szepet updated this revision to Diff 130503.
szepet marked 2 inline comments as done.
szepet added a comment.
Added comments and removed indirect goto support from this patch.
> This seems a bit scary because if there's no obvious one-to-once
> correspondence between entrances and exits along
szepet updated this revision to Diff 130505.
szepet added a comment.
> I essentially have one question at a glance - for loop counter variables,
> don't we want LoopEntrance be before the initialization?
I guess this would just make too much sense. Done that.
Additionally, handle the cases when
craig.topper created this revision.
craig.topper added reviewers: RKSimon, spatel, zvi, AndreiGrischenko.
This patch adds -mrdpid/-mno-rdpid and the rdpid intrinsic. The corresponding
LLVM commit has already been made.
https://reviews.llvm.org/D42272
Files:
include/clang/Basic/BuiltinsX86.de
Author: ctopper
Date: Thu Jan 18 16:28:42 2018
New Revision: 322912
URL: http://llvm.org/viewvc/llvm-project?rev=322912&view=rev
Log:
[X86] Add missing check for RDSEED to ICL, CNL, SKX sections of
test/Preprocessor/predefined-arch-macros.c
Modified:
cfe/trunk/test/Preprocessor/predefined-ar
lichray added inline comments.
Comment at: libcxx/include/experimental/simd:1561
+template >
+_Tp reduce(const simd<_Tp, _Abi>& __v, _BinaryOp __op = _BinaryOp()) {
Specified in terms of the transparent `plus<>`.
https://reviews.llvm.org/D41844
___
szepet updated this revision to Diff 130516.
szepet marked 2 inline comments as done.
szepet added a comment.
First, sorry for this delayed update, however, I was working on this and
running this on real projects. I wanted to make sure that this update will be
complete enough that this patch wou
lichray added inline comments.
Comment at: libcxx/include/experimental/simd:2330
+ simd<_Tp, _Abi>& __v) noexcept {
+ return where_expression, simd<_Tp, _Abi>>(__m, __v);
+}
style: `return {__m, __v};`?
https://reviews.llvm.org/D41843
_
szepet added inline comments.
Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:28-46
struct LoopState {
private:
enum Kind { Normal, Unrolled } K;
- const Stmt *LoopStmt;
- const LocationContext *LCtx;
- unsigned maxStep;
- LoopState(Kind InK, const Stmt *S, const L
juliehockett created this revision.
juliehockett added a reviewer: aaron.ballman.
Herald added a subscriber: klimek.
Adds AST matcher for a FunctionDecl that has a trailing return type.
https://reviews.llvm.org/D42273
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMat
mattd updated this revision to Diff 130523.
mattd retitled this revision from "[LangOpts] Add a LangOpt to represent
"#pragma region" support." to "Always allow "#pragma region".".
mattd edited the summary of this revision.
mattd added a comment.
I'm certainly fine with always allowing this pragm
phosek created this revision.
phosek added reviewers: aarongreen, mcgrathr, jakehehrlich, kcc.
Herald added a subscriber: cfe-commits.
libFuzzer has been ported to Fuchsia so enable it in the driver.
Repository:
rC Clang
https://reviews.llvm.org/D42275
Files:
lib/Driver/ToolChains/Fuchsia.
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
aemerson created this revision.
aemerson added reviewers: qcolombet, echristo.
Herald added subscribers: kristof.beyls, rovka.
Add an -fexperimental-isel driver option to enable/disable GlobalISel.
This is a more user friendly way of enabling GlobalISel instead of doing -mllvm
-global-isel.
Re
aemerson updated this revision to Diff 130530.
Repository:
rC Clang
https://reviews.llvm.org/D42276
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains/Clang.cpp
test/Driver/global-isel.c
Index: test/Driver/global-isel.c
Author: phosek
Date: Thu Jan 18 17:58:26 2018
New Revision: 322916
URL: http://llvm.org/viewvc/llvm-project?rev=322916&view=rev
Log:
[Fuchsia] Enable Fuzzer as a supported sanitizer on Fuchsia
libFuzzer has been ported to Fuchsia so enable it in the driver.
Differential Revision: https://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322916: [Fuchsia] Enable Fuzzer as a supported sanitizer on
Fuchsia (authored by phosek, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42275
Files:
lib/Driver/ToolChains/Fuchsia.cpp
vsk added a comment.
LGTM, for the record
Repository:
rC Clang
https://reviews.llvm.org/D42259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk added a comment.
Mind rebasing this when you have a chance?
Repository:
rC Clang
https://reviews.llvm.org/D42043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322918: [Refactor] Use enum instead of magic number in…
(authored by ether, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42227
Files:
lib/Sema/SemaDeclAttr.cpp
Index: lib/Sema/Se
Author: marshall
Date: Thu Jan 18 19:17:45 2018
New Revision: 322920
URL: http://llvm.org/viewvc/llvm-project?rev=322920&view=rev
Log:
Wrote my own version of is_permutation; that was dominating the timings
Modified:
libcxx/trunk/fuzzing/fuzzing.cpp
Modified: libcxx/trunk/fuzzing/fuzzing.cpp
Author: ether
Date: Thu Jan 18 19:07:00 2018
New Revision: 322918
URL: http://llvm.org/viewvc/llvm-project?rev=322918&view=rev
Log:
[Refactor] Use enum instead of magic number in
handleX86ForceAlignArgPointerAttr, NFC
Differential revision: https://reviews.llvm.org/D42227
Modified:
cfe/trun
phosek created this revision.
phosek added reviewers: jakehehrlich, mcgrathr, aarongreen.
Herald added subscribers: cfe-commits, cryptoad.
This adds driver tests for the Fuzzer support.
Repository:
rC Clang
https://reviews.llvm.org/D42283
Files:
test/Driver/fuchsia.c
Index: test/Driver/f
Author: phosek
Date: Thu Jan 18 20:08:06 2018
New Revision: 322922
URL: http://llvm.org/viewvc/llvm-project?rev=322922&view=rev
Log:
[Fuchsia] Tests for the Fuzzer support in Fuchsia driver
This adds driver tests for the Fuzzer support.
Differential Revision: https://reviews.llvm.org/D42283
Mod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322922: [Fuchsia] Tests for the Fuzzer support in Fuchsia
driver (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42283?vs
elsteveogrande updated this revision to Diff 130556.
elsteveogrande marked an inline comment as done.
elsteveogrande added a comment.
Fixes, but first, a question for reviewers:
Looking at the description of `clang_disposeString`:
/**
* \brief Free the given string.
*/
CINDEX_LINKAGE v
elsteveogrande updated this revision to Diff 130557.
elsteveogrande added a comment.
remove unneeded changes
Repository:
rC Clang
https://reviews.llvm.org/D42043
Files:
include/clang-c/CXString.h
tools/c-index-test/c-index-test.c
tools/libclang/CXString.cpp
Index: tools/libclang/CXStr
101 - 142 of 142 matches
Mail list logo
