Author: sammccall
Date: Thu Jan 18 00:35:04 2018
New Revision: 322821
URL: http://llvm.org/viewvc/llvm-project?rev=322821&view=rev
Log:
[clangd] Use fuzzy match to select top N index results.
Summary:
This makes performance slower but more predictable (it always processes
every symbol). We need t
This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rL322821: [clangd] Use fuzzy match to select top N index
results. (authored by sammccall, committed by ).
Herald added a reviewer: jkorous-apple.
Herald added a su
hintonda created this revision.
hintonda added reviewers: compnerd, beanz.
Herald added a subscriber: mgorny.
If CMAKE_ASM_COMPILER is set, cmake assumes
CMAKE_ASM_COMPILER_ID was also set, and doesn't try to set it.
Without CMAKE_ASM_COMPILER_ID, cmake can't set
CMAKE_ASM_COMPILER_OPTIONS_TARGET
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL322822: [clang-tidy] Don't generate fix for argument
constructed from std… (authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository
Author: hokein
Date: Thu Jan 18 00:58:18 2018
New Revision: 322822
URL: http://llvm.org/viewvc/llvm-project?rev=322822&view=rev
Log:
[clang-tidy] Don't generate fix for argument constructed from
std::initializer_list.
Summary:
A follow-up fix of rL311652.
The previous `vector` in our test is di
hintonda updated this revision to Diff 130367.
hintonda added a comment.
Refactor to eliminate need for second stage and toolchain files.
Repository:
rC Clang
https://reviews.llvm.org/D41829
Files:
cmake/caches/Linux.cmake
Index: cmake/caches/Linux.cmake
==
Author: sammccall
Date: Thu Jan 18 01:27:56 2018
New Revision: 322824
URL: http://llvm.org/viewvc/llvm-project?rev=322824&view=rev
Log:
[clangd] CodeCompleteTests cleanup: naming, ordering, helpers. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified: clang-
hokein updated this revision to Diff 130370.
hokein added a comment.
- add the matcher to dynamic registry.
- add documentation.
- remove duplicated ";".
Repository:
rC Clang
https://reviews.llvm.org/D42185
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
Author: hokein
Date: Thu Jan 18 01:47:57 2018
New Revision: 322826
URL: http://llvm.org/viewvc/llvm-project?rev=322826&view=rev
Log:
[ASTMatcher] Add isScoped matcher for enumDecl.
Summary:
Reviewers: bkramer, aaron.ballman
Subscribers: aaron.ballman, cfe-commits, klimek
Differential Revision:
On 18 January 2018 at 00:38, Rafael Avila de Espindola via cfe-commits
wrote:
> With this I am getting a test failure on linux:
>
> TEST 'Clang :: Driver/riscv-gnutools.c' FAILED
>
> Script:
> --
> /home/admin/llvm/build/bin/clang -target riscv32-linux-un
hokein updated this revision to Diff 130372.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a reviewer: jkorous-apple.
Ignore enum constants in scoped enum.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42074
Files:
clangd/index/SymbolCollector
hokein added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:75
+ // Skip nameless declarations.
+ if (ND->getDeclName().isEmpty())
+return true;
ilya-biryukov wrote:
> What are those declarations exactly?
This would ignore anonymous declarat
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rC322826: [ASTMatcher] Add isScoped matcher for enumDecl.
(authored by hokein, comm
ioeric added inline comments.
Comment at: unittests/clangd/SymbolCollectorTests.cpp:164
+TEST_F(SymbolCollectorTest, IncludeEnums) {
+ CollectorOpts.IndexMainFiles = false;
Could you add a test case like the following and check whether `ns::X` is in
the resul
Author: sammccall
Date: Thu Jan 18 02:24:01 2018
New Revision: 322827
URL: http://llvm.org/viewvc/llvm-project?rev=322827&view=rev
Log:
[clangd] Output log messages to stderr when not configured (e.g. in tests). NFC
Modified:
clang-tools-extra/trunk/clangd/Logger.cpp
clang-tools-extra/tru
vladimir.plyashkun updated this revision to Diff 130382.
vladimir.plyashkun added a comment.
Implemented test-case to check that `BaseFS` is actually used in `ClangTool`
Repository:
rC Clang
https://reviews.llvm.org/D41947
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
yvvan updated this revision to Diff 130384.
yvvan added a comment.
Rebased. Applies for current master.
Also ping again...
https://reviews.llvm.org/D41537
Files:
include/clang-c/Index.h
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/CodeCompleteOptions.h
lib/Frontend/ASTU
vladimir.plyashkun updated this revision to Diff 130385.
vladimir.plyashkun added a comment.
Moved logic to `ClangTidyMain`
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
Index
hokein updated this revision to Diff 130395.
hokein marked an inline comment as done.
hokein added a comment.
Add one more test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42074
Files:
clangd/index/SymbolCollector.cpp
unittests/clangd/SymbolCollectorTests.cpp
Index: u
Author: rksimon
Date: Thu Jan 18 05:28:54 2018
New Revision: 322845
URL: http://llvm.org/viewvc/llvm-project?rev=322845&view=rev
Log:
Fix MSVC "uninitialized variable" warning.
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modified: cfe/trunk/tools/c-index-test/c-index-test.c
URL:
h
ioeric added a comment.
Herald added a reviewer: jkorous-apple.
Overall looks good! Some ideas about code structure inlined.
Comment at: clangd/CodeComplete.cpp:327
+// The CompletionRecorder captures Sema code-complete output, including
context.
+// It filters out ignored res
Hahnfeld updated this revision to Diff 130399.
Hahnfeld retitled this revision from "[OpenMP] Generate unique name for
offloading entries" to "[OpenMP] Correct generation of offloading entries".
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
Use `llvm::Twine`, add `Packed
baloghadamsoftware updated this revision to Diff 130403.
baloghadamsoftware added a comment.
Updated according to the comments.
https://reviews.llvm.org/D41938
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/Si
ro added a comment.
Thanks for the quick review. Could you commit the base patch (which had been
approved some time ago) and this one?
Repository:
rC Clang
https://reviews.llvm.org/D42029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov created this revision.
ilya-biryukov added reviewers: bkramer, arphaman.
This patch removes IdentifierInfo from completion token after remembering
the identifier in the preprocessor.
Prior to this patch, completion token had the IdentifierInfo set to null when
completing at the star
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D42168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
mclow.lists created this revision.
mclow.lists added a reviewer: EricWF.
Herald added subscribers: kristof.beyls, aemerson.
See https://bugs.llvm.org/show_bug.cgi?id=35945, which reports that libc++
doesn't build for the Raspberry PI.
The problem is that the exception class is defined as a `char
Author: ibiryukov
Date: Thu Jan 18 07:16:53 2018
New Revision: 322853
URL: http://llvm.org/viewvc/llvm-project?rev=322853&view=rev
Log:
[Frontend] Allow to use PrecompiledPreamble without calling CanReuse
Summary:
The new method 'OverridePreamble' allows to override the preamble of
any source fil
Author: ibiryukov
Date: Thu Jan 18 07:17:00 2018
New Revision: 322854
URL: http://llvm.org/viewvc/llvm-project?rev=322854&view=rev
Log:
[clangd] Always use preamble (even stale) for code completion
Summary:
This improves performance of code completion, because we avoid stating
the files from the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322854: [clangd] Always use preamble (even stale) for code
completion (authored by ibiryukov, committed by ).
Herald added subscribers: llvm-commits, ioeric.
Repository:
rL LLVM
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322853: [Frontend] Allow to use PrecompiledPreamble without
calling CanReuse (authored by ibiryukov, committed by ).
Herald added a subscriber: ioeric.
Changed prior to commit:
https://reviews.llvm.org/
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access or do you need someone to land this patch
for you?
Repository:
rC Clang
https://reviews.llvm.org/D41947
_
krasimir added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1710
+enum CommentAlignment { CA_None, CA_Code, CA_Preprocessor };
+
Please comment these.
Comment at: lib/Format/TokenAnnotator.cpp:1756
+ if (Alignment == CA_Pre
Author: sammccall
Date: Thu Jan 18 07:31:30 2018
New Revision: 322856
URL: http://llvm.org/viewvc/llvm-project?rev=322856&view=rev
Log:
[clangd] Remove unused IncludeGlobals completion option, always pass true to
sema
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
clang-tools-
Author: hahnfeld
Date: Thu Jan 18 07:38:03 2018
New Revision: 322858
URL: http://llvm.org/viewvc/llvm-project?rev=322858&view=rev
Log:
[OpenMP] Correct generation of offloading entries
Firstly, each offloading entry must have a unique name or the
linker will complain if there are multiple files w
vladimir.plyashkun added a comment.
In https://reviews.llvm.org/D41947#980298, @ilya-biryukov wrote:
> Looks good. Do you have commit access or do you need someone to land this
> patch for you?
No, i don't have commit access.
Repository:
rC Clang
https://reviews.llvm.org/D41947
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322858: [OpenMP] Correct generation of offloading entries
(authored by Hahnfeld, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42168
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/Op
ilya-biryukov added inline comments.
Comment at: test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h:30
vector(initializer_list<_E> init);
+ ~vector();
};
hokein wrote:
> ilya-biryukov wrote:
> > Why do we need to add this destructor in this patch?
ilya-biryukov requested changes to this revision.
ilya-biryukov added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:345
+ if (!Buffer) {
+llvm::errs() << diag::err_missing_vfs_overlay_file << OverlayFile;
+r
fedor.sergeev added a comment.
I'm trying!
I had no access to Solaris box, and I finally got one yesterday, though it is
rather old one and slow.
I plan to resolve it all till the end of this week.
Repository:
rC Clang
https://reviews.llvm.org/D42029
__
ro added a comment.
Excellent, thanks a lot.
Repository:
rC Clang
https://reviews.llvm.org/D42029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. (See the comment about changing the comment, though)
Comment at: clangd/index/SymbolCollector.cpp:75
+ // Skip nameless declarations.
+ if (ND->getDeclN
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:270
+ /// namespace scopes which are visible to the qualified-id completion token.
+ std::vector Scopes;
+};
sammccall wrote:
> Just to check, if the user types:
> "vec" --> None
> "::vec"
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41947#980305, @vladimir.plyashkun wrote:
> In https://reviews.llvm.org/D41947#980298, @ilya-biryukov wrote:
>
> > Looks good. Do you have commit access or do you need someone to land this
> > patch for you?
>
>
> No, i don't have commit
eandrews added a comment.
That makes sense. Is it not possible to implement the required functionality
using a flag vs an attribute? In an earlier comment you mentioned adding the
global to @llvm.used to prevent GlobalDCE from removing it. Can you not do that
when using a flag?
https://review
sammccall updated this revision to Diff 130417.
sammccall marked 7 inline comments as done.
sammccall added a comment.
Addressed review comments, except for "refactor into class" which is still todo.
Added explicit check of code completion context kind.
Added tests (mostly updating existing ones).
Author: marshall
Date: Thu Jan 18 08:52:19 2018
New Revision: 322863
URL: http://llvm.org/viewvc/llvm-project?rev=322863&view=rev
Log:
A simple program for testing OSS-Fuzz test cases locally.
Added:
libcxx/trunk/fuzzing/fuzz_test.cpp
Added: libcxx/trunk/fuzzing/fuzz_test.cpp
URL:
http://ll
Author: marshall
Date: Thu Jan 18 09:01:34 2018
New Revision: 322864
URL: http://llvm.org/viewvc/llvm-project?rev=322864&view=rev
Log:
Use high_resolution_clock instead of steady_clock. Also now builds with gcc 7.2
(for comparison purposes)
Modified:
libcxx/trunk/fuzzing/fuzz_test.cpp
Modif
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:35
+tooling::CompileCommand getCompileCommand(GlobalCompilationDatabase &CDB,
+ PathRef File, PathRef ResourceDir) {
sammccall wrote:
> This seems
ilya-biryukov updated this revision to Diff 130428.
ilya-biryukov marked 7 inline comments as done.
ilya-biryukov added a comment.
Herald added a subscriber: ioeric.
Addressing review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42173
Files:
clangd/ClangdServer.cpp
ilya-biryukov added a comment.
With https://reviews.llvm.org/D41947 in place, do we still need this change? Or
can it be "abandoned" now?
Repository:
rC Clang
https://reviews.llvm.org/D41594
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ilya-biryukov added inline comments.
Comment at: include/clang/Tooling/Tooling.h:299
/// clang modules.
+ /// \param BaseFS Base virtual filesystem used for OverlayFileSystem creation
ClangTool(const CompilationDatabase &Compilations,
NIT: LLVM coding styl
juliehockett updated this revision to Diff 130427.
juliehockett added a comment.
Rebasing from trunk
https://reviews.llvm.org/D40580
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/MultipleInheritanceCheck.cpp
clang-tidy/fuchsia/Multi
bcain updated this revision to Diff 130431.
bcain added a comment.
Herald added a subscriber: cfe-commits.
Changed per review
Repository:
rCXX libc++
https://reviews.llvm.org/D41727
Files:
libcxx/utils/libcxx/test/config.py
Index: libcxx/utils/libcxx/test/config.py
==
mattd created this revision.
mattd added reviewers: rnk, rsmith.
Both MS and PS4 targets are capable of recognizing the
existence of: #pragma region, #pragma endregion.
This patch adds a LangOpt and sets the value based on target
information or MS compatibility. In the case of PS4 or MS we
shou
spatel created this revision.
spatel added reviewers: efriedma, hfinkel, rjmccall, rsmith.
Herald added a subscriber: mcrosier.
I'm not sure if the code comment is adequate or even correct, but hopefully the
change itself is valid.
Eli cited this section of the standard in PR35909 (
https://bug
sammccall updated this revision to Diff 130440.
sammccall added a comment.
Converted the big codeComplete function to a CodeCompleteFlow class
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42181
Files:
clangd/CodeComplete.cpp
clangd/FuzzyMatch.h
unittests/clangd/CodeComp
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:270
+ /// namespace scopes which are visible to the qualified-id completion token.
+ std::vector Scopes;
+};
ilya-biryukov wrote:
> sammccall wrote:
> > Just to check, if the user types:
> > "
Author: dhinton
Date: Thu Jan 18 10:29:36 2018
New Revision: 322870
URL: http://llvm.org/viewvc/llvm-project?rev=322870&view=rev
Log:
[cmake] [libcxxabi] Don't print warning when tests are disabled.
Summary:
Don't print, possibly erroneous, warning if
LIBCXXABI_INCLUDE_TESTS is false.
This patch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322870: [cmake] [libcxxabi] Don't print warning when
tests are disabled. (authored by dhinton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D422
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
Comment at: lib/Format/ContinuationIndenter.cpp:1336
+ unsigned OldSuffixSize = 2 + OldDelimiter.size();
+ std::string RawText =
+ Current.TokenText.substr(OldPre
Author: marshall
Date: Thu Jan 18 10:37:11 2018
New Revision: 322872
URL: http://llvm.org/viewvc/llvm-project?rev=322872&view=rev
Log:
Add memory tracking
Modified:
libcxx/trunk/fuzzing/fuzz_test.cpp
Modified: libcxx/trunk/fuzzing/fuzz_test.cpp
URL:
http://llvm.org/viewvc/llvm-project/libc
Author: benhamilton
Date: Thu Jan 18 10:37:16 2018
New Revision: 322873
URL: http://llvm.org/viewvc/llvm-project?rev=322873&view=rev
Log:
[ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style
Summary:
The Google style guide is neutral on whether there should be a
space befo
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322873: [ClangFormat] ObjCSpaceBeforeProtocolList should be
true in the google style (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41074?vs=126806&id=13044
majnemer added a comment.
Why not always support the pragma regardless of the compiler mode? Our
"support" for it just ignores it anyway...
https://reviews.llvm.org/D42248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
mattd added a comment.
In https://reviews.llvm.org/D42248#980541, @majnemer wrote:
> Why not always support the pragma regardless of the compiler mode? Our
> "support" for it just ignores it anyway...
Thanks for the reply @majnemer.
I am not opposed to that idea. My change just operates simi
MaskRay updated this revision to Diff 130458.
MaskRay added a comment.
More
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
=
benhamilton created this revision.
benhamilton added reviewers: Wizard, hokein, klimek.
Herald added a subscriber: cfe-commits.
We were missing some pretty common acronyms in the camelCase
property name check objc-property-declaration.
This expands the list and sorts it lexicographically, so we c
lebedev.ri added a comment.
Don't forget that you also need to regenerate the HTML docs:
$ cd docs/tools # yes, cd
$ ./dump_ast_matchers.py
Repository:
rC Clang
https://reviews.llvm.org/D42213
___
cfe-commits mailing list
cfe-commits@lists.l
elsteveogrande added a comment.
Thanks very much for looking at this @vsk ! I actually found an ASAN bug in my
new code, mixing and matching `malloc/free` and `operator`s `new/delete`.
Comment at: tools/c-index-test/c-index-test.c:3268
- filename = clang_getFileName(file);
efriedma added inline comments.
Comment at: lib/CodeGen/CGClass.cpp:410
+
+ // The GEP is to a derived object, so this GEP must be 'inbounds'.
+ Value = Builder.CreateInBoundsGEP(Value, Builder.CreateNeg(NonVirtualOffset),
Not sure this comment really adds anyt
khuttun updated this revision to Diff 130461.
khuttun added a comment.
- Detect unused return values also inside other kinds of statements than
compound statements
- Ignore void functions in the checker
- Check std::remove, std::remove_if and std::unique by default
https://reviews.llvm.org/D416
Author: sbc
Date: Thu Jan 18 11:31:33 2018
New Revision: 322880
URL: http://llvm.org/viewvc/llvm-project?rev=322880&view=rev
Log:
Convert comment to C-style to prevent warning
Modified:
cfe/trunk/tools/c-index-test/c-index-test.c
Modified: cfe/trunk/tools/c-index-test/c-index-test.c
URL:
ht
vsk added a comment.
Thanks for working on this :).
Comment at: tools/libclang/CXString.cpp:213
+ if (string.IsNullTerminated) {
+CString = (const char *) string.Contents;
+ } else {
elsteveogrande wrote:
> vsk wrote:
> > Basic question: If a non-owning C
Wizard added a comment.
Can you update the doc btw since the acronyms are not only for prefix anymore?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
khuttun added a comment.
The checker reports 7 warnings on LLVM + Clang code bases, all on
std::unique_ptr::release:
lib/Bitcode/Reader/BitReader.cpp:114:3
- release() called on moved-from unique_ptr
- no harm, just unnecessary
lib/ExecutionEngine/ExecutionEngine.cpp:149:7
- release() called
elsteveogrande created this revision.
elsteveogrande added reviewers: vsk, benlangmuir, akyrtzi.
Herald added a subscriber: cfe-commits.
(Separating some unrelated changes out of https://reviews.llvm.org/D42043)
Repository:
rC Clang
https://reviews.llvm.org/D42259
Files:
tools/c-index-test
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322883: c-index-test: small fix to CXString handling and
disposal (authored by steveo, committed by ).
Changed prior to c
elsteveogrande marked 2 inline comments as done.
elsteveogrande added inline comments.
Comment at: tools/c-index-test/c-index-test.c:3268
- filename = clang_getFileName(file);
- index_data->main_filename = clang_getCString(filename);
- clang_disposeString(filename);
+ index
benhamilton updated this revision to Diff 130478.
benhamilton added a comment.
- Added comment about prefixes and suffixes.
- Updated list of acronyms.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42253
Files:
clang-tidy/objc/PropertyDeclarationCheck.cpp
docs/clang-tidy/c
benhamilton created this revision.
benhamilton added reviewers: Wizard, hokein, klimek.
Herald added a subscriber: cfe-commits.
The existing option objc-property-declaration.Acronyms
replaces the built-in set of acronyms.
While this behavior is OK for clients that don't want the default
behavior,
Author: benhamilton
Date: Thu Jan 18 12:51:24 2018
New Revision: 322886
URL: http://llvm.org/viewvc/llvm-project?rev=322886&view=rev
Log:
[clang-tidy objc-property-declaration] Expand list of ObjC acronyms
Summary:
We were missing some pretty common acronyms in the camelCase
property name check o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322886: [clang-tidy objc-property-declaration] Expand list
of ObjC acronyms (authored by benhamilton, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE322886: [clang-tidy objc-property-declaration] Expand list
of ObjC acronyms (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42253?vs=130478&id=130480#toc
ckennelly marked an inline comment as done.
ckennelly added a comment.
I don't have commit access, so can this be committed to trunk?
Repository:
rCXX libc++
https://reviews.llvm.org/D41746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: jvesely
Date: Thu Jan 18 13:11:38 2018
New Revision: 322888
URL: http://llvm.org/viewvc/llvm-project?rev=322888&view=rev
Log:
half_sqrt: Cleanup implementation
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Removed:
li
Author: jvesely
Date: Thu Jan 18 13:11:35 2018
New Revision: 322887
URL: http://llvm.org/viewvc/llvm-project?rev=322887&view=rev
Log:
half_rsqrt: Cleanup implementation
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
lib
Author: jvesely
Date: Thu Jan 18 13:11:40 2018
New Revision: 322889
URL: http://llvm.org/viewvc/llvm-project?rev=322889&view=rev
Log:
half_cos: Implement using cos
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/t
Author: jvesely
Date: Thu Jan 18 13:11:45 2018
New Revision: 322891
URL: http://llvm.org/viewvc/llvm-project?rev=322891&view=rev
Log:
half_exp2: Implement using exp2
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc
Author: jvesely
Date: Thu Jan 18 13:11:48 2018
New Revision: 322892
URL: http://llvm.org/viewvc/llvm-project?rev=322892&view=rev
Log:
half_exp10: Implement using exp10
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libc
Author: jvesely
Date: Thu Jan 18 13:11:43 2018
New Revision: 322890
URL: http://llvm.org/viewvc/llvm-project?rev=322890&view=rev
Log:
half_exp: Implement using exp
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/t
Author: jvesely
Date: Thu Jan 18 13:11:56 2018
New Revision: 322895
URL: http://llvm.org/viewvc/llvm-project?rev=322895&view=rev
Log:
half_log2: Implement using log2
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc
Author: jvesely
Date: Thu Jan 18 13:11:58 2018
New Revision: 322896
URL: http://llvm.org/viewvc/llvm-project?rev=322896&view=rev
Log:
half_recip: Implement using 1/x
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc
Author: jvesely
Date: Thu Jan 18 13:11:53 2018
New Revision: 322894
URL: http://llvm.org/viewvc/llvm-project?rev=322894&view=rev
Log:
half_log10: Implement using log10
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libc
Author: jvesely
Date: Thu Jan 18 13:11:50 2018
New Revision: 322893
URL: http://llvm.org/viewvc/llvm-project?rev=322893&view=rev
Log:
half_log: Implement using log
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/t
Author: jvesely
Date: Thu Jan 18 13:12:04 2018
New Revision: 322898
URL: http://llvm.org/viewvc/llvm-project?rev=322898&view=rev
Log:
half_tan: Implement using tan
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/include/c
Author: jvesely
Date: Thu Jan 18 13:12:06 2018
New Revision: 322899
URL: http://llvm.org/viewvc/llvm-project?rev=322899&view=rev
Log:
half_divide: Implement using x/y
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libcl
Author: jvesely
Date: Thu Jan 18 13:12:01 2018
New Revision: 322897
URL: http://llvm.org/viewvc/llvm-project?rev=322897&view=rev
Log:
half_sin: Implement using sin
Passes CTS on carrizo
v2: Use full precision implementation
Reviewer: Jeroen Ketema
Signed-off-by: Jan Vesely
Added:
libclc/t
george.karpenkov added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:597
+ // than or equal to the quarter of the maximum value of that type.
+ bool shouldAggressivelySimplifyRelationalComparison();
+
High level comment: can y
MaskRay updated this revision to Diff 130486.
MaskRay added a comment.
More
Repository:
rC Clang
https://reviews.llvm.org/D42213
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index: include/clang/ASTMatchers/ASTMatchers.h
==
1 - 100 of 142 matches
Mail list logo
