[PATCH] D39903: [libclang] Allow pretty printing declarations

nik added a comment. > I can merge this for you. > Please add me as reviewer in any follow-up patches and we can turn them > around more quickly. That would be nice, thanks! I don't have any follow-up patches right now. Repository: rC Clang https://reviews.llvm.org/D39903 __

[PATCH] D42036: [clang-format] Keep comments aligned to macros

klimek added a comment. Just from a formatting point of view, why not: //. Comment #.define X Repository: rC Clang https://reviews.llvm.org/D42036 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: r322518 - Revert 319303: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2

Merged to 6.0 in r322539. On Mon, Jan 15, 2018 at 10:16 PM, Erich Keane via cfe-commits wrote: > Author: erichkeane > Date: Mon Jan 15 13:16:25 2018 > New Revision: 322518 > > URL: http://llvm.org/viewvc/llvm-project?rev=322518&view=rev > Log: > Revert 319303: Add _Float128 as alias to __float128

r322540 - [libclang] Add PrintingPolicy for pretty printing declarations

Author: jbcoe Date: Tue Jan 16 02:19:56 2018 New Revision: 322540 URL: http://llvm.org/viewvc/llvm-project?rev=322540&view=rev Log: [libclang] Add PrintingPolicy for pretty printing declarations Summary: Introduce clang_getCursorPrettyPrinted() for pretty printing declarations. Expose also Printi

[PATCH] D39903: [libclang] Allow pretty printing declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL322540: [libclang] Add PrintingPolicy for pretty printing declarations (authored by jbcoe, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D399

[PATCH] D42063: [clangd] Avoid combinatorial explosion in CodeCompleteTests.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42077: Ensure code complete with !LoadExternal sees all local decls.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a few NITs (see the comments) Comment at: include/clang/AST/DeclBase.h:1826 lookups_range lookups() const; - lookups_range noload_lookups() const;

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

krasimir created this revision. krasimir added a reviewer: bkramer. Herald added a subscriber: klimek. This patch changes the structure for raw string formatting options by making it language based (enumerate delimiters per language) as opposed to delimiter-based (specify the language for a delimi

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

krasimir updated this revision to Diff 129932. krasimir added a comment. - Update comments Repository: rC Clang https://reviews.llvm.org/D42098 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp unittests/Format/FormatTest.cpp unittests/F

[PATCH] D42073: [clangd] Query all visible scopes based on all visible using-namespace declarationsand containing namespace for global qualified code completion.

sammccall added a comment. Sounds like implementation is in flux, but a few comments that might be relevant. Comment at: clangd/CodeComplete.cpp:264 +/// (e.g. "ns::ab?"). +struct QueryScopes { + /// All scopes being queried in indexes. Each scope should meet the

[PATCH] D42099: [libclang] Add missing CINDEX_LINKAGE

nik created this revision. Herald added a subscriber: cfe-commits. nik added reviewers: yvvan, jbcoe. ...otherwise the build fails on Windows. Repository: rC Clang https://reviews.llvm.org/D42099 Files: include/clang-c/Index.h Index: include/clang-c/Index.h ==

r322546 - Add missing CINDEX_LINKAGE

Author: yvvan Date: Tue Jan 16 04:11:59 2018 New Revision: 322546 URL: http://llvm.org/viewvc/llvm-project?rev=322546&view=rev Log: Add missing CINDEX_LINKAGE Follow up for [libclang] Add PrintingPolicy for pretty printing declarations Differential Revision: https://reviews.llvm.org/D39903 Modi

[clang-tools-extra] r322547 - [clangd] Avoid combinatorial explosion in CodeCompleteTests.

Author: sammccall Date: Tue Jan 16 04:21:24 2018 New Revision: 322547 URL: http://llvm.org/viewvc/llvm-project?rev=322547&view=rev Log: [clangd] Avoid combinatorial explosion in CodeCompleteTests. Summary: This test dominates our unit test runtime, and the change speeds it up by 10x. We lose cove

[PATCH] D42063: [clangd] Avoid combinatorial explosion in CodeCompleteTests.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322547: [clangd] Avoid combinatorial explosion in CodeCompleteTests. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

[PATCH] D42077: Ensure code complete with !LoadExternal sees all local decls.

sammccall updated this revision to Diff 129937. sammccall marked 2 inline comments as done. sammccall added a comment. Remove default value of PreserveInternalState, and move doc comment. Repository: rC Clang https://reviews.llvm.org/D42077 Files: include/clang/AST/DeclBase.h include/cla

r322548 - Ensure code complete with !LoadExternal sees all local decls.

Author: sammccall Date: Tue Jan 16 04:33:46 2018 New Revision: 322548 URL: http://llvm.org/viewvc/llvm-project?rev=322548&view=rev Log: Ensure code complete with !LoadExternal sees all local decls. Summary: noload_lookups() was too lazy: in addition to avoiding external decls, it avoided populati

[PATCH] D42077: Ensure code complete with !LoadExternal sees all local decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322548: Ensure code complete with !LoadExternal sees all local decls. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D4207

r322549 - Squash -Wcovered-switch-default wairning

Author: sammccall Date: Tue Jan 16 04:54:28 2018 New Revision: 322549 URL: http://llvm.org/viewvc/llvm-project?rev=322549&view=rev Log: Squash -Wcovered-switch-default wairning Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-test.c URL: h

[PATCH] D41538: [analyzer] Fix some checker's output plist not containing the checker name #2

hans added a comment. In https://reviews.llvm.org/D41538#969207, @xazax.hun wrote: > In https://reviews.llvm.org/D41538#969205, @sylvestre.ledru wrote: > > > It missed the 6.0 branching. Will you try to get it on this branch? > > Thanks > > > Sure! I will try to do so: https://reviews.llvm.org/rC

r322551 - [NFC] fix trivial typo in document

Author: inouehrs Date: Tue Jan 16 05:19:31 2018 New Revision: 322551 URL: http://llvm.org/viewvc/llvm-project?rev=322551&view=rev Log: [NFC] fix trivial typo in document "the the" -> "the" Modified: cfe/trunk/docs/ThinLTO.rst Modified: cfe/trunk/docs/ThinLTO.rst URL: http://llvm.org/viewvc

[PATCH] D41906: [libunwind][PPC64] Added vector registers.

mstorsjo added a comment. No objections from me on this. There were a few stray cosmetic changes that perhaps could be split out, but it's not big enough that I'd object to it. So if @compnerd doesn't mind, I'll commit this. Repository: rL LLVM https://reviews.llvm.org/D41906 ___

[PATCH] D32845: [Analyzer] Iterator Checker - Part 4: Mismatched iterator checker for function parameters

a.sidorin added a comment. Hello Adam, This looks like a nice improvement. I have some remarks inline. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:382 } + } else if (!isa(&Call)) { +// The main purpose of iterators is to abstract away from different --

[PATCH] D32747: [Analyzer] Iterator Checker - Part 3: Invalidation check, first for (copy) assignments

a.sidorin added a comment. Hello Adam. I have a nit inline. Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:1256 +if (Cond(Reg.second)) { + State = setIteratorPosition(State, Reg.first, Proc(Reg.second)); +} Updating ProgramState is usu

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen updated this revision to Diff 129943. sdesmalen added a comment. Refactoring based on @aprantl's suggestions. https://reviews.llvm.org/D41698 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeG

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

sdesmalen marked 3 inline comments as done. sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2358 +if (auto *SizeNode = getVLASizeExpressionForType(EltTy)) + Subscripts.push_back(DBuilder.getOrCreateSubrange(0, SizeNode)); +else --

[PATCH] D42085: Add va_start()/va_copy()/va_end to Builtins.def

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Seems that some of these are tested in Sema/implicit-builtin-decl.c, but it doesn't look exhaustive and I'm not sure it's worth adding these. https://reviews.llvm.org/D42085

[PATCH] D41991: [clangd] Always use preamble (even stale) for code completion

bkramer added inline comments. Comment at: clangd/Compiler.h:39 +/// be consumed by the FrontendAction as it will have a pointer to the MainFile +/// buffer that will only be deleted if BeginSourceFile is called. std::unique_ptr prepareCompilerInstance( This com

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

hans added a comment. Alex, do you think the fix is still OK for the 6.0 branch? Let me know, and I'll merge it. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

Re: r321771 - [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

Merged to 6.0 in r322555. On Thu, Jan 4, 2018 at 12:11 AM, Vedant Kumar via cfe-commits wrote: > Author: vedantk > Date: Wed Jan 3 15:11:32 2018 > New Revision: 321771 > > URL: http://llvm.org/viewvc/llvm-project?rev=321771&view=rev > Log: > [CGBuiltin] Handle unsigned mul overflow properly (PR3

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

mclow.lists added a comment. I'm a bit leery of this patch. Not because of what it's trying to do, but rather, the introduction of a method `__clear_and_shrink` that leaves the string in an invalid state. For all the uses that you put it to, I don't think that's a problem (though I'm still w

[libcxx] r322556 - Change an internal table of constants for the poisson distribution from

Author: marshall Date: Tue Jan 16 06:54:36 2018 New Revision: 322556 URL: http://llvm.org/viewvc/llvm-project?rev=322556&view=rev Log: Change an internal table of constants for the poisson distribution from type 'result_type' to 'double'. The only thing that we ever do with these numbers is to pro

Re: r321754 - -gmodules: Emit debug info for implicit module imports via #include.

Merged to 6.0 in r322557. On Wed, Jan 3, 2018 at 8:10 PM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Wed Jan 3 11:10:21 2018 > New Revision: 321754 > > URL: http://llvm.org/viewvc/llvm-project?rev=321754&view=rev > Log: > -gmodules: Emit debug info for implicit module imports

Re: r321816 - [OPENMP] Add debug info for generated functions.

Please file a merge request bug blocking PR35804 for what you'd like merged (unless you already have). Thanks, Hans On Mon, Jan 8, 2018 at 5:27 PM, Alexey Bataev via cfe-commits wrote: > Will add some more tests later today > - > Best regards, > Alexey Bataev > > 08.01.2018 11:13, Da

r322559 - [OPENMP] Add support for `depend` clauses on `target simd`.

Author: abataev Date: Tue Jan 16 07:05:16 2018 New Revision: 322559 URL: http://llvm.org/viewvc/llvm-project?rev=322559&view=rev Log: [OPENMP] Add support for `depend` clauses on `target simd`. Added codegen for `depend` clauses on `#pragma omp target simd` directives. Added: cfe/trunk/test/

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. I think the only thing we need is a call to __set_long_cap(0) in the body of the if() to make the string be in a valid state, but if you follow the logic for a call to reserve(0) (after having called clear()) it doesn't even end up doing that (unless I'm missing somet

[PATCH] D42106: [analyzer] Remove the useless method declararion 'BugReporter::RemoveUnneededCalls()'.

MTC created this revision. MTC added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. MTC retitled this revision from "[analyzer] Remove the useless method declararion 'BugReporter::RemoveUnneedCalls()'." to "[analyzer] Remove the useless m

[PATCH] D42036: [clang-format] Keep comments aligned to macros

mzeren-vmw added a comment. In https://reviews.llvm.org/D42036#976827, @klimek wrote: > Just from a formatting point of view, why not: > > //. Comment > #.define X (assuming the '.'s are unintentional) There is some logic in placing `//` in column 0, since we place `#` in column 0. H

[PATCH] D41946: [clangd] Add support for different file URI schemas.

sammccall added a comment. Lots of quibbles here, some things we can certainly defer. Happy to chat offline if you're not sure... Comment at: clangd/URI.cpp:17 + +std::string FileURI::toString() const { return Schema + "://" + Path; } + This isn't correct, we

[PATCH] D42098: [clang-format] Reorganize RawStringFormat based on language

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang https://reviews.llvm.org/D42098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D42043: c-index: CXString: fix MSAN read-past-end bug

elsteveogrande updated this revision to Diff 129959. elsteveogrande added a comment. Change string-copy-on-demand logic; do only if `not IsNullTerminated`. Repository: rC Clang https://reviews.llvm.org/D42043 Files: include/clang-c/CXString.h tools/c-index-test/c-index-test.c tools/lib

r322562 - [SystemZ] Support vector registers with inline asm

Author: uweigand Date: Tue Jan 16 07:39:23 2018 New Revision: 322562 URL: http://llvm.org/viewvc/llvm-project?rev=322562&view=rev Log: [SystemZ] Support vector registers with inline asm Allow using vector register names and the "v" constraint in inline asm to ensure compatibility with GCC. Modi

Re: Re: r322018 - [OPENMP] Current status of OpenMP support.

Merged to 6.0 in r322564. Thanks, Hans On Mon, Jan 8, 2018 at 8:21 PM, GMail wrote: > This is is the status of OpenMP support in 6.0. There is nothing new since > branching. > > - > Best regards, > Alexey Bataev > > 08.01.2018 14:09, Jonas Hahnfeld via cfe-commits пишет: > > Can we b

[PATCH] D32859: [Analyzer] Iterator Checker - Part 5: Move Assignment of Containers

baloghadamsoftware updated this revision to Diff 129960. baloghadamsoftware added a comment. Rebased to current part 4. New tests added. Comments added. https://reviews.llvm.org/D32859 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp test/Analysis/mismatched-iterator.cpp Index: test/

[libcxx] r322566 - More constexpr algorithms from P0202. search/search_n

Author: marshall Date: Tue Jan 16 07:48:27 2018 New Revision: 322566 URL: http://llvm.org/viewvc/llvm-project?rev=322566&view=rev Log: More constexpr algorithms from P0202. search/search_n Modified: libcxx/trunk/include/algorithm libcxx/trunk/include/functional libcxx/trunk/include/ty

r322569 - [OPENMP] Add support for `depend` clauses on `target teams`.

Author: abataev Date: Tue Jan 16 07:57:07 2018 New Revision: 322569 URL: http://llvm.org/viewvc/llvm-project?rev=322569&view=rev Log: [OPENMP] Add support for `depend` clauses on `target teams`. Added codegen for `depend` clause on `#pragma omp target teams` directives. Added: cfe/trunk/test

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. Just to elaborate, in `reserve(0)` after the deallocation there's a check `if (__now_long)` which takes the else branch and only ends up calling `__set_short_size(__sz); // __sz = 0 here`. So even without this diff the only thing `reserve(0)` does after deallocating

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke added a comment. Sorry if I'm spamming too much. Just to be clear, I agree completely with your sentiment but I'm pretty sure that `__clear_and_shrink()` has exactly the same effects as `clear(); shrink_to_fit();`. Maybe `reserve(0);` should should be unconditionally calling `__set_

r322570 - [OPENMP] Add support for `depend` clauses on `target parallel` directive.

Author: abataev Date: Tue Jan 16 08:27:49 2018 New Revision: 322570 URL: http://llvm.org/viewvc/llvm-project?rev=322570&view=rev Log: [OPENMP] Add support for `depend` clauses on `target parallel` directive. Added codegen for `depend` clauses on `#pragma omp target parallel` directives. Added:

Re: r321816 - [OPENMP] Add debug info for generated functions.

Hi Hans, I don't think we need to merge some of these to 6.0 branch, they are not bug fixes, just some new functionality - Best regards, Alexey Bataev 16.01.2018 9:59, Hans Wennborg пишет: > Please file a merge request bug blocking PR35804 for what you'd like > merged (unless you alre

[PATCH] D41815: [clang-tidy] implement check for goto

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor formatting nit. Comment at: clang-tidy/hicpp/HICPPTidyModule.cpp:57 "hicpp-exception-baseclass"); -CheckFactories.registerC

r322571 - [OPENMP] Add support for `depend` clause on `target teams distribute`.

Author: abataev Date: Tue Jan 16 08:46:46 2018 New Revision: 322571 URL: http://llvm.org/viewvc/llvm-project?rev=322571&view=rev Log: [OPENMP] Add support for `depend` clause on `target teams distribute`. Added codegen for `depend` clauses on `#pragma omp target teams distribute` directives. Add

[PATCH] D41976: Low-hanging fruit optimization in string::__move_assign().

tvanslyke updated this revision to Diff 129969. tvanslyke added a comment. Implemented changes to ensure string state is valid after calling `__clear_and_shrink()`. Benchmark results are identical. https://reviews.llvm.org/D41976 Files: string Index: string ===

r322573 - Add va_start()/va_copy()/va_end to Builtins.def

Author: nico Date: Tue Jan 16 08:55:41 2018 New Revision: 322573 URL: http://llvm.org/viewvc/llvm-project?rev=322573&view=rev Log: Add va_start()/va_copy()/va_end to Builtins.def That way, clang suggests including stdarg.h when these are used in C files. https://reviews.llvm.org/D42085 Modified:

[PATCH] D42085: Add va_start()/va_copy()/va_end to Builtins.def

thakis closed this revision. thakis added a comment. r322573, thanks! Yes, I looked at the same file and came to the same conclusion regarding a test :-) https://reviews.llvm.org/D42085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

r322575 - [OPENMP] Add support for `depend` clauses on `target teams distribute

Author: abataev Date: Tue Jan 16 09:22:50 2018 New Revision: 322575 URL: http://llvm.org/viewvc/llvm-project?rev=322575&view=rev Log: [OPENMP] Add support for `depend` clauses on `target teams distribute simd` directives. Added codegen for `depend` clauses on `#pragma omp target teams distribute

r322577 - [OPENMP] Add support for `depend` clauses on `target parallel for`

Author: abataev Date: Tue Jan 16 09:41:04 2018 New Revision: 322577 URL: http://llvm.org/viewvc/llvm-project?rev=322577&view=rev Log: [OPENMP] Add support for `depend` clauses on `target parallel for` directives. Added codegen for `depend` clause on `#pragma omp target parallel for` directives.

[PATCH] D42110: Move target MV resolver to COMDAT

erichkeane created this revision. erichkeane added reviewers: espindola, hfinkel, echristo. As reported here: https://bugs.llvm.org/show_bug.cgi?id=35921 The resolver functions should be in their own COMDAT regions. This patch sets that up. https://reviews.llvm.org/D42110 Files: lib/CodeGen/

r322578 - [OPENMP] Add support for `depend` clauses on `target parallel for simd`

Author: abataev Date: Tue Jan 16 09:55:15 2018 New Revision: 322578 URL: http://llvm.org/viewvc/llvm-project?rev=322578&view=rev Log: [OPENMP] Add support for `depend` clauses on `target parallel for simd` directives. Added codegen for `depend` clauses on `#pragma omp target parallel for simd` di

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos updated this revision to Diff 129981. apazos added a comment. I tested this on windows and I had to add an assembler placeholder executable, just like it was done with the linker in the RISCV multilib dir checked under Inputs. Other observations, are these known issues? - multilib dir c

[PATCH] D42111: [Tooling] Don't deduplicate tool results in the All-TUs executor.

ioeric created this revision. ioeric added a reviewer: bkramer. Herald added subscribers: cfe-commits, klimek. As result deduplication or reduction is not supported in the framework, we should leave the deplication to tools (if needed) until the framework supports it. Repository: rC Clang ht

[PATCH] D42113: [clangd] Deduplicate symbols collected in global-symbol-builder tool.

ioeric created this revision. ioeric added reviewers: bkramer, sammccall. Herald added subscribers: cfe-commits, ilya-biryukov, klimek. After https://reviews.llvm.org/D42111, the executor framework no longer deduplicate tool results. Repository: rCTE Clang Tools Extra https://reviews.llvm.or

[PATCH] D41698: [DebugInfo] Enable debug information for C99 VLA types

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.h:86 + /// represented by instantiated Metadata nodes. + llvm::SmallDenseMap SizeExprCache; + sdesmalen wrote: > aprantl wrote: > > I'm expecting VLA's to not be very common, should we use a reg

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 129985. m.ostapenko added a comment. Hi Devin, now I'm very sorry for a such long delay. Now I have a bunch of time to proceed development of this patch (if scope contexts are still needed, of course). Regarding to approach you suggested (reuse LocalScop

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, alexfh, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adds a check to the Fuchsia module to warn if a function has a trailing return. See https:/

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added a comment. Can you give some background on what problem the coding standard is trying to avoid by banning this? For instance, if trailing return types are bad, are deduced return types similarly bad, or are those fine? Comment at: clang-tidy/fuchsia/Traili

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

juliehockett created this revision. juliehockett added a reviewer: alexfh. juliehockett added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. Updating Fuchsia overloaded operator warning message for clarity. https://reviews.llvm.org/D42120 Files: clang-tidy/fuchsia/Overloa

[PATCH] D41708: [clang-tidy] Update fuchsia-overloaded-operator to check for valid loc

juliehockett added a comment. The update to the message is also up for review here: D42120 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41708 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D42120: [clang-tidy] Fixing Fuchsia overloaded operator warning message

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/clang-tidy/fuchsia-overloaded-operator.cpp:6 int operator+(int); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: cannot overload 'operat

r322585 - [OPENMP] Add support for `depend` on `target teams distribute parallel

Author: abataev Date: Tue Jan 16 11:02:33 2018 New Revision: 322585 URL: http://llvm.org/viewvc/llvm-project?rev=322585&view=rev Log: [OPENMP] Add support for `depend` on `target teams distribute parallel for` directives. Added codegen for `depend` clauses on `#pragma omp target teams distribute

r322587 - [OPENMP] Add support for `depend` clauses on `target teams distribute

Author: abataev Date: Tue Jan 16 11:18:24 2018 New Revision: 322587 URL: http://llvm.org/viewvc/llvm-project?rev=322587&view=rev Log: [OPENMP] Add support for `depend` clauses on `target teams distribute parallel for simd` directives. Added codegen for `depend` clauses on `#pragma omp target team

r322589 - [DOCS] Updated current status of OpenMP support, NFC.

Author: abataev Date: Tue Jan 16 11:22:49 2018 New Revision: 322589 URL: http://llvm.org/viewvc/llvm-project?rev=322589&view=rev Log: [DOCS] Updated current status of OpenMP support, NFC. Modified: cfe/trunk/docs/OpenMPSupport.rst Modified: cfe/trunk/docs/OpenMPSupport.rst URL: http://llvm.

Re: r322350 - [ODRHash] Don't hash friend functions.

There was a different, possibly related, issue with templated methods that I just disabled checking for methods all together in r321396 until I can investigate further. On Mon, Jan 15, 2018 at 10:45 AM, David Blaikie wrote: > I'm surprised this problem is unique to friend functions with definiti

[PATCH] D42110: Move target MV resolver to COMDAT

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Seems reasonable. https://reviews.llvm.org/D42110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D42110: Move target MV resolver to COMDAT

This revision was automatically updated to reflect the committed changes. Closed by commit rC322592: Move target MV resolver to COMDAT (authored by erichkeane, committed by ). Repository: rC Clang https://reviews.llvm.org/D42110 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/attr-targe

r322592 - Move target MV resolver to COMDAT

Author: erichkeane Date: Tue Jan 16 11:49:52 2018 New Revision: 322592 URL: http://llvm.org/viewvc/llvm-project?rev=322592&view=rev Log: Move target MV resolver to COMDAT As reported here: https://bugs.llvm.org/show_bug.cgi?id=35921 The resolver functions should be in their own COMDAT regions. Th

r322593 - Add context to why test was disabled on Windows

Author: rtrieu Date: Tue Jan 16 11:53:06 2018 New Revision: 322593 URL: http://llvm.org/viewvc/llvm-project?rev=322593&view=rev Log: Add context to why test was disabled on Windows test/Modules/odr_hash-Friend.cpp triggers an assertion in MicrosoftMangle.cpp This has been reported in PR35939 Mo

Re: r322405 - Disable test for Windows to fix Windows buildbots.

Tracking bug is PR35939 r322593 adds comment to test case This test triggers an assertion in MicrosoftMangle.cpp On Mon, Jan 15, 2018 at 10:38 AM, David Blaikie wrote: > might be worth having an explanation (probably in both the commit message > and in a comment in the source) about why this tes

[PATCH] D37442: [C++17] Disallow lambdas in template parameters (PR33696).

Rakete updated this revision to Diff 130014. Rakete added a comment. I put the enum in `ExpressionEvaluationContextRecord` now, and fixed the `Type` -> `Kind` issue. If it's still ok, could you please commit it @rsmith? Thanks :) https://reviews.llvm.org/D37442 Files: include/clang/

[libunwind] r322596 - [PPC64] Added vector registers.

Author: mstorsjo Date: Tue Jan 16 12:54:10 2018 New Revision: 322596 URL: http://llvm.org/viewvc/llvm-project?rev=322596&view=rev Log: [PPC64] Added vector registers. The Registers_ppc64 class needed a couple of changes, both to accommodate the new registers as well as to handle the overlaps of V

[PATCH] D41906: [libunwind][PPC64] Added vector registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322596: [PPC64] Added vector registers. (authored by mstorsjo, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41906 Files: libunwind/trunk/include/__libunwind_config.h libunwind/tru

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete updated this revision to Diff 130020. Rakete added a comment. Addressed review comments :) https://reviews.llvm.org/D36357 Files: include/clang/Basic/DiagnosticParseKinds.td lib/Parse/ParseExprCXX.cpp test/Parser/cxx0x-lambda-expressions.cpp test/SemaCXX/new-delete-0x.cpp

[PATCH] D41921: [Parse] Forward brace locations to TypeConstructExpr

vsk updated this revision to Diff 130021. vsk marked 2 inline comments as done. vsk added a comment. - Address feedback from @aaron.ballman https://reviews.llvm.org/D41921 Files: include/clang/AST/ExprCXX.h include/clang/Sema/Initialization.h include/clang/Sema/Sema.h lib/CodeGen/Covera

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130027. juliehockett marked an inline comment as done. juliehockett added a comment. Updating checker to not warn for trailing returns on lambdas. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTi

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett added a comment. In https://reviews.llvm.org/D42116#977347, @aaron.ballman wrote: > Can you give some background on what problem the coding standard is trying to > avoid by banning this? For instance, if trailing return types are bad, are > deduced return types similarly bad, or ar

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

aaron.ballman added a comment. In https://reviews.llvm.org/D42116#977588, @juliehockett wrote: > In https://reviews.llvm.org/D42116#977347, @aaron.ballman wrote: > > > Can you give some background on what problem the coding standard is trying > > to avoid by banning this? For instance, if traili

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith added a comment. Did you forget to upload the updated patch? This looks unchanged compared to the prior version. https://reviews.llvm.org/D36357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: r322350 - [ODRHash] Don't hash friend functions.

If r322350 is temporary fix, I suggest r321395 may be reverted in release_60. Richard, how do you think? On Wed, Jan 17, 2018 at 4:27 AM Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > There was a different, possibly related, issue with templated methods that > I just disable

[PATCH] D41311: [CodeGen] Fix crash when a function taking transparent union is redeclared.

vsapsai updated this revision to Diff 130038. vsapsai added a comment. - Try another approach for the fix. It has broader impact but semantically seems to be more correct. Also I think `hasScalarEvaluationKind` should use `Arg->getType()` everywhere as it matches `EmitParmDecl` behaviour. Instea

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton created this revision. benhamilton added reviewers: jolesiak, krasimir. Herald added subscribers: cfe-commits, klimek. This improves upon the previous Objective-C header guessing heuristic from https://reviews.llvm.org/rC320479. Now, we run the lexer on C++ header files and look for O

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130041. benhamilton added a comment. - Move tests to FormatTestObjC.cpp Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp

Re: r322549 - Squash -Wcovered-switch-default wairning

Hello Sam, This commit broke one of our builders: http://lab.llvm.org:8011/builders/ubuntu-gcc7.1-werror/builds/4517 . . . FAILED: /usr/local/gcc-7.1/bin/gcc-7.1 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/clang/tools/c-

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai added a comment. I've addressed all known issues, please take another look. https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130042. benhamilton added a comment. - Tidy up Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp =

[PATCH] D42135: [Format] Improve ObjC header guessing heuristic

benhamilton updated this revision to Diff 130044. benhamilton added a comment. - Last cleanup for tests Repository: rC Clang https://reviews.llvm.org/D42135 Files: lib/Format/Format.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp ==

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb added a comment. After fighting with cmake for a bit, I just broke down and cross-compiled the tests by hand and then ran them under a qemu system (rather than using qemu user mode). All of the tests ran fine for me without crashing using GCC 6.3.0 for FreeBSD 12 with N32. Given the sa

Re: [clang-tools-extra] r322387 - [clangd] Code completion uses Sema for NS-level things in the current file.

Hi, ClangdTests/FuzzyMatch.Matches has been failing since this commit on a sanitized clang build on MacOS. I've seen some later commits trying to fix it, but the issue is still there. Could you please take a look? Steps to reproduce in case you need them: > cmake -G Ninja -DLIBCXX_SYSROOT=/Pat

[PATCH] D42139: [UPSTREAM] Allow passing additional compiler/linker flags for the tests

arichardson created this revision. arichardson added a reviewer: EricWF. Herald added subscribers: cfe-commits, mgorny. These flags can be specified using the CMake variables LIBCXX_TEST_LINKER_FLAGS and LIBCXX_TEST_COMPILER_FLAGS. When building the tests for CHERI I need to pass additional flags

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Wizard retitled this revision from "add ID as a special acronym to objc property declaration check for property names like bundleID. allow using acronyms as suffix." to "add ID as a special acronym to objc property decla

[PATCH] D42116: [clang-tidy] Adding Fuchsia checker for trailing returns

juliehockett updated this revision to Diff 130058. juliehockett added a comment. Good point -- updating checker to allow trailing returns if the decltype specifier is used. https://reviews.llvm.org/D42116 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp c

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322602: add ID as a special acronym to objc property declaration check for property… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.ll

  1   2   >