[PATCH] D41933: handle scoped_lockable objects being returned by value in C++17

rsmith created this revision. rsmith added reviewers: aaron.ballman, delesley, dblaikie. Herald added a subscriber: sanjoy. In C++17, guaranteed copy elision means that there isn't necessarily a constructor call when a local variable is initialized by a function call that returns a `scoped_locka

[PATCH] D41934: [analyzer] Fix CXXNewExpr callback order.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs, eraman. Even if we later change how these callbacks work (as in http://lists.llvm.org/pipermail/cfe-dev/2017-December/056314.html), i wanted

[PATCH] D41934: [analyzer] Fix CXXNewExpr callback order.

NoQ added inline comments. Comment at: test/Analysis/cxxnewexpr-callback-inline.cpp:31-32 +// CHECK-NEXT: PostStmt +// CHECK-NEXT: PreCall (foo) +// CHECK-NEXT: PostCall (foo) This ensures that there are no other callbacks after `PostStmt`, in particular that th

[PATCH] D41423: [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

rsmith added a comment. In https://reviews.llvm.org/D41423#968587, @vsapsai wrote: > OSS-Fuzz classifies the bug as medium severity security issue Well, you should probably fix it to not do that. Any sane threat model involving a C++ compiler should assume that if you can feed the compiler ar

[PATCH] D41935: [analyzer] NFC: Mark default constructors for ProgramPoints.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun. Herald added subscribers: cfe-commits, a.sidorin, rnkovacs, szepet. As suggested by Gabor in https://reviews.llvm.org/D41800, replace `{}` with `= default` for `ProgramPoint` default constructors. Repository: rC Clang http

[PATCH] D41423: [Lex] Avoid out-of-bounds dereference in LexAngledStringLiteral.

rsmith added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:2012-2015 +// Skip escaped characters. Escaped newlines will already be processed by +// getAndAdvanceChar. +if (C == '\\') + C = getAndAdvanceChar(CurPtr, Result); You can just d

[PATCH] D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts

phosek added a comment. In https://reviews.llvm.org/D41930#972923, @emaste wrote: > The title is more correctly "non-Apple hosts"? I.e., building on FreeBSD will > also use llvm-objcopy. That's a good point, updated. Repository: rC Clang https://reviews.llvm.org/D41930

[PATCH] D41930: [Fuchsia] Use llvm-objcopy as objcopy on non-Apple hosts

This revision was automatically updated to reflect the committed changes. Closed by commit rC322252: [Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts (authored by phosek, committed by ). Repository: rC Clang https://reviews.llvm.org/D41930 Files: cmake/caches/Fuchsia-stage2.cmake

r322252 - [Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts

Author: phosek Date: Wed Jan 10 20:17:57 2018 New Revision: 322252 URL: http://llvm.org/viewvc/llvm-project?rev=322252&view=rev Log: [Fuchsia] Use llvm-objcopy as objcopy on non-Darwin hosts llvm-objcopy already supports all the necessary functionality for ELF. Differential Revision: https://rev

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN marked 2 inline comments as done. TyanNN added inline comments. Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67 non_empty_dir, -file_in_bad_dir, +// file_in_bad_dir, // produces "St13exception_ptruncaught_e

[PATCH] D41929: [Fuchsia] Disable LLDB from the toolchain distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rC322253: [Fuchsia] Remove LLDB from the toolchain distribution (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D41929?vs=129377&id=129393#toc Repository: rC Clan

r322253 - [Fuchsia] Remove LLDB from the toolchain distribution

Author: phosek Date: Wed Jan 10 20:25:30 2018 New Revision: 322253 URL: http://llvm.org/viewvc/llvm-project?rev=322253&view=rev Log: [Fuchsia] Remove LLDB from the toolchain distribution This is currently not being used so disable it to reduce toolchain size. Differential Revision: https://revie

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

mclow.lists added inline comments. Comment at: test/std/experimental/filesystem/fs.op.funcs/fs.op.remove/remove.pass.cpp:67 non_empty_dir, -file_in_bad_dir, +// file_in_bad_dir, // produces "St13exception_ptruncaught_exceptions not yet implemented"

[PATCH] D40569: Use default IR alignment for cleanup.dest.slot.

adriweb added a comment. @rjmccall any ETA for a commit as requested by @jacobly? Repository: rC Clang https://reviews.llvm.org/D40569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

r322258 - Reland "[Driver] Update default sanitizer blacklist location"

Author: phosek Date: Wed Jan 10 22:42:12 2018 New Revision: 322258 URL: http://llvm.org/viewvc/llvm-project?rev=322258&view=rev Log: Reland "[Driver] Update default sanitizer blacklist location" This is related to moving the sanitizer blacklists to share/ subdirectory. Differential Revision: htt

r322260 - Revert "[Driver] Update default sanitizer blacklist location"

Author: phosek Date: Wed Jan 10 23:05:38 2018 New Revision: 322260 URL: http://llvm.org/viewvc/llvm-project?rev=322260&view=rev Log: Revert "[Driver] Update default sanitizer blacklist location" This reverts commit r322258: broke the dfsan build. Added: cfe/trunk/test/Driver/Inputs/resource_

[PATCH] D41039: Add support for attribute "trivial_abi"

ahatanak updated this revision to Diff 129397. ahatanak added a comment. In CXXRecordDecl::addedMember, set HasTrivialSpecialMembersForCall if Method->isTrivialForCall() returns true. This fixes a bug where CXXRecordDecl::hasNonTrivialDestructorForCall would return false for the implicit destr

[PATCH] D41937: [WebAssembly] supports -stdlib=libc++ switch

patcheng created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, sbc100, dschuff, jfb. Herald added a reviewer: EricWF. Referenced implementation from Fuchsia and Darwin Toolchain. Still only support CST_Libcxx. Now checks that the argument is really '-

<    1   2