[PATCH] D33563: Track whether a unary operation can overflow

aaron.ballman added inline comments. Comment at: test/Misc/ast-dump-stmt.c:66 + // CHECK:ImplicitCastExpr + // CHECK: DeclRefExpr{{.*}}'T2' 'int' +} efriedma wrote: > aaron.ballman wrote: > > efriedma wrote: > > > What does it mean for bitwise

[PATCH] D33563: Track whether a unary operation can overflow

aaron.ballman updated this revision to Diff 128984. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. https://reviews.llvm.org/D33563 Files: include/clang/AST/Expr.h lib/AST/ASTDumper.cpp lib/AST/ASTImporter.cpp lib/AST/Expr

[PATCH] D38639: [clangd] #include statements support for Open definition

malaperle added a comment. @ilya-biryukov Hi! I'll be updating William's patches that were in progress. I just have a few comments/question before I send a new update. (I also don't know if I can update this diff or I have to create a new diff on Phabricator... I guess we'll see!!).

r322038 - [X86] Replace cvt*2mask intrinsics with native IR using 'icmp slt X, zeroinitializer.

Author: ctopper Date: Mon Jan 8 14:37:56 2018 New Revision: 322038 URL: http://llvm.org/viewvc/llvm-project?rev=322038&view=rev Log: [X86] Replace cvt*2mask intrinsics with native IR using 'icmp slt X, zeroinitializer. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trunk/test/CodeGen

[PATCH] D41409: [analyzer] Fix intermediate diagnostics on paths that go through operator new().

dcoughlin added a comment. LGTM as well. Repository: rC Clang https://reviews.llvm.org/D41409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r322039 - Revert "Make rehash(0) work with ubsan's unsigned-integer-overflow."

Author: danalbert Date: Mon Jan 8 14:57:12 2018 New Revision: 322039 URL: http://llvm.org/viewvc/llvm-project?rev=322039&view=rev Log: Revert "Make rehash(0) work with ubsan's unsigned-integer-overflow." Seems to have broken some tests since I first wrote this a while back. Will reland after che

[PATCH] D41368: [libc++] Ignore bogus tautologic comparison warnings

smeenai abandoned this revision. smeenai added a comment. The warning was removed from `-Wall`. Repository: rCXX libc++ https://reviews.llvm.org/D41368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D33563: Track whether a unary operation can overflow

rsmith added a comment. Looks fine to me, wait to see if Eli has more comments. https://reviews.llvm.org/D33563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40513: [libcxx] Support the use of compiler-rt in lit tests

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Herald added a subscriber: llvm-commits. LGTM. Honestly, I'm surprised we don't already have a way to configure like this. Repository: rL LLVM https://reviews.llvm.org/D40513 __

[PATCH] D41837: Add Function multiversion to the release notes.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine. Can you also update include/clang/Basic/AttrDocs.td to mention multiversioning in `TargetDocs`? Then you can add a few words here to say "consult the documentation for the target a

r322043 - Document attribute target multiversioning.

Author: erichkeane Date: Mon Jan 8 15:36:29 2018 New Revision: 322043 URL: http://llvm.org/viewvc/llvm-project?rev=322043&view=rev Log: Document attribute target multiversioning. Add attribute target multiversioning to the release notes. Additionally adds multiversioning support to the attribut

[libcxx] r322044 - [libcxx] Support the use of compiler-rt in lit tests

Author: phosek Date: Mon Jan 8 15:36:53 2018 New Revision: 322044 URL: http://llvm.org/viewvc/llvm-project?rev=322044&view=rev Log: [libcxx] Support the use of compiler-rt in lit tests Don't link tests against libgcc when compiler-rt is being used. Differential Revision: https://reviews.llvm.or

[PATCH] D41837: Add Function multiversion to the release notes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322043: Document attribute target multiversioning. (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D41837?vs=128982&id=128995#toc Repository: rC Clang http

[PATCH] D40513: [libcxx] Support the use of compiler-rt in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX322044: [libcxx] Support the use of compiler-rt in lit tests (authored by phosek, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D40513 Files: test/CMakeLists.txt test/lit.site

[PATCH] D41575: [index] Return when DC is null in handleReference

akyrtzi added a comment. Ah, sorry I mislead you. To test this try using `c-index-test -index-file /path/to/file`, see other examples in `test/Index`, e.g. `test/Index/index-file.cpp` Repository: rL LLVM https://reviews.llvm.org/D41575 ___ cfe-

[PATCH] D41841: [OpenMP] Fix handling of clause on wrong directive

jdenny created this revision. jdenny added a reviewer: ABataev. First, this patch fixes an assert failure when, for example, "omp for" has num_teams. Second, this patch prevents duplicate diagnostics when, for example, "omp for" has uniform. This patch makes the general assumption (even where it

[PATCH] D33563: Track whether a unary operation can overflow

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D41842: [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi.

bsdjhb created this revision. bsdjhb added reviewers: compnerd, sdardis. Herald added a subscriber: arichardson. This is in preparation for adding support for N32 unwinding which reuses the newabi register class. https://reviews.llvm.org/D41842 Files: include/__libunwind_config.h src/Regist

[PATCH] D41788: [DeclPrinter] Fix two cases that crash clang -ast-print.

jlebar added a comment. I strongly approve of fixing these crashes, but I don't think I can say with confidence whether this change is correct. https://reviews.llvm.org/D41788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D41523: xmmintrin.h documentation fixes and updates

dyung added inline comments. Comment at: lib/Headers/xmmintrin.h:1927 /// -/// This intrinsic corresponds to the VPEXTRQ / MOVQ instruction. +/// This intrinsic corresponds to the VPEXTRQ / PEXTRQ instruction. /// RKSimon wrote: > Not necessarily, it could

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung added inline comments. Comment at: lib/Headers/mmintrin.h:1402 /// -/// This intrinsic corresponds to the VPSHUFLW / PSHUFLW instruction. +/// This intrinsic corresponds to the PSHUFLW instruction. /// craig.topper wrote: > This is overly specific Jus

[PATCH] D41517: mmintrin.h documentation fixes and updates

craig.topper added inline comments. Comment at: lib/Headers/mmintrin.h:1402 /// -/// This intrinsic corresponds to the VPSHUFLW / PSHUFLW instruction. +/// This intrinsic corresponds to the PSHUFLW instruction. /// dyung wrote: > craig.topper wrote: > > Thi

[PATCH] D41843: [libcxx] implement where expressions.

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. Where expressions have three cases: *) const_where_expression, simd<...>>, we store two references to the mask and the simd<> value. *) const_where_expression, simd_mask<...>>, we store

[PATCH] D41844: [libcxx] implement mask reductions

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. This is not efficiently implemented typename V::value_type reduce(const const_where_expression &x, typename V::value_type neutral_element, BinaryOperation binary_op); as w

[PATCH] D41845: [libcxx] clean up and complete

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. The cleanup patch adds sevreal TODOs for the following unimplemented features: *) aligned load *) simd<> version of functions This patch declares the completion of my implementation of

[PATCH] D41845: [libcxx] clean up and complete

timshen updated this revision to Diff 129006. timshen added a comment. Implement memory_alignment. https://reviews.llvm.org/D41845 Files: libcxx/include/experimental/simd Index: libcxx/include/experimental/simd === --- libcxx/in

[PATCH] D41376: [libcxx] Implement ABI for Clang/GCC vector extension, constructors, copy_from and copy_to.

timshen updated this revision to Diff 129008. timshen added a comment. Rebased. https://reviews.llvm.org/D41376 Files: libcxx/include/__config libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/include/utility libcxx/test/std/experimental/simd/simd.abi/vector

[PATCH] D41412: [libcxx] implement concat() and split()

timshen updated this revision to Diff 129009. timshen added a comment. Rebased. https://reviews.llvm.org/D41412 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.horizontal/concat.pass.cpp libcxx/test/std/experimental/simd/simd.horizontal/split.pass.cpp Index

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 129007. timshen added a comment. Rebased. https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/test/std/experimental/simd/nothing_to_do.pass.cpp libcxx/test/std/experimental/simd/simd.ca

[PATCH] D41415: [libcxx] implement casts.

timshen updated this revision to Diff 129010. timshen added a comment. Rebased. https://reviews.llvm.org/D41415 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.casts/simd_cast.pass.cpp libcxx/test/std/experimental/simd/simd.casts/static_simd_cast.pass.cpp

[PATCH] D41749: [analyzer] suppress nullability inference from a macro when result is used in another macro

dcoughlin accepted this revision. dcoughlin added a comment. Yes, this looks great! https://reviews.llvm.org/D41749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41747: [libcxx] implement simd_mask<> and operators.

timshen updated this revision to Diff 129012. timshen added a comment. Rebased. https://reviews.llvm.org/D41747 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.elementwise/operators.pass.cpp libcxx/test/std/experimental/simd/simd.mask.access/default.pass.cpp

[PATCH] D41422: [libcxx] implement operators and reduction.

timshen updated this revision to Diff 129011. timshen added a comment. Rebased. https://reviews.llvm.org/D41422 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.elementwise/clamp.pass.cpp libcxx/test/std/experimental/simd/simd.elementwise/max.pass.cpp libcx

[PATCH] D41756: [libcxx] implement simd_mask<> casts and some horizontal operations.

timshen updated this revision to Diff 129013. timshen added a comment. Rebased. https://reviews.llvm.org/D41756 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.casts/to_compatible.pass.cpp libcxx/test/std/experimental/simd/simd.casts/to_fixed_size.pass.cpp

r322052 - Fix use-after-free found by address-san on -r322028.

Author: erichkeane Date: Mon Jan 8 17:09:12 2018 New Revision: 322052 URL: http://llvm.org/viewvc/llvm-project?rev=322052&view=rev Log: Fix use-after-free found by address-san on -r322028. r322028 attempted to remove something from the "Manglings" list when it was no longer valid, and did so wit

[PATCH] D41517: mmintrin.h documentation fixes and updates

dyung updated this revision to Diff 129015. dyung added a comment. Updating diff based on review feedback. https://reviews.llvm.org/D41517 Files: lib/Headers/mmintrin.h Index: lib/Headers/mmintrin.h === --- lib/Headers/mmintrin

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

rsmith added a comment. The lexer is doing the right thing; per the C++ lexical rules, the `+1` is not part of the token in this case. I don't think this fix is in the right place; we will still examine characters after the end of the literal, even with this applied, and that doesn't seem righ

[PATCH] D41845: [libcxx] clean up and complete

timshen updated this revision to Diff 129017. timshen added a comment. Update on template variable #ifdefs in tests. https://reviews.llvm.org/D41845 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.cons/load.pass.cpp libcxx/test/std/experimental/simd/simd.mas

[PATCH] D41517: mmintrin.h documentation fixes and updates

efriedma added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// craig.topper wrote: > kromanova wrote: > > I tried clang

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai planned changes to this revision. vsapsai added a comment. Yep, the plan sounds reasonable. I also noticed that we have if (*s == '+' || *s == '-') s++; // sign code in `NumericLiteralParser::ParseNumberStartingWithZero` too. I plan to make the same change for hexadecimal numbers and

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Looks good to me with some minor nits inside (and also a request to consider factoring out common code). Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h

[PATCH] D41408: [analyzer] NFC: Fix nothrow operator new definition in a test.

dcoughlin added a comment. LGTM as well. Repository: rC Clang https://reviews.llvm.org/D41408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41800: [analyzer] Use a custom program point for the check::NewAllocator callback.

dcoughlin accepted this revision. dcoughlin added inline comments. This revision is now accepted and ready to land. Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:491 NodeBuilder &Bldr, ExplodedNode *Pred) { // TODO: Does this deserve a custom

[PATCH] D41575: [index] Return when DC is null in handleReference

MaskRay added a comment. In https://reviews.llvm.org/D41575#970412, @akyrtzi wrote: > Ah, sorry I mislead you. To test this try using `c-index-test -index-file > /path/to/file`, see other examples in `test/Index`, e.g. > `test/Index/index-file.cpp` Thanks for the command. It is really helpful

[PATCH] D41266: [analyzer] With c++-allocator-inlining, fix memory space for operator new pointers.

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:477 +bool ExprEngine::isStandardGlobalOperatorNewFunction(const CXXNewExpr *CNE) { + const FunctionDecl *FD = CNE->getOperatorNew(); + if (FD && !isa(FD) && !FD->isVariadic()) { -

[PATCH] D41516: emmintrin.h documentation fixes and updates

kromanova added inline comments. Herald added a subscriber: llvm-commits. Comment at: cfe/trunk/lib/Headers/emmintrin.h:3865 /// -/// This intrinsic corresponds to the VPUNPCKLQDQ / PUNPCKLQDQ -/// instruction. +/// This intrinsic does not correspond to a specific instructio

[PATCH] D41516: emmintrin.h documentation fixes and updates

efriedma added inline comments. Comment at: cfe/trunk/lib/Headers/emmintrin.h:4683 /// -/// This intrinsic has no corresponding instruction. +/// This intrinsic corresponds to the MOVDQ2Q instruction. /// kromanova wrote: > kromanova wrote: > > I'm not sure a

[PATCH] D41523: xmmintrin.h documentation fixes and updates

dyung updated this revision to Diff 129021. dyung added a comment. Update review based on feedback. https://reviews.llvm.org/D41523 Files: lib/Headers/xmmintrin.h Index: lib/Headers/xmmintrin.h === --- lib/Headers/xmmintrin.h ++

[PATCH] D41829: [cmake] Add cache file to bootstrap 2-stage linux cross compile on Darwin.

hintonda updated this revision to Diff 129028. hintonda added a comment. - Also pass LLVM_CONFIG_EXE. Repository: rC Clang https://reviews.llvm.org/D41829 Files: cmake/caches/Linux.cmake Index: cmake/caches/Linux.cmake === -

[PATCH] D41516: emmintrin.h documentation fixes and updates

kromanova added inline comments. Comment at: cfe/trunk/lib/Headers/emmintrin.h:4683 /// -/// This intrinsic has no corresponding instruction. +/// This intrinsic corresponds to the MOVDQ2Q instruction. /// efriedma wrote: > kromanova wrote: > > kromanova wrot

Re: r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

I haven't done a ton of investigation yet, but I suspect this commit is responsible for breaking my LLVM module selfhost build, which uses libc++ as the STL, and builds LLD (No bots appear to test this configuration). The error message can be found here: https://gist.github.com/EricWF/fb5e1d18eb10

[PATCH] D41842: [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks for splitting this up! https://reviews.llvm.org/D41842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D41523: xmmintrin.h documentation fixes and updates

kromanova added a comment. In https://reviews.llvm.org/D41523#968776, @craig.topper wrote: > The builtins are tested in tests like test/CodeGen/sse-builtins.c, Thank you! I wonder if -Wdocumentation is working... I have enabled it for a few tests, like avx-builtins.c, sse-builtins.c and re-r

<    1   2