Re: trivial_abi

On 2 January 2018 at 15:33, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hey, Richard et al. Akira and I were talking about the right ABI rule for > deciding can-pass-in-registers-ness for structs in the presence of > trivial_abi, and I think I like Akira's approach but want

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

vsapsai created this revision. vsapsai added reviewers: akyrtzi, doug.gregor. Herald added subscribers: kbarton, nemanjai. This fixes PR32732 by updating CurLexerKind to reflect available lexers. We were hitting null pointer in Preprocessor::Lex because CurLexerKind was CLK_Lexer but CurLexer was

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

vsapsai added a comment. A few approaches that I've considered but decided not to pursue: - Change code completion in comment so we don't exit file early but more gracefully. Decided not to do it because I believe early exit is important for code completion performance. And `CurLexer`/`CurLexer

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticGroups.td:438 def StrncatSize : DiagGroup<"strncat-size">; +def TautologicalTypeLimitCompare : DiagGroup<"tautological-type-li

Re: trivial_abi

> On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits > wrote: > > On 2 January 2018 at 15:33, John McCall via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Hey, Richard et al. Akira and I were talking about the right ABI rule for > deciding can-pass-in-registers-ness for

[libcxx] r321685 - Implement p0258r2: has_unique_object_representations

Author: marshall Date: Tue Jan 2 18:32:28 2018 New Revision: 321685 URL: http://llvm.org/viewvc/llvm-project?rev=321685&view=rev Log: Implement p0258r2: has_unique_object_representations Added: libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations

r321686 - PR35697: look at the first declaration when determining whether a function or

Author: rsmith Date: Tue Jan 2 18:34:35 2018 New Revision: 321686 URL: http://llvm.org/viewvc/llvm-project?rev=321686&view=rev Log: PR35697: look at the first declaration when determining whether a function or variable is extern "C" in linkage calculations. Modified: cfe/trunk/lib/AST/Decl.c

[PATCH] D41545: Replace cp -a in various Clang tests

hubert.reinterpretcast added a comment. I'll commit with `cp -R` tomorrow then; thanks. Repository: rC Clang https://reviews.llvm.org/D41545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: trivial_abi

> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: > > > >> On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >> On 2 January 2018 at 15:33, John McCall via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> Hey, Richard et

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} I have no objection to allowing ObjC attributes to be spelled in [[clang::objc_whatever]] style. We can debate giving them a more appropriate standard

[PATCH] D41512: [Sema] -Wtautological-constant-compare is too good. Cripple it.

thakis added a comment. FWIW we build with -Wall -Wextra and we disable this warning since it's in our (chromium's) opinion not useful on large real-world code. So I'm not sure it should be in -Wextra. (Also, I believe clang has historically tried to keep -Wall and -Wextra pretty similar?) Re

[libcxx] r321687 - Mark issue #2866 as "nothing to do"

Author: marshall Date: Tue Jan 2 19:43:32 2018 New Revision: 321687 URL: http://llvm.org/viewvc/llvm-project?rev=321687&view=rev Log: Mark issue #2866 as "nothing to do" Modified: libcxx/trunk/www/cxx1z_status.html Modified: libcxx/trunk/www/cxx1z_status.html URL: http://llvm.org/viewvc/l

Re: trivial_abi

On 2 January 2018 at 19:02, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: > > > > On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > On 2 January 2018 at 15:33, John McCall v

[libcxx] r321689 - Mark LWG2824 as complete. We already did it, but I added a test to be sure

Author: marshall Date: Tue Jan 2 20:37:30 2018 New Revision: 321689 URL: http://llvm.org/viewvc/llvm-project?rev=321689&view=rev Log: Mark LWG2824 as complete. We already did it, but I added a test to be sure Modified: libcxx/trunk/test/std/containers/sequences/list/list.ops/sort_comp.pass.c

Re: trivial_abi

> On Jan 2, 2018, at 10:43 PM, Richard Smith wrote: > > On 2 January 2018 at 19:02, John McCall via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka > > wrote: >> >> >> >>> On Jan 2, 2018, at 4:56 PM, Richar

[PATCH] D40481: [libclang] Fix cursors for arguments of Subscript and Call operators

nik added a comment. New year, new hope - ping :) https://reviews.llvm.org/D40481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40072: [libclang] Support querying whether a declaration is invalid

nik updated this revision to Diff 128491. nik added a comment. Had to rebase. Repository: rC Clang https://reviews.llvm.org/D40072 Files: include/clang-c/Index.h test/Index/print-type-size.cpp tools/c-index-test/c-index-test.c tools/libclang/CIndex.cpp tools/libclang/libclang.expor

<    1   2