lebedev.ri added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:439
def TautologicalUnsignedZeroCompare :
DiagGroup<"tautological-unsigned-zero-compare">;
def TautologicalUnsignedEnumZeroCompare :
DiagGroup<"tautological-unsigned-enum-zero-compare">;
+de
lebedev.ri updated this revision to Diff 128128.
lebedev.ri added a comment.
Move `TautologicalUnsignedZeroCompare` and
`TautologicalUnsignedEnumZeroCompare` into `TautologicalRangeCompare` too, and
enable them only in `-Wextra`.
Please advise re flag name for `warn_tautological_constant_compare
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for vpclmulqdq instructions, matching a similar work
on the backend (https://reviews.llvm.org/D40101)
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
in
Author: whitequark
Date: Mon Dec 25 05:06:09 2017
New Revision: 321440
URL: http://llvm.org/viewvc/llvm-project?rev=321440&view=rev
Log:
[libunwind] Avoid using C++ headers.
This is useful for building libunwind on libcxx-free systems.
Modified:
libunwind/trunk/src/DwarfParser.hpp
Modified:
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D41492
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
Author: whitequark
Date: Mon Dec 25 05:27:56 2017
New Revision: 321441
URL: http://llvm.org/viewvc/llvm-project?rev=321441&view=rev
Log:
[libunwind] convert error logs to _LIBUNWIND_LOG/_LIBUNWIND_LOG0.
Use the `_LIBUNWIND_LOG` and `_LIBUNWIND_LOG0` macros instead of
the explicit `fprintf` call.
Author: whitequark
Date: Mon Dec 25 05:42:41 2017
New Revision: 321442
URL: http://llvm.org/viewvc/llvm-project?rev=321442&view=rev
Log:
[libunwind] fix a typo in r321441.
Modified:
libunwind/trunk/src/DwarfParser.hpp
Modified: libunwind/trunk/src/DwarfParser.hpp
URL:
http://llvm.org/viewvc
coby updated this revision to Diff 128139.
coby added a comment.
removing guards to allow better diags
Repository:
rC Clang
https://reviews.llvm.org/D41573
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
l
oren_ben_simhon added a comment.
In https://reviews.llvm.org/D40478#962348, @craig.topper wrote:
> Are we sure we want a different command line option name from gcc? From our
> internal conversations with the gcc folks I thought they were suggesting that
> -fcf-protection could imply a software
oren_ben_simhon updated this revision to Diff 128141.
oren_ben_simhon added a comment.
Implemented comments posted until 12/24 (Thanks Craig)
Moved cf-protection attributes from function attributes to module attributes.
Repository:
rL LLVM
https://reviews.llvm.org/D40478
Files:
include/cla
oren_ben_simhon updated this revision to Diff 128143.
oren_ben_simhon added a comment.
Reverted clang-format whitespaces updates
Repository:
rL LLVM
https://reviews.llvm.org/D40478
Files:
include/clang/Basic/DiagnosticCommonKinds.td
include/clang/Basic/TargetInfo.h
include/clang/Driver
xgsa marked 5 inline comments as done.
xgsa added inline comments.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:276
+
+ using NolintMap = std::unordered_map xgsa wrote:
> > aaron.ballman wrote:
> > > Is there a better LLVM ADT to use here?
> > This data structure provi
xgsa updated this revision to Diff 128144.
xgsa marked an inline comment as done.
xgsa added a comment.
Herald added a subscriber: mgrang.
Review comments applied.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41326
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidyDiagn
Author: whitequark
Date: Mon Dec 25 09:05:07 2017
New Revision: 321445
URL: http://llvm.org/viewvc/llvm-project?rev=321445&view=rev
Log:
[libunwind] Add proper support for DWARF unwind on bare metal.
Right now, ARM EHABI unwind on bare metal expects to find the symbols
__exidx_start and __exidx_e
Generally I'd encourage you/anyone to use [&] for any lambda that doesn't
escape its scope - avoids any issues like this & doesn't really hinder
readability imho.
On Wed, Dec 20, 2017 at 9:23 AM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Wed Dec 20 09:2
Hi:
This change breaks in a local debug build, e.g.,:
/Users/dhinton/projects/llvm_project/libunwind/src/DwarfParser.hpp:559:28:
error: no member named 'numeric_limits' in namespace 'std'
assert(length < std::numeric_limits::max() && "pointer
overflow");
~^
thanks
On 2017-12-25 19:04, Don Hinton wrote:
Hi:
This change breaks in a local debug build, e.g.,:
/Users/dhinton/projects/llvm_project/libunwind/src/DwarfParser.hpp:559:28:
error: no member named 'numeric_limits' in namespace 'std'
assert(length < std::numeric_limits::max() && "pointer
overflo
Test case?
On Thu, Dec 21, 2017 at 2:39 PM Richard Trieu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rtrieu
> Date: Thu Dec 21 14:38:29 2017
> New Revision: 321319
>
> URL: http://llvm.org/viewvc/llvm-project?rev=321319&view=rev
> Log:
> [ODRHash] Canonicalize Decl's before pro
any chance this can be implemented based on keyboard layout, so it's good
for dvorak users as well? (maybe it already is, I don't know - just
mentioning it in case)
On Thu, Dec 21, 2017 at 2:58 PM George Karpenkov via Phabricator via
cfe-commits wrote:
> This revision was automatically updated t
On Mon, Dec 25, 2017 at 11:09 AM, whitequark
wrote:
> On 2017-12-25 19:04, Don Hinton wrote:
>
>> Hi:
>>
>> This change breaks in a local debug build, e.g.,:
>>
>> /Users/dhinton/projects/llvm_project/libunwind/src/DwarfPars
>> er.hpp:559:28:
>> error: no member named 'numeric_limits' in namespac
Here's the patch I applied locally.
hth...
don
diff --git a/src/DwarfParser.hpp b/src/DwarfParser.hpp
index 518101e..ac4f1c4 100644
--- a/src/DwarfParser.hpp
+++ b/src/DwarfParser.hpp
@@ -540,7 +540,7 @@ bool CFI_Parser::parseInstructions(A &addressSpace,
pint_t instructions,
results->cfa
Author: whitequark
Date: Mon Dec 25 12:04:47 2017
New Revision: 321446
URL: http://llvm.org/viewvc/llvm-project?rev=321446&view=rev
Log:
[libunwind] Unbreak debug builds after r321440.
Modified:
libunwind/trunk/src/DwarfParser.hpp
Modified: libunwind/trunk/src/DwarfParser.hpp
URL:
http://ll
On 2017-12-25 19:43, Don Hinton wrote:
Here's the patch I applied locally.
hth...
don
[snip]
I've committed a slightly beautified version of the patch (below)
as r321446. Cheers!
From 8a4760bafc1123f09438587ee5432eabdec3d33d Mon Sep 17 00:00:00 2001
From: whitequark
Date: Mon, 25 Dec 2017 20
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
While beauty is in the eye of the beholder, I'm not sure introducing a new
template function in a header that's only used in that header is a good
idea. Every file that includes DwarfParser.hpp is going to get that
template function -- and someone may try to use it someday.
However, if you did wa
On 2017-12-25 20:32, Don Hinton wrote:
While beauty is in the eye of the beholder, I'm not sure introducing a
new template function in a header that's only used in that header is a
good idea. Every file that includes DwarfParser.hpp is going to get
that template function -- and someone may try t
On Mon, Dec 25, 2017 at 12:43 PM, whitequark
wrote:
> On 2017-12-25 20:32, Don Hinton wrote:
>
>> While beauty is in the eye of the beholder, I'm not sure introducing a
>> new template function in a header that's only used in that header is a
>> good idea. Every file that includes DwarfParser.hp
Author: whitequark
Date: Mon Dec 25 13:08:41 2017
New Revision: 321448
URL: http://llvm.org/viewvc/llvm-project?rev=321448&view=rev
Log:
[libunwind] Remove dubious template function. NFC.
Per review by Don Hinton.
Modified:
libunwind/trunk/src/DwarfParser.hpp
Modified: libunwind/trunk/src/D
On 2017-12-25 20:54, Don Hinton wrote:
On Mon, Dec 25, 2017 at 12:43 PM, whitequark
wrote:
On 2017-12-25 20:32, Don Hinton wrote:
It should also assert for non-integral types.
True, but I do not know enough C++ magic to implement that. AIUI
std::numeric_limits implements this by specializing
Author: faisalv
Date: Mon Dec 25 14:23:20 2017
New Revision: 321449
URL: http://llvm.org/viewvc/llvm-project?rev=321449&view=rev
Log:
Add a fixit for attributes incorrectly placed prior to 'struct/class/enum'
keyword.
Suggest moving the following erroneous attrib list (based on location)
[[]] st
On Mon, Dec 25, 2017 at 1:10 PM, whitequark
wrote:
> On 2017-12-25 20:54, Don Hinton wrote:
>
>> On Mon, Dec 25, 2017 at 12:43 PM, whitequark
>> wrote:
>>
>>> On 2017-12-25 20:32, Don Hinton wrote:
>>>
It should also assert for non-integral types.
>>>
>>> True, but I do not know enough
MaskRay created this revision.
Herald added a subscriber: cfe-commits.
DC may sometimes be NULL and getContainerInfo(DC, Container) will fail.
Repository:
rC Clang
https://reviews.llvm.org/D41575
Files:
tools/libclang/CXIndexDataConsumer.cpp
Index: tools/libclang/CXIndexDataConsumer.cpp
MaskRay updated this revision to Diff 128148.
MaskRay added a comment.
DC -> Parent
Repository:
rC Clang
https://reviews.llvm.org/D41575
Files:
tools/libclang/CXIndexDataConsumer.cpp
Index: tools/libclang/CXIndexDataConsumer.cpp
===
MaskRay updated this revision to Diff 128149.
MaskRay added a comment.
DC -> Parent
Repository:
rC Clang
https://reviews.llvm.org/D41575
Files:
tools/libclang/CXIndexDataConsumer.cpp
Index: tools/libclang/CXIndexDataConsumer.cpp
===
MaskRay updated this revision to Diff 128150.
MaskRay added a comment.
Sorry for changing this back and forth. But I do not have a powerful
workstation and have to reverse engineer this.
Repository:
rC Clang
https://reviews.llvm.org/D41575
Files:
tools/libclang/CXIndexDataConsumer.cpp
I
35 matches
Mail list logo
