dyung created this revision.
This is the result of several patches we made internally to update the
documentation that we would like to have reviewed for possible submission.
The changes include:
1. Fixed innaccurate instruction mappings for various intrinsics.
2. Fixed description of NaN handl
lhchavez added inline comments.
Comment at: include/__mutex_base:65
void unlock() _NOEXCEPT
_LIBCPP_THREAD_SAFETY_ANNOTATION(release_capability());
+#ifdef _LIBCPP_HAS_THREAD_SAFETY_ANNOTATIONS
+const mutex& operator!() const { return *this; }
mclow.lis
lebedev.ri added inline comments.
Comment at: lib/Headers/avxintrin.h:1668
///operation to use: \n
-///0x00 : Equal (ordered, non-signaling)
-///0x01 : Less-than (ordered, signaling)
-///0x02 : Less-than-or-equal (ordered, signaling)
-///0x03 : Unordered (non
dyung created this revision.
This is the result of several patches we made internally to update the
documentation that we would like to have reviewed for possible submission.
The changes include:
1. Fix instruction mappings/listings for various intrinsics
These patches were made by Craig Flore
Author: rsmith
Date: Thu Dec 21 14:26:47 2017
New Revision: 321318
URL: http://llvm.org/viewvc/llvm-project?rev=321318&view=rev
Log:
Suppress "redundant parens" warning for "A (::B())".
This is a slightly odd construct (it's more common to see "A (::B)()") but can
happen in friend declarations, a
dyung created this revision.
This is the result of several patches we made internally to update the
documentation that we would like to have reviewed for possible submission.
The changes include:
1. Fix incorrect wording in various intrinsic descriptions. Previously the
descriptions used "low-
dyung created this revision.
This is the result of several patches we made internally to update the
documentation that we would like to have reviewed for possible submission.
The changes include:
1. Fix formatting issue due to hyphenated terms at line breaks.
2. Fix typo
These patches were mad
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
- __shfl_{up,down}* uses `unsigned int` for the third parameter.
- added [unsigned] long overloads for non-sync shuffles. Augments r319908 which
added long overload for sync shuffles.
https://reviews.llv
Author: rtrieu
Date: Thu Dec 21 14:38:29 2017
New Revision: 321319
URL: http://llvm.org/viewvc/llvm-project?rev=321319&view=rev
Log:
[ODRHash] Canonicalize Decl's before processing.
Canonicalizing the Decl before processing it as part of the hash should reduce
issues with non-canonical types show
dyung created this revision.
This is the result of several patches we made internally to update the
documentation that we would like to have reviewed for possible submission.
The changes include:
1. Fix inaccurate instruction listings.
2. Fix small issues in _mm_getcsr and _mm_setcsr.
3. Fix de
Author: george.karpenkov
Date: Thu Dec 21 14:57:51 2017
New Revision: 321320
URL: http://llvm.org/viewvc/llvm-project?rev=321320&view=rev
Log:
[analyzer] Add Javascript to analyzer HTML output to allow keyboard navigation.
Differential Revision: https://reviews.llvm.org/D41414
Modified:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321320: [analyzer] Add Javascript to analyzer HTML output to
allow keyboard navigation. (authored by george.karpenkov, committed by ).
Herald added a subscriber: cfe-commits.
Changed prior to commit:
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321320: [analyzer] Add Javascript to analyzer HTML output to
allow keyboard navigation. (authored by george.karpenkov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41414?vs=127919&
Author: adrian
Date: Thu Dec 21 15:03:05 2017
New Revision: 321321
URL: http://llvm.org/viewvc/llvm-project?rev=321321&view=rev
Log:
Delete dead code.
Modified:
cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe
akyrtzi added a comment.
Nice one! One minor change I'd suggest is to change `SymbolProperty` to `enum
class SymbolProperty : SymbolPropertySet`, so that if it needs to increase we
only change the type in one place.
Repository:
rC Clang
https://reviews.llvm.org/D41514
___
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Since this is tricky and we've seen it affecting user code, do you think it's a
bad idea to add tests to the test-suite?
https://reviews.llvm.org/D41521
___
arphaman created this revision.
arphaman added a reviewer: benlangmuir.
Herald added a subscriber: JDevlieghere.
This patch allows libclang to report a parser crash that's caused by `#pragma
clang __debug parser_crash` without using the `LLVM_BUILTIN_TRAP`. Instead a
new flag in PPOpts is used t
Author: probinson
Date: Thu Dec 21 15:19:25 2017
New Revision: 321323
URL: http://llvm.org/viewvc/llvm-project?rev=321323&view=rev
Log:
Update test after r321312
Modified:
clang-tools-extra/trunk/unittests/change-namespace/ChangeNamespaceTests.cpp
Modified:
clang-tools-extra/trunk/unittests
Author: erichkeane
Date: Thu Dec 21 15:27:36 2017
New Revision: 321324
URL: http://llvm.org/viewvc/llvm-project?rev=321324&view=rev
Log:
Correct hasFeature/isValidFeatureName's handling of shstk/adx/mwaitx
https://bugs.llvm.org/show_bug.cgi?id=35721 reports that x86intrin.h
is issuing a few warni
tra added a comment.
Added to my todo list. There are few more gaps that I want to test in order to
make sure we don't regress on compatibility with older CUDA versions while
changing these wrappers.
https://reviews.llvm.org/D41521
___
cfe-commit
NoQ added a comment.
So, essentially, `LoopContext` is per-loop, while `ScopeContext` is
per-iteration?
Comment at: lib/StaticAnalyzer/Core/LoopUnrolling.cpp:28-46
struct LoopState {
private:
enum Kind { Normal, Unrolled } K;
- const Stmt *LoopStmt;
- const LocationCont
juliehockett updated this revision to Diff 127960.
juliehockett marked 5 inline comments as done.
juliehockett added a comment.
Fixing comments
https://reviews.llvm.org/D41363
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/OverloadedOp
NoQ added a comment.
Or not. Loop counter has its own whole-loop scope.
I guess `LoopContext` can be treated as a sub-class of `ScopeContext`. And i
don't mind having `ScopeContext` be split into small distinct sub-classes.
Because we're stuck in cornercases for covering all possible scopes, wh
juliehockett added a comment.
> Are the Fuchsia library headers intended to also comply with this rule? I
> notice there's mention of a unique_ptr class, and I can't imagine that
> working without overloading more operators than just assignment. Perhaps this
> check should not be triggered for
erichkeane added a comment.
I'm sure most of you have taken off for the year, but if anyone had time,
*ping* :D
https://reviews.llvm.org/D40819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
benlangmuir added a comment.
Did you consider just using a different pragma that triggers this behaviour
instead of avoiding the crash? I don't really have a strong preference but I'd
be interested to hear what you think the pros/cons are.
Comment at: lib/Parse/ParseDecl.cpp
Author: ctopper
Date: Thu Dec 21 15:50:22 2017
New Revision: 321325
URL: http://llvm.org/viewvc/llvm-project?rev=321325&view=rev
Log:
[X86] Allow _mm_prefetch (both the header implementation and the builtin) to
accept bit 2 which is supposed to indicate the prefetched addresses will be
written t
Author: tra
Date: Thu Dec 21 15:52:09 2017
New Revision: 321326
URL: http://llvm.org/viewvc/llvm-project?rev=321326&view=rev
Log:
[CUDA] More fixes for __shfl_* intrinsics.
* __shfl_{up,down}* uses unsigned int for the third parameter.
* added [unsigned] long overloads for non-sync shuffles.
Dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rC321326: [CUDA] More fixes for __shfl_* intrinsics. (authored
by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41521?vs=127950&id=127962#toc
Repository:
rC Clang
https://rev
vsapsai created this revision.
vsapsai added reviewers: arphaman, ahatanak.
rdar://problem/33251668
https://reviews.llvm.org/D41528
Files:
clang/lib/Sema/SemaType.cpp
clang/test/Sema/warn-strict-prototypes.c
Index: clang/test/Sema/warn-strict-prototypes.c
=
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you
https://reviews.llvm.org/D41528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
arphaman abandoned this revision.
arphaman added a comment.
It turns out there's already something that works much better: `#pragma clang
__debug handle_crash`. Sorry about the redundant patch!
Repository:
rC Clang
https://reviews.llvm.org/D41526
__
kromanova added inline comments.
Comment at: lib/Headers/avxintrin.h:1668
///operation to use: \n
-///0x00 : Equal (ordered, non-signaling)
-///0x01 : Less-than (ordered, signaling)
-///0x02 : Less-than-or-equal (ordered, signaling)
-///0x03 : Unordered (non-
Author: bruno
Date: Thu Dec 21 18:53:30 2017
New Revision: 321337
URL: http://llvm.org/viewvc/llvm-project?rev=321337&view=rev
Log:
[Modules] Change private modules rules and warnings
We used to advertise private modules to be declared as submodules
(Foo.Private). This has proven to not scale wel
Author: faisalv
Date: Thu Dec 21 19:50:55 2017
New Revision: 321339
URL: http://llvm.org/viewvc/llvm-project?rev=321339&view=rev
Log:
Diagnose the various invalid decl-specifiers on nontype template parameters.
The standard correctly forbids various decl-specifiers that dont make sense on
non-ty
faisalv closed this revision.
faisalv added a comment.
Added via https://reviews.llvm.org/rC321339
Repository:
rC Clang
https://reviews.llvm.org/D40705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: ctopper
Date: Thu Dec 21 20:51:00 2017
New Revision: 321341
URL: http://llvm.org/viewvc/llvm-project?rev=321341&view=rev
Log:
[X86] Add 'prfchw' to the correct CPUs to match the backend.
Modified:
cfe/trunk/lib/Basic/Targets/X86.cpp
cfe/trunk/test/Preprocessor/predefined-arch-macr
Author: bruno
Date: Thu Dec 21 21:04:43 2017
New Revision: 321342
URL: http://llvm.org/viewvc/llvm-project?rev=321342&view=rev
Log:
[Modules] Map missing private submodules from Foo.Private to Foo_Private
In case `@import Foo.Private` fails because the submodule doesn't exist,
look for `Foo_Priva
Author: ctopper
Date: Thu Dec 21 21:09:38 2017
New Revision: 321343
URL: http://llvm.org/viewvc/llvm-project?rev=321343&view=rev
Log:
[X86] Add missing check lines for the silvermont cases in
predefined-arch-macros.c test.
Modified:
cfe/trunk/test/Preprocessor/predefined-arch-macros.c
Modif
jackoalan created this revision.
jackoalan added a reviewer: cfe-commits.
I maintain a couple build tools based on Clang's Tooling framework. The tools
are built and used directly out of the CMake binary directory (i.e. not
installed in a meaningful way).
This non-installed setup causes issues
sammccall updated this revision to Diff 127986.
sammccall added a comment.
Avoid repeating uint8_t type for SymbolProperty/SymbolPropertySet.
Repository:
rC Clang
https://reviews.llvm.org/D41514
Files:
include/clang/Index/IndexSymbol.h
lib/Index/IndexSymbol.cpp
tools/libclang/CXIndexDa
vladimir.plyashkun created this revision.
vladimir.plyashkun added reviewers: alexfh, benlangmuir.
vladimir.plyashkun added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
These changes introduce support for -vfsoverlay option in Clang-Tidy
The main reason for it:
In IDE inte
Author: sammccall
Date: Thu Dec 21 23:09:51 2017
New Revision: 321346
URL: http://llvm.org/viewvc/llvm-project?rev=321346&view=rev
Log:
Fix unused variable warning in SemaTemplate. NFC
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp
URL:
http://ll
vladimir.plyashkun created this revision.
vladimir.plyashkun added a reviewer: alexfh.
vladimir.plyashkun added projects: clang, clang-tools-extra.
Herald added subscribers: cfe-commits, klimek.
This is part of review - https://reviews.llvm.org/D41535
Repository:
rC Clang
https://reviews.llvm
vladimir.plyashkun added a comment.
Second part of review - https://reviews.llvm.org/D41536
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
xgsa added a comment.
Ping.
https://reviews.llvm.org/D41326
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: include/clang/AST/Type.h:1152
+NTFK_Struct, // non-trivial C struct.
+NTFK_Array// array that has non-trivial elements.
+ };
ahatanak wrote:
> rjmccall wrote:
> > ahatanak wrote:
> > > rjmccall wrote:
> >
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Interesting. Okay, LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D41433
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Those are some impressive numbers!
Excited to see this land, thanks for tracking down all the weird problems.
Comment at: clangd/ClangdUnit.cpp:536
+ // so we set
101 - 149 of 149 matches
Mail list logo
