r319746 - Add __WINT_MAX__.

2017-12-05 Thread Ed Schouten via cfe-commits
Author: ed Date: Tue Dec 5 01:13:18 2017 New Revision: 319746 URL: http://llvm.org/viewvc/llvm-project?rev=319746&view=rev Log: Add __WINT_MAX__. This definition is similar to __WCHAR_MAX__, except that it applies to wint_t. It's also documented as being supported by GCC 4.5 and later. Modified

[PATCH] D40415: [libcxx] Define istream_iterator equality comparison operators out-of-line

2017-12-05 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki added a comment. Ping https://reviews.llvm.org/D40415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r319748 - [clang-format] Releasenotes for rL319024 : Add option to group multiple #include blocks when sorting includes

2017-12-05 Thread Sylvestre Ledru via cfe-commits
Author: sylvestre Date: Tue Dec 5 01:23:47 2017 New Revision: 319748 URL: http://llvm.org/viewvc/llvm-project?rev=319748&view=rev Log: [clang-format] Releasenotes for rL319024 : Add option to group multiple #include blocks when sorting includes Summary: This change adds missing releasenotes for

[PATCH] D36672: [clang-tidy] readability-non-const-parameter: fixit on all function declarations

2017-12-05 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added a comment. Fixed by https://reviews.llvm.org/rL319021? Repository: rL LLVM https://reviews.llvm.org/D36672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

2017-12-05 Thread silviu.bara...@arm.com via Phabricator via cfe-commits
sbaranga added inline comments. Comment at: include/clang/Basic/Attr.td:1218-1228 def NeonPolyVectorType : TypeAttr { - let Spellings = [GNU<"neon_polyvector_type">]; + let Spellings = [Clang<"neon_polyvector_type">]; let Args = [IntArgument<"NumElements">]; let Document

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

2017-12-05 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan added inline comments. Comment at: cfe/trunk/lib/Sema/SemaOverload.cpp:6365 cast(FD)->getParent(), ObjectType, - ObjectClassification, Args.slice(1), CandidateSet, + ObjectClassification, Functi

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

2017-12-05 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clangd/ClangdUnit.cpp:377 + : Result(&Result), SymbolScore(score(Result)), FilterScore(FilterScore), +Score(FilterScore * SymbolScore) {} It might worth mentioning how well `FilterScore * SymbolScore` perfo

[PATCH] D40829: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation

2017-12-05 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth created this revision. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai, klimek. A user of the check opened a bugreport and reported that `std::exchange` triggers a false positive. I adjusted the doc to include a list of known (std) constructs that do trigger the issue

[PATCH] D40654: [clangd] Set completion options per-request.

2017-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319753: [clangd] Set completion options per-request. (authored by ibiryukov). Changed prior to commit: https://reviews.llvm.org/D40654?vs=124944&id=125487#toc Repository: rL LLVM https://reviews.llv

[clang-tools-extra] r319753 - [clangd] Set completion options per-request.

2017-12-05 Thread Ilya Biryukov via cfe-commits
Author: ibiryukov Date: Tue Dec 5 02:42:57 2017 New Revision: 319753 URL: http://llvm.org/viewvc/llvm-project?rev=319753&view=rev Log: [clangd] Set completion options per-request. Summary: Previously, completion options were set per ClangdServer instance. It will allow to change completion prefe

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

2017-12-05 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs added a comment. In https://reviews.llvm.org/D28820#944365, @efriedma wrote: > > What is the best way to modify the code for this compiler change ? > > Currently, the "interrupt" attribute only has an effect on functions, not > function pointers, so your code won't work the way you want

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

2017-12-05 Thread jina via Phabricator via cfe-commits
jina.nahias added a comment. ping https://reviews.llvm.org/D39719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40737: [clang-tidy] WIP Resubmit hicpp-multiway-paths-covered without breaking test

2017-12-05 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. @aaron.ballman I further investigated and the issue does not come directly from my code (at least thats what i believe) :) If i change the matcher simply to Finder->addMatcher(switchStmt().bind("switch"), this); The overflow still occurs! I assume that the recursiv

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-05 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. BTW, how will this feature interact with cpplint.py's way of handling specific NOLINT directives that use different lint rule names, which sometimes refer to the same rule (e.g. `// NOLINT(runtime/explicit)` suppresses the `runtime/explicit` cpplint rule that enforces th

[PATCH] D39279: Stringizing raw string literals containing newline

2017-12-05 Thread Jan Korous via Phabricator via cfe-commits
jkorous-apple added a comment. I see your concern. Would you just consider moving the annotation to header file then? It looks more like documentation of public interface than implementation details to me. I imagine any programmer interested in these methods needs to know these details so they

[PATCH] D39430: [clangd] various fixes

2017-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In https://reviews.llvm.org/D39430#943387, @malaperle wrote: > I'd rather keep one commit per fix or feature. I would think the clang-format > part should be one commit/review on its own. But I'm not very familiar with > the practices here so I'll let others comme

[PATCH] D40832: [clang-format] Adds canonical raw string delimiters support

2017-12-05 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added subscribers: cfe-commits, klimek. A canonical raw string delimiter for a given language is the preferred raw string delimiter to use for that language. For example, both 'pb' and 'proto' could serve to indentify a raw string literal as a proto string,

[PATCH] D40832: [clang-format] Adds canonical raw string delimiters support

2017-12-05 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 125501. krasimir added a comment. - Update documentation Repository: rC Clang https://reviews.llvm.org/D40832 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp unitt

[PATCH] D40834: [libc++] std::map: use throw_out_of_range()

2017-12-05 Thread Petteri Aimonen via Phabricator via cfe-commits
PetteriAimonen created this revision. Herald added a reviewer: EricWF. Previously std::map ignored out-of-bounds access when exceptions were disabled. Other containers such as std::vector use throw_out_of_range() which will terminate the program if exceptions are disabled. https://reviews.llvm.o

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-05 Thread Anton via Phabricator via cfe-commits
xgsa marked 2 inline comments as done. xgsa added inline comments. Comment at: docs/clang-tidy/index.rst:254-255 +While :program:`clang-tidy` diagnostics are intended to call out code that does +not adhere to a coding standard, or is otherwise problematic in some way, there +are

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-05 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 125517. xgsa added a comment. Updated documentation https://reviews.llvm.org/D40671 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp docs/ReleaseNotes.rst docs/clang-tidy/index.rst test/clang-tidy/nolint.cpp test/clang-tidy/nolintnextline.cpp Index

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

2017-12-05 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh created this revision. Herald added a subscriber: nhaehnle. Commit 7ac28eb0a5 / r310911 ("[OpenCL] Allow targets to select address space per type", 2017-08-15) made Basic depend on AST, introducing a circular dependency. Break this dependency by adding the OpenCLTypeKind enum in Basic and

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-05 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 125522. Nebiroth added a comment. Added error returns in findDocumentHighlights Ran clang-format on ClangdUnit.h, .cpp and ClangdServer.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38425 Files: clangd/ClangdLSPServer.cpp clangd/C

[PATCH] D33989: [OpenCL] Allow targets to select address space per type

2017-12-05 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh added a comment. Following up on the layering violation in https://reviews.llvm.org/D40838 Repository: rL LLVM https://reviews.llvm.org/D33989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: r319715 - Fix record-parsing-invocation.c test on Windows

2017-12-05 Thread Sean Eveson via cfe-commits
Hi, It looks like the test is still failing on one of the Windows build bots: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015 >From looking at the test locally it seems the problem is when you do `// RUN: not env...`. The env command doesn't get handled by llvm-lit.py, because it get

r319774 - [OPENMP] Fix assert fail after target implicit map checks.

2017-12-05 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 5 07:22:49 2017 New Revision: 319774 URL: http://llvm.org/viewvc/llvm-project?rev=319774&view=rev Log: [OPENMP] Fix assert fail after target implicit map checks. If the error is generated during analysis of implicitly or explicitly mapped variables, it may cause com

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Fixed in a bit different way in r319774 https://reviews.llvm.org/D40752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r319777 - [x86][AVX512] Lowering kunpack intrinsics to LLVM IR

2017-12-05 Thread Jina Nahias via cfe-commits
Author: jina.nahias Date: Tue Dec 5 07:42:47 2017 New Revision: 319777 URL: http://llvm.org/viewvc/llvm-project?rev=319777&view=rev Log: [x86][AVX512] Lowering kunpack intrinsics to LLVM IR This patch, together with a matching llvm patch (https://reviews.llvm.org/D39720), implements the lowerin

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

2017-12-05 Thread jina via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319777: [x86][AVX512] Lowering kunpack intrinsics to LLVM IR (authored by jina.nahias). Changed prior to commit: https://reviews.llvm.org/D39719?vs=122617&id=125525#toc Repository: rL LLVM https://r

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

2017-12-05 Thread jina via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319777: [x86][AVX512] Lowering kunpack intrinsics to LLVM IR (authored by jina.nahias). Repository: rC Clang https://reviews.llvm.org/D39719 Files: lib/Headers/avx512bwintrin.h lib/Headers/avx512f

[PATCH] D40580: [clang-tidy] Adding Fuchsia checker for multiple inheritance

2017-12-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: test/clang-tidy/fuchsia-multiple-inheritance.cpp:48 +}; + +// Inherits from multiple concrete classes. juliehockett wrote: > aaron.ballman wrote: > > The virtual base test cases I was thinking of were: > > ``` > >

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

2017-12-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:28-29 "fuchsia-default-arguments"); +CheckFactories.registerCheck( +"fuchsia-virtual-inheritance"); } Formatting looks off here. ==

[libcxx] r319779 - Mark a couple of internal routines as 'noexcept'

2017-12-05 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Dec 5 07:56:26 2017 New Revision: 319779 URL: http://llvm.org/viewvc/llvm-project?rev=319779&view=rev Log: Mark a couple of internal routines as 'noexcept' Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL: http://llvm.org/viewvc/llv

[PATCH] D40738: Don't use Wasm function sections for more than one function

2017-12-05 Thread Nicholas Wilson via Phabricator via cfe-commits
ncw added a comment. Thanks for the review @sunfish (and for the other input you've given). Could you land this for me Dan, as I don't have commit access? Thanks. Repository: rC Clang https://reviews.llvm.org/D40738 ___ cfe-commits mailing list

[PATCH] D40829: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation

2017-12-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This is reasonable, though if the list starts getting longer, we should consider trying to fix the bug rather than enumerate them. Comment at: docs/clang-tidy/

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

2017-12-05 Thread KCG via Phabricator via cfe-commits
kc.austin2017 added a comment. In https://reviews.llvm.org/D28820#944865, @jroelofs wrote: > In https://reviews.llvm.org/D28820#944365, @efriedma wrote: > > > > What is the best way to modify the code for this compiler change ? > > > > Currently, the "interrupt" attribute only has an effect on fu

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

2017-12-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In https://reviews.llvm.org/D39694#944642, @hfinkel wrote: > I think this is a good idea. Thanks for the review. I've replied to each comment and will make revisions after we agree on the behavioral issue you raised. Comment at: include/clang/Driver

[PATCH] D37813: clang-format: better handle namespace macros

2017-12-05 Thread Francois Ferrand via Phabricator via cfe-commits
Typz added a comment. I don't think this is really relevant for this tool: if someone changes the implementation of the macro, then *they* must indeed if it should not be formatted like a namespace (and keep the clang-format configuration unchanged), or if it should now be formatted like a clas

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-05 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle requested changes to this revision. malaperle added a comment. This revision now requires changes to proceed. Sorry I forgot to submit this additional comment in my last review pass :( Comment at: clangd/Protocol.cpp:365 + {"range", toJSON(DH.range)}, + {"ki

[PATCH] D40829: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation

2017-12-05 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. I agree. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40829: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation

2017-12-05 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 125536. JonasToth added a comment. - [Fix] typo Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40829 Files: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst Index: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst =

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-05 Thread Anton via Phabricator via cfe-commits
xgsa added a comment. In https://reviews.llvm.org/D40671#944906, @alexfh wrote: > BTW, how will this feature interact with cpplint.py's way of handling > specific NOLINT directives that use different lint rule names, which > sometimes refer to the same rule (e.g. `// NOLINT(runtime/explicit)`

[clang-tools-extra] r319785 - [clang-tidy] adjust cppcoreguidelines-owning-memory documentation

2017-12-05 Thread Jonas Toth via cfe-commits
Author: jonastoth Date: Tue Dec 5 08:37:49 2017 New Revision: 319785 URL: http://llvm.org/viewvc/llvm-project?rev=319785&view=rev Log: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation Summary: A user of the check opened a bugreport and reported that `std::exchange` triggers a fa

[PATCH] D40829: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation

2017-12-05 Thread Jonas Toth via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319785: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation (authored by JonasToth). Repository: rL LLVM https://reviews.llvm.org/D40829 Files: clang-tools-extra/trunk/docs/clang-tidy

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 125539. ilya-biryukov added a comment. Herald added a subscriber: klimek. Addressed some review comments. - Removed global context. - Context now stores a shared_ptr to ContextData to handle lifetimes properly. - Added helper getters for some commonly u

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

2017-12-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:41 uint32_t AddrSpc = CGM.getContext().getTargetAddressSpace( - CGM.getTarget().getOpenCLTypeAddrSpace(T)); + CGM.getTarget().getOpenCLTypeAddrSpace(TK)); switch (cast(T)->getKind()) { -

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov marked 6 inline comments as done. ilya-biryukov added a comment. A second attempt at implementing the `Context`s. Still missing a few comments, but hopefully ready for review. Comment at: clangd/Context.h:71 +/// before any clangd functions are called. +class Glo

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 125545. ilya-biryukov added a comment. Herald added a subscriber: klimek. - Updated to match the new Context implementation. - Logger is now stored in a global variable instead of the global Context. - Removed json-specific RequestContext, now storing al

[PATCH] D40489: [clangd] Changed tracing interfaces

2017-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Have to update to match the new `Context` implementation. https://reviews.llvm.org/D40489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. Additionally: - All async methods now take `Context` by-value and pass it to their `Callback`s or return them in `future`s. - All sync methods take `Context` by-ref In https://reviews.llvm.org/D40486#941210, @sammccall wrote: > This is pretty bikesheddy, but I

[PATCH] D40841: [analyzer] Fix a crash on C++17 AST for non-trivial construction into a trivial brace initializer.

2017-12-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. Herald added subscribers: cfe-commits, rnkovacs. Yet another situation where we cannot easily guess, by looking at the CFG, the target region for C++ constructor call. Consider the following brace initialization: struct A { A(); }; struct B : public A {

[PATCH] D40841: [analyzer] Fix a crash on C++17 AST for non-trivial construction into a trivial brace initializer.

2017-12-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 125547. NoQ added a comment. Add a forgotten //no-warning. https://reviews.llvm.org/D40841 Files: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp lib/StaticAnalyzer/Core/ExprEngineCXX.cpp test/Analysis/initializer.cpp Index: test/Analysis/initiali

r319793 - [analyzer] Mark heap-based symbolic regions in debug dumps.

2017-12-05 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Tue Dec 5 09:14:39 2017 New Revision: 319793 URL: http://llvm.org/viewvc/llvm-project?rev=319793&view=rev Log: [analyzer] Mark heap-based symbolic regions in debug dumps. They are now printed as HeapSymRegion{$x} in order to discriminate between that and regular SymRegion

[PATCH] D40793: [analyzer] Improve SymbolicRegion::dump() for heap pointers.

2017-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319793: [analyzer] Mark heap-based symbolic regions in debug dumps. (authored by dergachev). Repository: rC Clang https://reviews.llvm.org/D40793 Files: lib/StaticAnalyzer/Core/MemRegion.cpp Index

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

2017-12-05 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh updated this revision to Diff 125554. svenvh added a comment. Introducing ASTContext::getOpenCLTypeAddrSpace(const Type *T) as suggested. https://reviews.llvm.org/D40838 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp lib/Basic/Target

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. r319774 works for my current use cases. Thanks. While we're on this topic, do you happen to know the rationale behind the OpenMP restriction for which err_omp_union_type_not_allowed diagnoses violations? I googled but couldn't find the rationale. If you would prefer

[PATCH] D40737: [clang-tidy] WIP Resubmit hicpp-multiway-paths-covered without breaking test

2017-12-05 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth updated this revision to Diff 125556. JonasToth retitled this revision from "[clang-tidy] WIP Resubmit hicpp-multiway-paths-covered without breaking test " to "[clang-tidy] WIP Resubmit hicpp-multiway-paths-covered without breaking test". JonasToth added a comment. Herald added a s

[PATCH] D40832: [clang-format] Adds canonical raw string delimiters support

2017-12-05 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 125557. krasimir added a comment. - Make 'textproto' the canonical text proto delimiter for google style Repository: rC Clang https://reviews.llvm.org/D40832 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h lib/Format/Continua

[PATCH] D38801: [analyzer] In getSVal() API, disable auto-detection of void type as char type.

2017-12-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 12. NoQ added a comment. Herald added a subscriber: rnkovacs. Rebase on top of https://reviews.llvm.org/D39862 (attn. George!~). https://reviews.llvm.org/D38801 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h lib/StaticAnalyzer/Che

[PATCH] D40838: [OpenCL] Fix layering violation by getOpenCLTypeAddrSpace

2017-12-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D40838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-05 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin added a comment. In https://reviews.llvm.org/D40774#944751, @smeenai wrote: > In https://reviews.llvm.org/D40774#944749, @halyavin wrote: > > > In https://reviews.llvm.org/D40774#943993, @smeenai wrote: > > > > > Are you actually using libc++ with cl? :) > > > > > > People mostly use it

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40841: [analyzer] Fix a crash on C++17 AST for non-trivial construction into a trivial brace initializer.

2017-12-05 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:288 +// this-region of the parent stack frame). +if (dyn_cast_or_null(LCtx->getParentMap().getParent(CE))) { + MemRegionManager &MRMgr = getSValBuilder().getRegionManager(); --

r319800 - [OPENMP] Remove non-required parameters for distribute simd outlined

2017-12-05 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 5 09:41:34 2017 New Revision: 319800 URL: http://llvm.org/viewvc/llvm-project?rev=319800&view=rev Log: [OPENMP] Remove non-required parameters for distribute simd outlined region, NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/Sem

[PATCH] D40813: [clang-tidy] Adding Fuchsia checker for virtual inheritance

2017-12-05 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 125560. juliehockett marked 5 inline comments as done. https://reviews.llvm.org/D40813 Files: clang-tidy/fuchsia/CMakeLists.txt clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tidy/fuchsia/VirtualInheritanceCheck.cpp clang-tidy/fuchsia/VirtualInhe

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-05 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a subscriber: bcraig. smeenai added a comment. In https://reviews.llvm.org/D40774#945254, @halyavin wrote: > In https://reviews.llvm.org/D40774#944751, @smeenai wrote: > > > In https://reviews.llvm.org/D40774#944749, @halyavin wrote: > > > > > In https://reviews.llvm.org/D40774#9439

[PATCH] D40737: [clang-tidy] WIP Resubmit hicpp-multiway-paths-covered without breaking test

2017-12-05 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. @sbenza and @klimek the issue that occurs here is probably ASTMatchers related, thats why I added you. The problem: This patch introduces a stack overflow when building with `RelWithDebInfo` that is caught by the sanitizers. I isolated the issue in the big switch sta

r319801 - [WebAssembly] Don't use Wasm function sections for more than one function

2017-12-05 Thread Dan Gohman via cfe-commits
Author: djg Date: Tue Dec 5 09:46:17 2017 New Revision: 319801 URL: http://llvm.org/viewvc/llvm-project?rev=319801&view=rev Log: [WebAssembly] Don't use Wasm function sections for more than one function Patch by Nicholas Wilson! Fixes PR35467. Differential Revision: https://reviews.llvm.org/D4

[libcxx] r319802 - [libcxx] Fix intrinsics for MSVC

2017-12-05 Thread Shoaib Meenai via cfe-commits
Author: smeenai Date: Tue Dec 5 09:46:23 2017 New Revision: 319802 URL: http://llvm.org/viewvc/llvm-project?rev=319802&view=rev Log: [libcxx] Fix intrinsics for MSVC The parameter was previously renamed but MSVC path was not updated. Patch by Andrey Khalyavin. Differential Revision: https://re

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-05 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX319802: [libcxx] Fix intrinsics for MSVC (authored by smeenai). Repository: rCXX libc++ https://reviews.llvm.org/D40774 Files: include/algorithm Index: include/algorithm

[PATCH] D40738: Don't use Wasm function sections for more than one function

2017-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319801: [WebAssembly] Don't use Wasm function sections for more than one function (authored by djg). Repository: rC Clang https://reviews.llvm.org/D40738 Files: lib/Basic/Targets/OSTargets.h test/

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

2017-12-05 Thread Ben Craig via Phabricator via cfe-commits
bcraig added a comment. Talked with mclow and some Microsoft devs in Albuquerque. I'm not expecting include_next to show up in MSVC. Sometime in the next month I hope to rebase this change. https://reviews.llvm.org/D32411 ___ cfe-commits mailing

[PATCH] D39279: Stringizing raw string literals containing newline

2017-12-05 Thread Taewook Oh via Phabricator via cfe-commits
twoh updated this revision to Diff 125563. twoh added a comment. @jkorous-apple Got it. I agree that it would be better to move the comments to the header. Will land it soon. Thanks! https://reviews.llvm.org/D39279 Files: include/clang/Lex/Lexer.h lib/Lex/Lexer.cpp test/Preprocessor/macr

[PATCH] D39279: Stringizing raw string literals containing newline

2017-12-05 Thread Taewook Oh via Phabricator via cfe-commits
twoh updated this revision to Diff 125564. twoh added a comment. clang-format https://reviews.llvm.org/D39279 Files: include/clang/Lex/Lexer.h lib/Lex/Lexer.cpp test/Preprocessor/macro_raw_string.cpp unittests/Lex/LexerTest.cpp Index: unittests/Lex/LexerTest.cpp ===

[PATCH] D39739: [HCC] Add flag to Import Weak Functions in Function Importer

2017-12-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/Transforms/IPO/FunctionImport.cpp:107 +static cl::opt +ForceImportWeak("force-import-weak", cl::Hidden, +cl::desc("Allow weak functions to be imported"), AlexVlx wrote: > yaxunl wrote: > > Is it possib

Re: [PATCH] D40841: [analyzer] Fix a crash on C++17 AST for non-trivial construction into a trivial brace initializer.

2017-12-05 Thread Richard Smith via cfe-commits
On 5 December 2017 at 09:08, Artem Dergachev via Phabricator via cfe-commits wrote: > NoQ created this revision. > Herald added subscribers: cfe-commits, rnkovacs. > > Yet another situation where we cannot easily guess, by looking at the CFG, > the target region for C++ constructor call. > > Cons

[PATCH] D39739: [HCC] Add flag to Import Weak Functions in Function Importer

2017-12-05 Thread Brian Sumner via Phabricator via cfe-commits
b-sumner added a comment. The usual rule is to take the first weak definition encountered. Repository: rL LLVM https://reviews.llvm.org/D39739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

2017-12-05 Thread Galina Kistanova via cfe-commits
Hello Richard, This commit broke tests on one of our bots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6568 Failing Tests (3): . . . Clang :: Modules/var-templates.cpp . . . Please have a look? Thanks Galina On Mon, Dec 4, 2017 at 5:31 PM, Richard Smit

[clang-tools-extra] r319812 - Commit access test.

2017-12-05 Thread Julie Hockett via cfe-commits
Author: juliehockett Date: Tue Dec 5 10:50:49 2017 New Revision: 319812 URL: http://llvm.org/viewvc/llvm-project?rev=319812&view=rev Log: Commit access test. Modified: clang-tools-extra/trunk/clang-tidy/fuchsia/FuchsiaTidyModule.cpp Modified: clang-tools-extra/trunk/clang-tidy/fuchsia/Fuchs

[PATCH] D39739: [HCC] Add flag to Import Weak Functions in Function Importer

2017-12-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In https://reviews.llvm.org/D39739#945318, @b-sumner wrote: > The usual rule is to take the first weak definition encountered. Will this work for us? Usually we would like the last one to be linked. Repository: rL LLVM https://reviews.llvm.org/D39739

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

2017-12-05 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray updated this revision to Diff 125581. lichray added a comment. Rebased. Repository: rC Clang https://reviews.llvm.org/D39284 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DeclSpec.h lib/Parse/ParseExprCXX.cpp lib/Sema/SemaDeclCXX.cpp test/Misc/warning

[PATCH] D39430: [clangd] various fixes

2017-12-05 Thread Raoul Wols via Phabricator via cfe-commits
rwols added a comment. I will split this diff up into separate parts. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r319814 - [OPENMP] Fix implicit mapping analysis.

2017-12-05 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Dec 5 11:20:09 2017 New Revision: 319814 URL: http://llvm.org/viewvc/llvm-project?rev=319814&view=rev Log: [OPENMP] Fix implicit mapping analysis. Fixed processing of implicitly mapped objects in target-based executable directives. Modified: cfe/trunk/lib/Sema/Sema

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

2017-12-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. I'm okay with this change in principle, but Im worried that this may break the buildbots. Please ensure that they remain green after this change. Repository: rL LLVM https://reviews.l

[libcxx] r319816 - Enable auto-linking on Windows

2017-12-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Dec 5 11:32:49 2017 New Revision: 319816 URL: http://llvm.org/viewvc/llvm-project?rev=319816&view=rev Log: Enable auto-linking on Windows The MSVC driver and clang do not link against the C++ runtime explicitly. Instead, they rely on the auto-linking via the pragma (t

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

2017-12-05 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. After some more digging through libc++ test suite, I think I understand now why these are different variables. It may be possible to remove these and just rely on plain CMake variables but this is likely going to require some more CMake and lit surgery, so for now I'm go

[PATCH] D40660: Enable auto-linking on Windows

2017-12-05 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd closed this revision. compnerd added a comment. SVN r319816 Repository: rCXX libc++ https://reviews.llvm.org/D40660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

2017-12-05 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:1095 + if (Diags) { +Diags->Report(diag::err_drv_invalid_value) << "-verify=" << Prefix; +Diags->Report(diag::note_drv_verify_prefix_unique); jdenny wrote: > hfink

r319817 - Give this test a triple to avoid failures on MS bots.

2017-12-05 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Dec 5 11:39:37 2017 New Revision: 319817 URL: http://llvm.org/viewvc/llvm-project?rev=319817&view=rev Log: Give this test a triple to avoid failures on MS bots. Modified: cfe/trunk/test/Modules/var-templates.cpp Modified: cfe/trunk/test/Modules/var-templates.cpp URL

Re: r319727 - Generalize "static data member instantiated" notification to cover variable templates too.

2017-12-05 Thread Richard Smith via cfe-commits
Sorry about that, fixed in r319817. On 5 December 2017 at 10:38, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke tests on one of our bots: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64- > expensive-checks-win/builds/6568 > > F

[PATCH] D39284: Allow conditions to be decomposed with structured bindings

2017-12-05 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: test/Misc/warning-flags.c:19 The list of warnings below should NEVER grow. It should gradually shrink to 0. lichray wrote: > rsmith wrote: > > Please read and respect this rule :) > Do you know of some categories wh

[clang-tools-extra] r319820 - [clangd] Clean up code complete unit tests. NFC

2017-12-05 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Dec 5 12:11:29 2017 New Revision: 319820 URL: http://llvm.org/viewvc/llvm-project?rev=319820&view=rev Log: [clangd] Clean up code complete unit tests. NFC Modified: clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp Modified: clang-tools-extra/trunk/u

[libunwind] r319823 - [libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit

2017-12-05 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Dec 5 12:22:10 2017 New Revision: 319823 URL: http://llvm.org/viewvc/llvm-project?rev=319823&view=rev Log: [libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit These are expected to be set by the shared lit scripts used from libc++. Differential Revisio

[PATCH] D40817: [libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit

2017-12-05 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319823: [libunwind] Pass LIBUNWIND_SYSROOT and LIBUNWIND_GCC_TOOLCHAIN to lit (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40817?vs=125455&id=125590#toc Repository: rL LLV

[PATCH] D40850: suppress undefined-template warnings when the pattern is declared in a system header

2017-12-05 Thread Nick Lewycky via Phabricator via cfe-commits
nlewycky created this revision. The way to fix an undefined-template warning is to add lines to the header file that defines the template pattern. We should suppress the warnings when the template pattern is in a system header because we don't expect users to edit those. https://reviews.llvm.

[PATCH] D39694: [VerifyDiagnosticConsumer] support -verify=

2017-12-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Comment at: lib/Frontend/CompilerInvocation.cpp:1095 + if (Diags) { +Diags->Report(diag::err_drv_invalid_value) << "-verify=" << Prefix; +Diags->Report(diag::note_drv_verify_prefix_unique); hfinkel wrote: > jdenny w

[libunwind] r319830 - [libunwind][CMake] Set TARGET_TRIPLE if LIBUNWND_TARGET_TRIPLE is set

2017-12-05 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Dec 5 12:48:05 2017 New Revision: 319830 URL: http://llvm.org/viewvc/llvm-project?rev=319830&view=rev Log: [libunwind][CMake] Set TARGET_TRIPLE if LIBUNWND_TARGET_TRIPLE is set This follows the setup used by other runtimes and is expected by the lit configuration. Diffe

Re: r319715 - Fix record-parsing-invocation.c test on Windows

2017-12-05 Thread Alex L via cfe-commits
Thanks, I will take a look at it right now. I believe your solution is the right fix. On 5 December 2017 at 07:09, Sean Eveson wrote: > Hi, > > It looks like the test is still failing on one of the Windows build bots: > http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015 > > From lookin

  1   2   >