r319642 - Fix bug where we wouldn't break columns over the limit.

2017-12-04 Thread Manuel Klimek via cfe-commits
Author: klimek Date: Mon Dec 4 00:53:16 2017 New Revision: 319642 URL: http://llvm.org/viewvc/llvm-project?rev=319642&view=rev Log: Fix bug where we wouldn't break columns over the limit. Before, we would not break: int a = foo(/* trailing */); when the end of /* trailing */ was exactly the co

[PATCH] D40733: [clangd] GlobalCompilationDatabase interface changes

2017-12-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clangd/ClangdUnitStore.cpp:67 // FIXME: Don't overwrite it if it's already there. - Commands.front().CommandLine.push_back("-resource-dir=" + -

[PATCH] D40733: [clangd] GlobalCompilationDatabase interface changes

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319647: [clangd] GlobalCompilationDatabase interface changes (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D40733?vs=125151&id=125303#toc Repository: rL LLVM https://rev

[clang-tools-extra] r319647 - [clangd] GlobalCompilationDatabase interface changes

2017-12-04 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Dec 4 02:08:45 2017 New Revision: 319647 URL: http://llvm.org/viewvc/llvm-project?rev=319647&view=rev Log: [clangd] GlobalCompilationDatabase interface changes Summary: - GlobalCompilationDatabase now returns a single command (that's all we use) - fallback flags are n

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-04 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: docs/clang-tidy/index.rst:253 +Generally, there is no need to suppress :program:`clang-tidy` diagnostics. If +there are false positives, either a bug should be reported or the code should be aaron.ballman wrote: > I do

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-04 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:294 -static bool LineIsMarkedWithNOLINT(SourceManager &SM, SourceLocation Loc) { +static bool IsNOLINTFound(StringRef NolintMacro, StringRef Line, + unsigned DiagID, co

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

2017-12-04 Thread Ivan Kosarev via Phabricator via cfe-commits
kosarev added a comment. Responded here: https://bugs.llvm.org/show_bug.cgi?id=26603 Repository: rL LLVM https://reviews.llvm.org/D39455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

2017-12-04 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. It does still regress! In a sense this is a WIP that i did not clarify.(which i do now) While debugging the issue it seemed that parsing the AST did result in the stack overflow and not my check specific code. Looping over all case Labels seems to be done in a recursi

[PATCH] D40731: Integrate CHash into CLang

2017-12-04 Thread Christian Dietrich via Phabricator via cfe-commits
stettberger updated this revision to Diff 125309. stettberger marked 9 inline comments as done. stettberger added a comment. @Eugene.Zelenko Thank you for pointing me out on these issues. I ran clang-tidy and clang-format on CHashVisitor.h @rsmith You're right, there is already more than one imp

[PATCH] D40780: [clangd] Incorporate fuzzy-match into result rankings.

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: cfe-commits, klimek. The scoring function is fuzzy-match-quality * existing quality score. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40780 Files: clangd/ClangdUnit.cpp clangd/FuzzyMatch.h clangd/Protocol.h

[PATCH] D40781: [DataCollection] Allow choosing between collection categories

2017-12-04 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes created this revision. Herald added 1 blocking reviewer(s): teemperor. Herald added a subscriber: ilya-biryukov. This adds a list of collection categories to ClangDataCollectorsEmitter.cpp, in an aim to eventually unify the various AST hashing mechanisms (each one will get its own categor

[PATCH] D40719: [clangd] Split CodeComplete into a separate file. NFC

2017-12-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clangd/CodeComplete.h:10 +// +// Code completion provides suggestions for what the user might type next. +// After "std::string S; S." we might suggest memb

[clang-tools-extra] r319655 - [clangd] Split CodeComplete into a separate file. NFC

2017-12-04 Thread Sam McCall via cfe-commits
Author: sammccall Date: Mon Dec 4 05:49:59 2017 New Revision: 319655 URL: http://llvm.org/viewvc/llvm-project?rev=319655&view=rev Log: [clangd] Split CodeComplete into a separate file. NFC Summary: Shared details of ClangdUnit and CodeComplete moved to a new Compiler file. Reviewers: ilya-biry

[PATCH] D40719: [clangd] Split CodeComplete into a separate file. NFC

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rL319655: [clangd] Split CodeComplete into a separate file. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D40719?vs=125123&id=1

[PATCH] D40719: [clangd] Split CodeComplete into a separate file. NFC

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rCTE319655: [clangd] Split CodeComplete into a separate file. NFC (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D40719?vs=125123&id

[PATCH] D40731: Integrate CHash into CLang

2017-12-04 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes added a comment. In https://reviews.llvm.org/D40731#943469, @stettberger wrote: > @Eugene.Zelenko Thank you for pointing me out on these issues. I ran > clang-tidy and clang-format on CHashVisitor.h > > @rsmith You're right, there is already more than one implemenation of > {partial,un

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

2017-12-04 Thread Jan Korous via Phabricator via cfe-commits
jkorous-apple added a comment. LGTM otherwise. Comment at: tools/libclang/CIndexer.h:45 + std::string ToolchainPath; + llvm::sys::SmartMutex Mutex; + I am just wondering - since we anticipate multi-threaded usage, shouldn't we synchronize access to all membe

[PATCH] D40731: Integrate CHash into CLang

2017-12-04 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes added a comment. So you can define a category for cHash and add `let cHash = [{ .. }]` or `let cHash = TypeIIClone;` if you just want to reuse it. With this patch you can also use !codeconcat to append some code: https://reviews.llvm.org/D40782 Repository: rC Clang https://reviews.

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-12-04 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. In https://reviews.llvm.org/D35109#937763, @NoQ wrote: > For the type extension approach, somebody simply needs to do the math and > prove that it works soundly in all cases. Devin has been heroically coming up > with counter-examples so far, but even if he d

[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

2017-12-04 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: lib/AST/ASTImporter.cpp:5877 + DeclarationName Name = Importer.Import(E->getName()); + if (E->getName().isEmpty() && Name.isEmpty()) +return nullptr; Is this condition correct? https://reviews.llvm.org/D38694

[PATCH] D40731: Integrate CHash into CLang

2017-12-04 Thread Christian Dietrich via Phabricator via cfe-commits
stettberger added a comment. For my changes to StmtDataCollectors: I tried to leave the already existing entries in StmtDataCollector.td untouched and the test-cases still work OK. If there is something somebody could break by changing these files it would be good to have a test case for it. H

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-04 Thread Anton via Phabricator via cfe-commits
xgsa marked 2 inline comments as done. xgsa added inline comments. Comment at: docs/clang-tidy/index.rst:253 +Generally, there is no need to suppress :program:`clang-tidy` diagnostics. If +there are false positives, either a bug should be reported or the code should be ---

[PATCH] D39005: [OpenMP] Clean up variable and function names for NVPTX backend

2017-12-04 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld removed a reviewer: Hahnfeld. Hahnfeld added a comment. Fixed differently in https://reviews.llvm.org/rL319657. Repository: rL LLVM https://reviews.llvm.org/D39005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-04 Thread Anton via Phabricator via cfe-commits
xgsa updated this revision to Diff 125328. https://reviews.llvm.org/D40671 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp docs/ReleaseNotes.rst docs/clang-tidy/index.rst test/clang-tidy/nolint.cpp test/clang-tidy/nolintnextline.cpp Index: docs/clang-tidy/index.rst ==

[PATCH] D40784: [clangd] Split code-completion tests out of ClangdTests. NFC.

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek. Common parts are mostly FS related, so pulled out TestFS.h for the common stuff. Deliberately resisted cleaning up much here, so this is pretty mechanical. Repository: rCTE Clang Tools Extra

[PATCH] D40731: Integrate CHash into CLang

2017-12-04 Thread Johannes Altmanninger via Phabricator via cfe-commits
johannes added a comment. In https://reviews.llvm.org/D40731#943564, @stettberger wrote: > For my changes to StmtDataCollectors: I tried to leave the already existing > entries in StmtDataCollector.td untouched and the test-cases still work OK. > If there is something somebody could break by ch

[PATCH] D40784: [clangd] Split code-completion tests out of ClangdTests. NFC.

2017-12-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: unittests/clangd/CMakeLists.txt:16 JSONExprTests.cpp + TestFS.cpp TraceTests.cpp nit: maybe name it FSTests.cpp? to be consistent wi

[PATCH] D20124: [PCH] Serialize skipped preprocessor ranges

2017-12-04 Thread Cameron via Phabricator via cfe-commits
cameron314 updated this revision to Diff 125333. cameron314 added a comment. Here's the final patch that fixes `clang_getSkippedRegions` with regions in the preamble (as well as serializing the skipped regions in the PCH file). https://reviews.llvm.org/D20124 Files: include/clang/Lex/Preproc

r319658 - [OpenCL] Define __IMAGE_SUPPORT__ macro for SPIR

2017-12-04 Thread Sven van Haastregt via cfe-commits
Author: svenvh Date: Mon Dec 4 07:01:08 2017 New Revision: 319658 URL: http://llvm.org/viewvc/llvm-project?rev=319658&view=rev Log: [OpenCL] Define __IMAGE_SUPPORT__ macro for SPIR Add #define __IMAGE_SUPPORT__ 1 for SPIR targets to indicate that SPIR supports images. Patch by Dmitry Borisenkov

r319661 - [OPENMP] Codegen for `distribute simd` directive.

2017-12-04 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 4 07:38:33 2017 New Revision: 319661 URL: http://llvm.org/viewvc/llvm-project?rev=319661&view=rev Log: [OPENMP] Codegen for `distribute simd` directive. Initial codegen support for `distribute simd` directive. Added: cfe/trunk/test/OpenMP/distribute_simd_codege

Re: Clang-format: add finer-grained options for putting all arguments on one line.

2017-12-04 Thread Russell McClellan via cfe-commits
Another bump on this On Tue, Nov 28, 2017 at 10:43 AM, Russell McClellan wrote: > Another bump on this - again, this is my first time trying to submit a > patch, so please let me know if there's a better way to go about this. > > On Mon, Nov 20, 2017 at 10:22 AM, Russell McClellan > wrote: >> Hi

[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

2017-12-04 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin added inline comments. Comment at: lib/AST/ASTImporter.cpp:5877 + DeclarationName Name = Importer.Import(E->getName()); + if (E->getName().isEmpty() && Name.isEmpty()) +return nullptr; xazax.hun wrote: > Is this condition correct? Looks like it sh

[PATCH] D39739: [HCC] Add flag to Import Weak Functions in Function Importer

2017-12-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added inline comments. Comment at: lib/Transforms/IPO/FunctionImport.cpp:107 +static cl::opt +ForceImportWeak("force-import-weak", cl::Hidden, +cl::desc("Allow weak functions to be imported"), Is it possible not to expose this option throug

[PATCH] D40787: Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2017-12-04 Thread Daniel Kolozsvari via Phabricator via cfe-commits
koldaniel created this revision. koldaniel added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. Uses of std::uncaught_exception should be replaced with std::uncaught_exceptions, since the former is deprecated in C++17: http://en.cppreference.com/w/cpp/error/uncaught

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-04 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 125346. Nebiroth added a comment. Minor code cleanup Refactored findDocumentHighlights() to make tests pass when assertions are enabled Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38425 Files: clangd/ClangdLSPServer.cpp clangd/Clan

[PATCH] D40775: [libcxx] Add underscores to win32 locale headers.

2017-12-04 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs added inline comments. Comment at: src/support/win32/locale_win32.cpp:90 +__libcpp_locale_guard __current(__loc); va_list ap; +va_start( ap, __format ); __ap Comment at: src/support/win32/locale_win32.cpp:99 { va_lis

[PATCH] D39739: [HCC] Add flag to Import Weak Functions in Function Importer

2017-12-04 Thread Alex Voicu via Phabricator via cfe-commits
AlexVlx added inline comments. Comment at: lib/Transforms/IPO/FunctionImport.cpp:107 +static cl::opt +ForceImportWeak("force-import-weak", cl::Hidden, +cl::desc("Allow weak functions to be imported"), yaxunl wrote: > Is it possible not to expose t

[PATCH] D40787: Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2017-12-04 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: test/clang-tidy/modernize-replace-uncaught-exception.cpp:41 + + res = uncaught_exception(); + // CHECK-MESSAGES: [[@LINE-1]]:9: warning: 'std::uncaught_exception' is deprecated, use 'std::uncaught_exceptions' instead ---

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2017-12-04 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tidy/modernize/ReplaceUncaughtExceptionCheck.cpp:20 + +static const char *MatchText = "::std::uncaught_exception"; + Could that be a local variable in `registerMatchers`? Even though its static and const it migh

[PATCH] D40112: [CodeGen][X86] Fix handling of __fp16 vectors

2017-12-04 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. Any other comments from anyone? https://reviews.llvm.org/D40112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40567: Always show template parameters in IR type names

2017-12-04 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff added a comment. Consider a bit more complicated example. File `common.h` #ifndef COMMON_H #define COMMON_H struct Alarm { }; struct Info { }; template struct Handler; #endif File `use-1.cpp` #include "common.h" Handler *info; void set(Handler *e) { info = e; } Fil

[PATCH] D40775: [libcxx] Add underscores to win32 locale headers.

2017-12-04 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin updated this revision to Diff 125354. https://reviews.llvm.org/D40775 Files: include/support/win32/locale_win32.h src/support/win32/locale_win32.cpp Index: src/support/win32/locale_win32.cpp === --- src/support/win32/lo

[PATCH] D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll

2017-12-04 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin updated this revision to Diff 125356. halyavin added a comment. Updated diff to include whole context. https://reviews.llvm.org/D40071 Files: include/exception src/support/runtime/exception_pointer_msvc.ipp Index: src/support/runtime/exception_pointer_msvc.ipp

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2017-12-04 Thread Daniel Kolozsvari via Phabricator via cfe-commits
koldaniel added inline comments. Comment at: clang-tidy/modernize/ReplaceUncaughtExceptionCheck.cpp:32 + Finder->addMatcher( + declRefExpr(to(functionDecl(hasName(MatchText.bind("call_expr"), + this); JonasToth wrote: > Interesting. Did you conside

[libcxx] r319666 - [libcxx] Set up .arcconfig to point to new Diffusion CXX repository

2017-12-04 Thread Ben Hamilton via cfe-commits
Author: benhamilton Date: Mon Dec 4 09:55:28 2017 New Revision: 319666 URL: http://llvm.org/viewvc/llvm-project?rev=319666&view=rev Log: [libcxx] Set up .arcconfig to point to new Diffusion CXX repository Summary: We want to automatically copy the appropriate mailing list for review requests to

[PATCH] D40500: [libcxx] Set up .arcconfig to point to new Diffusion CXX repository

2017-12-04 Thread Ben Hamilton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319666: [libcxx] Set up .arcconfig to point to new Diffusion CXX repository (authored by benhamilton). Repository: rL LLVM https://reviews.llvm.org/D40500 Files: libcxx/trunk/.arcconfig Index: lib

[PATCH] D40671: [clang-tidy] Support specific checks for NOLINT directive

2017-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: docs/clang-tidy/index.rst:280 +lint-command +lint-command lint-args + xgsa wrote: > aaron.ballman wrote: > > This should have a subscript `opt` following `lint-args` to denote that the > > args are optiona

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-04 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. Can you also reformat the code too with clang-format? I think there's a few things in ClangdUnit.h/.cpp Comment at: clangd/ClangdServer.cpp:521 + std::shared_ptr Resources = Units.getFile(File); + assert(Resources && "Calling findDocumentHighlights

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2017-12-04 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. I think will be good idea to rename check to //modernize-use-uncaught-exceptions// to be consistent with other similar checks. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Repository: rCTE Clang Tools Extra https://reviews.llvm

[PATCH] D40793: [analyzer] Improve SymbolicRegion::dump() for heap pointers.

2017-12-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. Herald added subscribers: cfe-commits, rnkovacs. Because for every symbol `$x` we can construct exactly two different `MemRegion`s that both get dumped as `SymRegion{$x}`, and i didn't bother fixing it for years, i wanted to at least make the problem apparent. With thi

[PATCH] D39279: Stringizing raw string literals containing newline

2017-12-04 Thread Taewook Oh via Phabricator via cfe-commits
twoh updated this revision to Diff 125368. twoh added a comment. Thanks @jkorous-apple for the comment. I think your suggestion is a more precise description for the implementation, and adjusted the comments accordingly. I intentionally didn't add the details to the comments for the header, as LL

r319672 - Changing mixed CRLFs back to LFs; NFC.

2017-12-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Dec 4 10:36:34 2017 New Revision: 319672 URL: http://llvm.org/viewvc/llvm-project?rev=319672&view=rev Log: Changing mixed CRLFs back to LFs; NFC. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchersInternal.h Modified: cfe/trunk/include/clang/ASTMatchers/

[PATCH] D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host

2017-12-04 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D40795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[libcxx] r319675 - Fix PR#35948: generate_n does not accept floating point Size arguments.

2017-12-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Dec 4 10:59:14 2017 New Revision: 319675 URL: http://llvm.org/viewvc/llvm-project?rev=319675&view=rev Log: Fix PR#35948: generate_n does not accept floating point Size arguments. Modified: libcxx/trunk/include/type_traits libcxx/trunk/test/std/algorithms/alg.m

[PATCH] D39709: [analyzer] [NFC] remove duplicated function

2017-12-04 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. @dcoughlin @NoQ OK to commit? https://reviews.llvm.org/D39709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39709: [analyzer] [NFC] remove duplicated function

2017-12-04 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yep, looks good. https://reviews.llvm.org/D39709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D40775: [libcxx] Add underscores to win32 locale headers.

2017-12-04 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs added a comment. looks fine to me, but this is the sort of thing that @EricWF usually wants the final say on. https://reviews.llvm.org/D40775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2017-12-04 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: clang-tidy/modernize/ReplaceUncaughtExceptionCheck.cpp:32 + Finder->addMatcher( + declRefExpr(to(functionDecl(hasName(MatchText.bind("call_expr"), + this); koldaniel wrote: > JonasToth wrote: > > Interes

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

2017-12-04 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 125378. mibintc added a subscriber: eli.friedman. mibintc added a comment. I responded to comments from @eli.friedman and @hubert.reinterpretcast : I added FIXME comment regarding the "Q" suffix on the float 128 literals (gcc uses https://reviews.llvm.org/F

[PATCH] D40112: [CodeGen][X86] Fix handling of __fp16 vectors

2017-12-04 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM with the minor comment below. Comment at: include/clang/Basic/TargetInfo.h:563 + /// Check whether llvm intrinsics such as llvm.convert.to.fp16 should be used + /// to c

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

2017-12-04 Thread Melanie Blower via Phabricator via cfe-commits
mibintc marked 3 inline comments as done. mibintc added a comment. added inline replies to Eli and Hubert Comment at: lib/Frontend/InitPreprocessor.cpp:817 DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L"); + DefineFloatMacros(Builder, "FLT128", &TI.getFloa

[PATCH] D40501: [libcxxabi] Set up .arcconfig to point to new Diffusion CXXA repository

2017-12-04 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rCXXA libc++abi https://reviews.llvm.org/D40501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-04 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Are you actually using libc++ with cl? :) https://reviews.llvm.org/D40774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D40568: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

2017-12-04 Thread Kostya Serebryany via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319684: design document for a hardware-assisted memory safety (HWAMS) tool, similar to… (authored by kcc). Changed prior to commit: https://reviews.llvm.org/D40568?vs=125045&id=125398#toc Repository:

r319684 - design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

2017-12-04 Thread Kostya Serebryany via cfe-commits
Author: kcc Date: Mon Dec 4 12:01:38 2017 New Revision: 319684 URL: http://llvm.org/viewvc/llvm-project?rev=319684&view=rev Log: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer Summary: preliminary design document for a hardware-assisted memory sa

[libcxx] r319687 - Implement P0457R2: 'String Prefix and Suffix Checking' for c++2a

2017-12-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Dec 4 12:11:38 2017 New Revision: 319687 URL: http://llvm.org/viewvc/llvm-project?rev=319687&view=rev Log: Implement P0457R2: 'String Prefix and Suffix Checking' for c++2a Added: libcxx/trunk/test/std/strings/basic.string/string.ends_with/ libcxx/trunk/test/st

[PATCH] D40586: Implement p0457r2 - String Prefix and Suffix Checking

2017-12-04 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 319687 https://reviews.llvm.org/D40586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40787: [clang-tidy] Replace the usage of std::uncaught_exception with std::uncaught_exceptions

2017-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang-tidy/modernize/ReplaceUncaughtExceptionCheck.cpp:59 + if (!BeginLoc.isMacroID()) { +Diag << FixItHint::CreateInsertion(BeginLoc.getLocWithOffset(TextLength), + "s");

r319688 - Now that C++17 is official (https://www.iso.org/standard/68564.html), start changing the C++1z terminology over to C++17. NFC intended, these are all mechanical changes.

2017-12-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Dec 4 12:27:34 2017 New Revision: 319688 URL: http://llvm.org/viewvc/llvm-project?rev=319688&view=rev Log: Now that C++17 is official (https://www.iso.org/standard/68564.html), start changing the C++1z terminology over to C++17. NFC intended, these are all mechani

[clang-tools-extra] r319690 - Fix build after r319688: s/CPlusPlus1z/CPlusPlus17/

2017-12-04 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Dec 4 12:38:21 2017 New Revision: 319690 URL: http://llvm.org/viewvc/llvm-project?rev=319690&view=rev Log: Fix build after r319688: s/CPlusPlus1z/CPlusPlus17/ Modified: clang-tools-extra/trunk/clang-tidy/modernize/UnaryStaticAssertCheck.cpp Modified: clang-tools-extr

[libcxx] r319693 - Ooops. I checked in a test for a bug I haven't fixed yet. Temporrarily commented it out.

2017-12-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Dec 4 12:46:38 2017 New Revision: 319693 URL: http://llvm.org/viewvc/llvm-project?rev=319693&view=rev Log: Ooops. I checked in a test for a bug I haven't fixed yet. Temporrarily commented it out. Modified: libcxx/trunk/test/std/strings/basic.string/string.modifie

[PATCH] D40795: [OpenMP] Initial implementation of code generation for pragma 'teams distribute parallel for simd' on host

2017-12-04 Thread Carlo Bertolli via Phabricator via cfe-commits
carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 319696. Repository: rC Clang https://reviews.llvm.org/D40795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

2017-12-04 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman added inline comments. Comment at: tools/libclang/CIndexer.h:45 + std::string ToolchainPath; + llvm::sys::SmartMutex Mutex; + jkorous-apple wrote: > I am just wondering - since we anticipate multi-threaded usage, shouldn't we > synchronize access to a

r319697 - [analyzer] [NFC] remove duplicated function

2017-12-04 Thread George Karpenkov via cfe-commits
Author: george.karpenkov Date: Mon Dec 4 13:00:05 2017 New Revision: 319697 URL: http://llvm.org/viewvc/llvm-project?rev=319697&view=rev Log: [analyzer] [NFC] remove duplicated function Two copies of getSymLERange in RangeConstraintManager are virtually identical, which is clearly bad. This patc

[PATCH] D39709: [analyzer] [NFC] remove duplicated function

2017-12-04 Thread George Karpenkov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319697: [analyzer] [NFC] remove duplicated function (authored by george.karpenkov). Repository: rC Clang https://reviews.llvm.org/D39709 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp I

[PATCH] D40225: Add -std=c17 as a flag

2017-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 125407. aaron.ballman added a comment. Rebased on ToT and given more context. https://reviews.llvm.org/D40225 Files: include/clang/Basic/LangOptions.def include/clang/Frontend/LangStandard.h include/clang/Frontend/LangStandards.def lib/Fronten

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

2017-12-04 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. Looks good to me. Repository: rL LLVM https://reviews.llvm.org/D40673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D40566: Check if MemberExpr arguments are type-dependent.

2017-12-04 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. The part which seems to be throwing you off is "or the class member access expression refers to a member of an unknown specialization". A "member of an unknown specialization" is defined in [temp.dep.type] in the standard. https://reviews.llvm.org/D40566 _

[PATCH] D40548: [clangd] Prototyping index support and naive index-based global code completion. WIP

2017-12-04 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. Sorry for the delay, I'm looking into this now. I actually don't query (or even store!) any symbol names in the index interface now, only Occurrences queried by USR which is enough for findReferences and findDefinitions. It looks like storing names is the main part in

r319700 - [OPENMP] Fix PR35486: crash when collapsing loops with dependent iteration spaces.

2017-12-04 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Mon Dec 4 13:30:42 2017 New Revision: 319700 URL: http://llvm.org/viewvc/llvm-project?rev=319700&view=rev Log: [OPENMP] Fix PR35486: crash when collapsing loops with dependent iteration spaces. Though it is incorrect from point of view of OpenMP standard to have dependent

[PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

2017-12-04 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D40746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D40625: Harmonizing attribute GNU/C++ spellings

2017-12-04 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:602 def AnalyzerNoReturn : InheritableAttr { - let Spellings = [GNU<"analyzer_noreturn">]; + let Spellings = [Clang<"analyzer_noreturn">]; let Documentation = [Undocumented]; dcoug

[PATCH] D39903: [libclang] Allow pretty printing declarations

2017-12-04 Thread Cameron via Phabricator via cfe-commits
cameron314 added a comment. Locally we've done something similar (adding a `clang_getCursorPrettyPrintedDeclaration` function, though without exposing the `PrintingPolicy`) and overhauled `DeclPrinter` to produce proper pretty names. This is a hack that works well for us, but can never be upstr

r319702 - [libclang] Record parsing invocation to a temporary file when requested

2017-12-04 Thread Alex Lorenz via cfe-commits
Author: arphaman Date: Mon Dec 4 13:56:36 2017 New Revision: 319702 URL: http://llvm.org/viewvc/llvm-project?rev=319702&view=rev Log: [libclang] Record parsing invocation to a temporary file when requested by client This patch extends libclang by allowing it to record parsing operations to a tem

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

2017-12-04 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319702: [libclang] Record parsing invocation to a temporary file when requested (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D40527?vs=124788&id=125412#toc Repository: rC

[PATCH] D40527: [libclang] Record parsing invocation to a temporary file when requested by client

2017-12-04 Thread Alex Lorenz via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319702: [libclang] Record parsing invocation to a temporary file when requested (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D40527?vs=124788&id=125413#toc Repository: rL

r319703 - Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

2017-12-04 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Dec 4 13:58:43 2017 New Revision: 319703 URL: http://llvm.org/viewvc/llvm-project?rev=319703&view=rev Log: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26 Fedora27 is using a new version of glibc that refers to the _Float128 type. T

[PATCH] D40673: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2-26

2017-12-04 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319703: Add _Float128 as alias to __float128 to enable compilations on Fedora27/glibc2… (authored by erichkeane). Repository: rC Clang https://reviews.llvm.org/D40673 Files: include/clang/Basic/Toke

r319707 - Correctly handle line table entries without filenames during AST serialization

2017-12-04 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Dec 4 14:28:45 2017 New Revision: 319707 URL: http://llvm.org/viewvc/llvm-project?rev=319707&view=rev Log: Correctly handle line table entries without filenames during AST serialization The current code would hit an assert in ASTWriter when trying to write out the filename

[PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

2017-12-04 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319707: Correctly handle line table entries without filenames during AST serialization (authored by hans). Repository: rC Clang https://reviews.llvm.org/D40746 Files: lib/Serialization/ASTReader.cpp

[PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

2017-12-04 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319707: Correctly handle line table entries without filenames during AST serialization (authored by hans). Changed prior to commit: https://reviews.llvm.org/D40746?vs=125227&id=125419#toc Repository:

[PATCH] D40806: CodeGen: Fix invalid bitcasts for memcpy

2017-12-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. Herald added a subscriber: nhaehnle. CreateCoercedLoad/CreateCoercedStore assumes pointer argument of memcpy is in addr space 0, which is not correct and causes invalid bitcasts for triple amdgcn---amdgiz. It is fixed by using alloca addr space instead. https://rev

[PATCH] D40071: [libcxx] Implement exception_ptr on Windows without msvcprt.dll

2017-12-04 Thread David Majnemer via Phabricator via cfe-commits
majnemer added inline comments. Comment at: src/support/runtime/exception_pointer_msvc.ipp:119-123 +#ifdef _M_AMD64 +RtlPcToFileHeader( +reinterpret_cast(const_cast(throw_info)), +&image_base); +#endif Can't you use the image_base field in thr

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

2017-12-04 Thread KCG via Phabricator via cfe-commits
kc.austin2017 added a comment. Hi , I am looking for some helps on the issue i have in my project after this change for the compiler. typedef void (*callback_t)(uint32_t icciar, void * context); callback_t callee1; void _ _attribute__((interrupt("IRQ"))) __cs3_isr_irq() { callee1(icciar , co

[libcxx] r319710 - Implement more of P0600: '[[nodiscard]] in the library' for C++2a

2017-12-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Dec 4 15:03:42 2017 New Revision: 319710 URL: http://llvm.org/viewvc/llvm-project?rev=319710&view=rev Log: Implement more of P0600: '[[nodiscard]] in the library' for C++2a Modified: libcxx/trunk/include/new libcxx/trunk/www/cxx2a_status.html Modified: libcxx/

[libcxx] r319711 - Commit tests for changes in revision 319710

2017-12-04 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Dec 4 15:04:53 2017 New Revision: 319711 URL: http://llvm.org/viewvc/llvm-project?rev=319711&view=rev Log: Commit tests for changes in revision 319710 Added: libcxx/trunk/test/std/language.support/support.dynamic/new.delete/new.delete.array/new_size.fail.cpp

[PATCH] D40809: [WIP] [analyzer] Dump counterexample traces as C programs

2017-12-04 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov created this revision. Herald added subscribers: a.sidorin, szepet, xazax.hun. This patch is work in progress, but has already shown itself to be useful in a few cases. For large traces understanding the analyzer output can be painful, especially when arrows indicating the flow

[PATCH] D40809: [WIP] [analyzer] Dump counterexample traces as C programs

2017-12-04 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov updated this revision to Diff 125429. george.karpenkov edited the summary of this revision. https://reviews.llvm.org/D40809 Files: include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h lib/StaticAnalyzer/Checkers/UndefinedAssignmentChecker.cpp lib/StaticAnalyz

[libcxxabi] r319713 - [libcxxabi] Set up .arcconfig to point to new Diffusion CXXA repository

2017-12-04 Thread Ben Hamilton via cfe-commits
Author: benhamilton Date: Mon Dec 4 15:14:03 2017 New Revision: 319713 URL: http://llvm.org/viewvc/llvm-project?rev=319713&view=rev Log: [libcxxabi] Set up .arcconfig to point to new Diffusion CXXA repository Summary: We want to automatically copy the appropriate mailing list for review requests

[PATCH] D40501: [libcxxabi] Set up .arcconfig to point to new Diffusion CXXA repository

2017-12-04 Thread Ben Hamilton via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319713: [libcxxabi] Set up .arcconfig to point to new Diffusion CXXA repository (authored by benhamilton). Repository: rL LLVM https://reviews.llvm.org/D40501 Files: libcxxabi/trunk/.arcconfig Ind

  1   2   >