[PATCH] D39768: [coroutines] Promote cleanup.dest.slot allocas to registers to avoid storing it in the coroutine frame

2017-11-07 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov created this revision. Herald added a subscriber: EricWF. We don't want to store cleanup dest slot saved into the coroutine frame (as some of the cleanup code may access them after coroutine frame destroyed). This is an alternative to https://reviews.llvm.org/D37093 It is possible t

[clang-tools-extra] r317642 - Fix compile issue on MSVC.

2017-11-07 Thread Douglas Yung via cfe-commits
Author: dyung Date: Tue Nov 7 16:29:42 2017 New Revision: 317642 URL: http://llvm.org/viewvc/llvm-project?rev=317642&view=rev Log: Fix compile issue on MSVC. Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests.cpp Modified: clang-tools-extra/trunk/unittests/clangd/JSONExprTests

r317644 - [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

2017-11-07 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Tue Nov 7 16:39:18 2017 New Revision: 317644 URL: http://llvm.org/viewvc/llvm-project?rev=317644&view=rev Log: [AST] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/AST/CanonicalType.h

r317648 - [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

2017-11-07 Thread Eugene Zelenko via cfe-commits
Author: eugenezelenko Date: Tue Nov 7 17:03:16 2017 New Revision: 317648 URL: http://llvm.org/viewvc/llvm-project?rev=317648&view=rev Log: [Serialization] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Serializatio

[PATCH] D39762: [ObjC] Boxed strings should use the nullability from stringWithUTF8String's return type

2017-11-07 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D39762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D39776: [libcxx] Mark test cxa_deleted_virtual.pass.cpp as failing for previous libcxx versions.

2017-11-07 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai created this revision. r313500 added a fix for undefined "___cxa_deleted_virtual" symbol. Previous libcxx versions don't have the fix and corresponding test should be failing. rdar://problem/34521053 https://reviews.llvm.org/D39776 Files: libcxx/test/libcxx/language.support/cxa_delet

[PATCH] D39050: Add index-while-building support to Clang

2017-11-07 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added inline comments. Comment at: lib/Index/IndexUnitWriter.cpp:212 + return true; +}; + extra semi-colon (noticed this warning while compiling) https://reviews.llvm.org/D39050 ___ cfe-commits mailing l

r317664 - [X86] Add masked vcvtps2ph builtins to CheckX86BuiltinFunctionCall.

2017-11-07 Thread Craig Topper via cfe-commits
Author: ctopper Date: Tue Nov 7 20:54:26 2017 New Revision: 317664 URL: http://llvm.org/viewvc/llvm-project?rev=317664&view=rev Log: [X86] Add masked vcvtps2ph builtins to CheckX86BuiltinFunctionCall. This ensures that only immediates that fit in 8-bits are used. This matches what we do for the

[PATCH] D39050: Add index-while-building support to Clang

2017-11-07 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added inline comments. Comment at: lib/Index/IndexingAction.cpp:562 + + SourceManager &SM = CI.getSourceManager(); + DiagnosticsEngine &Diag = CI.getDiagnostics(); As a first attempt, I tried to use index::createIndexDataRecordingAction in combinatio

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

2017-11-07 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: test/CodeGen/avx512f-builtins.c:6231 + // CHECK: bitcast <16 x i1> %{{.*}} to i16 + // CHECK: and i32 %{{.*}}, 255 + // CHECK: shl i32 %{{.*}}, 8 Does this really produce kunpackb in the backend? The type promoti

[PATCH] D39332: [clang-refactor] Introduce a new rename rule for qualified symbols

2017-11-07 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:116 + /*Description=*/ + R"(Finds and renames qualified symbols in code with no indexer support. +It is used to move/rename a symbol to a new

[clang-tools-extra] r317670 - [clangd] Sort completion results.

2017-11-07 Thread Sam McCall via cfe-commits
Author: sammccall Date: Tue Nov 7 23:44:12 2017 New Revision: 317670 URL: http://llvm.org/viewvc/llvm-project?rev=317670&view=rev Log: [clangd] Sort completion results. Summary: This is (probably) not required by LSP, but at least one buggy client wants it. It also simplifies some tests - change

[PATCH] D39738: [clangd] Sort completion results.

2017-11-07 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL317670: [clangd] Sort completion results. (authored by sammccall). Repository: rL LLVM https://reviews.llvm.org/D39738 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp clang-tools-extra/trunk/

<    1   2