[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks. @K-ballo I always forget. Do you have commit access? https://reviews.llvm.org/D38831 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell updated this revision to Diff 121832. martell added a comment. Add command line documentation references Repository: rL LLVM https://reviews.llvm.org/D39673 Files: docs/ClangCommandLineReference.rst include/clang/Basic/LangOptions.def include/clang/Driver/Options.td include/c

[PATCH] D39050: Add index-while-building support to Clang

nathawes added inline comments. Comment at: lib/Index/IndexRecordHasher.cpp:103 + COMBINE_HASH(Hasher.hash(param->getType())); +} +return Hash; arphaman wrote: > Should you hash the return type as well? The return type doesn't affect the function's U

[PATCH] D39711: [analyzer] ObjCGenerics: Don't warn on cast conversions involving explicit cast

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:587 if (TrackedType && + !isa(CE) && !ASTCtxt.canAssignObjCInterfaces(DestObjectPtrType, *TrackedType) && Should it check that we are actuall

[PATCH] D38831: [libcxx] P0604, invoke_result and is_invocable

K-ballo added a comment. In https://reviews.llvm.org/D38831#917439, @EricWF wrote: > @K-ballo I always forget. Do you have commit access? I do not. It's all yours. https://reviews.llvm.org/D38831 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell added a comment. @mstorsjo I think this should help with issues like having to set the default for ARM to DWARF. If you can set it at run time then it should be a lot easier to just set that in the clang wrapper scripts. Long term I would like the MinGW Driver to load a different libunw

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

mstorsjo added a comment. In https://reviews.llvm.org/D39673#917506, @martell wrote: > @mstorsjo I think this should help with issues like having to set the default > for ARM to DWARF. > If you can set it at run time then it should be a lot easier to just set > that in the clang wrapper script

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

mstorsjo added a comment. In https://reviews.llvm.org/D39673#917506, @martell wrote: > @mstorsjo I think this should help with issues like having to set the default > for ARM to DWARF. Btw, in addition to making setting `__SEH__` conditional, it should also instead set `__ARM_DWARF_EH__` on A

[PATCH] D39673: Toolchain: Normalize dwarf, sjlj and seh eh

martell added a comment. In https://reviews.llvm.org/D39673, @martell wrote: > Long term I would like the MinGW Driver to load a different libunwind > depending on the exception model but that discussion might still be a little > off. In https://reviews.llvm.org/D39673#917510, @mstorsjo wro

<    1   2