[PATCH] D24886: Add [[clang::suppress(rule, ...)]] attribute

2017-10-29 Thread Hristo Hristov via Phabricator via cfe-commits
roccoor added a comment. Microsoft supports: [[gsl::suppress(bounds.3)]] Clang requires: [[gsl::suppress("bounds.3")]] Why is this inconsistency? Here is an example from CppCoreGuidelines [[suppress(bounds)]] char* raw_find(char* p, int n, char x)// find x in p[0]..p[n - 1] {

[PATCH] D38683: [X86][AVX512] lowering broadcastm intrinsic - clang part

2017-10-29 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

Re: [PATCH] D39360: [C++11] Don't put empty quotes in static_assert diagnostic.

2017-10-29 Thread Kim Gräsman via cfe-commits
A clang-tidy check to remove empty messages from source would be nice, though... - Kim Den 27 okt. 2017 10:24 fm skrev "Nicolas Lesser via Phabricator" < revi...@reviews.llvm.org>: > Rakete abandoned this revision. > Rakete added a comment. > > @kimgr Well, mostly because they bother me

[libcxx] r316867 - Issues to be voted on in ABQ

2017-10-29 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 29 12:02:00 2017 New Revision: 316867 URL: http://llvm.org/viewvc/llvm-project?rev=316867&view=rev Log: Issues to be voted on in ABQ Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/l

[libcxx] r316873 - Update status of 2950

2017-10-29 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 29 14:43:30 2017 New Revision: 316873 URL: http://llvm.org/viewvc/llvm-project?rev=316873&view=rev Log: Update status of 2950 Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-pro

[libcxx] r316874 - Initial triage

2017-10-29 Thread Marshall Clow via cfe-commits
Author: marshall Date: Sun Oct 29 14:57:58 2017 New Revision: 316874 URL: http://llvm.org/viewvc/llvm-project?rev=316874&view=rev Log: Initial triage Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewvc/llvm-project/li

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

2017-10-29 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Looks good; sorry for not catching that, either. https://reviews.llvm.org/D39177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D39374: CodeGen: Fix insertion position of addrspace cast for alloca

2017-10-29 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Ok. https://reviews.llvm.org/D39374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

2017-10-29 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Looks good, but you missed updating equality/hashing for the new Kind field. Comment at: lib/CodeGen/CodeGenTBAA.h:71 AccessType == Other.AccessType && Offset == Other.Offset; } This needs to factor in the Ki

[PATCH] D39412: [Driver] Give LIBRARY_PATH precedence over native toolchains

2017-10-29 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray created this revision. Herald added subscribers: aheejin, jgravelle-google, sbc100, nhaehnle, dschuff, jfb, emaste. `LIBRARY_PATH` expansion should happen before expanding native toolchains' linker arguments, if any, to allow overriding the default standard libraries to link. GCC suppo