danalbert created this revision.
Herald added a subscriber: mgorny.
libc++ doesn't yet have the code for this, but libc++abi does. Adding
the switch to libc++ since the flag in libc++abi is
`_LIBCXX_DYNAMIC_FALLBACK`, not `_LIBCXXABI_DYNAMIC_FALLBACK`, and it
will be needed here as well.
Reposit
danalbert updated this revision to Diff 118711.
danalbert added a comment.
Herald added a subscriber: mgorny.
Update the test with an XFAIL when _LIBCXX_DYNAMIC_FALLBACK is not set.
https://reviews.llvm.org/D38827 adds this cmake option to libc++.
https://reviews.llvm.org/D38599
Files:
CMake
danalbert planned changes to this revision.
danalbert added a comment.
Actually, I was wrong. This is implemented. Will update to set the flag the
configures this and add a test.
Repository:
rL LLVM
https://reviews.llvm.org/D38827
___
cfe-commit
craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:844-845
-// FIXME: Historically, we defined this legacy name, it would be nice to
-// remove it at some point. We've never exposed fine-grained names for
-// recent primary x86 CPUs, and we shou
danalbert planned changes to this revision.
danalbert added a comment.
In https://reviews.llvm.org/D38599#894041, @jroelofs wrote:
> (possibly renamed to _LIBCXXABI_DYNAMIC_FALLBACK)
I opted for adding this switch to libc++ instead. Like @rprichard points out,
we'll need to do this in `std::ty
jroelofs added a comment.
Needs a docs entry for the new flag (in libcxx's BuildingLibcxx.rst). Other
than that, all the stuff I've asked you to add LGTM. I'd still appreciate
@EricWF/@mclow's opinion on the meat of the functional change part of this
though... I don't know all the implications
On 22 September 2017 at 18:00, Volodymyr Sapsai via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
>
> On Sep 21, 2017, at 15:17, Richard Smith wrote:
>
> On 15 September 2017 at 12:51, Volodymyr Sapsai via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: vsapsai
>> Date: Fri S
chandlerc added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:844-845
-// FIXME: Historically, we defined this legacy name, it would be nice to
-// remove it at some point. We've never exposed fine-grained names for
-// recent primary x86 CPUs, and we should
george.karpenkov added a comment.
@mgorny I've replied via email, but the message didn't seem to appear here.
From my (maybe limited) understanding, running tests on standalone compiler-rt
builds was never something which was supported, as that required a fresh
compiler.
I've just tried running
danalbert abandoned this revision.
danalbert added a comment.
zygoloid and nbjoerg got me pointed in the right direction on this. Looks like
the user didn't have a key function defined for one of their classes, which was
actually the root of the problem.
Repository:
rL LLVM
https://reviews.
danalbert abandoned this revision.
danalbert added a comment.
nbjoerg and zygoloid got me pointed in the right direction. Both `Base` and
`BaseImpl` are missing their key functions, and that's the problem here. Patch
should be unnecessary.
https://reviews.llvm.org/D38599
___
Author: zturner
Date: Wed Oct 11 16:33:06 2017
New Revision: 315530
URL: http://llvm.org/viewvc/llvm-project?rev=315530&view=rev
Log:
[ADT] Make Twine's copy constructor private.
There's a lot of misuse of Twine scattered around LLVM. This
ranges in severity from benign (returning a Twine from a
Author: lhames
Date: Wed Oct 11 16:35:27 2017
New Revision: 315532
URL: http://llvm.org/viewvc/llvm-project?rev=315532&view=rev
Log:
Update cc1as_main for MCCodeEmitter ownership change in r315531.
Modified:
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/tools/driver/cc1as_main.cp
Hello everyone,
Below are some buildbot numbers for the week of 09/24/2017 - 09/30/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed to
Hello everyone,
Below are some buildbot numbers for the last week of 10/1/2017 - 10/7/2017.
Please see the same data in attached csv files:
The longest time each builder was red during the week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from greed
K-ballo created this revision.
Introduce a new form of `result_of` without function type encoding.
Rename and split `is_callable/is_nothrow_callable` into
`is_invocable/is_nothrow_invocable/is_invocable_r/is_nothrow_invocable_r` (and
associated types accordingly)
Change function type encoding
Author: zturner
Date: Wed Oct 11 16:54:34 2017
New Revision: 315536
URL: http://llvm.org/viewvc/llvm-project?rev=315536&view=rev
Log:
Revert "[ADT] Make Twine's copy constructor private."
This reverts commit 4e4ee1c507e2707bb3c208e1e1b6551c3015cbf5.
This is failing due to some code that isn't bu
rsmith added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:8667-8679
+ bool Result; // The result of the comparison
+ if ((Op == BO_GT && ValueType == LimitType::Max && ConstOnRight) ||
+ (Op == BO_GT && ValueType == LimitType::Min && !ConstOnRight) ||
+ (Op
Author: ctopper
Date: Wed Oct 11 19:06:17 2017
New Revision: 315547
URL: http://llvm.org/viewvc/llvm-project?rev=315547&view=rev
Log:
[X86] Remove a few unnecessary check lines from the predefined-arch-macros test.
These were testing OS macros and clang/llvm macros.
Modified:
cfe/trunk/test/
compnerd added a comment.
Don't you need a change to the intrinsics to actually map the builtin?
https://reviews.llvm.org/D38821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo added inline comments.
Comment at: src/libunwind.cpp:188
+ co->getInfo(&info);
+ pint_t orgArgSize = (pint_t)info.gp;
+ uint64_t orgFuncStart = info.start_ip;
rnk wrote:
> I think it makes sense to have this here: the contract is that if t
mstorsjo added a comment.
In https://reviews.llvm.org/D38821#895527, @compnerd wrote:
> Don't you need a change to the intrinsics to actually map the builtin?
Apparently, this change is all that's needed since the tests pass. I can of
course try to look closer and see what actually makes it wo
arphaman created this revision.
Repository:
rL LLVM
https://reviews.llvm.org/D38835
Files:
include/clang/Tooling/Refactoring/ASTSelection.h
lib/Tooling/Refactoring/ASTSelection.cpp
unittests/Tooling/ASTSelectionTest.cpp
Index: unittests/Tooling/ASTSelectionTest.cpp
=
nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: chapuni
Date: Wed Oct 11 23:39:44 2017
New Revision: 315566
URL: http://llvm.org/viewvc/llvm-project?rev=315566&view=rev
Log:
clang/module.modulemap: Create Clang_Frontend_CodeGenOptions to remove some
dependencies in clangBasic.
- Clang_Analysis
- Clang_C
- Clang_Frontend
- Clang_Lex
-
101 - 125 of 125 matches
Mail list logo
