jkorous-apple updated this revision to Diff 118287.
jkorous-apple added a comment.
added another test
https://reviews.llvm.org/D38707
Files:
lib/Index/USRGeneration.cpp
test/Index/USR/func-type.cpp
Index: test/Index/USR/func-type.cpp
===
hey Lang (& folks here) any chance there's some overlap between the RPC
functionality here and the RPC functionality in ORC that could be
deduplicated/refactored?
On Fri, Oct 6, 2017 at 5:30 AM Ilya Biryukov via Phabricator via
cfe-commits wrote:
> ilya-biryukov accepted this revision.
> ilya-bi
george.karpenkov updated this revision to Diff 118291.
george.karpenkov added a comment.
Review comments.
https://reviews.llvm.org/D38702
Files:
lib/Analysis/BodyFarm.cpp
test/Analysis/call_once.cpp
Index: test/Analysis/call_once.cpp
===
zturner added a comment.
I'm a little nervous about re-inventing a poor man's version of a reader writer
lock. Can we not just copy LLVM's?
Comment at: src/UnwindCursor.hpp:20
#ifndef _LIBUNWIND_HAS_NO_THREADS
- #include
+ #ifdef _WIN32
+#include
May
Hello Ilya,
This commit broke build on one of our builders:
http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/16435
Please have a look?
Thanks
Galina
On Mon, Oct 9, 2017 at 9:26 AM, Ilya Biryukov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ibiryukov
> D
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me!
https://reviews.llvm.org/D38702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: george.karpenkov
Date: Mon Oct 9 16:20:46 2017
New Revision: 315250
URL: http://llvm.org/viewvc/llvm-project?rev=315250&view=rev
Log:
[Analyzer] Do not segfault on unexpected call_once implementation
Fixes https://bugs.llvm.org/show_bug.cgi?id=34869
Differential Revision: https://review
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315250: [Analyzer] Do not segfault on unexpected call_once
implementation (authored by george.karpenkov).
Changed prior to commit:
https://reviews.llvm.org/D38702?vs=118291&id=118294#toc
Repository:
jkorous-apple added inline comments.
Comment at: lib/Index/USRGeneration.cpp:757
VisitType(FT->getReturnType());
- for (const auto &I : FT->param_types())
+ Out << '(';
+ for (const auto &I : FT->param_types()) {
arphaman wrote:
> I believe
jkorous-apple created this revision.
I have found two possible typos in documentation. Since English is not my first
language I would like to ask for verification.
https://reviews.llvm.org/D38711
Files:
docs/InternalsManual.rst
Index: docs/InternalsManual.rst
==
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
I think that the problem is that we are using the generic register name, but we
need to use the target specific register name. On x86, EIP/ESP are swapped.
We should also have
jroelofs accepted this revision.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D38711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
Author: rsmith
Date: Mon Oct 9 16:42:09 2017
New Revision: 315251
URL: http://llvm.org/viewvc/llvm-project?rev=315251&view=rev
Log:
[Modules TS] Module ownership semantics for redeclarations.
When declaring an entity in the "purview" of a module, it's never a
redeclaration of an entity in the pu
Author: jkorous
Date: Mon Oct 9 16:45:20 2017
New Revision: 315252
URL: http://llvm.org/viewvc/llvm-project?rev=315252&view=rev
Log:
Fix typos in documentation
Differential Revision: https://reviews.llvm.org/D38711
Modified:
cfe/trunk/docs/InternalsManual.rst
Modified: cfe/trunk/docs/Inter
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315252: Fix typos in documentation (authored by jkorous).
Changed prior to commit:
https://reviews.llvm.org/D38711?vs=118295&id=118296#toc
Repository:
rL LLVM
https://reviews.llvm.org/D38711
Files:
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D38707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
danalbert added a comment.
> Are you 100% sure that you're not just a person with broken code?
Absolutely, since it isn't my code ;) I maintain the toolchain and this is a
behavioral change when switching from libstdc++ to libc++.
> In other words, what did this guy from 2013 get wrong? -- or,
Author: jkorous
Date: Mon Oct 9 17:35:16 2017
New Revision: 315255
URL: http://llvm.org/viewvc/llvm-project?rev=315255&view=rev
Log:
R13575: Fix USR mangling for function pointer types
Differential Revision: https://reviews.llvm.org/D38707
Added:
cfe/trunk/test/Index/USR/func-type.cpp
Modif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315255: R13575: Fix USR mangling for function pointer types
(authored by jkorous).
Changed prior to commit:
https://reviews.llvm.org/D38707?vs=118287&id=118300#toc
Repository:
rL LLVM
https://review
Author: rsmith
Date: Mon Oct 9 17:49:38 2017
New Revision: 315256
URL: http://llvm.org/viewvc/llvm-project?rev=315256&view=rev
Log:
[Modules TS] Avoid computing the linkage of the enclosing DeclContext for a
declaration in the global module.
This works around a language issue where adding a typ
dcoughlin requested changes to this revision.
dcoughlin added a comment.
This revision now requires changes to proceed.
Apologies for the delay reviewing! As I noted inline, I'm pretty worried about
the performance impact of this. Is it possible to do the analysis in a single
traversal of the tr
Author: ahatanak
Date: Mon Oct 9 18:24:33 2017
New Revision: 315261
URL: http://llvm.org/viewvc/llvm-project?rev=315261&view=rev
Log:
[Sema][ObjC] Preserve syntactic sugar when removing
ARCReclaimReturnedObject cast.
This is a follow-up to r314370.
Rather than throwing away the enclosing parent
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315261: [Sema][ObjC] Preserve syntactic sugar when removing
(authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D38659?vs=118121&id=118302#toc
Repository:
rL LLVM
https://revie
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
This looks good to me! Thanks for adding this. Do you have commit access, or do
you need someone to commit it for you?
https://reviews.llvm.org/D37478
___
nemanjai added a comment.
In https://reviews.llvm.org/D38656#892072, @Carrot wrote:
> I worked on a similar bug as 31161, and then found this one, it should be
> same as in comment7.
> What is the current status of the work on that bug?
No one has had time to finalize a fix to it. Please go a
sepavloff updated this revision to Diff 118315.
sepavloff added a comment.
Updated patch according to reviewer's notes
https://reviews.llvm.org/D24933
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Config/config.h.cmake
include/clang/Driver/Driver
sepavloff marked 28 inline comments as done.
sepavloff added a comment.
@hfinkel Thank you for explanations!
https://reviews.llvm.org/D24933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
paquette added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:201
+ /// comparison)?
+ bool isGreaterOrEqual(const Expr *E, unsigned long long Val);
+
Maybe something like
```
/// Returns true if the value of \p E
r.stahl added a comment.
Since I do not have commit access, it would be nice if someone committed this
for me. Thanks!
https://reviews.llvm.org/D37478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, this is a nice improvement.
Repository:
rL LLVM
https://reviews.llvm.org/D38695
___
cfe-commits mailing list
cfe-commits@lists.llv
101 - 130 of 130 matches
Mail list logo
