Re: [PATCH] D31363: [libc++] Remove cmake glob for source files

2017-10-04 Thread Duncan P. N. Exon Smith via cfe-commits
I haven't looked at the patch. If this is guarded behind NOT LIBCXX_STANDALONE_BUILD checks, then it's probably fine. > On Oct 4, 2017, at 21:36, Zachary Turner wrote: > > This doesn’t match up with what beanz said. While I assume Duncan is the > final word, can we get some confirmation from

Re: [PATCH] D31363: [libc++] Remove cmake glob for source files

2017-10-04 Thread Zachary Turner via cfe-commits
It’s not, but the point is we’re already skirting the line On Wed, Oct 4, 2017 at 9:37 PM Duncan P. N. Exon Smith wrote: > I haven't looked at the patch. If this is guarded behind NOT > LIBCXX_STANDALONE_BUILD checks, then it's probably fine. > > > On Oct 4, 2017, at 21:36, Zachary Turner wrote

[PATCH] D38576: |libunwind] [docs] Mention that SjLj works on any OS on the archs where supported by the compiler

2017-10-04 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo created this revision. https://reviews.llvm.org/D38576 Files: docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/index.rst @@ -50,6 +50,7 @@ LinuxARM Clang, GCC EHABI Bare M

<    1   2