xazax.hun added a comment.
@leanil : Could you add a test case where the warnings are explicitly disabled
in the compilation command and also one where only the aliased warning is
explicitly disabled?
In https://reviews.llvm.org/D38171#878814, @lebedev.ri wrote:
> I feel like the current handl
aaron.ballman added a comment.
I'm not certain we have the semantics of `__declspec(nothrow)` exactly correct
-- a simple test shows that `__attribute__((nothrow))`, `__declspec(nothrow)`,
and `noexcept(true)` are subtly different.
When I run this with MSVC 2017, the terminate handler is not ca
xazax.hun added a comment.
In https://reviews.llvm.org/D38171#878808, @alexfh wrote:
> András, that's definitely an interesting idea. However, it might be
> interesting to explore a more principled approach:
>
> 1. Make `clang-diagnostic-*` checks first-class citizens and take full
> control of
lebedev.ri added a comment.
In https://reviews.llvm.org/D38171#880016, @xazax.hun wrote:
> In https://reviews.llvm.org/D38171#878814, @lebedev.ri wrote:
>
> > I feel like the current handling of the clang-tidy check aliases needs
> > adjusting.
> > If one enables all the checks (`Checks: '*'`),
alexfh added a comment.
In https://reviews.llvm.org/D38171#878814, @lebedev.ri wrote:
> On a somewhat related note, since this is already talking about aliases
>
> I feel like the current handling of the clang-tidy check aliases needs
> adjusting.
> If one enables all the checks (`Checks: '*'`
xazax.hun added a comment.
In https://reviews.llvm.org/D38171#880022, @lebedev.ri wrote:
> A mail [0] posted by @JonasToth is about the similar problem, i think we can
> continue there.
Great! Could you summarize your points there as well? Thanks in advance.
https://reviews.llvm.org/D38171
NoQ updated this revision to Diff 116542.
NoQ added a comment.
@dcoughlin: You're right, my reasoning and understanding was not correct, and
your explanation is much more clear. My code still makes sense to me though, so
i updated the comments to match. And moved the unusual logic for the
lvalu
Nebiroth added a comment.
In https://reviews.llvm.org/D36150#879194, @ilya-biryukov wrote:
> Looks good.
> Do you want me to submit this patch for you?
Yes please.
https://reviews.llvm.org/D36150
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: jina.nahias
Date: Mon Sep 25 06:38:08 2017
New Revision: 314102
URL: http://llvm.org/viewvc/llvm-project?rev=314102&view=rev
Log:
fixing a bug in mask[z]_set1 intrinsic
Differential Revision: https://reviews.llvm.org/D38231
Change-Id: I80bbff9cbe93e4be54d8a761ef9723edf3f57c57
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314102: fixing a bug in mask[z]_set1 intrinsic (authored by
jina.nahias).
Changed prior to commit:
https://reviews.llvm.org/D38231?vs=116513&id=116545#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: mzuckerm
Date: Mon Sep 25 06:49:32 2017
New Revision: 314104
URL: http://llvm.org/viewvc/llvm-project?rev=314104&view=rev
Log:
[Clang] Adding missing feature to goldmont
Change-Id: I6c22478d16b8e02ce60dae2f8c80d43bc5ab3a9c
Modified:
cfe/trunk/lib/Basic/Targets/X86.cpp
cfe/trunk/t
lebedev.ri added a comment.
In https://reviews.llvm.org/D38171#880025, @xazax.hun wrote:
> In https://reviews.llvm.org/D38171#880022, @lebedev.ri wrote:
>
> > A mail [0] posted by @JonasToth is about the similar problem, i think we
> > can continue there.
>
>
> Great! Could you summarize your po
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D38228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Anastasia updated this revision to Diff 116548.
Anastasia added a comment.
Addressed comments from Alexey.
https://reviews.llvm.org/D37804
Files:
lib/CodeGen/CGBuilder.h
lib/CodeGen/CGExpr.cpp
test/CodeGenOpenCL/vectorLoadStore.cl
Index: test/CodeGenOpenCL/vectorLoadStore.cl
===
Author: sylvestre
Date: Mon Sep 25 07:08:35 2017
New Revision: 314107
URL: http://llvm.org/viewvc/llvm-project?rev=314107&view=rev
Log:
Fix clangd when built with LLVM_LINK_LLVM_DYLIB=ON
Reviewers: malaperle, malaperle-ericsson, bkramer
Reviewed By: bkramer
Subscribers: bkramer, mgorny, ilya-bi
bader accepted this revision.
bader added a comment.
LGTM. Thanks!
https://reviews.llvm.org/D37804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Nebiroth updated this revision to Diff 116559.
Nebiroth added a comment.
Fixed inverted compile_commands check logic that made tests fail.
More readable command arg checks.
https://reviews.llvm.org/D37150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/GlobalCompilationD
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks good. Do you have commit access?
https://reviews.llvm.org/D38225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Anastasia added a comment.
I think we should add a test case when the same block is both called and
enqueued.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:113
+
+llvm::Value *CGOpenCLRuntime::emitOpenCLEnqueuedBlock(CodeGenFunction &CGF,
+
jbcoe added inline comments.
Comment at: bindings/python/tests/cindex/test_cursor.py:407
+# AvailabilityKind.DEPRECATED
+tu = get_tu('#include \n void test(char* s) { std::gets(s); }',
lang='cpp')
+cursor = get_cursor(tu, 'gets')
It might be better t
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good
https://reviews.llvm.org/D38226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: jvesely
Date: Mon Sep 25 09:04:37 2017
New Revision: 314111
URL: http://llvm.org/viewvc/llvm-project?rev=314111&view=rev
Log:
prepare_builtins: Fix compile breakage with older LLVM
Fixes r314050
reviewer: Tom Stellard
Signed-off-by: Jan Vesely
Modified:
libclc/trunk/utils/prepare-
Author: jvesely
Date: Mon Sep 25 09:07:34 2017
New Revision: 314112
URL: http://llvm.org/viewvc/llvm-project?rev=314112&view=rev
Log:
Rework atomic ops to use clang builtins rather than llvm asm
reviewer: Aaron Watry
Signed-off-by: Jan Vesely
Added:
libclc/trunk/generic/lib/atomic/atomic_a
Is there also missing test coverage here?
On Sun, Sep 24, 2017 at 8:19 AM Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rksimon
> Date: Sun Sep 24 08:17:46 2017
> New Revision: 314079
>
> URL: http://llvm.org/viewvc/llvm-project?rev=314079&view=rev
> Log:
> Fix impl
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:311
+// The header is basically 'struct { int; int; generic void *;
+// custom_fields; }'. Assert that that struct is packed.
+auto GenPtrAlign = CharUnits::fromQuantity(
remove one
danielmarjamaki added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D30295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rwols added a comment.
No, I don't have commit access. Feel free to merge.
https://reviews.llvm.org/D38225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kongyi added a comment.
ping...
Repository:
rL LLVM
https://reviews.llvm.org/D38158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Mon Sep 25 10:16:47 2017
New Revision: 314119
URL: http://llvm.org/viewvc/llvm-project?rev=314119&view=rev
Log:
[clangd] Fix missing "message" key when responding with unsupported method
The language server protocol dictates that a ResponseError should have a
[message string][1]
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314119: [clangd] Fix missing "message" key when responding
with unsupported method (authored by d0k).
Repository:
rL LLVM
https://reviews.llvm.org/D38225
Files:
clang-tools-extra/trunk/clangd/JSONRP
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D38158
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314124: [Sema] Null check in BuildDeclarationNameExpr
(authored by kongyi).
Changed prior to commit:
https://reviews.llvm.org/D38158?vs=116279&id=116571#toc
Repository:
rL LLVM
https://reviews.llvm.
Author: kongyi
Date: Mon Sep 25 10:36:54 2017
New Revision: 314124
URL: http://llvm.org/viewvc/llvm-project?rev=314124&view=rev
Log:
[Sema] Null check in BuildDeclarationNameExpr
Qualtype may point to null if we cannot infer its type yet.
Fixes PR33843
Differential Revision: https://reviews.llv
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Should we add tests to the test-suite? Or, are these already caught by the
existing tests we have?
https://reviews.llvm.org/D38188
___
cfe-comm
krasimir created this revision.
Herald added a subscriber: klimek.
This adds an ext/ header include category for google style.
https://reviews.llvm.org/D38243
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- li
tra added a comment.
In https://reviews.llvm.org/D38188#880318, @jlebar wrote:
> Should we add tests to the test-suite? Or, are these already caught by the
> existing tests we have?
That's the plan. Once clang can compile CUDA headers, I'll add CUDA-9 specific
tests to the testsuite and upda
Author: tra
Date: Mon Sep 25 10:55:26 2017
New Revision: 314129
URL: http://llvm.org/viewvc/llvm-project?rev=314129&view=rev
Log:
[CUDA] Fix names of __nvvm_vote* intrinsics.
Also fixed a syntax error in activemask().
Differential Revision: https://reviews.llvm.org/D38188
Modified:
cfe/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314129: [CUDA] Fix names of __nvvm_vote* intrinsics.
(authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D38188?vs=116400&id=116576#toc
Repository:
rL LLVM
https://reviews.llvm.org/
jlebar added inline comments.
Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:419
+TARGET_BUILTIN(__nvvm_match_any_sync_i64, "WiUiWi", "", "ptx60")
+// These return a pair {value, predicate} which requires custom lowering.
+TARGET_BUILTIN(__nvvm_match_all_sync_i32p, "UiUi
tra updated this revision to Diff 116578.
tra marked an inline comment as done.
tra added a comment.
Addressed Justin's comments.
https://reviews.llvm.org/D38191
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Headers/__clang_cuda_intrinsics.h
tra added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9603
+Value *Pred = Builder.CreateSExt(Builder.CreateExtractValue(ResultPair, 1),
+ PredOutPtr.getElementType());
+Builder.CreateStore(Pred, PredOutPtr);
---
chh added a comment.
ping.
https://reviews.llvm.org/D35743
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tra
Date: Mon Sep 25 11:53:57 2017
New Revision: 314135
URL: http://llvm.org/viewvc/llvm-project?rev=314135&view=rev
Log:
[NVPTX] added match.{any,all}.sync instructions, intrinsics & builtins.
Differential Revision: https://reviews.llvm.org/D38191
Modified:
cfe/trunk/include/clang/B
eandrews updated this revision to Diff 116581.
eandrews added a comment.
I've modified the patch to emit a warning for re-declarations only. I also
removed the isUsed check.
https://reviews.llvm.org/D36487
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CodeGenModule.cpp
li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314135: [NVPTX] added match.{any,all}.sync instructions,
intrinsics & builtins. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D38191?vs=116578&id=116584#toc
Repository:
rL LLVM
krasimir added a comment.
ping
https://reviews.llvm.org/D37695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mstorsjo
Date: Mon Sep 25 12:24:45 2017
New Revision: 314138
URL: http://llvm.org/viewvc/llvm-project?rev=314138&view=rev
Log:
[MinGW] Don't link -lmsvcrt if a different msvcrt version is to be linked
Differential Revision: https://reviews.llvm.org/D37530
Added:
cfe/trunk/test/Driver
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314138: [MinGW] Don't link -lmsvcrt if a different msvcrt
version is to be linked (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D37530?vs=114429&id=116587#toc
Repository:
Author: alexshap
Date: Mon Sep 25 12:32:33 2017
New Revision: 314141
URL: http://llvm.org/viewvc/llvm-project?rev=314141&view=rev
Log:
[analyzer] Fix crash on modeling of pointer arithmetic
This patch fixes analyzer's crash on the newly added test case
(see also https://bugs.llvm.org/show_bug.cg
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314141: [analyzer] Fix crash on modeling of pointer
arithmetic (authored by alexshap).
Changed prior to commit:
https://reviews.llvm.org/D38214?vs=116455&id=116590#toc
Repository:
rL LLVM
https://re
Author: jlebar
Date: Mon Sep 25 12:41:56 2017
New Revision: 314142
URL: http://llvm.org/viewvc/llvm-project?rev=314142&view=rev
Log:
Revert "[NVPTX] added match.{any,all}.sync instructions, intrinsics &
builtins.", rL314135.
Causing assertion failures on macos:
> Assertion failed: (Num < NumOpe
mstorsjo created this revision.
This makes it match the definition used within llvm and in libgcc, we
previously got the wrong layout on 64 bit.
https://reviews.llvm.org/D38247
Files:
src/Unwind-sjlj.c
Index: src/Unwind-sjlj.c
===
zaks.anna added a comment.
Sorry for the wait!
Repository:
rL LLVM
https://reviews.llvm.org/D30295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:134
+else if (I->isUnsigned())
+ OS << I->getZExtValue() << ", which is";
+else
Please print single quotes around the value.
===
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Thanks!
https://reviews.llvm.org/D36737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, aemerson.
When SJLJ exceptions are used, those functions aren't used.
This fixes build failures on ARM with SJLJ enabled, such as armv7/iOS.
https://reviews.llvm.org/D38249
Files:
src/UnwindLevel1.c
src/UnwindRegister
mstorsjo created this revision.
When targeting apple platforms, these functions are implemented in
Unwind_AppleExtras.cpp, but there's previously no implementation for
other platforms.
Does `__thread` have any specific runtime requirements on e.g. windows?
https://reviews.llvm.org/D38250
Files
Author: wmi
Date: Mon Sep 25 12:57:59 2017
New Revision: 314145
URL: http://llvm.org/viewvc/llvm-project?rev=314145&view=rev
Log:
Reinstall the patch "Use EmitPointerWithAlignment to get alignment information
of the pointer used in atomic expr" after fixing PR31620.
This is to fix PR34347. EmitA
srhines added a comment.
Ping.
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT added a comment.
> do you think `__declspec(nothrow)` calling the terminate handler in Clang is
> a bug?
It's certainly a behavior difference with potential performance impact,
although I don't think it can be viewed as a bug, strictly speaking. MSVC
treats `__declspec(nothrow)` as an
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
In https://reviews.llvm.org/D38209#880553, @STL_MSFT wrote:
> > do you think `__declspec(nothrow)` calling the terminate handler in Clang
> > is a bug?
>
> It's certainly a behavior difference with potential performance impac
werbitt reclaimed this revision.
werbitt added a comment.
This revision is now accepted and ready to land.
It looks like I just uploaded a diff against a bad branch, and I can't figure
out how to undo it. Sorry about that.
https://reviews.llvm.org/D37903
_
werbitt updated this revision to Diff 116605.
werbitt added a comment.
Cleanup Docs
- The first line of of an emacs docstring should be a complete sentence.
-Specify that "-assume-filname" is a clang-format option
https://reviews.llvm.org/D37903
Files:
tools/clang-format/clang-format.el
I
Hahnfeld created this revision.
Parsing the argument after -Xopenmp-target allocates memory that needs
to be freed. Associate it with the final DerivedArgList after we know
which one will be used.
https://reviews.llvm.org/D38257
Files:
include/clang/Driver/ToolChain.h
lib/Driver/Compilation
Hahnfeld created this revision.
AuxTriple is not set if host and device share a toolchain. Also,
removing an argument modifies the DAL which needs to be returned
for future use.
(Move tests back to offload-openmp.c as they are not related to GPUs.)
https://reviews.llvm.org/D38258
Files:
lib/D
Hahnfeld created this revision.
ToolChain::TranslateArgs() returns nullptr if no changes are performed.
This would currently mean that OpenMPArgs are lost. Patch fixes this
by falling back to simply using OpenMPArgs in that case.
https://reviews.llvm.org/D38259
Files:
lib/Driver/Compilation.c
Author: spatel
Date: Mon Sep 25 14:27:37 2017
New Revision: 314158
URL: http://llvm.org/viewvc/llvm-project?rev=314158&view=rev
Log:
[x86] make assertions less strict in avx512f test file
I'm not sure why yet, but there may be differences depending on the host?
Modified:
cfe/trunk/test/CodeG
eugenis updated this revision to Diff 116618.
eugenis added a comment.
Switched to SetLLVMFunctionAttributes
https://reviews.llvm.org/D37656
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGen/cfi-check-thumb.c
llvm/lib/Transforms/IPO/CrossDSOCFI.cpp
llvm/test/Transforms/CrossDSOCFI/
Author: spatel
Date: Mon Sep 25 14:31:08 2017
New Revision: 314159
URL: http://llvm.org/viewvc/llvm-project?rev=314159&view=rev
Log:
[x86] make assertions less strict in avx512f test file
Missed a line in r314158.
Modified:
cfe/trunk/test/CodeGen/avx512f-builtins.c
Modified: cfe/trunk/test/
gtbercea updated this revision to Diff 116621.
gtbercea added a comment.
Split line.
https://reviews.llvm.org/D37913
Files:
lib/Driver/ToolChains/Cuda.cpp
test/Driver/openmp-offload-gpu.c
Index: test/Driver/openmp-offload-gpu.c
=
gtbercea reopened this revision.
gtbercea added a comment.
This revision is now accepted and ready to land.
Open.
Repository:
rL LLVM
https://reviews.llvm.org/D37914
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: vlad.tsyrklevich
Date: Mon Sep 25 15:11:12 2017
New Revision: 314171
URL: http://llvm.org/viewvc/llvm-project?rev=314171&view=rev
Log:
Allow specifying sanitizers in blacklists
Summary:
This is the follow-up patch to D37924.
This change refactors clang to use the the newly added section
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314171: Allow specifying sanitizers in blacklists (authored
by vlad.tsyrklevich).
Repository:
rL LLVM
https://reviews.llvm.org/D37925
Files:
cfe/trunk/docs/ControlFlowIntegrity.rst
cfe/trunk/docs/
Author: nico
Date: Mon Sep 25 15:42:49 2017
New Revision: 314172
URL: http://llvm.org/viewvc/llvm-project?rev=314172&view=rev
Log:
clang-format/java: Always put space after `assert` keyword.
Previously, it was missing if the expression after the assert started with a (.
Modified:
cfe/trunk/l
Author: dberris
Date: Mon Sep 25 16:40:33 2017
New Revision: 314177
URL: http://llvm.org/viewvc/llvm-project?rev=314177&view=rev
Log:
[XRay][Driver] Do not link in XRay runtime in shared libs
Summary:
This change ensures that we don't link in the XRay runtime when building
shared libraries with c
Updated the diff. Unfortunately reviews.llvm.org is down, so I'll try
updating that page in the morning.
Sean
On 9/25/17 5:04 AM, Bruno Cardoso Lopes via Phabricator wrote:
bruno added inline comments.
Comment at: lib/AST/ExternalASTMerger.cpp:79
+ return cast(SearchRe
Author: dberris
Date: Mon Sep 25 17:41:08 2017
New Revision: 314178
URL: http://llvm.org/viewvc/llvm-project?rev=314178&view=rev
Log:
Revert "[XRay][Driver] Do not link in XRay runtime in shared libs"
Reverts r314177.
Removed:
cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp
Modified:
c
Author: matze
Date: Mon Sep 25 19:37:23 2017
New Revision: 314187
URL: http://llvm.org/viewvc/llvm-project?rev=314187&view=rev
Log:
CodeGenModule: Adapt to LLVM TargetLibraryInfo changes
Adapt to LLVM TargetLibraryInfo changes in r314185.
See also https://reviews.llvm.org/D38106 and https://revi
Author: dberris
Date: Mon Sep 25 20:18:11 2017
New Revision: 314188
URL: http://llvm.org/viewvc/llvm-project?rev=314188&view=rev
Log:
[XRay][Driver] Do not link in XRay runtime in shared libs
Summary:
This change ensures that we don't link in the XRay runtime when building
shared libraries with c
Author: dberris
Date: Mon Sep 25 20:45:37 2017
New Revision: 314189
URL: http://llvm.org/viewvc/llvm-project?rev=314189&view=rev
Log:
[XRay] Stop running tests for 'amd64', and remove -fPIE from tests.
Follow-up to D38226.
Modified:
cfe/trunk/test/Driver/XRay/lit.local.cfg
cfe/trunk/test
Author: dberris
Date: Mon Sep 25 21:00:41 2017
New Revision: 314190
URL: http://llvm.org/viewvc/llvm-project?rev=314190&view=rev
Log:
[XRay] Remove -fPIC from shared build test.
Follow-up to D38226.
Modified:
cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp
Modified: cfe/trunk/test/Driver/
Author: dberris
Date: Mon Sep 25 21:07:45 2017
New Revision: 314191
URL: http://llvm.org/viewvc/llvm-project?rev=314191&view=rev
Log:
[XRay] Only run shared tests when 'enable_shared' is true
Follow-up to D38226.
Modified:
cfe/trunk/test/Driver/XRay/lit.local.cfg
cfe/trunk/test/Driver/XR
Author: dberris
Date: Mon Sep 25 21:17:37 2017
New Revision: 314193
URL: http://llvm.org/viewvc/llvm-project?rev=314193&view=rev
Log:
[XRay] Run command once without piping to FileCheck
This allows us to debug the failures that come up from the build bots.
Follow-up to D38226.
Modified:
cfe
Author: dberris
Date: Mon Sep 25 21:29:25 2017
New Revision: 314194
URL: http://llvm.org/viewvc/llvm-project?rev=314194&view=rev
Log:
[XRay] Avoid actual linking when testing the driver
Use -### in the command to see just look for the output of -v.
Follow-up to D38226.
Modified:
cfe/trunk/t
tra created this revision.
Herald added a subscriber: sanjoy.
Also fixed a syntax error in activemask().
https://reviews.llvm.org/D38188
Files:
clang/lib/Headers/__clang_cuda_intrinsics.h
Index: clang/lib/Headers/__clang_cuda_intrinsics.h
yaxunl added a comment.
Do we need an option to disable this? In case it causes regression in some
applications and users want to disable it. At least for debugging.
Comment at: test/CodeGenOpenCL/convergent.cl:73
// CHECK: %[[tobool_pr:.+]] = phi i1 [ true, %[[if_then]] ],
tra created this revision.
Herald added subscribers: hiraditya, sanjoy, jholewinski.
https://reviews.llvm.org/D38191
Files:
clang/include/clang/Basic/BuiltinsNVPTX.def
clang/lib/CodeGen/CGBuiltin.cpp
clang/lib/Headers/__clang_cuda_intrinsics.h
clang/test/CodeGen/builtins-nvptx-ptx60.cu
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
Looks good.
Do you want me to submit this patch for you?
https://reviews.llvm.org/D36150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
spyffe updated this revision to Diff 116405.
spyffe marked 18 inline comments as done.
spyffe added a subscriber: cfe-commits.
spyffe added a comment.
Updated to reflect Bruno's suggestions.
- Commented `ExternalASTMerger.h` extensively.
- Refactored the log into a pluggable `raw_ostream` that de
gtbercea added a comment.
In https://reviews.llvm.org/D38040#878799, @Hahnfeld wrote:
> In https://reviews.llvm.org/D38040#878441, @gtbercea wrote:
>
> > The test is verifying whether the parameter is passed to the kernel
> > correctly. I believe it was not passed as a reference before the patch
rsmith added a comment.
I wonder whether this feature really pulls its weight compared to using `@file`
and prepending `-fmodule-file=` to each line.
The big difference between this patch and an `@file` seems to be the filtering
by prefix / storing this information as a subset of the data in a
erichkeane created this revision.
Herald added a subscriber: javed.absar.
Attribute nothrow is only allowed on functions, so I added that. Additionally,
it lacks any documentation, so I added some. Please wordsmith!
https://reviews.llvm.org/D38202
Files:
include/clang/Basic/Attr.td
includ
erichkeane created this revision.
Discovered that 'nothrow' (which is supposed to be an alias for noexcept)
was not warning with a throw inside of it. This patch corrects the behavior
previously created to add 'nothrow' to this list.
https://reviews.llvm.org/D38203
Files:
lib/Sema/AnalysisBa
erichkeane created this revision.
I discovered it was possible to create a 'nothrow' noexcept(false)
function, which is both non-sensical as well as seemingly breaking.
This patch warns if attribute nothrow is used with anything besides "noexcept".
"noexcept(true)" isn't possible, because the no
bruno added a comment.
Thanks for the additional docs! More comments below.
Comment at: lib/AST/ExternalASTMerger.cpp:116
+if (auto *ToDC = dyn_cast(To)) {
+ logs() << "(ExternalASTMerger*)" << (void*)&Parent
+ << " imported (DeclContext*)" << (void*)ToDC
-
boris added a comment.
Yes, the main "feature" of this approach compared to @file is the ability to
reuse an already existing file to store this information. Most build systems
that support C/C++ compilation have to store auxiliary dependency information
at least for the extracted header depend
boris updated this revision to Diff 116438.
boris marked an inline comment as done.
boris added a comment.
New revision this time with the tests (which got dropped from the earlier
revision diff for some reason).
https://reviews.llvm.org/D37299
Files:
docs/Modules.rst
include/clang/Basic/D
spyffe created this revision.
spyffe added a project: clang.
At @bruno 's request, recreating this with cfe-commits as a subscriber. The
original is https://reviews.llvm.org/D36589
`ExternalASTMerger` has hitherto relied on being able to look up any Decl
through its named `DeclContext` chain.
spyffe abandoned this revision.
spyffe marked 13 inline comments as done.
spyffe added a comment.
At @bruno 's request, abandoning this revision in favor of the updated
https://reviews.llvm.org/D38208.
That revision has all the changes requested.
https://reviews.llvm.org/D36589
_
erichkeane updated this revision to Diff 116433.
erichkeane added a comment.
Woops, didn't commit my correct tests!
https://reviews.llvm.org/D38205
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDeclAttr.cpp
test/SemaCXX/warn-conflicting-nothrow-attr-exception-spec.cpp
I
1 - 100 of 147 matches
Mail list logo
