morehouse updated this revision to Diff 116100.
morehouse added a comment.
- Add LLVM test.
https://reviews.llvm.org/D38063
Files:
clang/lib/CodeGen/CGClass.cpp
clang/test/CodeGenCXX/sanitize-dtor-callback.cpp
llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
llvm/test/Instrumenta
dcoughlin added a comment.
I'm OK with this going into the repo a is (although it is light on tests!), as
long as we have an agreement that you'll be OK with iteration on both the
interface and the implementation to handle real-world projects.
More specifically, for this to work well on large/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL313831: [MSan] Disable sanitization for
__sanitizer_dtor_callback. (authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D38063?vs=116100&id=116103#toc
Repository:
rL LLVM
https
Author: morehouse
Date: Wed Sep 20 15:53:08 2017
New Revision: 313831
URL: http://llvm.org/viewvc/llvm-project?rev=313831&view=rev
Log:
[MSan] Disable sanitization for __sanitizer_dtor_callback.
Summary:
Eliminate unnecessary instrumentation at __sanitizer_dtor_callback
call sites. Fixes https:/
wmi added inline comments.
Comment at: lib/Basic/Targets/X86.h:898
+ MaxAtomicPromoteWidth = 64;
+ MaxAtomicInlineWidth = 64;
+}
efriedma wrote:
> wmi wrote:
> > efriedma wrote:
> > > I don't think we need to mess with MaxAtomicPromoteWidth?
> > >
wmi updated this revision to Diff 116107.
wmi added a comment.
Herald added a subscriber: eraman.
Address Eli's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D38046
Files:
include/clang/Basic/TargetInfo.h
lib/Basic/Targets.cpp
lib/Basic/Targets/X86.h
test/CodeGenCXX/atomic-i
vsapsai created this revision.
Fix for too aggressive error err_type_defined_in_enum introduced in
r313386. Defining tags inside enumerations is prohibited in C++ but
allowed in C.
https://reviews.llvm.org/D38109
Files:
clang/lib/Sema/SemaDecl.cpp
clang/test/Sema/enum.c
Index: clang/test/
vsapsai added a comment.
Submitted for review https://reviews.llvm.org/D38109 - [fixup][Sema] Allow in C
to define tags inside enumerations.
Repository:
rL LLVM
https://reviews.llvm.org/D37089
___
cfe-commits mailing list
cfe-commits@lists.llvm.
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D38109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm created this revision.
Herald added a subscriber: wdng.
This was done for CUDA functions in r261779, and for the same
reason this also needs to be done for OpenCL. An arbitrary
function could have a barrier() call in it, which in turn
requires the calling function to be convergent.
https:
MatzeB added a comment.
With this commit some (old) code stops to compile as it seems to remove some
builtins, was that intentional?
Reproducer:
typedef long long __m128i __attribute__((__vector_size__(16)));
typedef short __v8hi __attribute__((__vector_size__(16)));
typedef char __v16qi
jlebar added a comment.
LGTM for the changes other than the test (I don't read opencl).
https://reviews.llvm.org/D38113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm updated this revision to Diff 116125.
arsenm added a comment.
Herald added a subscriber: nhaehnle.
Missed test update
https://reviews.llvm.org/D38113
Files:
include/clang/Basic/LangOptions.h
lib/CodeGen/CGCall.cpp
test/CodeGenOpenCL/amdgpu-attrs.cl
test/CodeGenOpenCL/convergent.c
MatzeB added a comment.
Actually, looking at the change it seems like it is and we better try to update
emmintrin.h...
Repository:
rL LLVM
https://reviews.llvm.org/D37562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/8038/steps/check-clang%20ubsan/logs/stdio
--
/mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/lib/AST/Decl.cpp:1333:42:
runtime error: load of value 15, which is not a valid value for type
'clang::LV
craig.topper added a comment.
Was the code not using emmintrin.h and instead copied code from it that used
the builtins?
Repository:
rL LLVM
https://reviews.llvm.org/D37562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
MatzeB added a comment.
In https://reviews.llvm.org/D37562#877209, @craig.topper wrote:
> Was the code not using emmintrin.h and instead copied code from it that used
> the builtins?
Turned out to be code that had been preprocessed in the past. I'll unpreprocess
the xmmintrin.h/emmintrin.h pa
eugenis added a subscriber: dberris.
eugenis added inline comments.
Comment at: include/clang/Basic/SanitizerSpecialCaseList.h:39
+ // Initialize SanitizerSections.
+ void sanitizerCompile();
+
"compile" in this method name is confusing. It's used in the base c
Thanks, I'll fix this tomorrow; if that's not soon enough, please go ahead
and revert (or fix by adding a dummy enumerator in lib/AST/Linkage.h).
On 20 Sep 2017 17:39, "Vitaly Buka via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fas
Author: vitalybuka
Date: Wed Sep 20 19:51:56 2017
New Revision: 313856
URL: http://llvm.org/viewvc/llvm-project?rev=313856&view=rev
Log:
Revert "Give external linkage and mangling to lambdas inside inline variables
and variable templates."
To fix: runtime error: load of value 15, which is not a
reverted by r313856
On Wed, Sep 20, 2017 at 6:30 PM, Richard Smith
wrote:
> Thanks, I'll fix this tomorrow; if that's not soon enough, please go ahead
> and revert (or fix by adding a dummy enumerator in lib/AST/Linkage.h).
>
> On 20 Sep 2017 17:39, "Vitaly Buka via cfe-commits" <
> cfe-commits@
ahatanak created this revision.
This patch fixes an infinite loop in IRGen that occurs when compiling the
following code:
void FUNC2() {
static void (^const block1)(int) = ^(int a){
if (a--)
block1(a);
};
When IRGen visits the call to "block1", it knows that it alway
ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
I think this is correct.
https://reviews.llvm.org/D38009
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
101 - 123 of 123 matches
Mail list logo
