[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:26 } throw non_derived_exception(); // Bad + // CHECK-MESSAGES: [[@LINE-1]]:9: warning: throwing an exception whose type 'non_derived_exception' is not derived from 'std::exception'

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

craig.topper created this revision. This patch implements the broadcastf32x2/broadcasti32x2 intrinsics using __builtin_shufflevector. https://reviews.llvm.org/D37287 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avx512dqintrin.h lib/Headers/avx512vldqintrin.h test/CodeGen/avx5

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

aymanmus added a comment. Did you make sure the resulted IR was lowered to the expected X86 instructions? https://reviews.llvm.org/D37287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

craig.topper added a comment. Yes I did. With the other bug fixed they all produced the correct instruction. https://reviews.llvm.org/D37287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] r312102 - [clang-tidy] test commit for granted access

Author: jonastoth Date: Wed Aug 30 00:50:28 2017 New Revision: 312102 URL: http://llvm.org/viewvc/llvm-project?rev=312102&view=rev Log: [clang-tidy] test commit for granted access Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp Modified: clang-tools-extra/tru

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris marked 2 inline comments as done. boris added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:986 +if (Val.find('=') == StringRef::npos) + Opts.ExtraDeps.push_back(Val); + } rsmith wrote: > Does a module file specified via `-fmodu

[PATCH] D37287: [X86] Implement broadcastf32x2 and broadcasti32x2 intrinsics using __builtin_shufflevector instead builtins

aymanmus accepted this revision. aymanmus added a comment. This revision is now accepted and ready to land. LGTM Thanks for the 2 patches. https://reviews.llvm.org/D37287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#856184, @dcoughlin wrote: > In either case, the important scenario I think we should support is choosing > at a call site to a C function the most likely definition of the called > function, based on number and type of parameters, fr

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Did anybody have a chance to review it and/or try it out? Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

r312105 - [modules] Add ability to specify module name to module file mapping

Author: borisk Date: Wed Aug 30 01:45:59 2017 New Revision: 312105 URL: http://llvm.org/viewvc/llvm-project?rev=312105&view=rev Log: [modules] Add ability to specify module name to module file mapping Extend the -fmodule-file option to support the [=] value format. If the name is omitted, then th

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL312105: [modules] Add ability to specify module name to module file mapping (authored by borisk). Changed prior to commit: https://reviews.llvm.org/D35020?vs=111826&id=113207#toc Repository: rL LLVM

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 113206. xazax.hun added a comment. - Added unit test to ensure the produced index format can be parsed. - Added further diagnostics. https://reviews.llvm.org/D34512 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt inclu

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113212. JonasToth marked 2 inline comments as done. JonasToth added a comment. - removing trailing comments https://reviews.llvm.org/D37060 Files: test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-exception-baseclass.cpp ==

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113213. JonasToth added a comment. fix patch, to diff against master again https://reviews.llvm.org/D37060 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-exception-basecl

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113214. JonasToth added a comment. struggling with arc... https://reviews.llvm.org/D37060 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-exception-baseclass.cpp =

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:29 +SourceChangeRefactoringRuleKind, +FindSymbolOccurrencesRefactoringRuleKind + }; I might miss some context here. As per your comment in https://review

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

nevion added a comment. I'm paying attention at least. I updated your patch prior to your posting and temporarily made due with it. I'm pretty nervous that I will lose work with my commit style and the lingering issue. Based on what I've seen so far I can't use the git hooks and so I want to

r312106 - [docs] Regenerate command line options reference

Author: borisk Date: Wed Aug 30 02:15:53 2017 New Revision: 312106 URL: http://llvm.org/viewvc/llvm-project?rev=312106&view=rev Log: [docs] Regenerate command line options reference Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 113217. JonasToth marked 5 inline comments as done. JonasToth added a comment. - fix spelling and grammar errors - adjust unit test to new diagnostics https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcor

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added a comment. addressed some issues, not all yet https://reviews.llvm.org/D36354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:29 +SourceChangeRefactoringRuleKind, +FindSymbolOccurrencesRefactoringRuleKind + }; hokein wrote: > I might miss some context here. As per your comment

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Any news on this? cc @djasper Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + JonasToth wrote: > aaron.ballman wrote: > > JonasToth

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols updated this revision to Diff 113219. rwols added a comment. Tidy up snippet handling - Put CK_Informative chunks in the label - Assert that there's at most one CK_ResultType chunk - CK_CurrentParameter never occurs while collecting completions, only while handling overloads. - For CK_Vert

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer updated this revision to Diff 113218. SjoerdMeijer added a comment. Comments addressed. Thanks for reviewing. https://reviews.llvm.org/D33719 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/BuiltinTypes.def include/clang/Basic/Specifiers.h

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols marked 10 inline comments as done. rwols added a comment. I followed your advice and kept the snippet functionality. We'll do the SignatureHelp stuff in another review. A "major" change is that, because CK_Informative chunks are put into the label now, we have to use the insertText, alway

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman created this revision. Herald added a reviewer: JonasToth. This patch changes the way that the refactoring results are produced. Instead of using different `RefactoringActionRule` subclasses for each result type, we now use a single `RefactoringResultConsumer`. This was suggested by Man

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

NoQ added a comment. In https://reviews.llvm.org/D35216#856093, @rsmith wrote: > The `CXXStdInitializerListExpr` node has pretty simple evaluation semantics: > it takes a glvalue array expression, and constructs a > `std::initializer_list` from it as if by filling in the two members with a > p

[PATCH] D37150: [clangd] Command line arg to specify compile_commands.json path

krasimir added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:89 + // if --compileCommands arg was invoked, check value and override default path + std::size_t found = CompileCommands.find_first_of("/"); + std::string TempString = CompileCommands; -

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman updated this revision to Diff 113222. arphaman added a comment. Fixed a comment Repository: rL LLVM https://reviews.llvm.org/D37291 Files: include/clang/Tooling/Refactoring/RefactoringActionRule.h include/clang/Tooling/Refactoring/RefactoringActionRules.h include/clang/Tooling

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols added a comment. So at this point the C++ changes are basically done, save for some minor things I guess. The problem is still that the VSCode extension doesn't do anything clever with the snippets. I have zero experience with TypeScript let alone extension development for VSCode, so it c

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman updated this revision to Diff 113223. arphaman added a comment. Use `std::move` Repository: rL LLVM https://reviews.llvm.org/D37291 Files: include/clang/Tooling/Refactoring/RefactoringActionRule.h include/clang/Tooling/Refactoring/RefactoringActionRules.h include/clang/Tooling

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

arphaman updated this revision to Diff 113224. arphaman marked an inline comment as done. arphaman added a comment. Herald added a reviewer: JonasToth. This revision now requires review to proceed. Rebase on top of https://reviews.llvm.org/D37291 Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thank you for working on this! I just tried, and the original false-positive i was hitting is now gone. So as far i'm concerned, this is good to go. Comment at: test

r312108 - Revert "Improve constant expression evaluation of arrays of unknown bound."

Author: mboehme Date: Wed Aug 30 03:44:46 2017 New Revision: 312108 URL: http://llvm.org/viewvc/llvm-project?rev=312108&view=rev Log: Revert "Improve constant expression evaluation of arrays of unknown bound." This reverts commit r311970. Breaks internal tests. Modified: cfe/trunk/include/c

r312109 - Add test case that was broken by r311970.

Author: mboehme Date: Wed Aug 30 03:44:51 2017 New Revision: 312109 URL: http://llvm.org/viewvc/llvm-project?rev=312109&view=rev Log: Add test case that was broken by r311970. See also discussion here: https://reviews.llvm.org/rL301963 As far as I can tell, this discussion was never resolved. M

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

lebedev.ri updated this revision to Diff 113226. lebedev.ri added a comment. Rebased. Repository: rL LLVM https://reviews.llvm.org/D36892 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check_clang_tidy.py

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 113228. lebedev.ri added a comment. Rebased. Repository: rL LLVM https://reviews.llvm.org/D36836 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp clang-tidy/readability/FunctionCognitiveCom

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

lebedev.ri updated this revision to Diff 113230. lebedev.ri added a comment. Rebased the correct branch this time... When splitting off https://reviews.llvm.org/D36892, and addressing the other review note in this Revision, i slightly messed up the local branches, so the wrong code got rebased p

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny added a comment. Ping again. https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r312112 - Revert r312105 [modules] Add ability to specify module name to module file mapping

Author: vleschuk Date: Wed Aug 30 04:31:56 2017 New Revision: 312112 URL: http://llvm.org/viewvc/llvm-project?rev=312112&view=rev Log: Revert r312105 [modules] Add ability to specify module name to module file mapping Looks like it breaks win10 builder. Removed: cfe/trunk/test/CXX/modules-t

Re: [PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

Hello Boris, looks like this revision broke tests on our win10 builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/11760 Clang :: CXX/modules-ts/basic/basic.link/module-declaration.cpp I had to revert this revision. Could you please take a look? On

[PATCH] D33852: Enable __declspec(selectany) on linux

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:2477 let Spellings = [Declspec<"selectany">, GCC<"selectany">]; let Documentation = [Undocumented]; } aaron.ballman wrote: > Since we're drastically modifying what platforms this

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

aaron.ballman added a comment. Instead of CHECK-NOTES, do we want to extend CHECK-MESSAGES to handle `note` in addition to `warning` and `error`? I'd prefer to keep the number of "magic" names as low as possible so I have to remember less stuff when writing or reviewing tests. Repository: r

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

aaron.ballman added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + JonasToth wrote: > JonasToth wrote: > > aaron.bal

[PATCH] D37210: [refactor] add a refactoring action rule that returns symbol occurrences

JonasToth resigned from this revision. JonasToth added a comment. This revision is now accepted and ready to land. sry. misconfigured herald :( Repository: rL LLVM https://reviews.llvm.org/D37210 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:54-62 +// CHECK-MESSAGES: [[@LINE-1]]:31: warning: throwing an exception whose type 'bad_generic_exception' is not derived from 'std::exception' +// CHECK-MESSAGES: 71:1: note: type define

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

krasimir added inline comments. Comment at: clangd/ClangdUnit.cpp:302 unsigned NumResults) override { -for (unsigned I = 0; I != NumResults; ++I) { - CodeCompletionResult &Result = Results[I]; - CodeCompletionString *CCS = Result.C

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

JonasToth added a comment. Note can be handled right now as well. E.g. // CHECK-MESSAGES: [[@LINE-2]]:3: note: type deduction did not result in an owner would the patch handle the codelocation correctly? Repository: rL LLVM https://reviews.llvm.org/D36892 _

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth added a comment. @aaron.ballman is it ok for you as well? otherwise i would commit it. https://reviews.llvm.org/D37060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

lebedev.ri added a comment. In https://reviews.llvm.org/D36892#856469, @aaron.ballman wrote: > Instead of CHECK-NOTES, do we want to extend CHECK-MESSAGES to handle `note` > in addition to `warning` and `error`? If i change `CHECK-MESSAGES` to also require all the notes to be checked, a *lot*

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

lebedev.ri added a comment. In https://reviews.llvm.org/D36892#856501, @JonasToth wrote: > Note can be handled right now as well. Yes. Adding this new prefix is about adding `-implicit-check-not=notes`. I.e. if you use `CHECK-MESSAGES`, then it will only enforce you to have check-lines for all

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

JonasToth added a comment. alright. i thought it would do something different, but the enforcement to handle all notes is a good thing. forget what i wrote :) Repository: rL LLVM https://reviews.llvm.org/D36892 ___ cfe-commits mailing list cfe-c

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman added inline comments. Comment at: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp:41 + "'std::exception'") + << BadThrow->getSubExpr()->getType() << BadThrow->getSourceRange(); Can you add a test tha

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

aaron.ballman added a comment. > I do agree that it makes sense to keep it as low as possible, but also i see > a clear logic between all thee current checks: Thank you for the explanation. I think that makes sense to me, but I'd like to hear from @alexfh before accepting. C

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 113246. JonasToth marked 8 inline comments as done. JonasToth added a comment. - added additional testcases, like @aaron.ballman requested - fixed diagnostics https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICP

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-signed-bitwise.cpp:205 + +#if 0 +// Scoped Enums must define their operations, so the overloaded operators must take care aaron.ballman wrote: > I don'

[PATCH] D37140: [clang-format] Fixed one-line if statement

krasimir added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:286 } +if (TheLine->Last->is(tok::l_brace) && +TheLine->First != TheLine->Last && No tests fail if this `if` statement gets removed. Please either remove it or add

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks! LGTM! https://reviews.llvm.org/D36586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp:41 + "'std::exception'") + << BadThrow->getSubExpr()->getType() << BadThrow->getSourceRange();

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113252. JonasToth added a comment. - added inheritance cases, adjusted matcher is required https://reviews.llvm.org/D37060 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp test/clang-tidy/hicpp-exception-baseclass.cpp Index: test/clang-tidy/hicpp-

r312121 - [refactor] Examine the whole range for ObjC @implementation decls

Author: arphaman Date: Wed Aug 30 06:24:37 2017 New Revision: 312121 URL: http://llvm.org/viewvc/llvm-project?rev=312121&view=rev Log: [refactor] Examine the whole range for ObjC @implementation decls when computing the AST selection Modified: cfe/trunk/lib/Tooling/Refactoring/ASTSelection.cp

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman added inline comments. Comment at: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp:41 + "'std::exception'") + << BadThrow->getSubExpr()->getType() << BadThrow->getSourceRange(); JonasToth wrote: > aar

[clang-tools-extra] r312122 - [clang-tidy] hicpp bitwise operations on signed integers

Author: jonastoth Date: Wed Aug 30 06:32:05 2017 New Revision: 312122 URL: http://llvm.org/viewvc/llvm-project?rev=312122&view=rev Log: [clang-tidy] hicpp bitwise operations on signed integers Summary: This check implements the rule [[ http://www.codingstandard.com/section/5-6-shift-operators/ |

[PATCH] D36892: [clang-tidy] check_clang_tidy.py: support CHECK-NOTES prefix

lebedev.ri updated this revision to Diff 113254. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Reword the 'no magic found' error message. Repository: rL LLVM https://reviews.llvm.org/D36892 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

lebedev.ri added a comment. Any status update here? :) I generally do see a benefit in this check, because `-Wcast-align` (at least currently?) does not warn on `reinterpret_cast<>()`. Repository: rL LLVM https://reviews.llvm.org/D33826 ___ cfe-

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols updated this revision to Diff 113258. rwols added a comment. Some more tweaks - Move assert to constructor of CompletionItemsCollector - Use a local variable for the annotations count - Move the documentation handling to its own private const member function https://reviews.llvm.org/D3710

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

lodato added a comment. Sorry, I have been very busy with other work so I haven't had a chance to follow along. (I don't work on LLVM team - I just contributed this script.) I'll try to carve out some time to review within the next week. Repository: rL LLVM https://reviews.llvm.org/D15465

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

Eugene.Zelenko added a comment. In https://reviews.llvm.org/D33826#856610, @lebedev.ri wrote: > Any status update here? :) > I generally do see a benefit in this check, because `-Wcast-align` (at least > currently?) does not warn on `reinterpret_cast<>()`. I think will be good idea to extend

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

lebedev.ri added a comment. In https://reviews.llvm.org/D33826#856619, @Eugene.Zelenko wrote: > In https://reviews.llvm.org/D33826#856610, @lebedev.ri wrote: > > > Any status update here? :) > > I generally do see a benefit in this check, because `-Wcast-align` (at > > least currently?) does no

[PATCH] D15465: [git-clang-format]: New option to perform formatting against staged changes only

Alexander-Shukaev added a comment. Hi @lodato, thanks mate. Repository: rL LLVM https://reviews.llvm.org/D15465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35955: clang-format: Add preprocessor directive indentation

krasimir added a comment. I'll land this for you, as discussed offline. The best thing is to apply for commit rights after you have a few patches landed. https://reviews.llvm.org/D35955 ___

r312124 - Driver: out-of-line static analyzer flag handling (NFC)

Author: compnerd Date: Wed Aug 30 07:18:08 2017 New Revision: 312124 URL: http://llvm.org/viewvc/llvm-project?rev=312124&view=rev Log: Driver: out-of-line static analyzer flag handling (NFC) Extract the analyzer flag handling into its own function to reduce the overall complexity of the construct

r312125 - clang-format: Add preprocessor directive indentation

Author: krasimir Date: Wed Aug 30 07:34:57 2017 New Revision: 312125 URL: http://llvm.org/viewvc/llvm-project?rev=312125&view=rev Log: clang-format: Add preprocessor directive indentation Summary: This is an implementation for [bug 17362](https://bugs.llvm.org/attachment.cgi?bugid=17362) which a

[PATCH] D35955: clang-format: Add preprocessor directive indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rL312125: clang-format: Add preprocessor directive indentation (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D35955?vs=112432&id=113261#toc Repository: rL LLVM https://revi

[PATCH] D33826: [clang-tidy] avoid pointer cast to more strict alignment check

lebedev.ri added a subscriber: rjmccall. lebedev.ri added a comment. In https://reviews.llvm.org/D33826#856619, @Eugene.Zelenko wrote: > In https://reviews.llvm.org/D33826#856610, @lebedev.ri wrote: > > > Any status update here? :) > > I generally do see a benefit in this check, because `-Wcast-

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth marked 3 inline comments as done. JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:9 +class deep_hierarchy : public derived_exception {}; class non_derived_exception {}; aaron.ballman wrote: > JonasToth wrote

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:9 +class deep_hierarchy : public derived_exception {}; class non_derived_exception {}; JonasToth wrote: > aaron.ballman wrote: > > JonasToth wrote: > > > aaron.ballm

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:39 + /// Handles the source replacements that are produced by a refactoring action. + virtual void handle(AtomicChanges SourceReplacements) = 0; +}; I think

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 113265. JonasToth added a comment. - adjusted the diagnostic for member variables https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguide

r312127 - [refactor] AST selection tree should contain syntactic form

Author: arphaman Date: Wed Aug 30 08:00:27 2017 New Revision: 312127 URL: http://llvm.org/viewvc/llvm-project?rev=312127&view=rev Log: [refactor] AST selection tree should contain syntactic form of PseudoObjectExpr The AST selection finder now constructs a selection tree that contains only the sy

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth marked 5 inline comments as done. JonasToth added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:9 +class deep_hierarchy : public derived_exception {}; class non_derived_exception {}; aaron.ballman wrote: > JonasToth wrote

r312131 - Revert r312127 as the ObjC unittest code fails to compile on Linux

Author: arphaman Date: Wed Aug 30 08:11:45 2017 New Revision: 312131 URL: http://llvm.org/viewvc/llvm-project?rev=312131&view=rev Log: Revert r312127 as the ObjC unittest code fails to compile on Linux Modified: cfe/trunk/lib/Tooling/Refactoring/ASTSelection.cpp cfe/trunk/unittests/Toolin

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman added subscribers: sbenza, klimek. aaron.ballman added inline comments. Comment at: test/clang-tidy/hicpp-exception-baseclass.cpp:9 +class deep_hierarchy : public derived_exception {}; class non_derived_exception {}; JonasToth wrote: > aaron.ball

[PATCH] D36410: [OpenCL] Handle taking address of block captures

yaxunl added a comment. In https://reviews.llvm.org/D36410#855358, @bader wrote: > In https://reviews.llvm.org/D36410#855282, @Anastasia wrote: > > > Ok, I will update it to be implicitly generic then. Just to be sure, @bader > > do you agree on this too? > > > > > > An alternative approached co

[PATCH] D37291: [refactor] Use a RefactoringResultConsumer instead of tagged refactoring rule classes

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResultConsumer.h:39 + /// Handles the source replacements that are produced by a refactoring action. + virtual void handle(AtomicChanges SourceReplacements) = 0; +}; ioeri

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D36272#856040, @anatol.pomozov wrote: > Hi Eric, thank you for your reply. Both these triples are currently broken, > with my change and without. > > The at

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

JonasToth updated this revision to Diff 113269. JonasToth marked an inline comment as done. JonasToth added a comment. - adjusted expected diagnostics - adjust diagnostics and remove private inheritance cases https://reviews.llvm.org/D37060 Files: clang-tidy/hicpp/ExceptionBaseclassCheck.cpp

r312132 - Recommit r312127: [refactor] AST selection tree should contain syntactic

Author: arphaman Date: Wed Aug 30 08:28:01 2017 New Revision: 312132 URL: http://llvm.org/viewvc/llvm-project?rev=312132&view=rev Log: Recommit r312127: [refactor] AST selection tree should contain syntactic form of PseudoObjectExpr The new commit adjusts unittest test code compilation options so

[PATCH] D37182: [libcxx] Special visibility macros for the experimental library

mclow.lists added a comment. The reason for building the filesystem library as a statically linked lib (instead of dynamic) is that for quite a while it was changing significantly. Having people link statically means that we can make changes w/o worrying (as much) about people using the librar

r312133 - Avoid 'size_t' typedef in the unittest ObjC code

Author: arphaman Date: Wed Aug 30 08:37:30 2017 New Revision: 312133 URL: http://llvm.org/viewvc/llvm-project?rev=312133&view=rev Log: Avoid 'size_t' typedef in the unittest ObjC code This should fix http://bb.pgr.jp/builders/test-clang-msc-x64-on-i686-linux-RA Modified: cfe/trunk/unittests/

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/cppcoreguidelines-owning-memory.rst:11 +The relevant sections in the `C++ Core Guidelines `_ are I.11, C.33, R.3 and GSL.Views +The

[PATCH] D37299: [Modules] Add ability to specify module name to module file mapping in a file

boris created this revision. Add the -fmodule-file-map=[=] option which can be used to specify a file that contains module name to precompiled modules files mapping, similar to -fmodule-file==. The can be used to only consider certain lines which can be useful if we want to store the mapping i

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth updated this revision to Diff 113272. JonasToth marked 5 inline comments as done. JonasToth added a comment. - fix typos and bad language https://reviews.llvm.org/D36354 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

aaron.ballman added a comment. In https://reviews.llvm.org/D36272#856722, @erichkeane wrote: > In https://reviews.llvm.org/D36272#856040, @anatol.pomozov wrote: > > > Hi Eric, thank you for your reply. Both these triples are currently broken, > > with my change and without. > > > > The attribute

[PATCH] D36354: [clang-tidy] Implement type-based check for `gsl::owner`

JonasToth added a comment. language in the docuementation improved https://reviews.llvm.org/D36354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37060: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! https://reviews.llvm.org/D37060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 113271. hamzasood added a comment. Herald added a subscriber: klimek. Implemented pretty printing and recursive AST visiting (both with appropriate unit tests). The pretty printing implementation includes fixing a few printing bugs (which I needed fixed t

[clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Author: jonastoth Date: Wed Aug 30 08:59:01 2017 New Revision: 312134 URL: http://llvm.org/viewvc/llvm-project?rev=312134&view=rev Log: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better Summary: This patch is a followup to the first revision D36583, that had problems wi

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Hi Jonas, I haven't seen any commit from you (*) fixing the buildbot failures caused by your previous commit (r312122). This has been keeping several bots red for quite a while: http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15/builds/10590 http://lab.llvm.org:8011/builders/clang-x86-windows

  1   2   >