PriMee added a comment.
I merged them just because of their presence in the same bug report... As to
the unit tests, I'll add them as soon as possible.
With reference to `extern` part, once again:
There is no brace wrapping flag that let us control opening brace's position.
In case of other key
NoQ added a comment.
Yeah, `LocAsInteger` is supported very poorly in most places. We can only get
away with it because people rarely cast pointers to integers.
Your reasoning about how `LocAsInteger` works poorly with eg. multiplication or
bitwise operations (consider some sanitizer computing
JonasToth added inline comments.
Comment at: clang-tidy/cppcoreguidelines/OwningMemoryCheck.cpp:294
+
+diag(BadClass->getLocStart(),
+ "class with an 'gsl::owner<>' as member but without declared "
aaron.ballman wrote:
> Instead of diagnosing this on
hamzasood added a comment.
Thanks for all of your feedback! It’s really helped to improve this patch.
Comment at: lib/AST/ExprCXX.cpp:979
+SourceRange LambdaExpr::getExplicitTemplateParameterListRange() const {
+ TemplateParameterList *List = getTemplateParameterList();
alexshap updated this revision to Diff 112784.
alexshap added a comment.
Return UnknownVal for non-comparison operations.
Add FIXME (improve modeling of "pointers as integers").
Repository:
rL LLVM
https://reviews.llvm.org/D37120
Files:
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/
szepet created this revision.
Herald added subscribers: baloghadamsoftware, whisperity.
This way the unrolling can be restricted for loops which will take at most a
given number of steps. It is defined as 128 in this patch and it seems to have
a good number for that purpose.
https://reviews.ll
mgorny updated this revision to Diff 112796.
mgorny added a comment.
Rebased the patch since it no longer applied.
https://reviews.llvm.org/D26796
Files:
lib/Driver/ToolChain.cpp
test/Driver/Inputs/basic_linux_tree/usr/i686-unknown-linux/lib/.keep
test/Driver/Inputs/basic_linux_tree/usr/
compnerd accepted this revision.
compnerd added a comment.
I don't think that there is a guarantee that compiler-rt and clang are upgraded
in lockstep. At least for the builtins, there is a relatively stable
interface. However, I don't think that at this point the Windows MSVC
environment dep
Author: mgorny
Date: Sat Aug 26 14:35:11 2017
New Revision: 311836
URL: http://llvm.org/viewvc/llvm-project?rev=311836&view=rev
Log:
[Driver] Use arch type to find compiler-rt libraries (on Linux)
Use llvm::Triple::getArchTypeName() when looking for compiler-rt
libraries, rather than the exact ar
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311836: [Driver] Use arch type to find compiler-rt libraries
(on Linux) (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26796?vs=112796&id=112800#toc
Repository:
rL LLVM
htt
mgorny added a comment.
Thanks a lot. Let's hope no buildbot complains now ;-).
Repository:
rL LLVM
https://reviews.llvm.org/D26796
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander-Shukaev updated this revision to Diff 112801.
Alexander-Shukaev added a comment.
Alright, so you got me excited about this task once again. Now, I've just
rebased to the latest `git-clang-format` and it has changed a bit.
Nevertheless, I've updated the previous patch accordingly and
Author: faisalv
Date: Sat Aug 26 19:21:21 2017
New Revision: 311839
URL: http://llvm.org/viewvc/llvm-project?rev=311839&view=rev
Log:
Pass the correct object argument when a member call to an 'unrelated' class is
made.
Prior to this patch, clang would do the wrong thing here (see inline comments
Prazek marked 9 inline comments as done.
Prazek added a comment.
Sorry for so late fixes, but it would be good to put it in 5.0
https://reviews.llvm.org/D33852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Prazek updated this revision to Diff 112805.
Prazek added a comment.
remove empty line
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
Index: test/SemaCXX/attr-selectany.cpp
===
Prazek updated this revision to Diff 112804.
Prazek added a comment.
Enable it on every platform
https://reviews.llvm.org/D33852
Files:
include/clang/Basic/Attr.td
test/Sema/attr-selectany.c
test/SemaCXX/attr-selectany.cpp
utils/TableGen/ClangAttrEmitter.cpp
Index: utils/TableGen/Clan
16 matches
Mail list logo
