r311640 - Fixups to FE tests affected by D36793

Author: coby Date: Thu Aug 24 01:47:26 2017 New Revision: 311640 URL: http://llvm.org/viewvc/llvm-project?rev=311640&view=rev Log: Fixups to FE tests affected by D36793 Differential Revision: https://reviews.llvm.org/D36794 Modified: cfe/trunk/test/CodeGen/mozilla-ms-inline-asm.c cfe/tru

[PATCH] D36794: Fixups to FE tests affected by D36793

This revision was automatically updated to reflect the committed changes. Closed by commit rL311640: Fixups to FE tests affected by D36793 (authored by coby). Changed prior to commit: https://reviews.llvm.org/D36794?vs=111340&id=112518#toc Repository: rL LLVM https://reviews.llvm.org/D36794

[PATCH] D37066: [clang-tidy] A follow-up fix of braced-init-list constructors in make-unique check.

hokein updated this revision to Diff 112519. hokein marked an inline comment as done. hokein added a comment. restrict to implicit conversion from std::initializer_list. https://reviews.llvm.org/D37066 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/Inputs/modernize-smart-

r311641 - Revert "[clang-format] Break non-trailing block comments"

Author: krasimir Date: Thu Aug 24 01:55:07 2017 New Revision: 311641 URL: http://llvm.org/viewvc/llvm-project?rev=311641&view=rev Log: Revert "[clang-format] Break non-trailing block comments" This reverts commit r311457. It reveals some dormant bugs in comment reflowing, like breaking a single l

[PATCH] D37066: [clang-tidy] A follow-up fix of braced-init-list constructors in make-unique check.

hokein added inline comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:279 if (const auto *CE = New->getConstructExpr()) { - for (const auto *Arg : CE->arguments()) { -if (llvm::isa(Arg)) { - return false; -} + if (!ast_matche

r311643 - [Clang][x86][Inline Asm] support for GCC style inline asm - Y constraints

Author: coby Date: Thu Aug 24 02:07:34 2017 New Revision: 311643 URL: http://llvm.org/viewvc/llvm-project?rev=311643&view=rev Log: [Clang][x86][Inline Asm] support for GCC style inline asm - Y constraints This patch is intended to enable the use of basic double letter constraints used in GCC ext

[PATCH] D36371: [Clang][x86][Inline Asm] support for GCC style inline asm - Y constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rL311643: [Clang][x86][Inline Asm] support for GCC style inline asm - Y constraints (authored by coby). Changed prior to commit: https://reviews.llvm.org/D36371?vs=111885&id=112521#toc Repository: rL L

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols created this revision. Enhances CompletionItemsCollector in such a way that snippet completions are presented to the client. This is a work-in-progress. It currently works in Sublime Text 3 using the new "LSP" plugin. In VSCode, the snippets are inserted into the buffer as plaintext without

[PATCH] D36075: [refactor] Initial support for refactoring action rules

ioeric added a comment. Thanks for the changes! The code is much clearer. I am wondering if the current design could be extended to support tools (or rules) that use AST matchers? Or is the selection expected to be powerful enough to replace AST matchers? We have a few tools in `clang-tools-ex

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

abeserminji updated this revision to Diff 112534. abeserminji added a comment. Added test //test/Driver/mips-mabs-warning.c// as suggested in comments. Repository: rL LLVM https://reviews.llvm.org/D35982 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticGr

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

ilya-biryukov requested changes to this revision. ilya-biryukov added a comment. This revision now requires changes to proceed. Thanks for taking your time to implement this! We need to add some test cases for new completion features. However, adding them may be a bit of a pain, so feel free to

[PATCH] D37104: [libc++] PR34298: Change std::function constructor and move assignment operator SFINAE checks to allow std::function with an incomplete return type

arphaman created this revision. This patch fixes PR34298 (https://bugs.llvm.org/show_bug.cgi?id=34298). Since Clang changed in r284549, Clang and libc++ prohibit the use of `std::function` with an incomplete return type, like in the example below: struct Continuation { std::function fn;

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResult.h:21 +struct RefactoringResult { + enum ResultKind { +/// A set of source replacements represented using a vector of ioeric wrote: > I'm a bit unsure about the ab

Re: [PATCH] D37090: Implement CFG construction for __finally.

I just realized that this doesn't do the right thing if the try body contains jumps out of the try. That's rare and the CFG is mostly used for warnings, but we should get that right anyhow I suppose. To fix this, I'd probably add a "ActiveFinally" member, and when building a node for a return, I'd

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added a comment. In https://reviews.llvm.org/D36075#851278, @ioeric wrote: > Thanks for the changes! The code is much clearer. > > I am wondering if the current design could be extended to support tools (or > rules) that use AST matchers? Or is the selection expected to be powerful > e

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:26 +template +detail::SourceSelectionRequirement< +typename selection::detail::EvaluateSelectionChecker< ioeric wrote: > Could you help me unde

[clang-tools-extra] r311651 - [clang-tidy] bugprone-undefined-memory-manipulation: include type into the message

Author: alexfh Date: Thu Aug 24 05:11:05 2017 New Revision: 311651 URL: http://llvm.org/viewvc/llvm-project?rev=311651&view=rev Log: [clang-tidy] bugprone-undefined-memory-manipulation: include type into the message Having the actual type in the message helps a lot understanding warnings in tem

[PATCH] D37066: [clang-tidy] A follow-up fix of braced-init-list constructors in make-unique check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! https://reviews.llvm.org/D37066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb added a comment. There are 105 alarms running the checker on the LibreOffice, 92 True positive, 13 not sure. https://reviews.llvm.org/D34275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

mcrosier created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. Clang side of https://reviews.llvm.org/D37081. Chad https://reviews.llvm.org/D37106 Files: test/Driver/aarch64-rdm.c Index: test/Driver/aarch64-rdm.c ==

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

rwols added a comment. Thanks for the quick review! I'm new to Phabricator and the `arc` CLI tool. Is the workflow like this: "address a comment, change a few lines, do `arc diff`, do this multiple times", or is it like this: "address all the comments, change lots of lines, do `arc diff`, do th

[PATCH] D36564: [analyzer] Fix SimpleSValBuilder::simplifySVal

alexfh added a comment. I suspect this might have caused http://llvm.org/PR34309. Could you take a look? Repository: rL LLVM https://reviews.llvm.org/D36564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D37004: [clang-diff] Fix the html output for CXXOperatorCallExpr

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM with one request below: Comment at: tools/clang-diff/ClangDiff.cpp:319 + "A Binary operator is supposed to have two arguments."); +for (int I : {1, 0,

[PATCH] D37066: [clang-tidy] A follow-up fix of braced-init-list constructors in make-unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311652: [clang-tidy] A follow-up fix of braced-init-list constructors in make-unique… (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D37066 Files: clang-tools-extra/trunk/clang-t

[clang-tools-extra] r311652 - [clang-tidy] A follow-up fix of braced-init-list constructors in make-unique check.

Author: hokein Date: Thu Aug 24 06:35:55 2017 New Revision: 311652 URL: http://llvm.org/viewvc/llvm-project?rev=311652&view=rev Log: [clang-tidy] A follow-up fix of braced-init-list constructors in make-unique check. Reviewers: alexfh Reviewed By: alexfh Subscribers: JDevlieghere, xazax.hun, c

[PATCH] D37101: [clangd] [WIP] Add support for snippet completions

ilya-biryukov added a comment. In https://reviews.llvm.org/D37101#851380, @rwols wrote: > Thanks for the quick review! I'm new to Phabricator and the `arc` CLI tool. > Is the workflow like this: "address a comment, change a few lines, do `arc > diff`, do this multiple times", or is it like this

[PATCH] D36564: [analyzer] Fix SimpleSValBuilder::simplifySVal

alexfh added a comment. In https://reviews.llvm.org/D36564#851384, @alexfh wrote: > I suspect this might have caused http://llvm.org/PR34309. Could you take a > look? FYI, PR34309 doesn't reproduce with this patch reverted. Repository: rL LLVM https://reviews.llvm.org/D36564 __

Re: r310887 - [analyzer] Fix SimpleSValBuilder::simplifySVal

This commit causes http://llvm.org/PR34309. Could you take a look? On Mon, Aug 14, 2017 at 11:23 PM, Alexander Shaposhnikov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexshap > Date: Mon Aug 14 14:23:08 2017 > New Revision: 310887 > > URL: http://llvm.org/viewvc/llvm-project?

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko updated this revision to Diff 112547. m.ostapenko added a comment. Ping^4 Repository: rL LLVM https://reviews.llvm.org/D16403 Files: include/clang/Analysis/AnalysisContext.h include/clang/Analysis/CFG.h include/clang/StaticAnalyzer/Core/AnalyzerOptions.h lib/Analysis/Anal

[PATCH] D37003: [clang-diff] Support templates

arphaman added inline comments. Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:299 } +// We want nodes to be in the same order as in the source code. +// So we traverse template parameters before the remainder of the declaration. Interesting, I didn't know that t

[clang-tools-extra] r311654 - [clang-tidy] Add missing IgnoreMacros doc for modernize-use-equals-default.

Author: hokein Date: Thu Aug 24 06:45:18 2017 New Revision: 311654 URL: http://llvm.org/viewvc/llvm-project?rev=311654&view=rev Log: [clang-tidy] Add missing IgnoreMacros doc for modernize-use-equals-default. A followup of rL311136. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/m

Re: [clang-tools-extra] r311654 - [clang-tidy] Add missing IgnoreMacros doc for modernize-use-equals-default.

Thank you! On Thu, Aug 24, 2017 at 3:45 PM, Haojian Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: hokein > Date: Thu Aug 24 06:45:18 2017 > New Revision: 311654 > > URL: http://llvm.org/viewvc/llvm-project?rev=311654&view=rev > Log: > [clang-tidy] Add missing IgnoreMacros doc

r311655 - [refactor] Add the AST source selection component

Author: arphaman Date: Thu Aug 24 06:51:09 2017 New Revision: 311655 URL: http://llvm.org/viewvc/llvm-project?rev=311655&view=rev Log: [refactor] Add the AST source selection component This commit adds the base AST source selection component to the refactoring library. AST selection is represente

[PATCH] D35012: [refactor] Add the AST source selection component

This revision was automatically updated to reflect the committed changes. Closed by commit rL311655: [refactor] Add the AST source selection component (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D35012?vs=108078&id=112550#toc Repository: rL LLVM https://reviews

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

aaron.ballman added inline comments. Comment at: lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:19 +// of casting an integer value that is out of range +//===--===// + If this check

r311656 - Add missing std::move call

Author: arphaman Date: Thu Aug 24 07:08:18 2017 New Revision: 311656 URL: http://llvm.org/viewvc/llvm-project?rev=311656&view=rev Log: Add missing std::move call This should fix http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental_build/41578/ Modified: cfe/trunk/lib/Tooling

[PATCH] D36564: [analyzer] Fix SimpleSValBuilder::simplifySVal

NoQ added a comment. I see, it seems that we've constructed `$x - 1` somewhere, where `$x` is a pointer, while such stuff normally looks as `&element{SymRegion{$x}, -1}`. I guess i'd have to take a more careful look at it soon. Repository: rL LLVM https://reviews.llvm.org/D36564

[PATCH] D37109: [clang-format] Emit absolute splits before lines for comments, try 2

krasimir created this revision. Herald added a subscriber: klimek. This recommits https://reviews.llvm.org/D36956 with an update to the added test case to not use raw string literals, since this makes gcc unhappy. https://reviews.llvm.org/D37109 Files: lib/Format/BreakableToken.cpp unittest

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks for fixing this. https://reviews.llvm.org/D37106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D37109: [clang-format] Emit absolute splits before lines for comments, try 2

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Does the test still test the same thing if you set the column limit to 60 and remove 20 spaces? If not, this is fine. https://reviews.llvm.org/D37109

[PATCH] D37109: [clang-format] Emit absolute splits before lines for comments, try 2

krasimir added a comment. @djasper: No. The test case is a special constellation. https://reviews.llvm.org/D37109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r311660 - [Driver][AArch64] Add tests for RDM feature.

Author: mcrosier Date: Thu Aug 24 07:32:55 2017 New Revision: 311660 URL: http://llvm.org/viewvc/llvm-project?rev=311660&view=rev Log: [Driver][AArch64] Add tests for RDM feature. Differential Revision: https://reviews.llvm.org/D37106 Added: cfe/trunk/test/Driver/aarch64-rdm.c Added: cfe/tr

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311660: [Driver][AArch64] Add tests for RDM feature. (authored by mcrosier). Changed prior to commit: https://reviews.llvm.org/D37106?vs=112543&id=112559#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. All right then, i approve! > There are 105 alarms running the checker on the LibreOffice, 92 True > positive, 13 not sure. That's impressively loud. I guess you can try reporting some of the bugs y

[PATCH] D35012: [refactor] Add the AST source selection component

krasimir added a comment. The test `CursorAtStartOfFunction` is segfaulting. Repository: rL LLVM https://reviews.llvm.org/D35012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r311664 - Fix use-after-free in Clang's ASTSelection unittest

Author: arphaman Date: Thu Aug 24 07:53:48 2017 New Revision: 311664 URL: http://llvm.org/viewvc/llvm-project?rev=311664&view=rev Log: Fix use-after-free in Clang's ASTSelection unittest Modified: cfe/trunk/unittests/Tooling/ASTSelectionTest.cpp Modified: cfe/trunk/unittests/Tooling/ASTSelec

[PATCH] D35955: clang-format: Add preprocessor directive indentation

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. From my side this looks good for now (we can always improve more later). Krasimir, what do you think? https://reviews.llvm.org/D35955 ___ cfe-

[PATCH] D35012: [refactor] Add the AST source selection component

arphaman added a comment. r311664 Repository: rL LLVM https://reviews.llvm.org/D35012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35955: clang-format: Add preprocessor directive indentation

krasimir added a comment. Thank you! I understand this patch better now. Looks good from my side! https://reviews.llvm.org/D35955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman updated this revision to Diff 112566. arphaman marked 2 inline comments as done. arphaman added a comment. - Rename `detail` to `internal`. - Remove the `BaseSpecializedRule`. - Simplify selection requirement and constraint evaluation. Repository: rL LLVM https://reviews.llvm.org/D36

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

mcrosier added a comment. In https://reviews.llvm.org/D37106#851441, @SjoerdMeijer wrote: > Thanks for fixing this. np! Thanks for the review! Repository: rL LLVM https://reviews.llvm.org/D37106 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added a comment. I'm glad this is finally in a state to land. Thanks for the helpful reviews! https://reviews.llvm.org/D35955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth added inline comments. Comment at: clang-tidy/hicpp/SignedBitwiseCheck.cpp:23 + const auto SignedIntegerOperand = + expr(ignoringImpCasts(hasType(isSignedInteger(.bind("signed_operand"); + aaron.ballman wrote: > JonasToth wrote: > > aaron.bal

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

ahatanak added a comment. In https://reviews.llvm.org/D36915#849622, @faisalv wrote: > I don't think this approach is entirely correct for at least the following > reasons: > > 1. in the lambda case the machinery that diagnoses capture failures should be > the machinery erroring on the lambda (

r311669 - [mips] Introducing option -mabs=[legacy/2008]

Author: petarj Date: Thu Aug 24 09:06:30 2017 New Revision: 311669 URL: http://llvm.org/viewvc/llvm-project?rev=311669&view=rev Log: [mips] Introducing option -mabs=[legacy/2008] In patch r205628 using abs.[ds] instruction is forced, as they should behave in accordance with flags Has2008 and ABS2

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

This revision was automatically updated to reflect the committed changes. Closed by commit rL311669: [mips] Introducing option -mabs=[legacy/2008] (authored by petarj). Changed prior to commit: https://reviews.llvm.org/D35982?vs=112534&id=112571#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 112572. JonasToth added a comment. - get up to date with master - added testcase for enums https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-ti

[PATCH] D36586: [clang-tidy] hicpp bitwise operations on signed integers

JonasToth updated this revision to Diff 112573. JonasToth added a comment. - fix indendation in testcase https://reviews.llvm.org/D36586 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tidy/hicpp/SignedBitwiseChec

[PATCH] D31370: [clang-tidy] Prototype to check for exception specification

JonasToth abandoned this revision. JonasToth added a comment. exception checking seems to end in the front end for such cases, so nothing to do here anymore. reimplement if there is need later. Repository: rL LLVM https://reviews.llvm.org/D31370 ___

[PATCH] D36075: [refactor] Initial support for refactoring action rules

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:26 +template +detail::SourceSelectionRequirement< +typename selection::detail::EvaluateSelectionChecker< arphaman wrote: > ioeric wrote: > > Coul

Re: r311601 - Fix a bug in CGDebugInfo::EmitInlineFunctionStart causing DILocations to be

Merged to 5.0 in r311671. On Wed, Aug 23, 2017 at 2:24 PM, Adrian Prantl via cfe-commits wrote: > Author: adrian > Date: Wed Aug 23 14:24:12 2017 > New Revision: 311601 > > URL: http://llvm.org/viewvc/llvm-project?rev=311601&view=rev > Log: > Fix a bug in CGDebugInfo::EmitInlineFunctionStart caus

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112574. danielcdh marked 2 inline comments as done. danielcdh added a comment. updated the patch to put it into function attribute so that it works with ThinLTO https://reviews.llvm.org/D37091 Files: docs/ClangCommandLineReference.rst include/clang/D

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringResult.h:21 +struct RefactoringResult { + enum ResultKind { +/// A set of source replacements represented using a vector of ioeric wrote: > arphaman wrote: > > ioeric wr

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/SourceSelectionConstraints.cpp:13 + +using namespace clang; +using namespace tooling; ioeric wrote: > We are tempted to avoid `using namespace` if possible. Why? It's not in a header. `using nam

r311672 - [clang-format] Emit absolute splits before lines for comments, try 2

Author: krasimir Date: Thu Aug 24 09:41:10 2017 New Revision: 311672 URL: http://llvm.org/viewvc/llvm-project?rev=311672&view=rev Log: [clang-format] Emit absolute splits before lines for comments, try 2 Summary: This recommits https://reviews.llvm.org/D36956 with an update to the added test case

[PATCH] D37109: [clang-format] Emit absolute splits before lines for comments, try 2

This revision was automatically updated to reflect the committed changes. Closed by commit rL311672: [clang-format] Emit absolute splits before lines for comments, try 2 (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D37109 Files: cfe/trunk/lib/Format/BreakableToken.cp

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

davidxl added a comment. Looks fine to me, but please wait for Richard's comment. https://reviews.llvm.org/D37091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37090: Implement CFG construction for __finally.

rnk added a comment. Re: jumps out of __try, I wonder if you can tie __finally into whatever the CFG does for C++ destructors. Comment at: test/Sema/warn-unreachable-ms.c:49 __try { - f(); + throw 1; } __except (1) { Nice. Would any noreteu

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

rnk added inline comments. Comment at: lib/Lex/Lexer.cpp:3076-3077 case '\r': +if (CurPtr[0] != Char && (CurPtr[0] == '\n' || CurPtr[0] == '\r')) + Char = getAndAdvanceChar(CurPtr, Result); // If we are inside a preprocessor directive and we see the end of line,

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

erichkeane added inline comments. Comment at: lib/Lex/Lexer.cpp:3076-3077 case '\r': +if (CurPtr[0] != Char && (CurPtr[0] == '\n' || CurPtr[0] == '\r')) + Char = getAndAdvanceChar(CurPtr, Result); // If we are inside a preprocessor directive and we see the end of

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

Hi Richard, It looks like this revision is breaking the x86_64-linux-bootstrap bot . Most of the UBSan checks are failing with the attached error. Full log at: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-b

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Mind doing the diff with -U9 so I can see TargetInfo.cpp with the full context? Repository: rL LLVM https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

rnk added inline comments. Comment at: lib/Lex/Lexer.cpp:3076-3077 case '\r': +if (CurPtr[0] != Char && (CurPtr[0] == '\n' || CurPtr[0] == '\r')) + Char = getAndAdvanceChar(CurPtr, Result); // If we are inside a preprocessor directive and we see the end of line,

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

erichkeane updated this revision to Diff 112581. erichkeane added a comment. Switched to simply \r\n instead of both cases. This fixes the issue, is likely faster (important, since this is a performance critical part of code), and a smaller-hammer. https://reviews.llvm.org/D37079 Files: li

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

erichkeane marked 2 inline comments as done. erichkeane added a comment. Decided there were a few additional advantages to just handling \r\n, so Added them. https://reviews.llvm.org/D37079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D37079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov updated this revision to Diff 112582. https://reviews.llvm.org/D36272 Files: include/clang/Basic/Attr.td lib/CodeGen/TargetInfo.cpp test/CodeGen/function-attributes.c Index: test/CodeGen/function-attributes.c =

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Erich, done. I also rerun tests and this time they are green. https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36564: [analyzer] Fix SimpleSValBuilder::simplifySVal

alexshap added a comment. @alexfh, thanks for letting me know, i will take a closer look at https://bugs.llvm.org/show_bug.cgi?id=34309 soon. Repository: rL LLVM https://reviews.llvm.org/D36564 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Are we SURE the stack alignment for this type is supposed to be 16 bit as well? I didn't see any discussion about it in the email conversation. I have very little understanding of this attribute, but I would (perhaps naiively) presume that it would be different on 6

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

It looks like this broke / found errors on the green dragon bot: http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_check/4115/consoleFull#15752874848254eaf0-7326-4999-85b0-388101f2d404 TEST 'LLVM-Unit :: ADT/./ADTTests/FilterIteratorTest.FunctionPointer' FAILED **

[PATCH] D36501: add flag to undo ABI change in r310401

rsmith added a comment. In https://reviews.llvm.org/D36501#836257, @rjmccall wrote: > Yeah, I think having an internal C++ ABI version makes a lot more sense than > having a million different flags. Is there a reason to expose this as a knob > to users at all? I don't see any reason anyone w

Re: r298574 - Fix issues in clang-format's AlignConsecutive modes.

For reference, this was reviewed in https://reviews.llvm.org/D21279 (Please always include review links in the future.) On Wed, Mar 22, 2017 at 7:51 PM, Nikola Smiljanic via cfe-commits wrote: > Author: nikola > Date: Wed Mar 22 21:51:25 2017 > New Revision: 298574 > > URL: http://llvm.org/viewv

[PATCH] D36075: [refactor] Initial support for refactoring action rules

alexshap added a comment. @arphaman The selection requirement is supposed to be orthogonal to AST matchers, not a replacement. It should be used when working with source selection in editors. I did mess around with moving over clang-reorder-fields using this kind of model and didn't see an

r311680 - Revert "[ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this'

Author: adrian Date: Thu Aug 24 11:18:24 2017 New Revision: 311680 URL: http://llvm.org/viewvc/llvm-project?rev=311680&view=rev Log: Revert "[ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the

Re: r311589 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' poin

I temporarily reverted the commit in r311680 to get the bots going again. -- adrian > On Aug 24, 2017, at 11:12 AM, Adrian Prantl via cfe-commits > wrote: > > It looks like this broke / found errors on the green dragon bot: > > http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_chec

[PATCH] D37115: [coroutines] Do not attempt to typo-correct when coroutine is looking for required members

GorNishanov created this revision. When SemaCoroutine looks for await_resume, it means it. No need for helpful: "Did you mean await_ready?" messages. Fixes PR33477 and a couple of FIXMEs in test/SemaCXX/coroutines.cpp https://reviews.llvm.org/D37115 Files: lib/Sema/SemaCoroutine.cpp test/

r311683 - [Preprocessor] Correct internal token parsing of newline characters in CRLF

Author: erichkeane Date: Thu Aug 24 11:36:07 2017 New Revision: 311683 URL: http://llvm.org/viewvc/llvm-project?rev=311683&view=rev Log: [Preprocessor] Correct internal token parsing of newline characters in CRLF Discovered due to a goofy git setup, the test system-headerline-directive.c (and a

[PATCH] D37079: [Preprocessor] Correct internal token parsing of newline characters in CRLF

This revision was automatically updated to reflect the committed changes. Closed by commit rL311683: [Preprocessor] Correct internal token parsing of newline characters in CRLF (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D37079?vs=112581&id=112589#toc Repository

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. Related maillist discussion is http://lists.llvm.org/pipermail/cfe-dev/2017-June/054359.html > Are we SURE the stack alignment for this type is supposed to be 16 bit as > well? I didn't see any discussion about it in the email conversation. > I have very little

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

anatol.pomozov added a comment. > Additionally, there is likely value to split the test run-line into 2, one > that specifies 64 bit Windows and one that is 64 bit Linux. The value being > that they validate two different code paths (whereas 32 is the same code > path). I added a RUN for trip

Re: r298574 - Fix issues in clang-format's AlignConsecutive modes.

This caused https://bugs.llvm.org/show_bug.cgi?id=33507 which is one of the last release blockers for 5.0.0. Can someone who's familiar with this code please take a look? On Thu, Aug 24, 2017 at 11:12 AM, Hans Wennborg wrote: > For reference, this was reviewed in https://reviews.llvm.org/D21279

[PATCH] D36272: [CodeGen][x86_64] Enable 'force_align_arg_pointer' attribute at x86_64

erichkeane added a comment. Aaron would likely know better than me... but could it be the spelling type should be GCC instead of GNU? https://reviews.llvm.org/D36272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

rsmith added inline comments. Comment at: docs/ClangCommandLineReference.rst:173-180 +.. option:: -faccurate-sample-profile, -fno-accurate-sample-profile +.. program:: clang + +If the sample profile is accurate, callsites without profile samples are marked +as cold. Otherwise, tr

[PATCH] D36501: add flag to undo ABI change in r310401

probinson added a comment. Locally we have a couple different tactics for dealing with changes that we can't support. A more coherent approach would be great. For example we defined a new TargetCXXABI::Kind value that is mostly GenericItaniumABI except where it isn't. I personally did not do mo

Re: [PATCH] D36501: add flag to undo ABI change in r310401

On 24 August 2017 at 12:24, Paul Robinson via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > probinson added a comment. > > Locally we have a couple different tactics for dealing with changes that > we can't support. A more coherent approach would be great. > For example we de

[PATCH] D34367: CodeGen: Fix address space of indirect function argument

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGCall.cpp:3832 + "indirect-arg-temp"); +IRCallArgs[FirstIRArg] = CastToAllocaAddrSpace(Addr.getPointer()); rjmccall wrote

Re: [PATCH] D36501: add flag to undo ABI change in r310401

> On Aug 24, 2017, at 3:48 PM, Richard Smith wrote: > On 24 August 2017 at 12:24, Paul Robinson via Phabricator via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > probinson added a comment. > > Locally we have a couple different tactics for dealing with changes that we > can't suppo

r311695 - [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the captured enclosing 'this' pointer

Author: rsmith Date: Thu Aug 24 13:10:33 2017 New Revision: 311695 URL: http://llvm.org/viewvc/llvm-project?rev=311695&view=rev Log: [ubsan] PR34266: When sanitizing the 'this' value for a member function that happens to be a lambda call operator, use the lambda's 'this' pointer, not the capture

[PATCH] D37091: Expose -mllvm -accurate-sample-profile to clang.

danielcdh updated this revision to Diff 112597. danielcdh marked 3 inline comments as done. danielcdh added a comment. update https://reviews.llvm.org/D37091 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp lib/Driver/ToolC

  1   2   >