ilya-biryukov added a comment.
The function in `ClangdServer` seems to be getting more complicated and more
complicated, mostly because of mixing up `std::string`, `StringRef`,
`SmallString`.
Here's a slightly revamped implementation of your function, hope you'll find it
(or parts of it) useful
dkrupp added a subscriber: zaks.anna.
dkrupp added a comment.
The creation of this library (libCrossTU) is approved for importing function
definitions. @zaks.anna, @NoQ , @klimek could you please help us reviewing the
code itself?
Then, when this is approved, we could progress with the review
Author: sam_parker
Date: Mon Aug 21 01:52:45 2017
New Revision: 311319
URL: http://llvm.org/viewvc/llvm-project?rev=311319&view=rev
Log:
[ARM][AArch64] Cortex-A75 and Cortex-A55 tests
Add frontend tests for Cortex-A75 and Cortex-A55, Arm's latest
big.LITTLE A-class cores. They implement the ARMv8
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311319: [ARM][AArch64] Cortex-A75 and Cortex-A55 tests
(authored by sam_parker).
Changed prior to commit:
https://reviews.llvm.org/D36731?vs=111664&id=111940#toc
Repository:
rL LLVM
https://reviews.
krasimir added a comment.
ping
https://reviews.llvm.org/D36614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
olista01 added reviewers: rnk, niravd, SjoerdMeijer.
olista01 added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D3
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me.
Repository:
rL LLVM
https://reviews.llvm.org/D3
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: olista01
Date: Mon Aug 21 02:54:46 2017
New Revision: 311325
URL: http://llvm.org/viewvc/llvm-project?rev=311325&view=rev
Log:
[ObjC] Use consistent comment style in inline asm
The comment markers accepted by the assembler vary between different targets,
but '//' is always accepted, so we
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311325: [ObjC] Use consistent comment style in inline asm
(authored by olista01).
Changed prior to commit:
https://reviews.llvm.org/D3?vs=110927&id=111942#toc
Repository:
rL LLVM
https://reviews
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This looks good to me.
https://reviews.llvm.org/D36872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D36821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks.
You should obtain commit access if you haven't already done so
(https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access). I can
commit this on your behalf as well
schroedersi added a comment.
Ping :)
https://reviews.llvm.org/D30946
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
faisalv added a comment.
In regards to representing this in the AST - I think (based on precedence) that
the number of explicit template parameters should be stored in
LambdaDefinitionData - and the interface exposed through LambdaExpr (where the
source information of the template parameter lis
Anastasia created this revision.
Added release notes describing committed functionality for OpenCL in release
5.0.
https://reviews.llvm.org/D36951
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseN
hamzasood marked 5 inline comments as done.
hamzasood added a comment.
So to clarify: NumExplicitTemplateParams should be stored in
LambdaDefinitionData (with an accessor in LambdaExpr) and
ExplicitTemplateParamRange (SourceRange) should be stored in LambdaExpr?
That makes sense, but doesn't see
bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM, except one nit.
Comment at: docs/ReleaseNotes.rst:146
+- Extended Clang builtins with required ``cl_khr_subgroups`` support.
+- Now interpreting empty argument function
Author: ibiryukov
Date: Mon Aug 21 05:03:08 2017
New Revision: 311330
URL: http://llvm.org/viewvc/llvm-project?rev=311330&view=rev
Log:
Fixed a crash on replaying Preamble's PP conditional stack.
Summary:
The crash occurs when the first token after a preamble is a macro
expansion.
Fixed by moving
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311330: Fixed a crash on replaying Preamble's PP conditional
stack. (authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36872
Files:
cfe/trunk/include/clang/Lex/Preprocessor.h
c
jklaehn added a comment.
In https://reviews.llvm.org/D35271#809159, @vsk wrote:
> I wonder if it's possible to do away with the calls to 'updated()'... it
> seems strange that we initialize the same preprocessor repeatedly. Is there
> any way to finalize an ASTInfoCollector after ReadAST happen
arphaman added inline comments.
Comment at: lib/CodeGen/CGExprComplex.cpp:156
+auto Constant = tryEmitDeclRefOrMemberExprAsConstant(
+ME, ME->getMemberDecl(), /*AllowSideEffects=*/true);
+if (Constant) {
rsmith wrote:
> If we can (correctly) allow
arphaman updated this revision to Diff 111956.
arphaman marked an inline comment as done.
arphaman added a comment.
- Get rid of the `AllowSideEffects` argument.
- Get rid of the old integer field evaluation code.
Repository:
rL LLVM
https://reviews.llvm.org/D36876
Files:
lib/CodeGen/CGExp
jklaehn created this revision.
jklaehn added a project: clang.
This patch allows checking whether a C++ record declaration is abstract through
libclang and clang.cindex (Python).
https://reviews.llvm.org/D36952
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor
jklaehn created this revision.
jklaehn added a project: clang.
Previously the `_tu` was not propagated to the returned cursor, leading to
errors when calling any
method on that cursor (e.g. `cursor.referenced`).
https://reviews.llvm.org/D36953
Files:
bindings/python/clang/cindex.py
binding
faisalv added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:1116
+ if (HasExplicitTemplateParams) {
+SmallVector TemplateParams;
+SourceLocation LAngleLoc, RAngleLoc;
hamzasood wrote:
> faisalv wrote:
> > Why not Just use/pass LSI->TemplatePara
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
https://reviews.llvm.org/D36951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
To Whom It May Concern,
I am writing in reference to a patch I created in response to the bug I have
decided to work on.
Bug comes from the official site:
https://bugs.llvm.org/show_bug.cgi?id=34001
Short overview:
Clang-format bug resulting in a strange behavior of control statements s
sdardis created this revision.
Add notes on this to the C language section, along with the C++ section.
https://reviews.llvm.org/D36954
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
===
--- docs/ReleaseNotes.rst
+++
jklaehn created this revision.
jklaehn added a project: clang.
Previously, `VisitAttributes` was not called for function and class templates
and thus their attributes were not accessible using libclang.
https://reviews.llvm.org/D36955
Files:
bindings/python/tests/cindex/test_cursor.py
tool
krasimir created this revision.
Herald added a subscriber: klimek.
This patch makes the splits emitted for the beginning of comment lines during
reformatting absolute. Previously, they were relative to the start of the
non-whitespace content of the line, which messes up further TailOffset
calculat
hamzasood added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:1116
+ if (HasExplicitTemplateParams) {
+SmallVector TemplateParams;
+SourceLocation LAngleLoc, RAngleLoc;
faisalv wrote:
> hamzasood wrote:
> > faisalv wrote:
> > > Why not Just use
NoQ added a comment.
Tests are still not working - they pass now, but they don't actually test
anything. Please make sure that tests actually work. Which means that
1. Tests pass when you run `make -j4 check-clang-analysis`;
2. Tests start failing when you change your code or expected-warning di
nik added a reviewer: hans.
nik added a comment.
I see this in trunk/master submitted, but not in the release_50 branch. Could
this be cherry-picked to 5.0?
Repository:
rL LLVM
https://reviews.llvm.org/D36872
___
cfe-commits mailing list
cfe-com
nik added a reviewer: erikjv.
nik added a comment.
Please submit as I do not have the necessary permissions.
https://reviews.llvm.org/D36821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
NoQ added a comment.
Most importantly, do you think we can enable the checker by default now? Was
this checker evaluated on any large codebase, and if so, how many true/false
positives did it find, probably compared to the old checker?
https://reviews.llvm.org/D34275
___
Author: atanasyan
Date: Mon Aug 21 07:08:29 2017
New Revision: 311334
URL: http://llvm.org/viewvc/llvm-project?rev=311334&view=rev
Log:
[mips] Remove checking of the redundant condition. NFC
Modified:
cfe/trunk/lib/Driver/ToolChains/Arch/Mips.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Arc
faisalv added inline comments.
Comment at: lib/Sema/SemaLambda.cpp:858
+KnownDependent = CurScope->getTemplateParamParent() != nullptr;
+ }
hamzasood wrote:
> faisalv wrote:
> > Hmm - now that you drew my attention to this ;) - I'm pretty sure this is
> >
faisalv added inline comments.
Comment at: lib/Parse/ParseExprCXX.cpp:1116
+ if (HasExplicitTemplateParams) {
+SmallVector TemplateParams;
+SourceLocation LAngleLoc, RAngleLoc;
hamzasood wrote:
> faisalv wrote:
> > hamzasood wrote:
> > > faisalv wrote:
>
anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D36949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
arphaman created this revision.
Clang's `DiagnosticOr` type mimics the `Expected` type from LLVM. It either
stores a partial diagnostic and its location or a value. I'll be using in
https://reviews.llvm.org/D36075.
Repository:
rL LLVM
https://reviews.llvm.org/D36969
Files:
include/clang/
arphaman added a comment.
Extracted `DiagnosticOr` to a separate patch at https://reviews.llvm.org/D36969.
I will update this patch tomorrow.
Repository:
rL LLVM
https://reviews.llvm.org/D36075
___
cfe-commits mailing list
cfe-commits@lists.llvm
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LG
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:371
+ std::string ContextPrefix;
+ if (auto *Namespace = dyn_cast(Context))
+ContextPrefix = Namespace->getQualifiedN
Anastasia added inline comments.
Comment at: docs/ReleaseNotes.rst:146
+- Extended Clang builtins with required ``cl_khr_subgroups`` support.
+- Now interpreting empty argument function as void argument list in OpenCL
code.
+- Add ``intel_reqd_sub_group_size`` attribute suppo
Hello,
Do we have time to merge this change into release 5.0.0? It's an
assertion failure fix, which shows up on C++ code involving
double-inheritance with empty base classes.
Artem.
On 8/18/17 9:20 PM, Alexander Shaposhnikov via cfe-commits wrote:
Author: alexshap
Date: Fri Aug 18 11:20:43
Author: szepet
Date: Mon Aug 21 09:10:19 2017
New Revision: 311344
URL: http://llvm.org/viewvc/llvm-project?rev=311344&view=rev
Log:
[StaticAnalyzer] Handle LoopExit CFGElement in the analyzer
This patch adds handling of the LoopExit CFGElements to the StaticAnalyzer.
This is reached by introduci
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311344: [StaticAnalyzer] Handle LoopExit CFGElement in the
analyzer (authored by szepet).
Changed prior to commit:
https://reviews.llvm.org/D35670?vs=110981&id=111993#toc
Repository:
rL LLVM
https:/
Author: morehouse
Date: Mon Aug 21 09:18:43 2017
New Revision: 311345
URL: http://llvm.org/viewvc/llvm-project?rev=311345&view=rev
Log:
[clang-proto-fuzzer] Update README.
Add instructions on how to modify the compiler invocation.
Modified:
cfe/trunk/tools/clang-fuzzer/README.txt
Modified:
DIVYA updated this revision to Diff 111998.
DIVYA added a comment.
- added test qsort_worst_uint32 in algorithm.bench.cpp
https://reviews.llvm.org/D36423
Files:
benchmarks/GenerateInput.hpp
benchmarks/algorithms.bench.cpp
include/algorithm
Index: include/algorithm
===
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D36931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: szepet
Date: Mon Aug 21 09:32:57 2017
New Revision: 311346
URL: http://llvm.org/viewvc/llvm-project?rev=311346&view=rev
Log:
[StaticAnalyzer] LoopUnrolling: Track a LoopStack in order to completely unroll
specific loops
The LoopExit CFG information provides the opportunity to not mark th
rnk added a comment.
> Don't add any EH edges to the CFG for SEH. In practice, BuildOpts.AddEHEdges
> is always false in practice from what I can tell, and with SEH every single
> stmt would have to get an EH edge.
Since we can't mix C++ EH and SEH, do you think it would be better to reuse the
Author: lenary
Date: Mon Aug 21 09:40:35 2017
New Revision: 311347
URL: http://llvm.org/viewvc/llvm-project?rev=311347&view=rev
Log:
[clang] Fix tests for Emitting Single Inline Remark
Summary: This change depends on https://reviews.llvm.org/D36054 and should be
landed at the same time.
Reviewe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311347: [clang] Fix tests for Emitting Single Inline Remark
(authored by lenary).
Repository:
rL LLVM
https://reviews.llvm.org/D36949
Files:
cfe/trunk/test/Frontend/optimization-remark-with-hotness.
On Mon, Aug 21, 2017 at 12:41 PM, Reid Kleckner via Phabricator via
cfe-commits wrote:
> rnk added a comment.
>
> > Don't add any EH edges to the CFG for SEH. In practice,
> BuildOpts.AddEHEdges is always false in practice from what I can tell, and
> with SEH every single stmt would have to get a
hintonda added a comment.
I've submitted a patch, https://reviews.llvm.org/D36971, that moves
find_first_existing_file and
find_first_existing_vc_file to ADDLLVM so they can be reused here. If that
patch is accepted and lands,
you can then remove these versions and check to see if that solves
thakis added inline comments.
Comment at: lib/Analysis/CFG.cpp:448
+BuildOpts(buildOpts), switchExclusivelyCovered(false),
+switchCond(nullptr), cachedEntry(nullptr), lastLookup(nullptr) {}
(this is now a no-op and only a clang-formatting of the
thakis updated this revision to Diff 112015.
thakis edited the summary of this revision.
thakis added a comment.
Just use TryTerminatedBlock
https://reviews.llvm.org/D36914
Files:
lib/Analysis/CFG.cpp
test/Sema/warn-unreachable-ms.c
Index: test/Sema/warn-unreachable-ms.c
==
hamzasood updated this revision to Diff 112018.
hamzasood added a comment.
- Info about a lambda's explicit template parameters is now exposed in the AST
(see changes to LambdaExpr). It turns out that no extra storage was actually
needed to achieve this.
- Removed remnants of a previous implemen
On Fri, Aug 18, 2017 at 5:22 PM, Dehao Chen wrote:
> On Fri, Aug 18, 2017 at 2:46 PM, Hans Wennborg wrote:
>>
>> Should we mention this in the release notes?
>>
>>
>> Is the flag documented somewhere?
>
>
> It's documented in the Options.td file, do you think there are other
> documents that need
vsk added a comment.
Would it be more convenient to extend ErrorInfo instead of creating a new
diagnostic wrapper? E.g one benefit of passing around Expected's is that
there's some assurance the diagnostics will be reported.
Repository:
rL LLVM
https://reviews.llvm.org/D36969
___
jklaehn created this revision.
jklaehn added a project: clang.
This patch allows checking the availability of cursors through libclang and
clang.cindex (Python).
This e.g. allows to check whether a C++ member function has been marked as
deleted.
https://reviews.llvm.org/D36973
Files:
bindin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311359: Update Clang 5.0 release notes for ms_abi and
__builtin_ms_va_list for aarch64 (authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D36931?vs=111857&id=112022#toc
Repositor
vsk added a comment.
In https://reviews.llvm.org/D35271#847306, @jklaehn wrote:
> In https://reviews.llvm.org/D35271#809159, @vsk wrote:
>
> > I wonder if it's possible to do away with the calls to 'updated()'... it
> > seems strange that we initialize the same preprocessor repeatedly. Is there
Author: kamil
Date: Mon Aug 21 12:12:14 2017
New Revision: 311365
URL: http://llvm.org/viewvc/llvm-project?rev=311365&view=rev
Log:
Enable libfuzzer on NetBSD/amd64
Summary:
Enable SanitizerKind::Fuzzer and SanitizerKind::FuzzerNoLink on x86_64.
Sponsored by
Reviewers: joerg, kcc, vitalybuka,
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm, please commit to the 5.0 branch
https://reviews.llvm.org/D36954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Nikolai suggested this should be merged to 5.0. Richard, what do you think?
On Mon, Aug 21, 2017 at 5:03 AM, Ilya Biryukov via cfe-commits
wrote:
> Author: ibiryukov
> Date: Mon Aug 21 05:03:08 2017
> New Revision: 311330
>
> URL: http://llvm.org/viewvc/llvm-project?rev=311330&view=rev
> Log:
> F
hans added a comment.
In https://reviews.llvm.org/D36872#847416, @nik wrote:
> I see this in trunk/master submitted, but not in the release_50 branch. Could
> this be cherry-picked to 5.0?
I've replied on the commit message thread. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D368
I'm ok with it if Anna approves.
On Mon, Aug 21, 2017 at 9:06 AM, Artem Dergachev wrote:
> Hello,
>
> Do we have time to merge this change into release 5.0.0? It's an assertion
> failure fix, which shows up on C++ code involving double-inheritance with
> empty base classes.
>
> Artem.
>
>
> On 8/
hintonda added a comment.
ping...
https://reviews.llvm.org/D36347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I approve.Thanks Hans!
Anna
> On Aug 21, 2017, at 1:05 PM, Hans Wennborg wrote:
>
> I'm ok with it if Anna approves.
>
> On Mon, Aug 21, 2017 at 9:06 AM, Artem Dergachev wrote:
>> Hello,
>>
>> Do we have time to merge this change into release 5.0.0? It's an assertion
>> failure fix, which show
srhines added a comment.
Ping.
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Merged in r311378.
Thanks,
Hans
On Mon, Aug 21, 2017 at 1:12 PM, Anna Zaks wrote:
> I approve.Thanks Hans!
> Anna
>> On Aug 21, 2017, at 1:05 PM, Hans Wennborg wrote:
>>
>> I'm ok with it if Anna approves.
>>
>> On Mon, Aug 21, 2017 at 9:06 AM, Artem Dergachev wrote:
>>> Hello,
>>>
>>> Do we h
hintonda added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
While obviously correct, are you concerned
srhines marked an inline comment as done.
srhines added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
hi
Thanks!
On Mon, Aug 21, 2017 at 1:28 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Merged in r311378.
>
> Thanks,
> Hans
>
> On Mon, Aug 21, 2017 at 1:12 PM, Anna Zaks wrote:
> > I approve.Thanks Hans!
> > Anna
> >> On Aug 21, 2017, at 1:05 PM, Hans Wennborg wrote:
>
hintonda added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
srhines wrote:
> hintonda wrote:
> > While
Author: stl_msft
Date: Mon Aug 21 15:19:33 2017
New Revision: 311391
URL: http://llvm.org/viewvc/llvm-project?rev=311391&view=rev
Log:
[Driver] Recognize DevDiv internal builds of MSVC, with a different directory
structure.
This is a reasonably non-intrusive change, which I've verified
works for
vsapsai added a comment.
Thanks for review, Alex. I've requested commit access and plan to commit the
change myself to make sure everything works as expected.
https://reviews.llvm.org/D36853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
Author: ahatanak
Date: Mon Aug 21 15:46:46 2017
New Revision: 311397
URL: http://llvm.org/viewvc/llvm-project?rev=311397&view=rev
Log:
[Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is
supplied.
With this change, -fno-exceptions disables unwind tables unless
-funwind-tables is sup
jgravelle-google created this revision.
Herald added subscribers: aheejin, klimek.
Rename stop-after to stop-after-topdown. When building LLVM with
-DLLVM_BUILD_LLVM_DYLIB=ON, stop-after collides with the stop-after
already present in LLVM.
This also refactors the flag to a boolean, to reflect th
PR19668 was marked as a release blocker. Is this suitable for merging?
On Tue, Aug 15, 2017 at 6:49 PM, Richard Smith via cfe-commits
wrote:
> Author: rsmith
> Date: Tue Aug 15 18:49:53 2017
> New Revision: 310983
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310983&view=rev
> Log:
> PR19668,
Yes, I'd very much like to get this into the upcoming release.
On 21 August 2017 at 16:16, Hans Wennborg wrote:
> PR19668 was marked as a release blocker. Is this suitable for merging?
>
> On Tue, Aug 15, 2017 at 6:49 PM, Richard Smith via cfe-commits
> wrote:
> > Author: rsmith
> > Date: Tue A
Author: george.karpenkov
Date: Mon Aug 21 16:25:19 2017
New Revision: 311406
URL: http://llvm.org/viewvc/llvm-project?rev=311406&view=rev
Log:
Moving libFuzzer to compiler-rt: required updates to the Clang driver.
Differential Revision: https://reviews.llvm.org/D36909
Modified:
cfe/trunk/lib
srhines marked an inline comment as done.
srhines added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
hi
Clean merge in r311410. Thanks.
On Mon, Aug 21, 2017 at 4:21 PM, Richard Smith wrote:
> Yes, I'd very much like to get this into the upcoming release.
>
> On 21 August 2017 at 16:16, Hans Wennborg wrote:
>>
>> PR19668 was marked as a release blocker. Is this suitable for merging?
>>
>> On Tue, A
hintonda added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:505
-assert(!Err &&
- "Replacements must not conflict since ranges have been merged.");
-llvm::consumeError(std::move(Err));
srhines wrote:
> hintonda wrote:
> > srhine
Is there something we need for 5.0.0 here?
On Sat, Aug 12, 2017 at 9:58 PM, Saleem Abdulrasool
wrote:
> Yeah, we should adjust that. Technically, it is `_Unwind_Control_Block on
> ARM EHABI. However, _Unwind_Exception is aliased to that, which is why we
> can use that in the personality routine
Author: george.karpenkov
Date: Mon Aug 21 17:04:05 2017
New Revision: 311412
URL: http://llvm.org/viewvc/llvm-project?rev=311412&view=rev
Log:
Fixed driver tests for -fsanitize=fuzzer.
Modified:
cfe/trunk/test/Driver/fuzzer.c
Modified: cfe/trunk/test/Driver/fuzzer.c
URL:
http://llvm.org/vie
bcraig added a comment.
LGTM. You should probably get one other person to approve though. I'm hoping
that @EricWF or @mclow.lists will take a look
https://reviews.llvm.org/D36423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
hintonda added a comment.
It's just too bad llvm::cantFail() doesn't take an optional string.
But the code is cleaner, so I won't comment further.
https://reviews.llvm.org/D36806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
Author: george.karpenkov
Date: Mon Aug 21 19:10:53 2017
New Revision: 311422
URL: http://llvm.org/viewvc/llvm-project?rev=311422&view=rev
Log:
Test fix: only add shared libraries to rpath.
Modified:
cfe/trunk/lib/Driver/ToolChains/Darwin.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/Darwin.c
Rakete updated this revision to Diff 112103.
Rakete added a comment.
Rebased and friendly ping.
https://reviews.llvm.org/D36357
Files:
include/clang/Basic/DiagnosticParseKinds.td
lib/Parse/ParseExprCXX.cpp
test/Parser/cxx0x-lambda-expressions.cpp
test/SemaCXX/new-delete-0x.cpp
wangxindsb updated this revision to Diff 112110.
wangxindsb added a comment.
- Fix the errors of the tests;
- Add `-analyzer-output=text` to the run-line;
- Change the message of the visitor's diagnostic piece.
https://reviews.llvm.org/D34275
Files:
lib/StaticAnalyzer/Checkers/VirtualCallChec
wangxindsb added a comment.
@NoQ
In https://reviews.llvm.org/D34275#847434, @NoQ wrote:
> Most importantly, do you think we can enable the checker by default now? Was
> this checker evaluated on any large codebase, and if so, how many true/false
> positives did it find, probably compared to th
Author: vitalybuka
Date: Mon Aug 21 22:18:28 2017
New Revision: 311428
URL: http://llvm.org/viewvc/llvm-project?rev=311428&view=rev
Log:
Update libprotobuf-mutator revision
Modified:
cfe/trunk/cmake/modules/ProtobufMutator.cmake
Modified: cfe/trunk/cmake/modules/ProtobufMutator.cmake
URL:
h
rjmccall added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:1323
+ if (result.HasSideEffects && !AllowSideEffects) {
+assert(!isa(E) && "declrefs should not have side effects");
return ConstantEmission();
The side effects here are those associate
djasper added inline comments.
Comment at: lib/Format/BreakableToken.cpp:553
StringRef TrimmedContent = Content[LineIndex].ltrim(Blanks);
- return getReflowSplit(TrimmedContent, ReflowPrefix, PreviousEndColumn,
-ColumnLimit);
+ Split TrimmedSplit = ge
djasper added inline comments.
Comment at: lib/Format/FormatToken.h:397
+ (!Previous ||
+ Previous->isOneOf(tok::comma, tok::equal, tok::l_brace) ||
+ Next->is(tok::r_brace;
Is this list coming from existing tests?
98 matches
Mail list logo
