[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 111806. wangxindsb added a comment. +enum class ObjectState : bool { CtorCalled, DtorCalled }; +} // end namespace Add namespace closing comment. https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris marked 6 inline comments as done. boris added a comment. I've marked as "done" items that I have resolved in my local revision (not yet uploaded) and have added one comment for further feedback. Comment at: lib/Frontend/CompilerInvocation.cpp:982 +StringRef Val = A->

[PATCH] D36180: [clang-diff] Add option to dump the AST, one node per line

This revision was automatically updated to reflect the committed changes. Closed by commit rL311232: [clang-diff] Add option to dump the AST, one node per line (authored by krobelus). Repository: rL LLVM https://reviews.llvm.org/D36180 Files: cfe/trunk/test/Tooling/clang-diff-ast.cpp cfe/

r311232 - [clang-diff] Add option to dump the AST, one node per line

Author: krobelus Date: Sat Aug 19 02:36:14 2017 New Revision: 311232 URL: http://llvm.org/viewvc/llvm-project?rev=311232&view=rev Log: [clang-diff] Add option to dump the AST, one node per line Summary: This is done with -ast-dump; the JSON variant has been renamed to -ast-dump-json. Reviewers:

r311233 - [clang-diff] Fix test

Author: krobelus Date: Sat Aug 19 03:05:24 2017 New Revision: 311233 URL: http://llvm.org/viewvc/llvm-project?rev=311233&view=rev Log: [clang-diff] Fix test Modified: cfe/trunk/test/Tooling/clang-diff-ast.cpp Modified: cfe/trunk/test/Tooling/clang-diff-ast.cpp URL: http://llvm.org/viewvc/ll

r311234 - [StaticAnalyzer] LoopUnrolling: Exclude cases where the counter is escaped before the loop

Author: szepet Date: Sat Aug 19 03:24:52 2017 New Revision: 311234 URL: http://llvm.org/viewvc/llvm-project?rev=311234&view=rev Log: [StaticAnalyzer] LoopUnrolling: Exclude cases where the counter is escaped before the loop Adding escape check for the counter variable of the loop. It is achieved

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

hamzasood updated this revision to Diff 111812. hamzasood added a comment. Changed a documentation comment to use \brief instead of stating the function name. Only enter the template parameter scope if needed. Changed the phrasing of the diagnostic when an empty template parameter list is encoun

r311235 - [CFG] Add LoopExit information to CFG

Author: szepet Date: Sat Aug 19 04:19:16 2017 New Revision: 311235 URL: http://llvm.org/viewvc/llvm-project?rev=311235&view=rev Log: [CFG] Add LoopExit information to CFG This patch introduces a new CFG element CFGLoopExit that indicate when a loop ends. It does not deal with returnStmts yet (lef

r311237 - [clang-diff] Make printing of matches optional

Author: krobelus Date: Sat Aug 19 05:04:04 2017 New Revision: 311237 URL: http://llvm.org/viewvc/llvm-project?rev=311237&view=rev Log: [clang-diff] Make printing of matches optional Reviewers: arphaman Subscribers: klimek Differential Revision: https://reviews.llvm.org/D36181 Modified: cfe

[PATCH] D36181: [clang-diff] Make printing of matches optional

This revision was automatically updated to reflect the committed changes. Closed by commit rL311237: [clang-diff] Make printing of matches optional (authored by krobelus). Changed prior to commit: https://reviews.llvm.org/D36181?vs=109503&id=111815#toc Repository: rL LLVM https://reviews.ll

r311240 - [clang-diff] Fix warning about useless comparison

Author: krobelus Date: Sat Aug 19 06:29:44 2017 New Revision: 311240 URL: http://llvm.org/viewvc/llvm-project?rev=311240&view=rev Log: [clang-diff] Fix warning about useless comparison Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp URL:

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris added inline comments. Comment at: lib/Serialization/ASTReader.cpp:4145-4146 +// by-name lookup. +if (Type == MK_PrebuiltModule || Type == MK_ExplicitModule) + ModuleMgr.registerPrebuilt(F); break; rsmith wrote: > I'm worri

[PATCH] D35020: [Modules] Add ability to specify module name to module file mapping

boris updated this revision to Diff 111826. boris added a comment. New revision of the patch that I believe addresses all the issues except for the '=' escaping. https://reviews.llvm.org/D35020 Files: docs/Modules.rst include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h inc

r311241 - [clang-diff] Add HTML side-by-side diff output

Author: krobelus Date: Sat Aug 19 08:40:45 2017 New Revision: 311241 URL: http://llvm.org/viewvc/llvm-project?rev=311241&view=rev Log: [clang-diff] Add HTML side-by-side diff output Reviewers: arphaman Subscribers: mgorny Differential Revision: https://reviews.llvm.org/D36182 Added: cfe/tr

[PATCH] D36182: [clang-diff] Add HTML side-by-side diff output

This revision was automatically updated to reflect the committed changes. Closed by commit rL311241: [clang-diff] Add HTML side-by-side diff output (authored by krobelus). Changed prior to commit: https://reviews.llvm.org/D36182?vs=110553&id=111829#toc Repository: rL LLVM https://reviews.ll

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

NoQ added a comment. First of all, thanks everybody for working on this. I'd see what i can do. Comment at: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp:29 namespace { +enum class ObjectState : bool { CtorCalled, DtorCalled }; +} // end namespace Please

[PATCH] D36707: [CodeGen]Refactor CpuSupports/CPUIs Builtin Code Gen to better work with "target" implementation

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

r311249 - [clang-diff] Fix compiler warning

Author: krobelus Date: Sat Aug 19 10:12:25 2017 New Revision: 311249 URL: http://llvm.org/viewvc/llvm-project?rev=311249&view=rev Log: [clang-diff] Fix compiler warning Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp URL: http://llvm.org

[PATCH] D36855: Fixed pointer to const& member function on rvalues, P0704r1

Rakete updated this revision to Diff 111840. Rakete marked 2 inline comments as done. Rakete added a comment. Update entry on the C++ status page. https://reviews.llvm.org/D36855 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp test/SemaCXX/cxx2a-poin

r311250 - Add clang-diff to tool_patterns in test/lit.cfg

Author: krobelus Date: Sat Aug 19 10:52:29 2017 New Revision: 311250 URL: http://llvm.org/viewvc/llvm-project?rev=311250&view=rev Log: Add clang-diff to tool_patterns in test/lit.cfg Modified: cfe/trunk/test/lit.cfg Modified: cfe/trunk/test/lit.cfg URL: http://llvm.org/viewvc/llvm-project/c

r311251 - [clang-diff] Simplify mapping

Author: krobelus Date: Sat Aug 19 10:53:01 2017 New Revision: 311251 URL: http://llvm.org/viewvc/llvm-project?rev=311251&view=rev Log: [clang-diff] Simplify mapping Summary: Until we find a decent heuristic on how to choose between multiple identical trees, there is no point in supporting multipl

[PATCH] D36183: [clang-diff] Simplify mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rL311251: [clang-diff] Simplify mapping (authored by krobelus). Repository: rL LLVM https://reviews.llvm.org/D36183 Files: cfe/trunk/include/clang/Tooling/ASTDiff/ASTDiff.h cfe/trunk/lib/Tooling/ASTD

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added inline comments. Comment at: include/clang/Sema/ScopeInfo.h:774 + /// \brief The number of parameters in the template parameter list that were + /// explicitely specified by the user, as opposed to being invented by use + /// of an auto parameter. ---

[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas

faisalv added a comment. In regards to that failing test (that was added since review began) - could you fix that test pls (i.e. rename the nested ttp 'U' to something else) and move it into the function 'f' as requested by the author? Might want to include a similar (but not same) example of ma

[PATCH] D36492: [time-report] Add preprocessor timer

modocache added inline comments. Comment at: include/clang/Lex/PreprocessorOptions.h:165 public: - PreprocessorOptions() : UsePredefines(true), DetailedRecord(false), + PreprocessorOptions() : PPTimer("preprocessor", "Preprocessing"), + UsePredefines(t

[PATCH] D36820: [Bash-autocompletion] Add support for -std=

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D36931: Update LLVM 5.0 release notes for ms_abi and __builtin_ms_va_list for aarch64

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D36931 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/Release

r311270 - clang/test/Tooling/clang-diff-ast.cpp: Satisfy thiscall.

Author: chapuni Date: Sat Aug 19 17:02:20 2017 New Revision: 311270 URL: http://llvm.org/viewvc/llvm-project?rev=311270&view=rev Log: clang/test/Tooling/clang-diff-ast.cpp: Satisfy thiscall. clang/test/Tooling/clang-diff-ast.cpp:45:12: error: expected string not found in input // CHECK: CXX

[PATCH] D36882: [clang-proto-fuzzer] Allow user-specified compiler arguments.

kcc added a comment. Update the README file please (with a text similar to this commit message) Comment at: cfe/trunk/tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp:32 + for (int I = 1; I < *argc; I++) { +if (strcmp((*argv)[I], "-ignore_remaining_args=1") == 0) { + fo

[PATCH] D36839: [SanitizerCoverage] Add stack depth tracing instrumentation.

kcc added a comment. Please also write a lit test for test/DeepRecursionTest.cpp (e.g. test/deep-recursion.test) Repository: rL LLVM https://reviews.llvm.org/D36839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb marked 3 inline comments as done. wangxindsb added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp:29 namespace { +enum class ObjectState : bool { CtorCalled, DtorCalled }; +} // end namespace NoQ wrote: > Please remind

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 111862. wangxindsb added a comment. - Rename reportbug(); - Change message "Pure function" to "pure virtual function"; - Fixing: expected-warning; https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb added inline comments. Comment at: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp:31 +} // end namespace + // FIXME: Ascending over StackFrameContext maybe another method. + Add the FIXME https://reviews.llvm.org/D34275 __