[PATCH] D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.

dcoughlin added a comment. I just want to second that we really don't want to treat the analyzer-config options as user visible. These are useful as staging flags for analyzer development/testing and occasionally as customization points for IDEs/build systems. But they do not expose a coherent

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Sounds good to me, but Eric or Marshall need to sign off. On Thu, Aug 3, 2017 at 10:15 AM, Shoaib Meenai wrote: > Ping. > > On 7/28/17, 7:57 PM, "Shoaib Meenai" wrote: > > Marshall, Eric, Hans, > > Any objections to backporting this to 5.0? It fixes a potential visibility > issue for

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 109589. yawanng marked 9 inline comments as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecCheck.cpp clang-tidy/android/CloexecCheck.h clang-tidy/andr

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

yawanng added inline comments. Comment at: clang-tidy/android/CloexecCheck.h:35 + + // This issue has three types. + // Type1 is to insert the necessary macro flag in the flag argument. hokein wrote: > It is unclear to me what the "issue" means here? I assume t

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

danielmarjamaki updated this revision to Diff 109590. danielmarjamaki added a comment. Cleaned up the patch a little. Thanks Gabor for telling me about SValBuilder::getKnownValue() Repository: rL LLVM https://reviews.llvm.org/D30295 Files: include/clang/StaticAnalyzer/Core/PathSensitive/C

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 109591. yaxunl added a comment. Add comments to SyncScope.h https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/Basic/Builtins.def include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

rjmccall added a comment. Looks fine to me. https://reviews.llvm.org/D32199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36016: [clang-tidy] Support initializer-list constructor cases in modernize-make-unique.

hokein updated this revision to Diff 109594. hokein marked 3 inline comments as done. hokein added a comment. Address review comments https://reviews.llvm.org/D36016 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp test/clang-tidy/Inputs/modernize-smart-ptr/initializer_list.h test/clang-

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev updated this revision to Diff 109593. fedor.sergeev added a comment. Corrected comments as suggested by Aaron. Will be replying on other suggestions inline. https://reviews.llvm.org/D35755 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h lib/Driver/ToolChains

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

fedor.sergeev added a reviewer: tstellar. fedor.sergeev marked 11 inline comments as done. fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1840 +// Yet, still look for RHEL devtoolsets +// (should it be done Linux-only??) +Prefixes.push_

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:701 + PPMaybeIncludeGuard->TokenText == FormatTok->TokenText && + PPIndentLevel > 0) { +--PPIndentLevel; djasper wrote: > I think you'll need substantially more tests her

r309968 - [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

Author: dcoughlin Date: Thu Aug 3 11:12:22 2017 New Revision: 309968 URL: http://llvm.org/viewvc/llvm-project?rev=309968&view=rev Log: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output This change adds support for cross-file diagnostic paths in html output. If the

[PATCH] D30406: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output

This revision was automatically updated to reflect the committed changes. Closed by commit rL309968: [Analyzer] Add support for displaying cross-file diagnostic paths in HTML output (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D30406?vs=102838&id=109601#toc Reposi

[PATCH] D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rL LLVM https://reviews.llvm.org/D30155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

mcgrathr updated this revision to Diff 109603. mcgrathr added a comment. Added test. https://reviews.llvm.org/D36254 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchsia.c === --- test/Dri

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr updated this revision to Diff 109605. mcgrathr added a comment. Check -dynamic-linker in test. https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c Index: test/Driver/fuchs

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

t-tye added inline comments. Comment at: docs/LanguageExtensions.rst:1935 +builtin function, and are named with a ``__opencl_`` prefix.) Low-level ARM exclusive memory builtins Should it also say: ``` The macros ``__OPENCL_MEMORY_SCOPE_WORK_ITEM``, ``__OPENC

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

rnk added a comment. I discovered this code in llvm/lib/Support/Windows/Signals.inc which explains why we leak so many temp files on Windows: // FIXME: open files cannot be deleted. if (FilesToRemove != NULL) while (!FilesToRemove->empty()) { llvm::sys::fs::remove(FilesToRemove->ba

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

efriedma added a comment. Do you actually need a new flag for this? "-fno-common" will ensure clang doesn't generate globals with common linkage. Repository: rL LLVM https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

efriedma added inline comments. Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp: + GVar->setLinkage(llvm::GlobalValue::ExternalLinkage); + GVar->setSection("rodata"); +} Also, this change is clearly unacceptable; among other things,

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

weimingz added a comment. In https://reviews.llvm.org/D36249#830645, @saugustine wrote: > In https://reviews.llvm.org/D36249#830121, @weimingz wrote: > > > I tried to address it via checking pre-defined macros: > > https://reviews.llvm.org/D31573 > > > > As long as the macros are defined correct

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. I'm ok with this. Repository: rL LLVM https://reviews.llvm.org/D36249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

saugustine added a comment. Landed as r309973 Repository: rL LLVM https://reviews.llvm.org/D36249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. It's required for feature parity with GCC. -fno-common will place globals into the bss section which uses memory at runtime. The -membedded-data and -muninit-const-in-rodata options are for reducing RAM usage in some embedded environments. Repository: rL LLVM https

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added inline comments. Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp: + GVar->setLinkage(llvm::GlobalValue::ExternalLinkage); + GVar->setSection("rodata"); +} efriedma wrote: > Also, this change is clearly unacceptable; am

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

efriedma added a comment. LLVM never puts constant data into the BSS. See isSuitableForBSS in lib/Target/TargetLoweringObjectFile.cpp. (gcc's behavior is just weird... apparently, whether or not constant data is placed in the BSS with -fno-common depends on the syntactic form of the initializ

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

joerg added a comment. I don't see any reason why zero-initialised constants should be emitted in BSS. I know that GCC does that and I just fixed bugs in that because created wrong section flags for it. So yes, I'd prefer to revert this and fix the real problem. Repository: rL LLVM https:/

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: docs/LanguageExtensions.rst:1935 +builtin function, and are named with a ``__opencl_`` prefix.) Low-level ARM exclusive memory builtins t-tye wrote: > Should it also say: > > `

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 109612. yaxunl marked an inline comment as done. yaxunl added a comment. Added documentation about __OPENCL_MEMORY_SCOPE_* by Tony's comments. https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/Bas

[PATCH] D35847: clang-format: Fix left pointer alignment after delctype/typeof

euhlmann updated this revision to Diff 109613. euhlmann added a comment. This uses `FormatToken::getPreviousNonComment` and adds a test. This also fixes a bug in token annotation that was breaking the test (by also using `getPreviousNonComment` instead of `Previous`) https://reviews.llvm.org/D

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. In https://reviews.llvm.org/D35917#830898, @joerg wrote: > I don't see any reason why zero-initialised constants should be emitted in > BSS. I know that GCC does that and I just fixed bugs in that because created > wrong section flags for it. So yes, I'd prefer to rever

r309975 - Don't emit undefined-internal warnings for CXXDeductionGuideDecls.

Author: rsmith Date: Thu Aug 3 12:24:27 2017 New Revision: 309975 URL: http://llvm.org/viewvc/llvm-project?rev=309975&view=rev Log: Don't emit undefined-internal warnings for CXXDeductionGuideDecls. Patch by ~paul (cynecx on phabricator)! Some test massaging by me. Added: cfe/trunk/docs/Mod

[PATCH] D35678: Omit sumbodule semantics for TS modules

rsmith added a comment. This will need a test case. Comment at: lib/Frontend/CompilerInstance.cpp:1598-1612 + // FIXME: Should we be deciding whether this is a submodule (here and + // below) based on -fmodules-ts or should we pass a flag and make the + // caller decide? +

r309978 - [mips] Revert r309942 & r309940

Author: sdardis Date: Thu Aug 3 12:39:51 2017 New Revision: 309978 URL: http://llvm.org/viewvc/llvm-project?rev=309978&view=rev Log: [mips] Revert r309942 & r309940 This reverts commit r309942 & commit r309940. A revert was requested following post commit review. Removed: cfe/trunk/test/Co

[clang-tools-extra] r309979 - [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build

Author: mgorny Date: Thu Aug 3 12:41:33 2017 New Revision: 309979 URL: http://llvm.org/viewvc/llvm-project?rev=309979&view=rev Log: [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build Prepend the clang library directory (determined using SHLIBDIR, alike in clang) to the LD_LIBR

[PATCH] D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL309979: [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D30155?vs=89062&id=109616#toc Repository: rL LLVM

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. https://reviews.llvm.org/rL309978 for the revert. Repository: rL LLVM https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

t-tye accepted this revision. t-tye added a comment. LGTM https://reviews.llvm.org/D28691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

thakis added a comment. I'm going to land this. It's early in the 6.0 cycle, so if this causes issues, we should have time to find them and then follow up in case we run into any. https://reviews.llvm.org/D36238 ___ cfe-commits mailing list cfe-com

r309984 - Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

Author: nico Date: Thu Aug 3 14:06:36 2017 New Revision: 309984 URL: http://llvm.org/viewvc/llvm-project?rev=309984&view=rev Log: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name. This helps some tools that do things based on the output's extension. For example, we got reports

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

thakis closed this revision. thakis added a comment. 309984. https://reviews.llvm.org/D36238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs.

teemperor abandoned this revision. teemperor added a comment. I see, thanks for the information! If we don't need to support this in the shell-completion and we shouldn't report invalid arguments, then it seems this review is stuck here. I'll abandon as I don't see any other use case for this c

[PATCH] D36230: [X86][Asm] Allow negative immediate to appear before bracketed expression

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good Repository: rL LLVM https://reviews.llvm.org/D36230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309995: [coverage] Special-case calls to noreturn functions. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D36250?vs=109457&id=109644#toc Repository: rL LLVM https://revi

r309995 - [coverage] Special-case calls to noreturn functions.

Author: efriedma Date: Thu Aug 3 15:27:36 2017 New Revision: 309995 URL: http://llvm.org/viewvc/llvm-project?rev=309995&view=rev Log: [coverage] Special-case calls to noreturn functions. The code after a noreturn call doesn't execute. The pattern in the testcase is pretty common in LLVM (a swit

r309999 - Enable AddressSanitizer for Fuchsia targets

Author: phosek Date: Thu Aug 3 16:02:22 2017 New Revision: 30 URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev Log: Enable AddressSanitizer for Fuchsia targets Patch by Roland McGrath Differential Revision: https://reviews.llvm.org/D35922 Modified: cfe/trunk/cmake/caches/Fu

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL30: Enable AddressSanitizer for Fuchsia targets (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35922?vs=109605&id=109645#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

dcoughlin added a comment. It still seems like we are inferring invariants that are not sound. Do we need to restrict the symbolic transformation so that it only applies when A - B, too, is known to not overflow? Is that sufficient? Is it often the case that the analyzer knows these restriction

[PATCH] D36294: CFI: blacklist STL allocate() from unrelated-casts

pcc added a subscriber: cfe-commits. pcc added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:785 + // Ignore unrelated casts from C++ calls to allocate(). Don't match on the + // namespace because not all allocators are in std:: The comment sho

[PATCH] D34992: Emit static constexpr member as available_externally definition

mehdi_amini added a comment. Ping again @rsmith (or anyone else) https://reviews.llvm.org/D34992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310006 - [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions.

Author: ahatanak Date: Thu Aug 3 16:55:42 2017 New Revision: 310006 URL: http://llvm.org/viewvc/llvm-project?rev=310006&view=rev Log: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions. This commit fixes a bug where clang/llvm doesn't emit an unwind table for a function when it is mark

[PATCH] D35693: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rL310006: [Driver][Darwin] Pass -munwind-table when !UseSjLjExceptions. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D35693?vs=107563&id=109659#toc Repository: rL LLVM htt

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D34992: Emit static constexpr member as available_externally definition

rsmith added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2293 /// If ExcludeCtor is true, the duration when the object's constructor runs -/// will not be considered. The caller will need to verify that the object is -/// not written to during its constructi

r310010 - [Coverage] Precise region termination with deferred regions

Author: vedantk Date: Thu Aug 3 17:29:20 2017 New Revision: 310010 URL: http://llvm.org/viewvc/llvm-project?rev=310010&view=rev Log: [Coverage] Precise region termination with deferred regions The current coverage implementation doesn't handle region termination very precisely. Take for example

[PATCH] D35925: [Coverage] Precise region termination with deferred regions

vsk closed this revision. vsk added a comment. Committed in r310010 https://reviews.llvm.org/D35925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36294: CFI: blacklist STL allocate() from unrelated-casts

vlad.tsyrklevich updated this revision to Diff 109668. vlad.tsyrklevich marked 2 inline comments as done. vlad.tsyrklevich added a comment. Address pcc's comments https://reviews.llvm.org/D36294 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGen/cfi-unrelated-cast.cpp Index: test/CodeGen

[PATCH] D36294: CFI: blacklist STL allocate() from unrelated-casts

vlad.tsyrklevich marked an inline comment as done. vlad.tsyrklevich added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:789 +auto *MD = dyn_cast_or_null(D); +if (MD && MD->getName().equals("allocate") && MD->getNumParams() == 2) { + auto *BT = MD->para

[PATCH] D36294: CFI: blacklist STL allocate() from unrelated-casts

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36254: [Driver][Fuchsia] Pass --hash-style=gnu to the linker

This revision was automatically updated to reflect the committed changes. Closed by commit rL310017: [Driver][Fuchsia] Pass --hash-style=gnu to the linker (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D36254?vs=109603&id=109677#toc Repository: rL LLVM https://revie

r310017 - [Driver][Fuchsia] Pass --hash-style=gnu to the linker

Author: phosek Date: Thu Aug 3 19:39:27 2017 New Revision: 310017 URL: http://llvm.org/viewvc/llvm-project?rev=310017&view=rev Log: [Driver][Fuchsia] Pass --hash-style=gnu to the linker The .gnu_hash format is superior, and all versions of the Fuchsia dynamic linker support it. Differential Rev

[PATCH] D35863: Use the allocator's pointers for deallocation in `std::list`

Quuxplusone updated this revision to Diff 109678. Quuxplusone added a comment. I've updated https://reviews.llvm.org/D35863 to be actually correct AFAICT from my local testing; but I'm not sure what's the most appropriate way to get "fancy allocator" tests into libcxx's test suite. The way I did

[PATCH] D36019: [clang-format] Fix bug with ENAS_DontAlign and empty lines

jtbandes added a comment. @djasper Bump :) https://reviews.llvm.org/D36019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r309995 - [coverage] Special-case calls to noreturn functions.

Hi Eli, I think this commit is breaking the stage2 coverage build for clang: http://green.lab.llvm.org/green/job/clang-stage2-coverage-R_build/1402 FAILED: tools/clang/lib/AST/CMakeFiles/clangAST.dir/ItaniumMangle.cpp.o /U

r310019 - Revert "[coverage] Special-case calls to noreturn functions."

Author: vedantk Date: Thu Aug 3 21:08:23 2017 New Revision: 310019 URL: http://llvm.org/viewvc/llvm-project?rev=310019&view=rev Log: Revert "[coverage] Special-case calls to noreturn functions." This reverts commit r309995. It looks like it's responsible for breaking the stage2 coverage build:

Re: r309995 - [coverage] Special-case calls to noreturn functions.

Reverted in r310019. vedant > On Aug 3, 2017, at 9:07 PM, Vedant Kumar wrote: > > Hi Eli, > > I think this commit is breaking the stage2 coverage build for clang: > http://green.lab.llvm.org/green/job/clang-stage2-coverage-R_build/1402 >

[PATCH] D36148: clang-format: [JS] support fields with case/switch/default labels.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D36148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D35826: [Driver] Error if ARM mode was selected explicitly for M-profile CPUs.

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. This makes sense to me. LGTM. Thanks! https://reviews.llvm.org/D35826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r310030 - Revert r309984, "Use "foo-12345.o" instead of "foo.o-12345" as temporary file name."

Author: chapuni Date: Thu Aug 3 23:35:32 2017 New Revision: 310030 URL: http://llvm.org/viewvc/llvm-project?rev=310030&view=rev Log: Revert r309984, "Use "foo-12345.o" instead of "foo.o-12345" as temporary file name." It generates MODULE--.pcm, then GlobalModuleIndex.cpp is

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this in https://reviews.llvm.org/rL310030 to unbreak -fmodules. See GlobalModuleIndex.cpp. It seeks the suffix ".pcm". https://reviews.llvm.org/D36238 ___

<    1   2