[PATCH] D36252: [diagtool] Add ability to get name from id

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

arphaman added a comment. In https://reviews.llvm.org/D27827#829661, @thakis wrote: > We just noticed that if you call __builtin_available() for the first time > after activating your app's sandbox, the function will fail: > > SandboxViolation: crdmg(15489) deny file-read-data > /System/Library

[PATCH] D36177: [clang-diff] Add commandline arguments.

arphaman added inline comments. Comment at: test/Tooling/clang-diff-args.sh:1 +RUN: echo a > %t.cpp + I think a '.test' extension rather than '.sh' is better Comment at: test/Tooling/clang-diff-args.sh:3 + +RUN: echo "CHECK: unknown type name '

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov created this revision. https://reviews.llvm.org/D36261 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/tool/ClangdMain.cpp unittests/clangd/ClangdTests.cpp Index: unittests/clangd/ClangdTests.cpp ==

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + I think you have to use `%python` instead of `python`, like LLVM tests do. https://reviews.llvm.org/D36178

[PATCH] D36181: [clang-diff] Make printing of matches optional

arphaman added inline comments. Comment at: test/Tooling/clang-diff-args.sh:10 + +RUN: echo "// CHECK-NOT: {{.}}" > %t-no-output +RUN: clang-diff %S/clang-diff-ast.cpp %S/clang-diff-ast.cpp -- 2>&1 -std=c++11 \ You can use `MYCHECK-NOT` in this file and run `Fil

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

arphaman added inline comments. Comment at: clangd/ClangdServer.h:107 +public: + /// Indicates that requests must be executed immidieately on the calling + /// thread. Typo: immediately https://reviews.llvm.org/D36261 __

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. After a chat with @klimek, working on an implementation that would use `openAt()`. https://reviews.llvm.org/D36226 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

klimek added inline comments. Comment at: clangd/ClangdServer.h:105 +/// A helper class to pass concurrency parameters to ClangdScheduler. +class SchedulingParams { +public: I think calling it "Options" is more idiomatic. Comment at: clangd/Cla

[PATCH] D35894: [clangd] Code hover for Clangd

ilya-biryukov added a comment. In https://reviews.llvm.org/D35894#829190, @malaperle wrote: > @Nebiroth I think it's OK to put this on hold until we make the "semantic" > hover and figure out how to have both. From our perspective, this is going > beyond parity of what we had before but it's se

[PATCH] D35372: [clang-tidy] Refactor the code and add a close-on-exec check on memfd_create() in Android module.

hokein added a comment. Sorry for the delay, and thanks for refining it. In general, I'm fine with the current design, a few comments below. Comment at: clang-tidy/android/CloexecCheck.cpp:62 +const int ArgPos) { + const auto MatchedCall = Result.Nodes.getNodeAs("func");

[PATCH] D35932: [clang-tidy] Add integer division check

rnkovacs updated this revision to Diff 109497. rnkovacs edited the summary of this revision. rnkovacs added a comment. Uploaded a more thought-out version of the check with more cases covered and hopefully clearer docs. It produces no hits on LLVM&Clang. https://reviews.llvm.org/D35932 Files:

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + arphaman wrote: > I think you have to use `%python` instead of `python`, like LLVM tests do. ok So I have to

[PATCH] D36177: [clang-diff] Add commandline arguments.

johannes updated this revision to Diff 109502. johannes added a comment. fix tests https://reviews.llvm.org/D36177 Files: test/Tooling/clang-diff-args.test test/Tooling/clang-diff-basic.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp =

[PATCH] D36181: [clang-diff] Make printing of matches optional

johannes updated this revision to Diff 109503. johannes added a comment. fix tests https://reviews.llvm.org/D36181 Files: test/Tooling/clang-diff-args.test test/Tooling/clang-diff-basic.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp

[PATCH] D36183: [clang-diff] Simplify mapping

johannes updated this revision to Diff 109504. johannes added a comment. merge parent changes https://reviews.llvm.org/D36183 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-basic.cpp In

[PATCH] D36185: [clang-diff] Fix similarity computation

johannes updated this revision to Diff 109505. johannes added a comment. merge parent changes https://reviews.llvm.org/D36185 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-bottomup.cpp test/Tooling/clang-diff-opt.cpp test/Toolin

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + johannes wrote: > arphaman wrote: > > I think you have to use `%python` instead of `python`, like LLVM tests

[PATCH] D36177: [clang-diff] Add commandline arguments.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think you have to test the -p option too (check the compilation database can be loaded and arguments are propagated to the parser), otherwise LGTM! https://reviews.llvm.org/D36177 __

[PATCH] D36181: [clang-diff] Make printing of matches optional

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D36181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + johannes wrote: > arphaman wrote: > > I think you have to use `%python` instead of `python`, like LLVM tests

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added inline comments. Comment at: test/Tooling/clang-diff-json.cpp:1 +// RUN: clang-diff -ast-dump %s -- | python -m json.tool | FileCheck %s + arphaman wrote: > johannes wrote: > > johannes wrote: > > > arphaman wrote: > > > > I think you have to use `

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman added a comment. @johannes , you have to add %python substitution to lit.cfg, see my attached patch that does it.F4172676: python.diff https://reviews.llvm.org/D36178 ___ cfe-commits mailing list cfe-com

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. The check doesn't fully support smart-ptr usages inside macros, which may cause incorrect fixes, or even crashes, ignore them for now. https://reviews.llvm.org/D36264 Files: clang-tidy/modernize/MakeSmartPtrCheck

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov updated this revision to Diff 109524. ilya-biryukov added a comment. Added a very rough prototype of vfs::RealFileSystem not using openat. Not ready for submission yet, wanted to start discussion about Windows implementation. https://reviews.llvm.org/D36226 Files: include/clang

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

arphaman added a comment. LGTM. Although I'm not 100% sure it's fully NFC, so if you can't come up with a test please justify why. https://reviews.llvm.org/D36176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D36226: Added a RealFileSystem implementation that does not rely on global CWD.

ilya-biryukov added a comment. Requires changes in Support library to run correctly: https://reviews.llvm.org/D36265 https://reviews.llvm.org/D36226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D35787: [clang-tidy] Ignore vector in inefficient-vector-operation.

hokein added a comment. In https://reviews.llvm.org/D35787#819007, @alexfh wrote: > Should we look at whether the size is statically known? Do you mean the size of the template type T in `vector`? STL only provides a template specialization for `std::vector`, so I think excluding `vector` is

[PATCH] D36259: [OpenCL] Remove extra select functions from opencl-c.h

yaxunl added a comment. In https://reviews.llvm.org/D36259#830122, @bader wrote: > Out of curiosity: how did you detect this? > Can we use the same approach for writing tests? Some user code generated call to a select function which we do not have in library, then Brian found that there are e

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.h:121-122 +public: + /// Returns the number of threads to use when shouldRunsynchronously() is + /// false. Must not be called if shouldRunsynchronously() is true. + unsigned getThreadsCount(); --

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov updated this revision to Diff 109527. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Addressed review comments. - Fixed typos. - Renamed SchedulingParams to SchedulingOptions. https://reviews.llvm.org/D36261 Files: clangd/ClangdLSPServer.cpp cl

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. Ping. https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

atanasyan added inline comments. Comment at: include/clang/Driver/Options.td:2065 +def mno_uninit_const_in_rodata : Flag<["-"], "mno-uninit-const-in-rodata">, + Group, HelpText<"Do not Place uninitialized constants in the " + "read-only data section ins

[PATCH] D36208: [mips] Enable `long_call/short_call` attributes on MIPS64

atanasyan updated this revision to Diff 109528. atanasyan retitled this revision from "[mips] Enable target-specific attributes for MIPS64" to "[mips] Enable `long_call/short_call` attributes on MIPS64". atanasyan edited the summary of this revision. atanasyan added a comment. Simplify and reduce

Re: [clang-tools-extra] r308721 - [clangd] Specified --gcc-toolchain explicitly in VFS test.

My builder is failing, [ RUN ] ClangdVFSTest.SearchLibDir /home/bb/bootstrap-clang-libcxx-lld-i686-linux/llvm-project/clang-tools-extra/unittests/clangd/ClangdTests.cpp:492: Failure Value of: DiagConsumer.hadErrorInLastDiags() Actual: true Expected: false [ FAILED ] ClangdVFSTest.SearchLi

r309935 - [mips] Add support -m(no-)embedded-data option

Author: sdardis Date: Thu Aug 3 06:04:29 2017 New Revision: 309935 URL: http://llvm.org/viewvc/llvm-project?rev=309935&view=rev Log: [mips] Add support -m(no-)embedded-data option Add support for the -membedded-data option which places constant data in the .rodata section, rather than the .sdata

[PATCH] D35914: [mips] Add support -m(no-)embedded-data option

This revision was automatically updated to reflect the committed changes. Closed by commit rL309935: [mips] Add support -m(no-)embedded-data option (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D35914 Files: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/lib/Dri

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

krasimir added a comment. Great! Comment at: clangd/ClangdServer.h:131 + /// Handles running WorkerRequests of ClangdServer on a separate threads. /// Currently runs only one worker thread. typo: "on separate threads" Comment at: clangd/Cla

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov updated this revision to Diff 109532. ilya-biryukov added a comment. - Removed SchedulingOptions altogether, replaced with AsyncThreadsCount. https://reviews.llvm.org/D36261 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdSer

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

johannes added a comment. In https://reviews.llvm.org/D36176#830341, @arphaman wrote: > LGTM. Although I'm not 100% sure it's fully NFC, so if you can't come up with > a test please justify why. There are changes that affect the output. Firstly the computation of the rightmost descendant; the

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov added inline comments. Comment at: clangd/tool/ClangdMain.cpp:69 + SchedulingOptions SchedOpts = + !RunSynchronously ? SchedulingOptions::RunOnWorkerThreads(ThreadsCount) +: SchedulingOptions::RunOnCallingThread(); kras

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov updated this revision to Diff 109534. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Fixed more typos/inconsistences in comments, pointed out by @krasimir. https://reviews.llvm.org/D36261 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServe

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

arphaman added a comment. Ok, please include this info in the commit message. https://reviews.llvm.org/D36176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r308721 - [clangd] Specified --gcc-toolchain explicitly in VFS test.

Seems like a proper fix. Do you want me to submit it for you? On Thu, Aug 3, 2017 at 3:03 PM, NAKAMURA Takumi wrote: > My builder is failing, > > [ RUN ] ClangdVFSTest.SearchLibDir > /home/bb/bootstrap-clang-libcxx-lld-i686-linux/llvm- > project/clang-tools-extra/unittests/clangd/ClangdTest

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: include/clang/Basic/Builtins.def:717 +ATOMIC_BUILTIN(__opencl_atomic_fetch_max, "v.", "t") + #undef ATOMIC_BUILTIN t-tye wrote: > Will the OpenCL 2.0 memory fences also be support

[clang-tools-extra] r309936 - ClangdTests: Try to unbreak the case CLANG_DEFAULT_CXX_STDLIB=libc++.

Author: chapuni Date: Thu Aug 3 06:30:43 2017 New Revision: 309936 URL: http://llvm.org/viewvc/llvm-project?rev=309936&view=rev Log: ClangdTests: Try to unbreak the case CLANG_DEFAULT_CXX_STDLIB=libc++. Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp Modified: clang-tools

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

johannes updated this revision to Diff 109537. johannes added a comment. use %python in tests https://reviews.llvm.org/D36178 Files: include/clang/Tooling/ASTDiff/ASTDiff.h lib/Tooling/ASTDiff/ASTDiff.cpp test/Tooling/clang-diff-json.cpp test/lit.cfg test/lit.site.cfg.in tools/clang

[PATCH] D36180: [clang-diff] Add option to dump the AST, one node per line

johannes updated this revision to Diff 109538. johannes added a comment. merge update https://reviews.llvm.org/D36180 Files: test/Tooling/clang-diff-ast.cpp test/Tooling/clang-diff-json.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp =

[PATCH] D36182: [clang-diff] Add HTML side-by-side diff output

johannes updated this revision to Diff 109539. johannes added a comment. make test work with python 2 https://reviews.llvm.org/D36182 Files: test/Tooling/Inputs/clang-diff-basic-src.cpp test/Tooling/clang-diff-basic.cpp test/Tooling/clang-diff-html.py tools/clang-diff/CMakeLists.txt t

[PATCH] D36176: [clang-diff] Fix some errors and inconsistencies

johannes updated this revision to Diff 109536. johannes edited the summary of this revision. johannes added a comment. update commit message https://reviews.llvm.org/D36176 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/A

[PATCH] D36178: [clang-diff] Move the JSON export function to clang-diff

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

mcrosier added a comment. Seems reasonable to me as well.. https://reviews.llvm.org/D36238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 109542. yaxunl marked 5 inline comments as done. yaxunl added a comment. Herald added subscribers: aheejin, dschuff, jfb. Revised by Tony's and John's comments. https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h

r309937 - [clang-format] Fix parsing of <>-style proto options

Author: krasimir Date: Thu Aug 3 06:43:45 2017 New Revision: 309937 URL: http://llvm.org/viewvc/llvm-project?rev=309937&view=rev Log: [clang-format] Fix parsing of <>-style proto options Summary: This patch fixes the parsing of proto option fields like `option op = <...>`. Previously the parser

[PATCH] D36217: [clang-format] Fix parsing of <>-style proto options

This revision was automatically updated to reflect the committed changes. Closed by commit rL309937: [clang-format] Fix parsing of <>-style proto options (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D36217 Files: cfe/trunk/lib/Format/UnwrappedLineParser.cpp cfe/tru

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis updated this revision to Diff 109545. sdardis marked an inline comment as done. sdardis added a comment. Address review comment. https://reviews.llvm.org/D35917 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/TargetInfo.cpp lib/Driver

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1523 + CmdArgs.push_back("-muninit-const-in-rodata"); + A->claim(); +} atanasyan wrote: > What's happened if the `-muninit-const-in-rodata` is used without > `-m

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

gamesh411 updated this revision to Diff 109546. gamesh411 added a comment. Applied most of the suggested changes, thanks for all the insights! https://reviews.llvm.org/D33672 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnal

r309940 - [mips] Implement -muninit-const-in-rodata

Author: sdardis Date: Thu Aug 3 07:01:17 2017 New Revision: 309940 URL: http://llvm.org/viewvc/llvm-project?rev=309940&view=rev Log: [mips] Implement -muninit-const-in-rodata This option when combined with -mgpopt and -membedded-data places all uninitialized constant variables in the read-only s

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

This revision was automatically updated to reflect the committed changes. Closed by commit rL309940: [mips] Implement -muninit-const-in-rodata (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D35917 Files: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/include/clan

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. Thanks for the reviews of all of these options. Repository: rL LLVM https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35847: clang-format: Fix left pointer alignment after delctype/typeof

krasimir added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2206 +return (Left.is(tok::r_paren) && Line.MightBeFunctionDecl && +!(Left.MatchingParen && Left.MatchingParen->Previous && + Left.MatchingParen->Previous->isOneOf(tok::kw_typeo

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

gamesh411 marked 9 inline comments as done. gamesh411 added a comment. As for the the loss of precision problem, in the special case of char the size of char is known. However does the analysis have the necessary information in this stage to know the size of an int for example? I found bit-width

Re: r309940 - [mips] Implement -muninit-const-in-rodata

On Thu, Aug 03, 2017 at 02:01:17PM -, Simon Dardis via cfe-commits wrote: > Author: sdardis > Date: Thu Aug 3 07:01:17 2017 > New Revision: 309940 > > URL: http://llvm.org/viewvc/llvm-project?rev=309940&view=rev > Log: > [mips] Implement -muninit-const-in-rodata > > This option when combined

[PATCH] D27207: Adds hasUnqualifiedDesugaredType to allow matching through type sugar.

alexfh added inline comments. Comment at: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h:2749 +/// \endcode +/// The matcher type(hasUniqualifeidDesugaredType(recordType())) matches +/// both B and A. Typo: hasUniqualifeidDesugaredType (actually, two typos).

[PATCH] D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos

krasimir updated this revision to Diff 109551. krasimir added a comment. - Rebase with master https://reviews.llvm.org/D36143 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestProto.cpp unittests/Format/FormatTestTextProto.cpp Index: unittests/Format/FormatTestTextPr

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun added a comment. In https://reviews.llvm.org/D34512#829712, @rsmith wrote: > Organizationally, this seems fine. Carry on :) Great news! Thank you! https://reviews.llvm.org/D34512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 109552. xazax.hun marked 3 inline comments as done. xazax.hun added a comment. - Addressed review comments. https://reviews.llvm.org/D34512 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt include/clang/Basic/Diagnostic

[PATCH] D36143: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos

This revision was automatically updated to reflect the committed changes. Closed by commit rL309941: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D36143 Files: cfe/trunk/lib/Format/ContinuationIn

r309941 - [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos

Author: krasimir Date: Thu Aug 3 07:17:29 2017 New Revision: 309941 URL: http://llvm.org/viewvc/llvm-project?rev=309941&view=rev Log: [clang-format] Fix indent of 'key <...>' and 'key {...}' in text protos Summary: This patch fixes the indentation of the code pattern `key <...>`and `key {...}`

[PATCH] D34512: Add preliminary Cross Translation Unit support library

krasimir added inline comments. Comment at: include/clang/CrossTU/CrossTUDiagnostic.h:16 +namespace clang { + namespace diag { +enum { LLVM Style uses no indent for namespaces. Reformat with `clang-format`. Comment at: include/clang/CrossT

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

yaxunl updated this revision to Diff 109556. yaxunl added a comment. Add assert to make sure pre-defined macros __OPENCL_MEMORY_SCOP_* to be consistent with SyncScope enum. https://reviews.llvm.org/D28691 Files: docs/LanguageExtensions.rst include/clang/AST/Expr.h include/clang/Basic/Bui

[PATCH] D34512: Add preliminary Cross Translation Unit support library

xazax.hun updated this revision to Diff 109559. xazax.hun marked 2 inline comments as done. xazax.hun added a comment. - Address further review comments. https://reviews.llvm.org/D34512 Files: include/clang/Basic/AllDiagnostics.h include/clang/Basic/CMakeLists.txt include/clang/Basic/Diag

r309942 - [mips] Fixup r309940.

Author: sdardis Date: Thu Aug 3 07:35:06 2017 New Revision: 309942 URL: http://llvm.org/viewvc/llvm-project?rev=309942&view=rev Log: [mips] Fixup r309940. Needed a // REQUIRES: mips-registered-target Modified: cfe/trunk/test/CodeGen/mips-uninit-const-in-ro.c Modified: cfe/trunk/test/CodeGe

[PATCH] D36264: [clang-tidy] Ignore macros in make-unique check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with one comment. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:114 - if (Construct) + if (Construct && !Construct->getLocation().isMacroID()) checkConst

[PATCH] D36016: [clang-tidy] Support initializer-list constructor cases in modernize-make-unique.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a couple of comments. Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:253 +// std::make_smart_ptr({}); +auto NumArgs = NewConstruct->getNumAr

[PATCH] D36016: [clang-tidy] Support initializer-list constructor cases in modernize-make-unique.

malcolm.parsons added inline comments. Comment at: test/clang-tidy/modernize-make-unique.cpp:291 + + // Initialization with ordinary constructor. + std::unique_ptr PG3 = std::unique_ptr(new G{1, 2}); The comment doesn't match the test? https://reviews.llvm.or

Re: [PATCH] D27827: [ObjC] CodeGen support for @available on macOS

On Thu, Aug 3, 2017 at 4:13 AM, Alex Lorenz via Phabricator via cfe-commits wrote: > arphaman added a comment. > > In https://reviews.llvm.org/D27827#829661, @thakis wrote: > > > We just noticed that if you call __builtin_available() for the first > time after activating your app's sandbox, the f

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

thakis added a comment. Looks like the email reply didn't make it to phab, so here it is again: It's in this program, which is pretty stand-alone: https://cs.chromium.org/chromium/src/chrome/utility/safe_browsing/mac/crdmg.cc?q=crdmg&sq=package:chromium&l=95 EnableSandbox() is on line 134. clan

[PATCH] D33722: [clang-tidy] Add checker for undelegated copy of base classes

szdominik updated this revision to Diff 109564. szdominik marked 2 inline comments as done. szdominik added a comment. Herald added a subscriber: JDevlieghere. Fixed check-fixes lines in test cases. Updated matcher definition. https://reviews.llvm.org/D33722 Files: clang-tidy/misc/CMakeLists.

[PATCH] D36051: [clang-tidy] List the checkers with autofix

alexfh added a comment. In https://reviews.llvm.org/D36051#825428, @xazax.hun wrote: > Maybe instead of a separate list, having this information like yes/no column > in a table in the original is more user-friendly. What the better format is would depend on for which purpose do we want to exp

[PATCH] D36150: [clangd] LSP extension to switch between source/header file

Nebiroth updated this revision to Diff 109566. Nebiroth marked 7 inline comments as done. Nebiroth added a comment. [clangd] LSP extension to switch between source/header file https://reviews.llvm.org/D36150 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D27827: [ObjC] CodeGen support for @available on macOS

thakis added a comment. (Our workaround is to call __builtin_available() once before engaging the sandbox, which isn't so bad. Just thought I'd let you know about it; this isn't a serious bug for us.) Repository: rL LLVM https://reviews.llvm.org/D27827 ___

[PATCH] D35894: [clangd] Code hover for Clangd

malaperle added a comment. In https://reviews.llvm.org/D35894#830178, @ilya-biryukov wrote: > In https://reviews.llvm.org/D35894#829190, @malaperle wrote: > > > @Nebiroth I think it's OK to put this on hold until we make the "semantic" > > hover and figure out how to have both. From our perspect

r309948 - Fix some typos in the documentation.

Author: xazax Date: Thu Aug 3 08:38:14 2017 New Revision: 309948 URL: http://llvm.org/viewvc/llvm-project?rev=309948&view=rev Log: Fix some typos in the documentation. Patch by: Reka Nikolett Kovacs Modified: cfe/trunk/docs/InternalsManual.rst Modified: cfe/trunk/docs/InternalsManual.rst U

RE: r309940 - [mips] Implement -muninit-const-in-rodata

> From: Joerg Sonnenberger [mailto:jo...@bec.de] > Sent: 03 August 2017 15:12 > To: cfe-commits@lists.llvm.org > Cc: Simon Dardis > Subject: Re: r309940 - [mips] Implement -muninit-const-in-rodata > > On Thu, Aug 03, 2017 at 02:01:17PM -, Simon Dardis via cfe-commits > wrote: > > Author: sdard

[PATCH] D36249: Mark tests that need intel 80-bit floats as x86-only

saugustine added a comment. In https://reviews.llvm.org/D36249#830121, @weimingz wrote: > I tried to address it via checking pre-defined macros: > https://reviews.llvm.org/D31573 > > As long as the macros are defined correctly by clang, we don't need to worry > about the specific target machine

[PATCH] D28691: Add OpenCL 2.0 atomic builtin functions as Clang builtin

rjmccall added a comment. LGTM. I'm fine with the plan to handle potentially non-constant scopes in a follow-up patch. Comment at: include/clang/Basic/SyncScope.h:21 +/// \brief Defines the synch scope values used by the atomic builtins and +/// expressions +enum class SyncSc

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic updated this revision to Diff 109571. spetrovic marked 2 inline comments as done. Repository: rL LLVM https://reviews.llvm.org/D34878 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/CC1Options.td include/clang/Driver/Options.td lib/Driver/ToolChains/A

[PATCH] D34878: [ARM] Option for reading thread pointer from coprocessor register

spetrovic added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:136 +if (ThreadPointer == ReadTPMode::Invalid && +!StringRef(A->getValue()).empty()) { + D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args); bruno wrote: > Wha

r309955 - [diagtool] Add ability to pass in the id and return the name for a

Author: dhinton Date: Thu Aug 3 09:13:13 2017 New Revision: 309955 URL: http://llvm.org/viewvc/llvm-project?rev=309955&view=rev Log: [diagtool] Add ability to pass in the id and return the name for a particular diagnostic. Differential Revision: https://reviews.llvm.org/D36252 Modified: cfe

[PATCH] D36252: [diagtool] Add ability to get name from id

This revision was automatically updated to reflect the committed changes. Closed by commit rL309955: [diagtool] Add ability to pass in the id and return the name for a (authored by dhinton). Repository: rL LLVM https://reviews.llvm.org/D36252 Files: cfe/trunk/test/Misc/find-diagnostic-id.c

Re: r308996 - [coroutines] Add serialization/deserialization of coroutines

On Wed, Aug 2, 2017 at 3:29 PM, Richard Smith wrote: > On 31 July 2017 at 09:11, Hans Wennborg via cfe-commits > wrote: >> >> Richard, Gor asked for this to be merged to 5.0. What do you think? > > > Sounds good to me. r309954. Thanks! > >> On Tue, Jul 25, 2017 at 11:01 AM, Gor Nishanov via cfe

[libcxx] r309958 - Merging r309917:

Author: hans Date: Thu Aug 3 09:34:10 2017 New Revision: 309958 URL: http://llvm.org/viewvc/llvm-project?rev=309958&view=rev Log: Merging r309917: r309917 | ericwf | 2017-08-02 19:50:43 -0700 (Wed, 02 Aug 2017) | 4 lines Ad

[PATCH] D35678: Omit sumbodule semantics for TS modules

boris added a comment. Ping. https://reviews.llvm.org/D35678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32199: [TySan] A Type Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#828526, @rjmccall wrote: > Has this proposal run aground? I'm going back over some old patches that > I've been CC'ed on and trying to make sure they're not blocking on my review. I need to rebase these now that we've "fixed" the uni

r309960 - Revert r304836.

Author: nico Date: Thu Aug 3 09:46:17 2017 New Revision: 309960 URL: http://llvm.org/viewvc/llvm-project?rev=309960&view=rev Log: Revert r304836. See discussion in https://reviews.llvm.org/D33900#824172 Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL

[PATCH] D33900: Print registered targets in clang's version information

thakis added a comment. I've reverted this in 309960, as discussed. https://reviews.llvm.org/D33900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Ping. On 7/28/17, 7:57 PM, "Shoaib Meenai" wrote: Marshall, Eric, Hans, Any objections to backporting this to 5.0? It fixes a potential visibility issue for clients of the header. On 7/28/17, 7:54 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-commits" wrote:

  1   2   >