yamaguchi updated this revision to Diff 109283.
yamaguchi added a comment.
Fixed typo.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Driver/au
ruiu accepted this revision.
ruiu added a comment.
LGTM
https://reviews.llvm.org/D36209
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yamaguchi
Date: Wed Aug 2 00:20:27 2017
New Revision: 309794
URL: http://llvm.org/viewvc/llvm-project?rev=309794&view=rev
Log:
[Bash-autocompletion] Add comment to test so that it is easier to fix
Summary:
clang/test/Driver/autocomplete.c is a test for --autocomplete, and this
test might
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309794: [Bash-autocompletion] Add comment to test so that it
is easier to fix (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36209?vs=109283&id=109285#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309795: Use VFS operations in FileManager::makeAbsolutePath.
(authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36155
Files:
cfe/trunk/lib/Basic/FileManager.cpp
cfe/trunk/unitt
Author: ibiryukov
Date: Wed Aug 2 00:25:24 2017
New Revision: 309795
URL: http://llvm.org/viewvc/llvm-project?rev=309795&view=rev
Log:
Use VFS operations in FileManager::makeAbsolutePath.
Summary: It used to call into llvm::sys::fs::make_absolute.
Reviewers: akyrtzi, erikjv, bkramer, krasimir,
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
I just wanted to take a step back and discuss what we want to get from code
hover in the first place.
I would expect a typical code hover to be a bit more involved and
klimek updated this revision to Diff 109287.
klimek marked an inline comment as done.
klimek added a comment.
Address review comment.
https://reviews.llvm.org/D36154
Files:
clang-tidy/google/StringReferenceMemberCheck.cpp
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/InaccurateE
klimek added a comment.
ptal
https://reviews.llvm.org/D36154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kimgr added a comment.
I was about to suggest SymbolLocation or even SymbolLoc, but it appears to keep
track of more than locations. "Reference" sounds a little open-ended. No more
ideas here, I'm afraid.
Repository:
rL LLVM
https://reviews.llvm.org/D36156
___
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
looks good
https://reviews.llvm.org/D36154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: danielmarjamaki
Date: Wed Aug 2 01:26:56 2017
New Revision: 309799
URL: http://llvm.org/viewvc/llvm-project?rev=309799&view=rev
Log:
[StaticAnalyzer] Fix false positives for unreachable code in macros.
Example:
#define MACRO(C) if (C) { static int x; .. }
void foo() {
MACRO(0)
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309799: [StaticAnalyzer] Fix false positives for unreachable
code in macros. (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D36141?vs=109086&id=109294#toc
Repository:
Author: ibiryukov
Date: Wed Aug 2 01:53:48 2017
New Revision: 309800
URL: http://llvm.org/viewvc/llvm-project?rev=309800&view=rev
Log:
[clangd] Capitalized descriptions of clangd options. NFC.
To follow the style of other options shown on `clangd -help`.
Modified:
clang-tools-extra/trunk/cl
Author: ibiryukov
Date: Wed Aug 2 02:08:39 2017
New Revision: 309801
URL: http://llvm.org/viewvc/llvm-project?rev=309801&view=rev
Log:
[clangd] Run clang-format on all clangd sources. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
clang-tools-extra/trunk/clangd/ClangdL
klimek added inline comments.
Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:32
+/// a macro expansion.
+class SymbolOccurrence {
+public:
I understand the exact vs. non-exact idea, but can you expand a bit on how
Obj-C code looks where
sdardis added a comment.
Some comments:
Currently there is no support in the backend for the interrupt attribute for
mips64 / using N32 & N64 abis, it will give a fatal error. Previously the
backend lacked support for the static relocation model which is an expected
requirement for interrupt h
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM. Please document this change in the release notes.
https://reviews.llvm.org/D36191
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
atanasyan added a comment.
In https://reviews.llvm.org/D36208#828853, @sdardis wrote:
> Currently there is no support in the backend for the interrupt attribute for
> mips64 / using N32 & N64 abis, it will give a fatal error. Previously the
> backend lacked support for the static relocation mod
arphaman added a comment.
That makes sense. It's kinda weird not to report the `null`, but I guess it
makes sense if the `null` sanitiser is off. It's not actually UB unless it's
dereferenced, right, so casts are allowed?
Comment at: test/CodeGenCXX/ubsan-type-checks.cpp:73
+
aaron.ballman added a comment.
In https://reviews.llvm.org/D36208#828881, @atanasyan wrote:
> In https://reviews.llvm.org/D36208#828853, @sdardis wrote:
>
> > Currently there is no support in the backend for the interrupt attribute
> > for mips64 / using N32 & N64 abis, it will give a fatal erro
krasimir updated this revision to Diff 109322.
krasimir added a comment.
- Fix similar issue for 'key {...}'
https://reviews.llvm.org/D36143
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestProto.cpp
unittests/Format/FormatTestTextProto.cpp
Index: unittests/Format/F
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:65-68
+ ArrayRef getNameLocations() const { return Locations; }
+ ArrayRef getNameLengths() const {
+return llvm::makeArrayRef(NameLengths, Locations.size());
+ }
-
johannes added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96
: TreeImpl(llvm::make_unique(this, Node, AST)) {}
+ SyntaxTree(const SyntaxTree &Tree) = delete;
~SyntaxTree();
arphaman wrote:
> It might be better to add a move co
arphaman added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96
: TreeImpl(llvm::make_unique(this, Node, AST)) {}
+ SyntaxTree(const SyntaxTree &Tree) = delete;
~SyntaxTree();
johannes wrote:
> arphaman wrote:
> > It might be bet
arphaman added inline comments.
Comment at: include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:65-68
+ ArrayRef getNameLocations() const { return Locations; }
+ ArrayRef getNameLengths() const {
+return llvm::makeArrayRef(NameLengths, Locations.size());
+ }
-
sdardis added a comment.
I think for the interrupt attribute, it should be an error. Currently it's an
implementation detail that it errors out in the backend but in principal it can
be supported (I haven't gotten around to addressing it.)
For the micromips attribute, I believe it should be an
aaron.ballman added a comment.
In https://reviews.llvm.org/D36208#828955, @sdardis wrote:
> I think for the interrupt attribute, it should be an error. Currently it's an
> implementation detail that it errors out in the backend but in principal it
> can be supported (I haven't gotten around to
Author: klimek
Date: Wed Aug 2 06:04:44 2017
New Revision: 309809
URL: http://llvm.org/viewvc/llvm-project?rev=309809&view=rev
Log:
Unify and simplify the behavior of the hasDeclaration matcher.
Originally, we weren't able to match on Type nodes themselves (only QualType),
so the hasDeclaration
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309809: Unify and simplify the behavior of the
hasDeclaration matcher. (authored by klimek).
Changed prior to commit:
https://reviews.llvm.org/D27104?vs=108608&id=109325#toc
Repository:
rL LLVM
http
klimek added a comment.
Just as a general note: adding cfe-commits after the fact is usually not a good
idea, as we lose the history of the review in the email list (which is the
source of truth).
https://reviews.llvm.org/D36184
___
cfe-commits ma
arphaman updated this revision to Diff 109326.
arphaman added a comment.
Address review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D36156
Files:
include/clang/Tooling/Refactoring/Rename/RenamingAction.h
include/clang/Tooling/Refactoring/Rename/SymbolName.h
include/clang/Too
Author: klimek
Date: Wed Aug 2 06:13:11 2017
New Revision: 309810
URL: http://llvm.org/viewvc/llvm-project?rev=309810&view=rev
Log:
Adapt clang-tidy checks to changing semantics of hasDeclaration.
Differential Revision: https://reviews.llvm.org/D36154
Modified:
clang-tools-extra/trunk/clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309810: Adapt clang-tidy checks to changing semantics of
hasDeclaration. (authored by klimek).
Repository:
rL LLVM
https://reviews.llvm.org/D36154
Files:
clang-tools-extra/trunk/clang-tidy/google/St
krasimir created this revision.
This patch fixes the parsing of proto option fields like `option op = <...>`.
Previously the parser did not enter the right code path inside the angle braces,
causing the contents to be split into several unwrapped lines inside.
https://reviews.llvm.org/D36217
Fi
sdardis added a comment.
@aaron.ballman I missed your first comments when I'd submitted mine.
In https://reviews.llvm.org/D36208#828957, @aaron.ballman wrote:
> In https://reviews.llvm.org/D36208#828955, @sdardis wrote:
>
> > I think for the interrupt attribute, it should be an error. Currently
aaron.ballman added a comment.
In https://reviews.llvm.org/D36208#829006, @sdardis wrote:
> @aaron.ballman I missed your first comments when I'd submitted mine.
>
> In https://reviews.llvm.org/D36208#828957, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D36208#828955, @sdardis wrote:
>
malaperle added a comment.
In https://reviews.llvm.org/D35894#828702, @ilya-biryukov wrote:
> I just wanted to take a step back and discuss what we want to get from code
> hover in the first place.
>
> I would expect a typical code hover to be a bit more involved and include:
>
> - "kind" of a s
Author: arphaman
Date: Wed Aug 2 07:15:27 2017
New Revision: 309813
URL: http://llvm.org/viewvc/llvm-project?rev=309813&view=rev
Log:
[rename] NFC, extract symbol canonicalization logic into function
This function will be used by the clang-refactor's rename actions
Modified:
cfe/trunk/inclu
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522
// to be re-used for method bodies as well.
- ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope);
+ ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope|
+
hintonda added a comment.
In https://reviews.llvm.org/D36083#827745, @arphaman wrote:
> Makes sense. I'll see if I can get somewhere with the regex idea.
Btw, I created a quick prototype with sed and found that the diag strings
aren't unique -- which isn't surprising since there's no requireme
Author: waltl
Date: Wed Aug 2 07:36:52 2017
New Revision: 309815
URL: http://llvm.org/viewvc/llvm-project?rev=309815&view=rev
Log:
Define _GNU_SOURCE for RTEMS c++
Summary: This is required by the libc++ locale support.
Reviewers: jyknight
Subscribers: fedor.sergeev
Differential Revision: htt
arphaman added a comment.
This needs a test for the fixits as well, see test/FixIt/fixit-availability*
https://reviews.llvm.org/D36200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov added a comment.
> I think all of those would be great. Our objective is to bring basic but
> correct features that will put us close to parity with Eclipse CDT, so that
> our users can transition. In CDT only the "raw" source is shown, similar to
> this patch (except in CDT it at
Author: jvesely
Date: Wed Aug 2 08:00:59 2017
New Revision: 309820
URL: http://llvm.org/viewvc/llvm-project?rev=309820&view=rev
Log:
configure.py: Make python3 friendly
mostly prints and exceptions.
Few behavioral changes are documented in the text
Generated Makefile is identical between python2
christof commandeered this revision.
christof added a reviewer: salari01.
christof added a comment.
Herald added a subscriber: aheejin.
With the ok of the author, I'll try to get some movement on this work again.
https://reviews.llvm.org/D31814
___
chill added inline comments.
Comment at: lib/Parse/ParseCXXInlineMethods.cpp:521-522
// to be re-used for method bodies as well.
- ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope);
+ ParseScope FnScope(this, Scope::FnScope|Scope::DeclScope|
+
Hello all, buildbot is currently down due to hardware failure. We are
currently working on it. Sorry for the inconvenience.
--
Best Regards,
Victor
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
malaperle added a comment.
In https://reviews.llvm.org/D35894#829109, @ilya-biryukov wrote:
> > I think all of those would be great. Our objective is to bring basic but
> > correct features that will put us close to parity with Eclipse CDT, so that
> > our users can transition. In CDT only the
malaperle added a comment.
@Nebiroth I think it's OK to put this on hold until we make the "semantic"
hover and figure out how to have both. From our perspective, this is going
beyond parity of what we had before but it's seems like the right thing to do.
https://reviews.llvm.org/D35894
___
There is power outage in the area where the servers are located. They
say the power will be restored at 10:45 AM PDT, I'd estimate buildbot
online time about ~12:00.
On 08/02/2017 06:31 PM, Victor Leschuk wrote:
> Hello all, buildbot is currently down due to hardware failure. We are
> currently w
Buildbot is up and running. Sorry for the delay.
On 08/02/2017 06:31 PM, Victor Leschuk wrote:
> Hello all, buildbot is currently down due to hardware failure. We are
> currently working on it. Sorry for the inconvenience.
>
--
Best Regards,
Victor
_
thakis added a comment.
Awesome, thanks! Maybe mention the PR# for this in the commit message.
https://reviews.llvm.org/D36191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Should clang warn if you request static libc++ on fuchsia? It now silently
ignores the flag, right?
On Aug 1, 2017 9:18 PM, "Petr Hosek via Phabricator via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
This revision was automatically updated to reflect the committed changes.
Closed by commit
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This looks reasonable to me, once it's been formatted. Let's give @rsmith a few
days to comment before committing, though.
https://reviews.llvm.org/D33676
___
ilya-biryukov created this revision.
Allows to have multiple instances of RealFileSystem that have
different working directories.
https://reviews.llvm.org/D36226
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
unittests/Basic/VirtualFileSystemTest.cpp
Index
ilya-biryukov added a comment.
Also tested by temporarily replacing `getRealFileSystem()` body with `return
createThreadFriendlyRealFS();` and running `check-all`, all tests passed.
To be more specific, there was one crash in clang-format, as there is a piece
of code that uses raw pointer from `
chill updated this revision to Diff 109366.
chill added a comment.
Updated with only whitespace changes after formating each changed line with
clang-format.
https://reviews.llvm.org/D33676
Files:
include/clang/Sema/Scope.h
lib/Parse/ParseCXXInlineMethods.cpp
lib/Parse/ParseDecl.cpp
lib
chill added a comment.
Thanks for the review, I'll wait a few days.
https://reviews.llvm.org/D33676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erik.pilkington added a comment.
In https://reviews.llvm.org/D36200#829104, @arphaman wrote:
> This needs a test for the fixits as well, see test/FixIt/fixit-availability*
Why? This patch doesn't change the behavior of the fixits, so there isn't any
new behavior to test.
https://reviews.llvm
arphaman added a comment.
Right, sorry, I didn't realize that code was moved.
https://reviews.llvm.org/D36200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Basic/OpenCLOptions.h:132
- void disableAll() {
+ void enableAll(bool On = true) {
for (llvm::StringMap::iterator I = OptMap.begin(),
May be the name could be `setAll` since it's doing both enabl
aaron.ballman added inline comments.
Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23
+ memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()),
+ varDecl(hasStaticStorageDuration(,
+
aaron.ballman added a comment.
In https://reviews.llvm.org/D33672#827513, @xazax.hun wrote:
> Even though it is not undefined behavior in C, it can still cause surprising
> behavior for the users. I think maybe putting it into the optin package
> instead of cplusplus is better. What do you thin
coby created this revision.
Herald added a subscriber: eraman.
Currently, only non-negative immediate is allowed prior to a brac expression
(memory reference).
MASM / GAS does not have any problem cope with the left side of the real line,
so we should be able to as well.
llvm: https://reviews.l
Author: marshall
Date: Wed Aug 2 10:31:09 2017
New Revision: 309838
URL: http://llvm.org/viewvc/llvm-project?rev=309838&view=rev
Log:
Fix PR33727: std::basic_stringbuf only works with DefaultConstructible
allocators. Thanks to Jonathan Wakely for the report and suggested fix
Modified:
libcx
aaron.ballman added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:1511
+ StringRef Suff64 = "/64";
+ // Solaris uses platform-specific suffixes instead of /64
+ if (TargetTriple.getOS() == llvm::Triple::Solaris) {
Add a period at the end of the co
Merged to 5.0 in r309844.
On Sun, Jul 30, 2017 at 2:14 PM, Brad Smith via cfe-commits
wrote:
> Author: brad
> Date: Sun Jul 30 14:13:59 2017
> New Revision: 309523
>
> URL: http://llvm.org/viewvc/llvm-project?rev=309523&view=rev
> Log:
> Also pass -pie back to the linker when linking on OpenBSD.
bruno added inline comments.
Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:136
+if (ThreadPointer == ReadTPMode::Invalid &&
+!StringRef(A->getValue()).empty()) {
+ D.Diag(diag::err_drv_invalid_mtp) << A->getAsString(Args);
What happens if you pa
vsk marked an inline comment as done.
vsk added a comment.
In https://reviews.llvm.org/D36112#828891, @arphaman wrote:
> That makes sense. It's kinda weird not to report the `null`, but I guess it
> makes sense if the `null` sanitiser is off.
It is kinda weird, but any such diagnostic would fi
At first thank you for the nice test case.
This crash is not caused by r305903. The root cause is that instantiation
of f is triggered when parse of f is not finished yet. This is the
case just addressed by that change.
The instantiation is requested by the code (https://github.com/llvm-mirro
r/cl
Author: vedantk
Date: Wed Aug 2 11:10:31 2017
New Revision: 309846
URL: http://llvm.org/viewvc/llvm-project?rev=309846&view=rev
Log:
[ubsan] Have -fsanitize=vptr emit a null check if -fsanitize=null isn't
available
In r309007, I made -fsanitize=null a hard prerequisite for -fsanitize=vptr. I
di
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309846: [ubsan] Have -fsanitize=vptr emit a null check if
-fsanitize=null isn't… (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D36112?vs=108988&id=109385#toc
Repository:
rL
Author: marshall
Date: Wed Aug 2 11:21:34 2017
New Revision: 309851
URL: http://llvm.org/viewvc/llvm-project?rev=309851&view=rev
Log:
Fix shadowing warning
Modified:
libcxx/trunk/test/std/input.output/string.streams/stringstream.cons/string.pass.cpp
Modified:
libcxx/trunk/test/std/input.o
Author: vedantk
Date: Wed Aug 2 11:24:12 2017
New Revision: 309852
URL: http://llvm.org/viewvc/llvm-project?rev=309852&view=rev
Log:
[docs] Remove accidental unindent to appease the sphinx bot
Bot failure:
http://lab.llvm.org:8011/builders/clang-sphinx-docs/builds/12043/steps/docs-clang-html/log
phosek added a comment.
One more thing, would it be possible add a test case to `test/Driver/fuchsia.c`
covering this?
Repository:
rL LLVM
https://reviews.llvm.org/D35922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
euhlmann added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:383
+ Current.Previous->is(tok::hash) && State.FirstIndent > 0) {
+// subtract 1 so indent lines up with non-preprocessor code
+Spaces += State.FirstIndent;
djasper wrote
jmgao updated this revision to Diff 109411.
jmgao added a comment.
Remove accidental trailing backslash.
https://reviews.llvm.org/D36237
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Analysis/ThreadSafety.cpp
lib/Sema/SemaDeclAttr.cpp
test/Sema/attr
Author: marshall
Date: Wed Aug 2 13:29:26 2017
New Revision: 309881
URL: http://llvm.org/viewvc/llvm-project?rev=309881&view=rev
Log:
Rename a couple variables to eliminate a shadow warning. No functionality change
Modified:
libcxx/trunk/src/experimental/filesystem/operations.cpp
Modified:
thakis created this revision.
This helps some tools that do things based on the output's extension.
For example, we got reports from users on Windows that have a tool that scan a
build output dir (but skip .obj files). The tool would keep the "foo.obj-12345"
file open, and then when clang tried
jmgao updated this revision to Diff 109412.
jmgao added a comment.
Fix commit messages.
https://reviews.llvm.org/D36237
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Analysis/ThreadSafety.cpp
lib/Sema/SemaDeclAttr.cpp
test/Sema/attr-capabilities.c
yaxunl updated this revision to Diff 109406.
yaxunl marked 29 inline comments as done.
yaxunl added a comment.
Revised by reviewers' comments.
https://reviews.llvm.org/D28691
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/Basic/Builtins.def
include/clang/Basic
johannes updated this revision to Diff 109414.
johannes added a comment.
move most functional changes to other commits
move constructor for Syntaxtree
https://reviews.llvm.org/D36176
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling
Author: rafael
Date: Wed Aug 2 13:32:35 2017
New Revision: 309885
URL: http://llvm.org/viewvc/llvm-project?rev=309885&view=rev
Log:
Update for llvm change.
Modified:
cfe/trunk/lib/Parse/ParseStmtAsm.cpp
cfe/trunk/tools/driver/cc1as_main.cpp
Modified: cfe/trunk/lib/Parse/ParseStmtAsm.cpp
thakis added a comment.
We just noticed that if you call __builtin_available() for the first time after
activating your app's sandbox, the function will fail:
SandboxViolation: crdmg(15489) deny file-read-data
/System/Library/CoreServices/SystemVersion.plist
Violation: deny file-read-data
johannes updated this revision to Diff 109415.
johannes added a comment.
add some test, replace -no-compilation-database with --
https://reviews.llvm.org/D36177
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-args.sh
test/Tooling/cl
johannes updated this revision to Diff 109416.
johannes added a comment.
getSourceRangeOffsets, test
https://reviews.llvm.org/D36178
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-json.cpp
tools/clang-diff/ClangDiff.cpp
Index: too
johannes updated this revision to Diff 109417.
johannes added a comment.
remove unused SubtreeIterator
https://reviews.llvm.org/D36179
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-b
Author: shenhan
Date: Wed Aug 2 12:53:38 2017
New Revision: 309873
URL: http://llvm.org/viewvc/llvm-project?rev=309873&view=rev
Log:
[UBSan] Provide default blacklist filename for UBSan
Summary:
This is to provide a default blacklist filename for UBSan.
While UBSan is turned on, it's better tha
johannes updated this revision to Diff 109420.
johannes added a comment.
rename to -dump-matches, add a test
https://reviews.llvm.org/D36181
Files:
test/Tooling/clang-diff-args.sh
test/Tooling/clang-diff-basic.cpp
tools/clang-diff/ClangDiff.cpp
Index: tools/clang-diff/ClangDiff.cpp
johannes updated this revision to Diff 109419.
johannes added a comment.
Herald added a subscriber: klimek.
add a test
https://reviews.llvm.org/D36180
Files:
test/Tooling/clang-diff-ast.cpp
test/Tooling/clang-diff-json.cpp
tools/clang-diff/ClangDiff.cpp
Index: tools/clang-diff/ClangDiff.
johannes updated this revision to Diff 109421.
johannes added a comment.
-
https://reviews.llvm.org/D36182
Files:
test/Tooling/Inputs/clang-diff-basic-src.cpp
test/Tooling/clang-diff-basic.cpp
test/Tooling/clang-diff-html.py
tools/clang-diff/CMakeLists.txt
tools/clang-diff/ClangDiff.c
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks good, but let's confirm with Richard before we change behavior.
https://reviews.llvm.org/D36238
___
cfe-commits mailing list
cfe-commits@lists.ll
johannes updated this revision to Diff 109422.
johannes edited the summary of this revision.
johannes added a comment.
-
https://reviews.llvm.org/D36183
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/Inputs/clang-diff-basic-src.cpp
test/Tooli
johannes updated this revision to Diff 109423.
johannes added a comment.
tests
https://reviews.llvm.org/D36184
Files:
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
Index: test/Tooling/clang-diff-ast.cpp
===
-
johannes updated this revision to Diff 109424.
johannes added a comment.
add test for Options.MaxSize
https://reviews.llvm.org/D36185
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-bottomup.cpp
test/Tooling/clang-diff-opt.cpp
tes
johannes updated this revision to Diff 109425.
johannes added a comment.
NFC renames
https://reviews.llvm.org/D36186
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
test/Tooling/clang-diff-basic.cpp
test/Tooling/clang-diff
johannes updated this revision to Diff 109426.
johannes added a comment.
renamse, NFC
https://reviews.llvm.org/D36186
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
test/Tooling/clang-diff-ast.cpp
test/Tooling/clang-diff-basic.cpp
test/Tooling/clang-dif
johannes added inline comments.
Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:96
: TreeImpl(llvm::make_unique(this, Node, AST)) {}
+ SyntaxTree(const SyntaxTree &Tree) = delete;
~SyntaxTree();
arphaman wrote:
> johannes wrote:
> > arphaman wrote:
johannes added a comment.
In https://reviews.llvm.org/D36177#828909, @arphaman wrote:
> There should be a test that ensures that `stop-after` works and `extra-arg`s
> are correctly passed to the compiler.
`stop-after` is not tested yet. It is also broken in this patch, I will move it
to a lat
1 - 100 of 137 matches
Mail list logo
