lebedev.ri added a comment.
In https://reviews.llvm.org/D33365#802884, @lebedev.ri wrote:
> In https://reviews.llvm.org/D33365#775916, @alexfh wrote:
>
> > I think, this kind of a check needs some prior research (not necessarily in
> > the sense of a printed paper, but at least a thoughtful anal
chill added a comment.
Ping.
https://reviews.llvm.org/D33676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst created this revision.
Herald added a subscriber: klimek.
clang-format would previously drop the whitespace after `extends` in code such
as:
class Foo extends {} {}
Where the first set of curly braces is an inline object literal type.
https://reviews.llvm.org/D36131
Files:
lib/Fo
mprobst created this revision.
Herald added a subscriber: klimek.
Formerly, `import {default as X} from y;` would not be recognized as an import.
https://reviews.llvm.org/D36132
Files:
lib/Format/SortJavaScriptImports.cpp
unittests/Format/SortImportsTestJS.cpp
Index: unittests/Format/Sort
ilya-biryukov created this revision.
The new implementation allows code completion that never waits for AST.
https://reviews.llvm.org/D36133
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/ClangdUnitStore.cpp
clangd/ClangdUnitSto
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D35012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: malcolm.parsons
Date: Tue Aug 1 02:54:05 2017
New Revision: 309668
URL: http://llvm.org/viewvc/llvm-project?rev=309668&view=rev
Log:
[clang-tidy] Handle anonymous structs/unions in member init checks.
Use getAnyMember() instead of getMember() to avoid crash on anonymous
structs/unions.
D
Author: malcolm.parsons
Date: Tue Aug 1 02:53:55 2017
New Revision: 309667
URL: http://llvm.org/viewvc/llvm-project?rev=309667&view=rev
Log:
[ASTMatchers] Allow forField to match indirect fields.
This is needed for PR32966.
Reviewed by alexfh.
Modified:
cfe/trunk/include/clang/ASTMatchers/
ilya-biryukov added a comment.
I also want to rename ClangdUnit and ClangdUnitStore accordingly, but will do
that in a separate commit so that git-svn correctly detects the renames (i.e.
don't want file contents changes).
https://reviews.llvm.org/D36133
_
klimek added a comment.
Apart from nits, looks OK to me - Eric, are all your concerns addressed?
Comment at: include/clang/Tooling/Refactoring/ASTSelection.h:51-53
+ ast_type_traits::DynTypedNode Node;
+ SourceSelectionKind SelectionKind;
+ std::vector Children;
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Yep. Lgtm!
Repository:
rL LLVM
https://reviews.llvm.org/D35012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
bkramer added inline comments.
Comment at: clangd/ClangdServer.h:113
+ /// queue. The request will be run on a separate thread.
+ template void addToFront(Func &&F, Args &&...
As);
+ /// Add a new request to run function \p F with args \p As to the end of the
---
Author: coby
Date: Tue Aug 1 03:51:09 2017
New Revision: 309672
URL: http://llvm.org/viewvc/llvm-project?rev=309672&view=rev
Log:
[x86][inline-asm]Allow a pack of Control Debug to be properly picked
Allows the incorporation of legit (x86) Debug Regs within inline asm stataements
Differential Re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309672: [x86][inline-asm]Allow a pack of Control Debug to be
properly picked (authored by coby).
Changed prior to commit:
https://reviews.llvm.org/D36074?vs=108872&id=109073#toc
Repository:
rL LLVM
mprobst updated this revision to Diff 109078.
mprobst added a comment.
- revert bogus change
https://reviews.llvm.org/D36131
Files:
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
===
joerg added a comment.
I had a long discussion with James about this on IRC without reaching a clear
consensus. I consider forcing this behavior on all targets to be a major bug.
It should be opt-in and opt-in only:
(1) The header name is not mandated by any standard. It is not in any namespace
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D36131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/SortJavaScriptImports.cpp:416
break;
- if (Current->isNot(tok::identifier))
+ if (Current->isNot(tok::identifier) && Current->
mprobst created this revision.
Herald added a subscriber: klimek.
E.g. don't wrap like this:
(foo.bar.baz).and.bam(Blah.of({
}))
But rather:
(foo.bar.baz)
.and.bam(Blah.of({}))
https://reviews.llvm.org/D36139
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.
danielmarjamaki created this revision.
Herald added a subscriber: whisperity.
This fixes a FP. Without the fix, the checker says that "static int x;" is
unreachable.
Repository:
rL LLVM
https://reviews.llvm.org/D36141
Files:
lib/StaticAnalyzer/Checkers/UnreachableCodeChecker.cpp
test/An
mprobst created this revision.
Herald added a subscriber: klimek.
In JavaScript, may keywords can be used in method names and thus call sites:
foo.delete();
foo.instanceof();
clang-format would previously insert whitespace after the `instanceof`. This
change generically skips inserting white
spetrovic updated this revision to Diff 109088.
https://reviews.llvm.org/D34878
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Options.td
lib/Driver/ToolChains/Arch/ARM.cpp
lib/Driver/ToolChains/Arch/ARM.h
lib/Driver/ToolCha
mprobst updated this revision to Diff 109089.
mprobst added a comment.
- support switch, case, delete.
https://reviews.llvm.org/D36142
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
==
spetrovic added a comment.
Comments addressed.
https://reviews.llvm.org/D34878
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilya-biryukov updated this revision to Diff 109091.
ilya-biryukov added a comment.
- Fixed a bug that caused CppFiles to be deleted while used.
https://reviews.llvm.org/D36133
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
clangd/ClangdU
krasimir created this revision.
Herald added a subscriber: klimek.
This patch fixes the indentation of the code pattern `key <...>` in text protos.
Previously, such line would be alinged depending on the column of the previous
colon, which usually indents too much.
https://reviews.llvm.org/D3614
joerg added a comment.
I had a long discussion with James about this on IRC without reaching a clear
consensus. I consider forcing this behavior on all targets to be a major bug.
It should be opt-in and opt-in only:
(1) The header name is not mandated by any standard. It is not in any namespa
mprobst created this revision.
Herald added a subscriber: klimek.
Previously, const enums would get formatted differently because the modifier
was not recognized.
https://reviews.llvm.org/D36144
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Forma
mibintc planned changes to this revision.
mibintc added a comment.
I will prepare another patch responding to joerg's comment:
> Quoted Text
I had a long discussion with James about this on IRC without reaching a clear
consensus. I consider forcing this behavior on all targets to be a major bug
xazax.hun accepted this revision.
xazax.hun added reviewers: NoQ, dcoughlin.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D36141
___
cfe-commits mailing list
cfe-co
mprobst created this revision.
Herald added a subscriber: klimek.
`throw (...)` should have a whitespace following it, as do await and void.
https://reviews.llvm.org/D36146
Files:
lib/Format/TokenAnnotator.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
Author: joey
Date: Tue Aug 1 06:27:09 2017
New Revision: 309678
URL: http://llvm.org/viewvc/llvm-project?rev=309678&view=rev
Log:
[OpenCL] Add missing subgroup builtins
This adds get_kernel_max_sub_group_size_for_ndrange and
get_kernel_sub_group_count_for_ndrange.
Modified:
cfe/trunk/includ
mprobst created this revision.
Herald added a subscriber: klimek.
clang-format would previously fail to detect that an arrow functions parameter
block is not an expression, and thus insert whitespace around the `|` and `&`
type operators in it.
https://reviews.llvm.org/D36147
Files:
lib/For
xazax.hun added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp:126
+ << BinaryOperator::getOpcodeStr(B->getOpcode())
+ << "' expression is undefined due to shift count >= width of type";
+ } else {
danielm
mprobst created this revision.
Herald added a subscriber: klimek.
`case:` and `default:` would normally parse as labels for a `switch` block.
However in TypeScript, they can be used in field declarations, e.g.:
interface I {
case: string;
}
This change special cases parsing them in decla
krasimir created this revision.
Herald added a subscriber: klimek.
This patch adds LLVM_NODISCARD to Replacements::merge. I've hit this
several times already.
https://reviews.llvm.org/D36149
Files:
include/clang/Tooling/Core/Replacement.h
Index: include/clang/Tooling/Core/Replacement.h
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Thanks!!!
https://reviews.llvm.org/D36149
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Nebiroth created this revision.
Small extension to LSP to allow clients to use clangd to switch between C
header files and source files.
Final version will use the completed clangd indexer.
https://reviews.llvm.org/D36150
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/C
This change causes an assertion failure on valid code. Could you take a
look at fixing this?
A reduced test case:
$ cat /tmp/SemaTemplateInstantiateDecl-crash2.cpp
template
constexpr void f(T) {
f(0);
}
$ clang -fsyntax-only -std=c++11 /tmp/SemaTemplateInstantiateDecl-crash2.cpp
assert.h asser
baloghadamsoftware updated this revision to Diff 109117.
baloghadamsoftware added a comment.
Overflow scenarios skipped.
https://reviews.llvm.org/D35109
Files:
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/svalbuilder-rearrange-comparisons.c
Index: test/Analysis/svalbuilder-r
malaperle requested changes to this revision.
malaperle added inline comments.
This revision now requires changes to proceed.
Comment at: clangd/ClangdServer.cpp:292
+
+ if (path.compare(path.length() - 4, 4, ".cpp") == 0) {
+path = path.substr(0, (path.length() - 4));
-
malaperle added a comment.
In the commit message, you could add that we will use and index of symbols
later to be able to switch from header to source file when the file names don't
match. This is more or less the justification of why we want this in Clangd and
not on the client.
https://revi
arphaman added inline comments.
Comment at: clangd/ClangdServer.cpp:292
+
+ if (path.compare(path.length() - 4, 4, ".cpp") == 0) {
+path = path.substr(0, (path.length() - 4));
malaperle wrote:
> this won't work for other extensions, we need to make this more
barancsuk updated this revision to Diff 109120.
barancsuk marked 7 inline comments as done.
barancsuk added a comment.
Address review comments
https://reviews.llvm.org/D35937
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.cpp
clang-tidy/readabili
barancsuk added inline comments.
Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23
+ memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()),
+ varDecl(hasStaticStorageDuration(,
+
Author: krasimir
Date: Tue Aug 1 07:58:14 2017
New Revision: 309689
URL: http://llvm.org/viewvc/llvm-project?rev=309689&view=rev
Log:
[Tooling] Add LLVM_NODISCARD to Replacements::merge
Summary:
This patch adds LLVM_NODISCARD to Replacements::merge. I've hit this
several times already.
Reviewer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309689: [Tooling] Add LLVM_NODISCARD to Replacements::merge
(authored by krasimir).
Repository:
rL LLVM
https://reviews.llvm.org/D36149
Files:
cfe/trunk/include/clang/Tooling/Core/Replacement.h
In
ilya-biryukov updated this revision to Diff 109124.
ilya-biryukov added a comment.
Addressed review comments.
- Moved implementations of template function to header.
- Fixed a typo.
https://reviews.llvm.org/D36133
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
ilya-biryukov marked 3 inline comments as done.
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.h:113
+ /// queue. The request will be run on a separate thread.
+ template void addToFront(Func &&F, Args &&...
As);
+ /// Add a new request to run function
baloghadamsoftware updated this revision to Diff 109126.
baloghadamsoftware added a comment.
Herald added a subscriber: JDevlieghere.
Test changed. I made some bad throws reachable, but the frontend check still
does detects them.
https://reviews.llvm.org/D33537
Files:
clang-tidy/misc/CMakeLi
xazax.hun added a comment.
Even though it is not undefined behavior in C, it can still cause surprising
behavior for the users. I think maybe putting it into the optin package instead
of cplusplus is better. What do you think?
https://reviews.llvm.org/D33672
xazax.hun added a comment.
Even though it is not undefined behavior in C, it can still cause surprising
behavior for the users. I think maybe putting it into the optin package instead
of cplusplus is better. What do you think?
https://reviews.llvm.org/D33672
klimek created this revision.
Herald added a subscriber: JDevlieghere.
https://reviews.llvm.org/D36154
Files:
clang-tidy/google/StringReferenceMemberCheck.cpp
clang-tidy/misc/DanglingHandleCheck.cpp
clang-tidy/misc/InaccurateEraseCheck.cpp
clang-tidy/misc/UseAfterMoveCheck.cpp
clang-tid
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
ship it!
https://reviews.llvm.org/D36133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
jyu2 added a comment.
In https://reviews.llvm.org/D33537#827509, @baloghadamsoftware wrote:
> Test changed. I made some bad throws reachable, but the frontend check still
> does detects them.
If block contains two or more throws, that mean compiler can not statically
know throw is really thro
ilya-biryukov created this revision.
It used to call into llvm::sys::fs::make_absolute.
https://reviews.llvm.org/D36155
Files:
lib/Basic/FileManager.cpp
unittests/Basic/FileManagerTest.cpp
Index: unittests/Basic/FileManagerTest.cpp
=
malaperle requested changes to this revision.
malaperle added a comment.
This revision now requires changes to proceed.
Can you also update your code with the latest SVN trunk? The patch does not
apply cleanly anymore.
Comment at: clangd/ClangdServer.cpp:11
#include "ClangdSe
Author: mprobst
Date: Tue Aug 1 08:46:10 2017
New Revision: 309695
URL: http://llvm.org/viewvc/llvm-project?rev=309695&view=rev
Log:
clang-format: [JS] handle object types in extends positions.
Summary:
clang-format would previously drop the whitespace after `extends` in code such
as:
clas
Author: ibiryukov
Date: Tue Aug 1 08:51:38 2017
New Revision: 309696
URL: http://llvm.org/viewvc/llvm-project?rev=309696&view=rev
Log:
[clangd] Rewrote AST and Preamble management.
Summary: The new implementation allows code completion that never waits for AST.
Reviewers: bkramer, krasimir, kli
Author: mprobst
Date: Tue Aug 1 08:54:43 2017
New Revision: 309697
URL: http://llvm.org/viewvc/llvm-project?rev=309697&view=rev
Log:
clang-format: [JS] support default imports.
Summary: Formerly, `import {default as X} from y;` would not be recognized as
an import.
Reviewers: djasper
Subscrib
arphaman created this revision.
Herald added a subscriber: mgorny.
Symbol occurrences store the results of local rename and will also be used for
the global, indexed rename results. They can be converted to a set of
`AtomicChanges` as well. This is a preparation patch for both the support of
mu
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D36144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D36146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D36147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309696: [clangd] Rewrote AST and Preamble management.
(authored by ibiryukov).
Repository:
rL LLVM
https://reviews.llvm.org/D36133
Files:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tool
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2355
+(Left.Tok.getIdentifierInfo() ||
+ Left.isOneOf(tok::kw_switch, tok::kw_case, tok::kw_delete)))
+ return false;
Why is instanceof not required in this list?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309695: clang-format: [JS] handle object types in extends
positions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36131
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/t
djasper added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:2009
+// Prefer breaking call chains (".foo") over empty "{}", "[]" or "()".
+if ((Left.is(tok::l_brace) && Right.is(tok::r_brace)) ||
+(Left.is(tok::l_square) && Right.is(tok::r_square)) ||
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309697: clang-format: [JS] support default imports.
(authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D36132?vs=109059&id=109136#toc
Repository:
rL LLVM
https://reviews.llvm.o
bkramer added inline comments.
Comment at: clang-tidy/google/StringReferenceMemberCheck.cpp:31
+ auto String = anyOf(namedDecl(hasName("::std::string")),
recordDecl(hasName("::string")));
auto ConstString = qualType(isConstQualified(), hasDeclaration(St
ilya-biryukov requested changes to this revision.
ilya-biryukov added a reviewer: ilya-biryukov.
ilya-biryukov added a comment.
Also, +1 to the comments about file extensions, we have to cover at least `.c`,
`.cc` and `.cpp` for source files, `.h` and `.hpp` for header files.
Yes, sure, I will investigate it.
Thanks,
--Serge
2017-08-01 21:32 GMT+07:00 Alexander Kornienko :
> This change causes an assertion failure on valid code. Could you take a
> look at fixing this?
>
> A reduced test case:
>
> $ cat /tmp/SemaTemplateInstantiateDecl-crash2.cpp
> template
> constex
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
Thanks, it does make sense to update llvm-cov.
LGTM:
Comment at: lib/CodeGen/CoverageMappingGen.cpp:554
+ // useful to try and create a deferred region inside o
hintonda added a comment.
This is a good example of how to script lldb, but it's predicated on knowing
the diag name, which is great if you know the name.
However, this isn't my use case. I don't have the diag name, just a diagnostic
message. In order to get the diag name associated with a sp
vsk updated this revision to Diff 109142.
vsk marked 2 inline comments as done.
vsk edited the summary of this revision.
vsk added a comment.
Thanks for the review! I'll hold off on landing this until the llvm-cov changes
are in, so that people don't hit the issue where unexpected line execution
mprobst created this revision.
Herald added a subscriber: klimek.
Previously, clang-format would consider the following code line to be part of
the comment and incorrectly format the rest of the file.
https://reviews.llvm.org/D36159
Files:
lib/Format/FormatTokenLexer.cpp
unittests/Format/Fo
t.p.northover updated this revision to Diff 109149.
t.p.northover added a comment.
Sounds like an improvement, I've updated the diff.
https://reviews.llvm.org/D35817
Files:
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/lib/Sema/SemaChecking.cpp
clang/lib/Sema/SemaExpr.cpp
clang
Author: mprobst
Date: Tue Aug 1 10:12:15 2017
New Revision: 309703
URL: http://llvm.org/viewvc/llvm-project?rev=309703&view=rev
Log:
clang-format: [JS] consistenly format enums.
Summary: Previously, const enums would get formatted differently because the
modifier was not recognized.
Reviewers:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309703: clang-format: [JS] consistenly format enums.
(authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36144
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/F
Author: ibiryukov
Date: Tue Aug 1 10:17:37 2017
New Revision: 309705
URL: http://llvm.org/viewvc/llvm-project?rev=309705&view=rev
Log:
[clangd] Fixed MSVC compilation failures.
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.h
Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h
URL:
Author: mprobst
Date: Tue Aug 1 10:19:32 2017
New Revision: 309707
URL: http://llvm.org/viewvc/llvm-project?rev=309707&view=rev
Log:
clang-format: [JS] handle union types in arrow functions.
Summary: clang-format would previously fail to detect that an arrow functions
parameter block is not an
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309707: clang-format: [JS] handle union types in arrow
functions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36147
Files:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trun
Author: mprobst
Date: Tue Aug 1 10:22:15 2017
New Revision: 309710
URL: http://llvm.org/viewvc/llvm-project?rev=309710&view=rev
Log:
clang-format: [JS] whitespace between keywords and parenthesized expressions.
Summary: `throw (...)` should have a whitespace following it, as do await and
void.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309710: clang-format: [JS] whitespace between keywords and
parenthesized expressions. (authored by mprobst).
Repository:
rL LLVM
https://reviews.llvm.org/D36146
Files:
cfe/trunk/lib/Format/TokenAnno
kimgr added a comment.
High-level comment from the peanut gallery:
The word "occurrences" is horrible to type and most people misspell it (you did
great here!) Would you consider something like "SymbolMatches" or even
"SymbolHits"?
Repository:
rL LLVM
https://reviews.llvm.org/D36156
___
Author: mprobst
Date: Tue Aug 1 10:35:57 2017
New Revision: 309712
URL: http://llvm.org/viewvc/llvm-project?rev=309712&view=rev
Log:
clang-format: [JS] prefer wrapping chains over empty literals.
Summary:
E.g. don't wrap like this:
(foo.bar.baz).and.bam(Blah.of({
}))
But rather:
(
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309712: clang-format: [JS] prefer wrapping chains over empty
literals. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D36139?vs=109082&id=109155#toc
Repository:
rL LLVM
htt
Author: mprobst
Date: Tue Aug 1 10:42:16 2017
New Revision: 309713
URL: http://llvm.org/viewvc/llvm-project?rev=309713&view=rev
Log:
clang-format: [JS] no whitespace between typeof operator and l_paren.
Modified:
cfe/trunk/lib/Format/FormatToken.h
cfe/trunk/lib/Format/TokenAnnotator.cpp
arphaman added a comment.
Makes sense. I'll see if I can get somewhere with the regex idea.
Repository:
rL LLVM
https://reviews.llvm.org/D36083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
arphaman added a comment.
In https://reviews.llvm.org/D36156#827733, @kimgr wrote:
> High-level comment from the peanut gallery:
>
> The word "occurrences" is horrible to type and most people misspell it (you
> did great here!) Would you consider something like "SymbolMatches" or even
> "Symbol
Author: ibiryukov
Date: Tue Aug 1 11:27:58 2017
New Revision: 309720
URL: http://llvm.org/viewvc/llvm-project?rev=309720&view=rev
Log:
[clangd] Fix more MSVC compilation failures.
It turns out MSVC does not allow non-copyable classes in std::future
and std::promise template arguments.
Modified:
boris added a comment.
Ping.
https://reviews.llvm.org/D35020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
delesley accepted this revision.
delesley added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D36122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: bruno
Date: Tue Aug 1 12:05:25 2017
New Revision: 309722
URL: http://llvm.org/viewvc/llvm-project?rev=309722&view=rev
Log:
[Sema] Fix lax conversion between non ext vectors
r282968 introduced a regression due to the lack of proper testing.
Re-add lax conversion support between non ext ve
Author: phosek
Date: Tue Aug 1 12:15:32 2017
New Revision: 309724
URL: http://llvm.org/viewvc/llvm-project?rev=309724&view=rev
Log:
[CMake] Include sancov tool in Fuchsia toolchain
Differential Revision: https://reviews.llvm.org/D35930
Modified:
cfe/trunk/cmake/caches/Fuchsia-stage2.cmake
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309724: [CMake] Include sancov tool in Fuchsia toolchain
(authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D35930?vs=108418&id=109173#toc
Repository:
rL LLVM
https://reviews.ll
Author: jmgao
Date: Tue Aug 1 12:18:05 2017
New Revision: 309725
URL: http://llvm.org/viewvc/llvm-project?rev=309725&view=rev
Log:
Thread Safety Analysis: fix assert_capability.
Summary:
Previously, the assert_capability attribute was completely ignored by
thread safety analysis.
Reviewers: del
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309725: Thread Safety Analysis: fix assert_capability.
(authored by jmgao).
Repository:
rL LLVM
https://reviews.llvm.org/D36122
Files:
cfe/trunk/include/clang/Basic/Attr.td
cfe/trunk/lib/Analysis/
mstorsjo added inline comments.
Comment at: lib/Basic/Targets/AArch64.cpp:466-467
+ case CC_X86ThisCall:
+ case CC_X86FastCall:
+ case CC_X86VectorCall:
+return CCCR_Ignore;
mstorsjo wrote:
> rnk wrote:
> > Do they really ignore __fastcall and __vectorcall
farahhariri created this revision.
Herald added a subscriber: mgorny.
[libc++] added support for build with dataflow sanitizer
https://reviews.llvm.org/D36168
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+
1 - 100 of 148 matches
Mail list logo
