[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

dcoughlin added a comment. I have some concerns about soundness when the rearrangement may overflow. Here is an example: void clang_analyzer_eval(int); void foo(signed char A, signed char B) { if (A + 0 >= B + 0) { clang_analyzer_eval(A - 126 == B + 3); // This yields FALSE with

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

szepet added a comment. In https://reviews.llvm.org/D34260#821186, @teemperor wrote: > Try fixing this invalid read and the buildbots (and my builds :) ) should be > working again. Yeah, thanks for the help! :) I already sent a fix for that: https://reviews.llvm.org/rL309036 and another one:

[PATCH] D34365: [FrontEnd] Allow overriding the default C/C++ -std via CMake vars

mgorny added a comment. Ping. https://reviews.llvm.org/D34365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35796: [analyzer] Misused polymorphic object checker

rnkovacs updated this revision to Diff 108226. https://reviews.llvm.org/D35796 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/MisusedPolymorphicObjectChecker.cpp test/Analysis/MisusedPolymorphicObject.cpp In

[PATCH] D35796: [analyzer] Misused polymorphic object checker

rnkovacs added a comment. In https://reviews.llvm.org/D35796#819965, @NoQ wrote: > It seems that this check is more powerful because it works by knowing the > dynamic type of the object. However, i still suspect that > `-Wnon-virtual-dtor` (the other one, without `delete-`, that simply asks to

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 108236. wangxindsb added a comment. - Change the bugtype, just like the older checker. https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis/virtualcall.cpp Index: test/Analysis/virtualcall.cpp =

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

fhahn created this revision. Herald added subscribers: kristof.beyls, aemerson. This updates the relevant Clang parts for the LLVM change https://reviews.llvm.org/D35882. https://reviews.llvm.org/D35884 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/ARM.

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi updated this revision to Diff 108241. MontyKutyi added a comment. Added test for the fix. https://reviews.llvm.org/D34030 Files: include/clang/AST/RecursiveASTVisitor.h unittests/AST/PostOrderASTVisitor.cpp Index: unittests/AST/PostOrderASTVisitor.cpp ===

Re: r308965 - This patch enables the usage of constant Enum identifiers within Microsoft style inline assembly statements.

FTR, this was reverted in r309004. On Tue, Jul 25, 2017 at 12:43 PM, Matan Haroush via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mharoush > Date: Tue Jul 25 03:43:43 2017 > New Revision: 308965 > > URL: http://llvm.org/viewvc/llvm-project?rev=308965&view=rev > Log: > This patch e

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

szepet closed this revision. szepet added a comment. So the fixes seem to work. The problem was the line 'StackFrame = StackFrame->getParent()->getCurrentStackFrame();' since I havent checked if the parent of the StackFrame is nullptr. (It is quite interesting that it just not crashed on my com

[PATCH] D35538: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

peter.smith updated this revision to Diff 108245. peter.smith added a comment. Thanks both for the comments, I've added the missing punctuation and have expanded the tests so that we anchor the check to the function and check for the operation that will be lowered by the back-end. https://revi

[PATCH] D35013: [inline asm] repeating constraint matches the same output

zizhar abandoned this revision. zizhar added a comment. I agree, My bad, apparently gcc doesn't support that, I see no reason to add that. Closing the review. Repository: rL LLVM https://reviews.llvm.org/D35013 ___ cfe-commits mailing list cfe-co

r309088 - Update after LLVM change r309087

Author: grimar Date: Wed Jul 26 02:10:17 2017 New Revision: 309088 URL: http://llvm.org/viewvc/llvm-project?rev=309088&view=rev Log: Update after LLVM change r309087 Modified: cfe/trunk/lib/Driver/Driver.cpp cfe/trunk/lib/FrontendTool/ExecuteCompilerInvocation.cpp cfe/trunk/tools/driv

r309106 - Recommit r308327 2nd time: Add a warning for missing

Author: arphaman Date: Wed Jul 26 05:20:57 2017 New Revision: 309106 URL: http://llvm.org/viewvc/llvm-project?rev=309106&view=rev Log: Recommit r308327 2nd time: Add a warning for missing '#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files The first recommit (r308441) cau

r309112 - [Bash-completion] Fixed a bug that file doesn't autocompleted after =

Author: yamaguchi Date: Wed Jul 26 06:30:36 2017 New Revision: 309112 URL: http://llvm.org/viewvc/llvm-project?rev=309112&view=rev Log: [Bash-completion] Fixed a bug that file doesn't autocompleted after = Summary: File path wasn't autocompleted after `-fmodule-cache-path=[tab]`, so fixed this bu

[PATCH] D35763: [Bash-completion] Fixed a bug that file doesn't autocompleted after =

This revision was automatically updated to reflect the committed changes. Closed by commit rL309112: [Bash-completion] Fixed a bug that file doesn't autocompleted after = (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35763?vs=107787&id=108266#toc Repository: rL

r309113 - [Bash-autocompletion] Show HelpText with possible flags

Author: yamaguchi Date: Wed Jul 26 06:36:58 2017 New Revision: 309113 URL: http://llvm.org/viewvc/llvm-project?rev=309113&view=rev Log: [Bash-autocompletion] Show HelpText with possible flags Summary: `clang --autocomplete=-std` will show ``` -std: Language standard to compile for -std= Langu

[PATCH] D35759: [Bash-autocompletion] Show HelpText with possible flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL309113: [Bash-autocompletion] Show HelpText with possible flags (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D35759?vs=107791&id=108267#toc Repository: rL LLVM https://

r309116 - unguarded availability: add a fixit for the "annotate '...'

Author: arphaman Date: Wed Jul 26 06:58:02 2017 New Revision: 309116 URL: http://llvm.org/viewvc/llvm-project?rev=309116&view=rev Log: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note rdar://33539233 Differential Revision: https://review

[PATCH] D35726: unguarded availability: add a fixit for the "annotate '...' with an availability attribute to silence" note

This revision was automatically updated to reflect the committed changes. arphaman marked 2 inline comments as done. Closed by commit rL309116: unguarded availability: add a fixit for the "annotate '...' (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D35726?vs=107903&

[PATCH] D34091: Support for querying the exception specification type through libclang

mgorny added a comment. This patch has introduced a test suite failure: == ERROR: Failure: ImportError (No module named util) -- Traceback (most recent c

[PATCH] D30155: [clang-tools-extra] [test] Fix clang library dir in LD_LIBRARY_PATH For stand-alone build

mgorny added a comment. Another ping. @beanz, any chance you could take a look at this? Repository: rL LLVM https://reviews.llvm.org/D30155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r309118 - Regression test for PR10856

Author: sepavloff Date: Wed Jul 26 07:58:55 2017 New Revision: 309118 URL: http://llvm.org/viewvc/llvm-project?rev=309118&view=rev Log: Regression test for PR10856 Added: cfe/trunk/test/SemaTemplate/instantiate-friend-function.cpp Added: cfe/trunk/test/SemaTemplate/instantiate-friend-functio

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

petarj added a comment. Can you check if this change introduced clang-x86-windows-msvc2015 buildbot failure ? Repository: rL LLVM https://reviews.llvm.org/D35406 ___ cfe-

[PATCH] D35894: Code hover for Clangd

malaperle requested changes to this revision. malaperle added a comment. This revision now requires changes to proceed. Normally we put [clangd] in the title. Comment at: clangd/ClangdLSPServer.cpp:11 #include "ClangdLSPServer.h" +#include "clang/Basic/SourceManager.h" #inclu

[PATCH] D35894: Code hover for Clangd

arphaman added a comment. arphaman added inline comments. Comment at: clangd/Protocol.h:106 Range range; + FileID unitFileID; It doesn't look like it's appropriate to store a translation unit specific value in the `Location` which, if I'm not mistaken, is

Re: r308824 - [Bash-autocompletion] Fixed typo and add '-' after -Wno

Merged to 5.0 in r309130. On Sat, Jul 22, 2017 at 5:35 AM, Yuka Takahashi via cfe-commits wrote: > Author: yamaguchi > Date: Sat Jul 22 05:35:15 2017 > New Revision: 308824 > > URL: http://llvm.org/viewvc/llvm-project?rev=308824&view=rev > Log: > [Bash-autocompletion] Fixed typo and add '-' after

Re: r309058 - [CodeGen] Correctly model std::byte's aliasing properties

Yes, I think so. Richard, what say you? On Tue, Jul 25, 2017 at 4:41 PM, David Majnemer via cfe-commits wrote: > Should this go into 5.0 ? > > On Tue, Jul 25, 2017 at 4:33 PM, David Majnemer via cfe-commits > wrote: >> >> Author: majnemer >> Date: Tue Jul 25 16:33:58 2017 >> New Revision: 309058

Re: r309058 - [CodeGen] Correctly model std::byte's aliasing properties

I think so too :) On 26 Jul 2017 9:23 am, "Hans Wennborg via cfe-commits" < cfe-commits@lists.llvm.org> wrote: Yes, I think so. Richard, what say you? On Tue, Jul 25, 2017 at 4:41 PM, David Majnemer via cfe-commits wrote: > Should this go into 5.0 ? > > On Tue, Jul 25, 2017 at 4:33 PM, David Ma

Re: r309058 - [CodeGen] Correctly model std::byte's aliasing properties

r309135. Thanks! On Wed, Jul 26, 2017 at 9:29 AM, Richard Smith wrote: > I think so too :) > > On 26 Jul 2017 9:23 am, "Hans Wennborg via cfe-commits" > wrote: > > Yes, I think so. Richard, what say you? > > On Tue, Jul 25, 2017 at 4:41 PM, David Majnemer via cfe-commits > wrote: >> Should this

[PATCH] D35670: [StaticAnalyzer] Handle LoopExit CFGElement in the analyzer

szepet updated this revision to Diff 108312. szepet added a subscriber: cfe-commits. szepet added a comment. Accidentally left debug print removed. https://reviews.llvm.org/D35670 Files: include/clang/Analysis/ProgramPoint.h include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib

[PATCH] D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option

NoQ added a comment. Cool, i totally forgot that we have valgrind! :) https://reviews.llvm.org/D34260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

danielcdh updated this revision to Diff 108316. danielcdh marked an inline comment as done. danielcdh added a comment. update https://reviews.llvm.org/D35746 Files: lib/CodeGen/BackendUtil.cpp Index: lib/CodeGen/BackendUtil.cpp ===

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

danielcdh marked 2 inline comments as done. danielcdh added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:847-859 if (PGOOpt.RunProfileGen) PGOOpt.ProfileGenFile = CodeGenOpts.InstrProfileOutput.empty() ? DefaultProfileGenName : CodeGenOpts.InstrProfileO

[PATCH] D35903: [x86][inline-asm]Allow a pack of Control Regs to be properly picked

coby created this revision. Herald added a subscriber: eraman. Allows the incorporation of legit (x86) Control Regs within inline asm stataements Repository: rL LLVM https://reviews.llvm.org/D35903 Files: lib/Basic/Targets/X86.cpp test/CodeGen/ms-inline-asm.c Index: lib/Basic/Targets/

[PATCH] D35538: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

peter.smith added a comment. I've created https://reviews.llvm.org/D35904 to cover adding a test for LLVMs use of the runtime helper functions. https://reviews.llvm.org/D35538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

[PATCH] D35906: Add bitrig removal to release notes

erichkeane created this revision. As requested, I hope I did this right. https://reviews.llvm.org/D35906 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++ docs/ReleaseNotes.rst @@ -54,6

[libunwind] r309143 - Merging r308871:

Author: hans Date: Wed Jul 26 10:57:50 2017 New Revision: 309143 URL: http://llvm.org/viewvc/llvm-project?rev=309143&view=rev Log: Merging r308871: r308871 | chill | 2017-07-24 02:19:32 -0700 (Mon, 24 Jul 2017) | 17 lines [l

Re: [libunwind] r308871 - [libunwind] Handle .ARM.exidx tables without sentinel last entry

Saleem asked for this to be merged to 5.0: r309143. On Mon, Jul 24, 2017 at 2:19 AM, Momchil Velikov via cfe-commits wrote: > Author: chill > Date: Mon Jul 24 02:19:32 2017 > New Revision: 308871 > > URL: http://llvm.org/viewvc/llvm-project?rev=308871&view=rev > Log: > [libunwind] Handle .ARM.exi

[PATCH] D35906: Add bitrig removal to release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good. Thanks! Comment at: docs/ReleaseNotes.rst:61 +- Bitrig OS was merged back into OpenBSD, so Bitrig support has been +removed from Clang/LLVM. + I thi

r309145 - Add bitrig removal to release notes

Author: erichkeane Date: Wed Jul 26 11:04:45 2017 New Revision: 309145 URL: http://llvm.org/viewvc/llvm-project?rev=309145&view=rev Log: Add bitrig removal to release notes Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-p

[libunwind] r309147 - Partial fix for PR33858

Author: jroelofs Date: Wed Jul 26 11:13:57 2017 New Revision: 309147 URL: http://llvm.org/viewvc/llvm-project?rev=309147&view=rev Log: Partial fix for PR33858 https://reviews.llvm.org/D35848 Modified: libunwind/trunk/test/CMakeLists.txt libunwind/trunk/test/lit.site.cfg.in Modified: lib

Re: r309106 - Recommit r308327 2nd time: Add a warning for missing

On Wed, Jul 26, 2017 at 5:20 AM, Alex Lorenz via cfe-commits wrote: > Author: arphaman > Date: Wed Jul 26 05:20:57 2017 > New Revision: 309106 > > URL: http://llvm.org/viewvc/llvm-project?rev=309106&view=rev > Log: > Recommit r308327 2nd time: Add a warning for missing > '#pragma pack (pop)' and s

[libunwind] r309150 - Merging r309147:

Author: hans Date: Wed Jul 26 11:30:42 2017 New Revision: 309150 URL: http://llvm.org/viewvc/llvm-project?rev=309150&view=rev Log: Merging r309147: r309147 | jroelofs | 2017-07-26 11:13:57 -0700 (Wed, 26 Jul 2017) | 4 lines

Re: [libunwind] r309147 - Partial fix for PR33858

Merged to 5.0 in r309150. On Wed, Jul 26, 2017 at 11:13 AM, Jonathan Roelofs via cfe-commits wrote: > Author: jroelofs > Date: Wed Jul 26 11:13:57 2017 > New Revision: 309147 > > URL: http://llvm.org/viewvc/llvm-project?rev=309147&view=rev > Log: > Partial fix for PR33858 > > https://reviews.llvm

[PATCH] D35420: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef

AlexeySotkin updated this revision to Diff 108334. AlexeySotkin added a comment. Rebasing on tip of trank https://reviews.llvm.org/D35420 Files: lib/CodeGen/CodeGenFunction.cpp test/CodeGenOpenCL/kernel-arg-info.cl Index: test/CodeGenOpenCL/kernel-arg-info.cl =

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer added a comment. Ping. (CXX ABI change committed, doc patch created) https://reviews.llvm.org/D33719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35420: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rL309155: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef (authored by AlexeySotkin). Repository: rL LLVM https://reviews.llvm.org/D35420 Files: cfe/trunk/lib/CodeGen/CodeGen

r309155 - [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef

Author: AlexeySotkin Date: Wed Jul 26 11:49:54 2017 New Revision: 309155 URL: http://llvm.org/viewvc/llvm-project?rev=309155&view=rev Log: [OpenCL] Fix access qualifiers metadata for kernel arguments with typedef Subscribers: cfe-commits, yaxunl, Anastasia Differential Revision: https://reviews.

[PATCH] D35854: Fix double destruction of objects when OpenMP construct is canceled

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D35854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D35914: [mips] Add support -m(no-)embedded-data option

sdardis created this revision. Herald added a subscriber: arichardson. Add support for the -membedded-data option which places constant data in the .rodata section, rather than the .sdata section. https://reviews.llvm.org/D35914 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/C

r309186 - Revert r309106 "Recommit r308327 2nd time: Add a warning for missing"

Author: hans Date: Wed Jul 26 14:29:24 2017 New Revision: 309186 URL: http://llvm.org/viewvc/llvm-project?rev=309186&view=rev Log: Revert r309106 "Recommit r308327 2nd time: Add a warning for missing" The warning fires on non-suspicious code in Chromium. Reverting until a solution is figured out.

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis created this revision. Herald added a subscriber: arichardson. This option when combined with -mgpopt and -membedded-data places all uninitialized constant variables in the read-only section. https://reviews.llvm.org/D35917 Files: include/clang/Driver/Options.td include/clang/Fronte

Re: r309106 - Recommit r308327 2nd time: Add a warning for missing

On Wed, Jul 26, 2017 at 11:27 AM, Hans Wennborg wrote: > On Wed, Jul 26, 2017 at 5:20 AM, Alex Lorenz via cfe-commits > wrote: >> Author: arphaman >> Date: Wed Jul 26 05:20:57 2017 >> New Revision: 309106 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=309106&view=rev >> Log: >> Recommit r3083

r309189 - Clang and LLVM search for different versions of libxml2, reset found

Author: ecbeckmann Date: Wed Jul 26 14:47:17 2017 New Revision: 309189 URL: http://llvm.org/viewvc/llvm-project?rev=309189&view=rev Log: Clang and LLVM search for different versions of libxml2, reset found variable before each search so that they don't conflict. Modified: cfe/trunk/CMakeLists

r309193 - Convert mac file format to unix

Author: kzhuravl Date: Wed Jul 26 14:59:45 2017 New Revision: 309193 URL: http://llvm.org/viewvc/llvm-project?rev=309193&view=rev Log: Convert mac file format to unix Differential Revision: https://reviews.llvm.org/D35900 Modified: cfe/trunk/include/clang/Lex/VariadicMacroSupport.h Modified

r309195 - Add branch weights to branches for static initializers.

Author: rsmith Date: Wed Jul 26 15:01:09 2017 New Revision: 309195 URL: http://llvm.org/viewvc/llvm-project?rev=309195&view=rev Log: Add branch weights to branches for static initializers. The initializer for a static local variable cannot be hot, because it runs at most once per program. That's

[PATCH] D34801: [coverage] Make smaller regions for the first case of a switch.

vsk added a comment. Hi Eli, are you waiting on something before landing this? Repository: rL LLVM https://reviews.llvm.org/D34801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34748: [clang-diff] improve mapping accuracy

johannes updated this revision to Diff 108370. johannes retitled this revision from "[clang-diff] improve mapping accuracy, HTML side-by-side diff." to "[clang-diff] improve mapping accuracy". https://reviews.llvm.org/D34748 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Toolin

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

mcgrathr created this revision. mcgrathr added a project: Sanitizers. Herald added subscribers: mgorny, srhines. Repository: rL LLVM https://reviews.llvm.org/D35922 Files: cmake/caches/Fuchsia-stage2.cmake lib/Driver/SanitizerArgs.cpp lib/Driver/ToolChains/Fuchsia.cpp Index: lib/Driver

[libcxx] r309209 - Creating release directory for release_500.

Author: hans Date: Wed Jul 26 15:38:50 2017 New Revision: 309209 URL: http://llvm.org/viewvc/llvm-project?rev=309209&view=rev Log: Creating release directory for release_500. Added: libcxx/tags/RELEASE_500/ ___ cfe-commits mailing list cfe-commits@

[libcxx] r309210 - Creating release candidate rc1 from release_500 branch

Author: hans Date: Wed Jul 26 15:38:53 2017 New Revision: 309210 URL: http://llvm.org/viewvc/llvm-project?rev=309210&view=rev Log: Creating release candidate rc1 from release_500 branch Added: libcxx/tags/RELEASE_500/rc1/ (props changed) - copied from r309209, libcxx/branches/release_

[libcxxabi] r309211 - Creating release directory for release_500.

Author: hans Date: Wed Jul 26 15:38:53 2017 New Revision: 309211 URL: http://llvm.org/viewvc/llvm-project?rev=309211&view=rev Log: Creating release directory for release_500. Added: libcxxabi/tags/RELEASE_500/ ___ cfe-commits mailing list cfe-commi

[libcxxabi] r309212 - Creating release candidate rc1 from release_500 branch

Author: hans Date: Wed Jul 26 15:38:54 2017 New Revision: 309212 URL: http://llvm.org/viewvc/llvm-project?rev=309212&view=rev Log: Creating release candidate rc1 from release_500 branch Added: libcxxabi/tags/RELEASE_500/rc1/ - copied from r309211, libcxxabi/branches/release_50/ ___

[libunwind] r309223 - Creating release directory for release_500.

Author: hans Date: Wed Jul 26 15:39:01 2017 New Revision: 309223 URL: http://llvm.org/viewvc/llvm-project?rev=309223&view=rev Log: Creating release directory for release_500. Added: libunwind/tags/RELEASE_500/ ___ cfe-commits mailing list cfe-commi

[libunwind] r309224 - Creating release candidate rc1 from release_500 branch

Author: hans Date: Wed Jul 26 15:39:02 2017 New Revision: 309224 URL: http://llvm.org/viewvc/llvm-project?rev=309224&view=rev Log: Creating release candidate rc1 from release_500 branch Added: libunwind/tags/RELEASE_500/rc1/ (props changed) - copied from r309223, libunwind/branches/re

[PATCH] D35922: [Driver] Enable AddressSanitizer for Fuchsia targets

phosek added inline comments. Comment at: cmake/caches/Fuchsia-stage2.cmake:50 set(RUNTIMES_${target}-fuchsia_LIBCXX_ABI_VERSION 2 CACHE STRING "") + set(RUNTIMES_${target}-fuchsia_SANITIZER_USE_COMPILER_RT ON CACHE BOOL "") endforeach() I think we also need

[PATCH] D35923: Fix PR32332 - PCM nondeterminism with builtins caused by global module index

aprantl created this revision. Long story short: I think that it is too dangerous to rely on the global module index for anything but diagnostics. The global module index is only rebuilt in two cases: a. When triggered by Sema for diagnosing errors b. At the very end of FrontendAction::Exec

r309226 - Headers: improve ARM EHABI coverage of unwind.h

Author: compnerd Date: Wed Jul 26 15:55:23 2017 New Revision: 309226 URL: http://llvm.org/viewvc/llvm-project?rev=309226&view=rev Log: Headers: improve ARM EHABI coverage of unwind.h Ensure that we define the `_Unwind_Control_Block` structure used on ARM EHABI targets. This is needed for buildin

[PATCH] D34114: [clang] A better format for unnecessary packed warning.

yawanng updated this revision to Diff 108380. yawanng edited the summary of this revision. yawanng added a comment. Change the condition of this unnecessary packed warning to when the alignment of the class is one byte. Remove all field-level warning. https://reviews.llvm.org/D34114 Files: l

[PATCH] D34114: [clang] A better format for unnecessary packed warning.

yawanng added a comment. In https://reviews.llvm.org/D34114#800253, @rsmith wrote: > Some concrete suggestions throughout the patch, but I think we should take a > step back and reconsider this warning approach: it seems bizarre for us to > warn on any packed struct that happens to contain a `c

Re: r309189 - Clang and LLVM search for different versions of libxml2, reset found

This commit hasn't been imported to https://github.com/llvm-project/llvm-project-20170507. Do we need to do anything to make sure it gets picked up eventually? I wonder if there are more "missing commits" like this. Have we seen divergence between SVN and the prototype git monorepo in the past? On

[PATCH] D35903: [x86][inline-asm]Allow a pack of Control Regs to be properly picked

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D35903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

chh added inline comments. Comment at: lib/AST/RecordLayoutBuilder.cpp:1888 -if (Packed && UnpackedAlignment > CharUnits::One() && -getSize() == UnpackedSize) Diag(D->getLocation(), diag::warn_unnecessary_packed) Why not keeping the (getSize()

Re: r309189 - Clang and LLVM search for different versions of libxml2, reset found

Seems clang.git stuck to r309145. LLVM.ORG's git-svn doesn't fetch r309155. At the moment, I made llvm-project.git suspended. It will be rebased later. On Thu, Jul 27, 2017 at 8:13 AM Reid Kleckner wrote: > This commit hasn't been imported to > https://github.com/llvm-project/llvm-project-20170

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

yawanng added inline comments. Comment at: lib/AST/RecordLayoutBuilder.cpp:1888 -if (Packed && UnpackedAlignment > CharUnits::One() && -getSize() == UnpackedSize) Diag(D->getLocation(), diag::warn_unnecessary_packed) chh wrote: > Why not keepi

[PATCH] D35923: Fix PR32332 - PCM nondeterminism with builtins caused by global module index

doug.gregor added a comment. I am *very* concerned about this. The optimization that avoids doing lookups within module files where we "know" we won't find anything was very important at the time it was introduced, so I'd like to understand better why it didn't make a significant difference in

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

sgundapa added a comment. I am waiting for others to approve/review the decision. https://reviews.llvm.org/D35577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

yawanng updated this revision to Diff 108395. yawanng edited the summary of this revision. yawanng added a comment. Including cases '__attribute__((packed, aligned(X)));'. When the alignment before packing is less or equal to the packed one, he 'packed' attribute not including 'aligned(X)' seems

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

yawanng updated this revision to Diff 108397. https://reviews.llvm.org/D34114 Files: lib/AST/RecordLayoutBuilder.cpp test/CodeGenCXX/warn-padded-packed.cpp Index: test/CodeGenCXX/warn-padded-packed.cpp === --- test/CodeGenCXX/w

Add associateTargetInfo API

Add associateTargetInfo API Consolidates duplicate logic behind a convenience API on the CompilerInstance class both to set the target and return whether the target was set successfully. Index: include/clang/Frontend/CompilerInstance.h ==

[PATCH] D33900: Print registered targets in clang's version information

mehdi_amini added a comment. In https://reviews.llvm.org/D33900#820281, @hans wrote: > In https://reviews.llvm.org/D33900#818968, @mehdi_amini wrote: > > > I think @thakis is right: this too verbose to be the default --version. > > We likely shouldn't ship this in clang-5.0 (@hans). > > > Let me

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

yawanng updated this revision to Diff 108401. yawanng added a comment. Add more tests. https://reviews.llvm.org/D34114 Files: lib/AST/RecordLayoutBuilder.cpp test/CodeGenCXX/warn-padded-packed.cpp Index: test/CodeGenCXX/warn-padded-packed.cpp ===

[PATCH] D35925: [Coverage] Precise region termination with deferred regions

vsk created this revision. The current coverage implementation doesn't handle region termination very precisely. Take for example an `if' statement with a `return': void f() { if (true) { return; // The `if' body's region is terminated here. } // This line gets the same covera

r309244 - [Coverage] NFC: Save a pair of calls to get{Start,End}

Author: vedantk Date: Wed Jul 26 19:20:20 2017 New Revision: 309244 URL: http://llvm.org/viewvc/llvm-project?rev=309244&view=rev Log: [Coverage] NFC: Save a pair of calls to get{Start,End} Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp Modified: cfe/trunk/lib/CodeGen/CoverageMappingG

r309245 - [Coverage] NFC: Simplify sanity checks with a SpellingRange utility

Author: vedantk Date: Wed Jul 26 19:20:25 2017 New Revision: 309245 URL: http://llvm.org/viewvc/llvm-project?rev=309245&view=rev Log: [Coverage] NFC: Simplify sanity checks with a SpellingRange utility This should simplify D35925. Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp Modif

[PATCH] D35678: Omit sumbodule semantics for TS modules

boris added a comment. Ping. https://reviews.llvm.org/D35678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35406: [clangd] Replace ASTUnit with manual AST management.

ilya-biryukov added a comment. In https://reviews.llvm.org/D35406#821567, @petarj wrote: > Can you check if this change introduced clang-x86-windows-msvc2015 buildbot > failure > ? It did. Was fixed in r308959

[PATCH] D35930: [CMake] Include sancov tool in Fuchsia toolchain

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D35930 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsi