[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

fedor.sergeev added a comment. > can you recommend someone to review the extra test changes? I'm rather new to the project and thus rather bad at finding reviewers. Also generally I do not consider myself qualified enough to be the only reviewer, though in this particular case I believe I spent

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek added a comment. In https://reviews.llvm.org/D33470#790484, @aaron.ballman wrote: > In https://reviews.llvm.org/D33470#789791, @Prazek wrote: > > > In https://reviews.llvm.org/D33470#764846, @aaron.ballman wrote: > > > > > Once you fix the typo in the check, can you run it over some large

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 104281. Prazek marked 2 inline comments as done. Prazek added a comment. Herald added a subscriber: JDevlieghere. - fixed docs - fixes - Last fixes? https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefaultNumericsChec

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc added inline comments. Comment at: include/clang/Format/Format.h:993 + /// inside ``IncludeCategories``. + bool IncludeRegexCaseInsensitive; + djasper wrote: > Do we really need a flag here? Shouldn't we just always do this? I have no opinion one way

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 104288. Prazek added a comment. Small fix https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefaultNumericsCheck.cpp clang-tidy/misc/DefaultNumericsCheck.h clang-tidy/misc/MiscTidyModule.cpp docs/ReleaseNotes.rst

[PATCH] D34714: [MS] Don't statically initialize dllimport member function pointers

majnemer created this revision. r306137 made dllimport pointers to member functions non-constant. This is correct because a load must be executed to resolve any dllimported data. However, r306137 did not account for the use of dllimport member function pointers used as template arguments. This ch

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 104297. Prazek added a comment. fixed broken test https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefaultNumericsCheck.cpp clang-tidy/misc/DefaultNumericsCheck.h clang-tidy/misc/MiscTidyModule.cpp docs/ReleaseN

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

danielcdh created this revision. Herald added subscribers: eraman, mehdi_amini, sanjoy. This implements the clang bits of https://reviews.llvm.org/D34720, and add corresponding test to verify if it worked. https://reviews.llvm.org/D34721 Files: lib/CodeGen/BackendUtil.cpp test/CodeGen/pgo-

r306483 - [libclang] Support for querying the exception specification type through libclang

Author: jbcoe Date: Tue Jun 27 15:54:56 2017 New Revision: 306483 URL: http://llvm.org/viewvc/llvm-project?rev=306483&view=rev Log: [libclang] Support for querying the exception specification type through libclang Summary: This patch exposes the exception specification type (noexcept, etc.) of a

[PATCH] D34091: Support for querying the exception specification type through libclang

This revision was automatically updated to reflect the committed changes. Closed by commit rL306483: [libclang] Support for querying the exception specification type through… (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D34091?vs=102934&id=104301#toc Repository: rL

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

danielcdh added inline comments. Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:4 +// RUN: %clang_cc1 -O2 -fexperimental-new-pass-manager -fprofile-sample-use=%S/Inputs/pgo-sample-thinlto-summary.prof %s -emit-llvm -o - 2>&1 | FileCheck %s -check-prefix=SAMPLEPGO +// RUN

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

saugustine updated this revision to Diff 104307. saugustine added a comment. Rework this patch to use argument adjusters. It turns out that the call to newInvocation from ClangFuzzer has a very limited set of hard-coded arguments, so I don't think it is necessary to do the hand-adjusting there. An

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei created this revision. Herald added subscribers: xazax.hun, mgorny. This patch adds a new Static Analyzer checker for the correct use of handle in Magenta kernel. The concept of handle is very similar to file descriptor in Unix. This checker checks leaks, use after release and double re

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang updated this revision to Diff 104308. mgrang added a comment. Comments addressed. https://reviews.llvm.org/D34706 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-macros.c Index: test/Preprocessor/predefined-macros.c

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

ruiu accepted this revision. ruiu added a comment. LGTM. I don't think I have enough knowledge to sign off, but as Saleem has already LGTM'ed, I guess it should be okay. https://reviews.llvm.org/D34706 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D34725: Add sample PGO integration test to cover profile annotation and inlining.

danielcdh created this revision. Herald added a subscriber: sanjoy. The patch makes the integration test cover major sample PGO components. https://reviews.llvm.org/D34725 Files: test/CodeGen/Inputs/pgo-sample.prof test/CodeGen/pgo-sample.c Index: test/CodeGen/pgo-sample.c ===

r306489 - [COFF, ARM64] Add support for Windows ARM64 COFF format

Author: mgrang Date: Tue Jun 27 16:56:34 2017 New Revision: 306489 URL: http://llvm.org/viewvc/llvm-project?rev=306489&view=rev Log: [COFF, ARM64] Add support for Windows ARM64 COFF format Summary: This is the clang part of the initial implementation to support Windows ARM64 COFF format. Review

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

This revision was automatically updated to reflect the committed changes. Closed by commit rL306489: [COFF, ARM64] Add support for Windows ARM64 COFF format (authored by mgrang). Changed prior to commit: https://reviews.llvm.org/D34706?vs=104308&id=104317#toc Repository: rL LLVM https://rev

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen created this revision. Herald added subscribers: hiraditya, eraman, inglorion, mehdi_amini, sanjoy. Previously it doesn't actually invoke the designated new PM builder functions. https://reviews.llvm.org/D34728 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/lib/Passes/PassBuilder.cpp

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

timshen added a comment. A question I have is that I don't know how to test this. Ideally we want -debug-pass-manager from opt, but that flag is not part of the LLVM libraries. https://reviews.llvm.org/D34728 ___ cfe-commits mailing list cfe-commit

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:804-807 + case 0: +return PassBuilder::O0; + case 1: Why is this change needed? Comment at: clang/lib/CodeGen/BackendUtil.cpp:885-886 if (CodeGenOpts.Op

r306494 - [CodeGen] Fix assertion failure in EmitCallArg.

Author: ahatanak Date: Tue Jun 27 17:42:48 2017 New Revision: 306494 URL: http://llvm.org/viewvc/llvm-project?rev=306494&view=rev Log: [CodeGen] Fix assertion failure in EmitCallArg. The assertion was failing when a method of a parameterized class was called and the types of the argument and para

[PATCH] D34665: [CodeGen] Fix assertion failure in EmitCallArg

This revision was automatically updated to reflect the committed changes. Closed by commit rL306494: [CodeGen] Fix assertion failure in EmitCallArg. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D34665?vs=104086&id=104327#toc Repository: rL LLVM https://reviews.l

[PATCH] D34714: [MS] Don't statically initialize dllimport member function pointers

rnk added a comment. Did you locally add a test case for the dllimport member function pointer template argument? Comment at: lib/Sema/SemaTemplate.cpp:5704 + else +NPV = isNullPointerValueTemplateArgument(S, Param, ParamType, ResultArg); + Think we shoul

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

tejohnson added inline comments. Comment at: llvm/test/Other/new-pm-thinlto-defaults.ll:157 ; CHECK-PRELINK-O-NEXT: Running pass: GlobalOptPass -; CHECK-PRELINK-O-NEXT: Running pass: NameAnonGlobalPass ; CHECK-POSTLINK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> -

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added inline comments. Comment at: llvm/test/Other/new-pm-thinlto-defaults.ll:157 ; CHECK-PRELINK-O-NEXT: Running pass: GlobalOptPass -; CHECK-PRELINK-O-NEXT: Running pass: NameAnonGlobalPass ; CHECK-POSTLINK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> -

[PATCH] D34714: [MS] Don't statically initialize dllimport member function pointers

majnemer added a comment. In https://reviews.llvm.org/D34714#793205, @rnk wrote: > Did you locally add a test case for the dllimport member function pointer > template argument? Arg, yes. Forgot to add the file... Comment at: lib/Sema/SemaTemplate.cpp:5704 + else +NPV

r306497 - Remove a redundant call to ArgList::hasFlag. NFC.

Author: vedantk Date: Tue Jun 27 18:56:07 2017 New Revision: 306497 URL: http://llvm.org/viewvc/llvm-project?rev=306497&view=rev Log: Remove a redundant call to ArgList::hasFlag. NFC. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL:

[PATCH] D34444: Teach codegen to work in incremental processing mode.

rjmccall added a comment. Okay. In that case, I see two problems, one major and one potentially major. The major problem is that, as Richard alludes to, you need to make sure you emit any on-demand definitions that Sema registered with CodeGen during the initial CGM's lifetime but used in late

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

Hahnfeld added a subscriber: cfe-commits. Hahnfeld edited reviewers, added: rsmith, rengolin; removed: cfe-commits. Hahnfeld added a comment. Some comments inline. In general you should consider posting an RFC on cfe-dev because this change will basically affect all compilations on GNU/Linux if t

r306511 - DiagnosticRenderer.h: Prune \param SM, corresponding to rL306384. [-Wdocumentation]

Author: chapuni Date: Tue Jun 27 23:46:23 2017 New Revision: 306511 URL: http://llvm.org/viewvc/llvm-project?rev=306511&view=rev Log: DiagnosticRenderer.h: Prune \param SM, corresponding to rL306384. [-Wdocumentation] Modified: cfe/trunk/include/clang/Frontend/DiagnosticRenderer.h Modified:

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

chapuni added inline comments. Comment at: cfe/trunk/include/clang/Frontend/DiagnosticRenderer.h:131 /// \param FixItHints The FixIt hints active for this diagnostic. /// \param SM The SourceManager; will be null if the diagnostic came from the ///frontend, thus

[PATCH] D34740: [X86][InlineAsm][Ms Compatibility]Prefer variable name over a register when the two collides

coby created this revision. Herald added a subscriber: eraman. On MS-style, the following snippet: int eax; __asm mov eax, ebx should yield loading of ebx, into the location pointed by the variable eax This patch sees to it. Currently, a reg-to-reg move would have been invoked. llvm: https://

<    1   2