r306372 - clang/test/CodeGenObjC/ivar-type-encoding.m: Tweak to satisfy -m32.

Author: chapuni Date: Tue Jun 27 00:40:47 2017 New Revision: 306372 URL: http://llvm.org/viewvc/llvm-project?rev=306372&view=rev Log: clang/test/CodeGenObjC/ivar-type-encoding.m: Tweak to satisfy -m32. Modified: cfe/trunk/test/CodeGenObjC/ivar-type-encoding.m Modified: cfe/trunk/test/CodeGen

[Diffusion] rL306364: [CodeGen][ObjC] Fix GNU's encoding of bit-field ivars.

chapuni added subscribers: cfe-commits, chapuni. chapuni added a comment. Could you confirm if my change were reasonable? Or rewrite it. /cfe/trunk/test/CodeGenObjC/ivar-type-encoding.m:51 It was incompatible to -m32. @9 = private unnamed_addr constant [6 x i8] c"b96c1\00", align 1 Tweaked i

r306373 - Switch TestVisitor to Lang_C via -x c

Author: sberg Date: Tue Jun 27 00:59:56 2017 New Revision: 306373 URL: http://llvm.org/viewvc/llvm-project?rev=306373&view=rev Log: Switch TestVisitor to Lang_C via -x c ...instead of -std=c99, as the latter lead to error: invalid argument '-std=c99' not allowed with 'C++' complaints in test

[PATCH] D34417: Switch TestVisitor to Lang_C via -x c

This revision was automatically updated to reflect the committed changes. Closed by commit rL306373: Switch TestVisitor to Lang_C via -x c (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D34417?vs=103263&id=104101#toc Repository: rL LLVM https://reviews.llvm.org/D3441

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

Serge_Preis added a comment. Thank you all for your help! The problem was that in Windows-targeted builds -fdelayed-template-parsing is set by default affecting template symbols appearance in index. Throwing -fno-delayed-template-parsing to c-index-test fixed the situation for failed configurat

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

Serge_Preis updated this revision to Diff 104102. Serge_Preis added a comment. -fno-delayed-template-parsing atted to c-index-test arguments for consistent testing results among all targets https://reviews.llvm.org/D32439 Files: lib/Sema/SemaDeclCXX.cpp test/Index/ctor-init-source-loc.cpp

r306374 - Make sure TraverseInitListExpr visits InitListExpr exactly twice

Author: sberg Date: Tue Jun 27 01:04:08 2017 New Revision: 306374 URL: http://llvm.org/viewvc/llvm-project?rev=306374&view=rev Log: Make sure TraverseInitListExpr visits InitListExpr exactly twice ... once each for the syntactic and semantic form. Without this fix, behavior of the newly added tes

[PATCH] D34419: Make sure TraverseInitListExpr visits InitListExpr exactly twice

sberg added a comment. committed as https://reviews.llvm.org/rL306374 https://reviews.llvm.org/D34419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22128: Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion

This revision was automatically updated to reflect the committed changes. Closed by commit rL306377: Make CastExpr::getSubExprAsWritten look through implicit temporary under… (authored by sberg). Changed prior to commit: https://reviews.llvm.org/D22128?vs=103449&id=104104#toc Repository: rL

r306377 - Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion

Author: sberg Date: Tue Jun 27 01:19:09 2017 New Revision: 306377 URL: http://llvm.org/viewvc/llvm-project?rev=306377&view=rev Log: Make CastExpr::getSubExprAsWritten look through implicit temporary under CK_ConstructorConversion With struct S1 {}; struct S2 { operator S1(); }; S1 f

[clang-tools-extra] r306378 - [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

Author: hokein Date: Tue Jun 27 01:31:27 2017 New Revision: 306378 URL: http://llvm.org/viewvc/llvm-project?rev=306378&view=rev Log: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks. Summary: If the class being created in unique_ptr is in anonymous nampespace, the anonymous n

[PATCH] D34286: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306378: [clang-tidy] Fix type names in modernize-use-unique/shared_ptr checks. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D34286 Files: clang-tools-extra/trunk/clang-tidy/mod

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. https://reviews.llvm.org/D34674 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/modernize-make-unique

[PATCH] D34449: [clang-tidy] Enable constexpr definitions in headers.

xazax.hun updated this revision to Diff 104111. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. Herald added a subscriber: JDevlieghere. - Updates according to the reviews. https://reviews.llvm.org/D34449 Files: clang-tidy/misc/DefinitionsInHeadersCheck.cpp test/clang

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

hokein updated this revision to Diff 104113. hokein added a comment. Fix code style. https://reviews.llvm.org/D34674 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/modernize-make-

Re: r306127 - [GSoC] Add support for CC1 options.

On 27/06/17 07:17, Saleem Abdulrasool via cfe-commits wrote: I think that we shouldn't be providing completion for `-cc1` options. `-cc1as` options are fine as the IAS serves as a replacement for the traditional unix `as`. But, the `NoDriverOption` values shouldn't be exposed to users. They

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

arphaman added a comment. Thanks! I'll recommit today. https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306383 - Reapply "Frontend support for Nios2 target"

Author: n.bozhenov Date: Tue Jun 27 02:48:24 2017 New Revision: 306383 URL: http://llvm.org/viewvc/llvm-project?rev=306383&view=rev Log: Reapply "Frontend support for Nios2 target" Summary: - Implements TargetInfo class for Nios2 target. - Enables handling of -march and -mcpu options for Nios2 ta

[PATCH] D34506: Relax an assert in the comparison of source locations

xazax.hun added a comment. In https://reviews.llvm.org/D34506#791089, @akyrtzi wrote: > Comparing SourceLocations from different translation units is not meaningful > and my concern is that treating source locations like this can very easily > lead to errors where by mistake the code is resolvi

[PATCH] D34623: [clang-format] Add a test for associative map proto buffer fields

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D34623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

r306384 - Revert "Revert "[NFC] Refactor DiagnosticRenderer to use FullSourceLoc""

Author: christof Date: Tue Jun 27 02:50:38 2017 New Revision: 306384 URL: http://llvm.org/viewvc/llvm-project?rev=306384&view=rev Log: Revert "Revert "[NFC] Refactor DiagnosticRenderer to use FullSourceLoc"" This reverts commit r305688 meaning it reintroduces r305684. To repeat: [NFC] Refactor D

[PATCH] D31709: [NFC] Refactor DiagnosticRenderer to use FullSourceLoc

This revision was automatically updated to reflect the committed changes. Closed by commit rL306384: Revert "Revert "[NFC] Refactor DiagnosticRenderer to use FullSourceLoc"" (authored by christof). Changed prior to commit: https://reviews.llvm.org/D31709?vs=101933&id=104115#toc Repository: r

[clang-tools-extra] r306385 - [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

Author: psmith Date: Tue Jun 27 03:04:04 2017 New Revision: 306385 URL: http://llvm.org/viewvc/llvm-project?rev=306385&view=rev Log: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc D31709 [NFC] Refactor DiagnosticRenderer to use FullSourceLoc was committed in r305684 and rever

[PATCH] D34513: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc

This revision was automatically updated to reflect the committed changes. Closed by commit rL306385: [NFC] Update to account for DiagnosticRenderer use of FullSourceLoc (authored by psmith). Changed prior to commit: https://reviews.llvm.org/D34513?vs=103570&id=104116#toc Repository: rL LLVM

r306386 - [clang-format] Add a test for associative map proto buffer fields

Author: krasimir Date: Tue Jun 27 03:06:40 2017 New Revision: 306386 URL: http://llvm.org/viewvc/llvm-project?rev=306386&view=rev Log: [clang-format] Add a test for associative map proto buffer fields Summary: The test suite was missing a test about associative maps: https://developers.google.com

[PATCH] D34623: [clang-format] Add a test for associative map proto buffer fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL306386: [clang-format] Add a test for associative map proto buffer fields (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D34623 Files: cfe/trunk/unittests/Format/FormatTestProt

[PATCH] D34102: [analyzer] Add portability package for the checkers.

NoQ added a comment. In https://reviews.llvm.org/D34102#788138, @zaks.anna wrote: > I think it's better to have inconsistency than having checks applicable to > windows in a package named portability.unix. In https://reviews.llvm.org/D34102#788138, @zaks.anna wrote: > If there will be check

[PATCH] D34329: [GSoC] Clang AST diffing

johannes updated this revision to Diff 104124. https://reviews.llvm.org/D34329 Files: include/clang/Tooling/ASTDiff/ASTDiff.h include/clang/Tooling/ASTDiff/ASTDiffInternal.h lib/Tooling/ASTDiff/ASTDiff.cpp lib/Tooling/ASTDiff/CMakeLists.txt lib/Tooling/CMakeLists.txt test/Tooling/clan

r306392 - Recommit r306103: PR26195: Set correct NestedNameSpecifierLoc for the

Author: arphaman Date: Tue Jun 27 03:35:30 2017 New Revision: 306392 URL: http://llvm.org/viewvc/llvm-project?rev=306392&view=rev Log: Recommit r306103: PR26195: Set correct NestedNameSpecifierLoc for the dependent initializer This commit fixes incorrect source positions of dependent c'tor initia

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

arphaman added a comment. Recommitted in r306392. https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32439: Fix for incorrect source position of dependent c'tor initializer (bug:26195)

chapuni added a comment. @Serge_Preis @arphaman Thanks! https://reviews.llvm.org/D32439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Could anybody take a look at on this please? Thanks, Peter https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33644: Add default values for function parameter chunks

yvvan added a comment. Recheck please the latest diff https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34279: Fix release_40 build with MSVC (VS 2015)

yvvan abandoned this revision. yvvan added a comment. Can't reproduce an error anymore https://reviews.llvm.org/D34279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306396 - [analyzer] Move zero-size allocation checks to optin.portability.

Author: dergachev Date: Tue Jun 27 04:14:39 2017 New Revision: 306396 URL: http://llvm.org/viewvc/llvm-project?rev=306396&view=rev Log: [analyzer] Move zero-size allocation checks to optin.portability. This is a new checker package. It contains checkers that highlight well-documented implementati

[PATCH] D34102: [analyzer] Add portability package for the checkers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306396: [analyzer] Move zero-size allocation checks to optin.portability. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D34102?vs=102829&id=104133#toc Repository: rL LLVM

[PATCH] D34680: Fix clang-cl build -fprofile-instr-use flag

yvvan created this revision. Reproduced while building llvm with clang-cl. I have trained profdata file. When I tried to use it I got crash complaining of nullptr casted inside visitor. https://reviews.llvm.org/D34680 Files: lib/CodeGen/CodeGenPGO.cpp Index: lib/CodeGen/CodeGenPGO.cpp

[PATCH] D34680: clang-cl crashes with -fprofile-instr-use flag

yvvan added a comment. F3487082: llvm.profdata Profdata which causes crash https://reviews.llvm.org/D34680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added a comment. Just to clarify: I'm fine with adding the Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:32 +public: + ASTDiff(SyntaxTree &T1, SyntaxTree &T2, ComparisonOptions *Options); + Can you pass-in the options by value instead of a point

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added a comment. Ignore the "Just to clarify: I'm fine with adding the" comment, it was from last week that was saved in my session and that I didn't delete. https://reviews.llvm.org/D34329 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

bcraig added a comment. _LIBCPP_MS_CRT seems fine too. https://reviews.llvm.org/D34588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34329: [clang-diff] Initial implementation.

arphaman added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:57 + SyntaxTree(T *Node, const ASTContext &AST) + : TreeImpl(llvm::make_unique(this, Node, AST)) {} + If you want to use two different names then something like `SyntaxTreeI

[PATCH] D34621: [clang-format] Support <>-style proto message fields

krasimir updated this revision to Diff 104146. krasimir added a comment. - Rebase with master - Updated implementation with the new tests https://reviews.llvm.org/D34621 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/Format/Unwrappe

[PATCH] D34621: [clang-format] Support <>-style proto message fields

krasimir updated this revision to Diff 104148. krasimir added a comment. - Remove todo test case https://reviews.llvm.org/D34621 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLin

[PATCH] D34621: [clang-format] Support <>-style proto message fields

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D34621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r306406 - [clang-format] Support <>-style proto message fields

Author: krasimir Date: Tue Jun 27 06:43:07 2017 New Revision: 306406 URL: http://llvm.org/viewvc/llvm-project?rev=306406&view=rev Log: [clang-format] Support <>-style proto message fields Summary: This patch adds support for <>-style proto message fields inside proto options. Previously these wer

[PATCH] D34621: [clang-format] Support <>-style proto message fields

This revision was automatically updated to reflect the committed changes. Closed by commit rL306406: [clang-format] Support <>-style proto message fields (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D34621 Files: cfe/trunk/lib/Format/ContinuationIndenter.cpp cfe/tr

r306408 - [clang-format] Fix a buildbot failure after r306406

Author: krasimir Date: Tue Jun 27 06:58:41 2017 New Revision: 306408 URL: http://llvm.org/viewvc/llvm-project?rev=306408&view=rev Log: [clang-format] Fix a buildbot failure after r306406 Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp Modified: cfe/trunk/lib/Format/UnwrappedLineParser

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D34674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r306409 - [clang-format] Fix a clang-tidy warning, NFC

Author: krasimir Date: Tue Jun 27 07:07:45 2017 New Revision: 306409 URL: http://llvm.org/viewvc/llvm-project?rev=306409&view=rev Log: [clang-format] Fix a clang-tidy warning, NFC Modified: cfe/trunk/lib/Format/NamespaceEndCommentsFixer.cpp Modified: cfe/trunk/lib/Format/NamespaceEndComments

[PATCH] D34686: [AArch64] Add hasFP16VectorArithmetic helper function. NFCI

SjoerdMeijer created this revision. Herald added subscribers: kristof.beyls, aemerson. This is a clean-up for different ARMV8-A architecture kinds. Helper function hasFP16VectorArithmetic makes things a bit more “scalable” if we want to add ARMv8.3 at some point. https://reviews.llvm.org/D3468

[PATCH] D34687: [Tooling] CompilationDatabase should be able to strip position arguments when `-fsyntax-only` is used

arphaman created this revision. Right now, Clang fails to create a fixed compilation database when the compilation arguments use `-fsyntax-only` instead of `-c`. The reported error is: "warning: no compile jobs found". This happens because we don't look at the compilation job when stripping the

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

xazax.hun updated this revision to Diff 104167. xazax.hun retitled this revision from "Relax an assert in the comparison of source locations" to "Factor out a functionality from `isBeforeInTranslationUnit`". xazax.hun edited the summary of this revision. xazax.hun added a comment. - New approach

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

xazax.hun added a comment. I created a new public API that is using a piece of code that was factored out from `isBeforeInTranslationUnit`. Using this new function it is possible to implement proper comparison of source locations within the Static Analyzer. What do you think? https://reviews.

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

fhahn added a comment. I'd like to fix PR22999 and was wondering if you think adding a function-section attribute to the IR would be a viable solution? When doing LTO, we could add the same function-section to each function in a module in the IRLinker. @mehdi_amini did you think something like

[PATCH] D34695: _Float16 preprocessor macro definitions

SjoerdMeijer created this revision. Herald added subscribers: aheejin, dschuff, jfb. This adds the _Float16 preprocessor macro definitions. https://reviews.llvm.org/D34695 Files: lib/Frontend/InitPreprocessor.cpp lib/Headers/float.h test/Preprocessor/init.c Index: test/Preprocessor/init.

Re: [Diffusion] rL306364: [CodeGen][ObjC] Fix GNU's encoding of bit-field ivars.

Thanks for the fix! The change looks reasonable to me. On Tue, Jun 27, 2017 at 12:46 AM, NAKAMURA Takumi via Phabricator < revi...@reviews.llvm.org> wrote: > chapuni added subscribers: cfe-commits, chapuni. > chapuni added a comment. > > Could you confirm if my change were reasonable? Or rewrite

r306419 - [OPENMP] Use MapVector instead of DenseMap for stable codegen, NFC.

Author: abataev Date: Tue Jun 27 08:46:42 2017 New Revision: 306419 URL: http://llvm.org/viewvc/llvm-project?rev=306419&view=rev Log: [OPENMP] Use MapVector instead of DenseMap for stable codegen, NFC. Modified: cfe/trunk/include/clang/AST/OpenMPClause.h cfe/trunk/lib/CodeGen/CGOpenMPRunt

[PATCH] D33719: Add _Float16 as a C/C++ source language type

SjoerdMeijer added a comment. I have create a separate patch for the _Float16 preprocessor macro definitions in https://reviews.llvm.org/D34695. https://reviews.llvm.org/D33719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

mehdi_amini added a comment. In https://reviews.llvm.org/D24644#792168, @fhahn wrote: > I'd like to fix PR22999 and was wondering if you think adding a > function-section attribute to the IR would be a viable solution? > > When doing LTO, we could add the same function-section to each function i

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

hokein updated this revision to Diff 104190. hokein added a comment. Remove a redundant empty line. https://reviews.llvm.org/D34674 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h test/clang-tidy/modernize-make-unique.cpp Index: test/clang-tidy/

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

arphaman created this revision. Herald added a subscriber: mgorny. The core engine of clang-rename will be used for local and global renames in the new refactoring engine (http://lists.llvm.org/pipermail/cfe-dev/2017-June/054286.html). I haven't renamed the files/cleaned up the code in this pat

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc added a comment. @fedor.sergeev do you have time to review my (hopefully) final revision? Also can you recommend someone to review the extra test changes? Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list

[PATCH] D34674: [clang-tidy] Handle new array expressions in modernize-make-unique check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306421: [clang-tidy] Handle new array expressions in modernize-make-unique check. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D34674 Files: clang-tools-extra/trunk/clang-tidy/

[clang-tools-extra] r306421 - [clang-tidy] Handle new array expressions in modernize-make-unique check.

Author: hokein Date: Tue Jun 27 09:25:05 2017 New Revision: 306421 URL: http://llvm.org/viewvc/llvm-project?rev=306421&view=rev Log: [clang-tidy] Handle new array expressions in modernize-make-unique check. Reviewers: alexfh Reviewed By: alexfh Subscribers: JDevlieghere, xazax.hun, cfe-commits

[PATCH] D34206: [clang-tidy] Add "MakeSmartPtrFunction" option to modernize-make-shared/unique checks.

hokein added a comment. In https://reviews.llvm.org/D34206#790406, @alexfh wrote: > Ping me once you're done fixing the bugs. The bugs are fixed. The patch is ready for review ;) https://reviews.llvm.org/D34206 ___ cfe-commits mailing list cfe-co

[PATCH] D24644: Pass -ffunction-sections/-fdata-sections along to gold-plugin

fhahn added a comment. In https://reviews.llvm.org/D24644#792262, @mehdi_amini wrote: > In https://reviews.llvm.org/D24644#792168, @fhahn wrote: > > > I'd like to fix PR22999 and was wondering if you think adding a > > function-section attribute to the IR would be a viable solution? > > > > When

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

yaxunl added a comment. In https://reviews.llvm.org/D34342#786941, @bader wrote: > Added test case reproducing the issue described in the description. > Removed test cases from test/SemaOpenCL/sampler_t.cl covered by > test/CodeGenOpenCL/sampler.cl. > > While I was moving one test case from tes

[PATCH] D34506: Factor out a functionality from `isBeforeInTranslationUnit`

akyrtzi added a comment. I'd prefer to avoid including whitespace-only changes (there are a couple of lines in the diff with only whitespace change), otherwise LGTM! https://reviews.llvm.org/D34506 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

danielcdh updated this revision to Diff 104199. danielcdh added a comment. update comments https://reviews.llvm.org/D34663 Files: test/CodeGen/pgo-sample-thinlto-summary.c Index: test/CodeGen/pgo-sample-thinlto-summary.c === --

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

smeenai resigned from this revision. smeenai added a comment. Sorry, I've been meaning to respond for a while. This is kinda ugly, but I can't think of a better way to do it. I'm fine with this, but given that it's a pretty invasive change, I'm not comfortable accepting. You may wanna ping @Eri

[PATCH] D34342: [OpenCL] Fix code generation of function-scope constant samplers.

bader added a comment. Note: `get_sampler_initializer` from my test case returns integer, not a sampler, but having function is not relevant to the problem. Here is a bit simplified test case without function calls that still reproduces the problem: kernel void foo(int sampler_init_value) {

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

davidxl added inline comments. Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:39 +// O2: if.true.direct_targ // ThinLTO-NOT: if.true.direct_targ void icp(void (*p)()) { Is the thinLTO behavior here expected? https://reviews.llvm.org/D34663 _

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

danielcdh added inline comments. Comment at: test/CodeGen/pgo-sample-thinlto-summary.c:39 +// O2: if.true.direct_targ // ThinLTO-NOT: if.true.direct_targ void icp(void (*p)()) { davidxl wrote: > Is the thinLTO behavior here expected? Yes, it's expected, icp is

[PATCH] D34663: Update test for enabling ICP for AutoFDO.

davidxl accepted this revision. davidxl added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D34663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

r306430 - Update test for enabling ICP for AutoFDO.

Author: dehao Date: Tue Jun 27 10:23:42 2017 New Revision: 306430 URL: http://llvm.org/viewvc/llvm-project?rev=306430&view=rev Log: Update test for enabling ICP for AutoFDO. Summary: This is the test update patch for https://reviews.llvm.org/D34662 Reviewers: davidxl Reviewed By: davidxl Subsc

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 104201. wangxindsb marked an inline comment as done. wangxindsb added a comment. -Fix the bug of the virtual call during a function call of the object. -Add flag for the PUREONLY. https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/Virtu

r306433 - [x86] weaken test checks that shouldn't be here in the first place

Author: spatel Date: Tue Jun 27 10:39:46 2017 New Revision: 306433 URL: http://llvm.org/viewvc/llvm-project?rev=306433&view=rev Log: [x86] weaken test checks that shouldn't be here in the first place This test would fail after the proposed change in: https://reviews.llvm.org/D34242 Modified:

r306434 - Update the test comment to clarify the intention of the test.

Author: dehao Date: Tue Jun 27 10:45:40 2017 New Revision: 306434 URL: http://llvm.org/viewvc/llvm-project?rev=306434&view=rev Log: Update the test comment to clarify the intention of the test. Modified: cfe/trunk/test/CodeGen/pgo-sample-thinlto-summary.c Modified: cfe/trunk/test/CodeGen/pgo

[libunwind] r306442 - [libunwind] Add _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS

Author: nico Date: Tue Jun 27 11:37:06 2017 New Revision: 306442 URL: http://llvm.org/viewvc/llvm-project?rev=306442&view=rev Log: [libunwind] Add _LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS It's useful to be able to disable visibility annotations entirely; for example, if we're building libunwind

r306444 - CodeGen: load indirect ObjC ARC arguments in prologue

Author: compnerd Date: Tue Jun 27 11:37:51 2017 New Revision: 306444 URL: http://llvm.org/viewvc/llvm-project?rev=306444&view=rev Log: CodeGen: load indirect ObjC ARC arguments in prologue When generating a prologue, add loads for ARC arguments passed indirectly. Patch by Dave Lee! Added: c

[PATCH] D34580: [CodeGen][ObjC] Load indirect ARC arguments in prolog

compnerd closed this revision. compnerd added a comment. SVN r306444 https://reviews.llvm.org/D34580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34665: [CodeGen] Fix assertion failure in EmitCallArg

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This seems fine, thanks. https://reviews.llvm.org/D34665 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r306447 - test: fix test for release builds

Author: compnerd Date: Tue Jun 27 11:57:50 2017 New Revision: 306447 URL: http://llvm.org/viewvc/llvm-project?rev=306447&view=rev Log: test: fix test for release builds Use a regex capture to avoid hardcoding the name. This should repair the failing buildbot. Modified: cfe/trunk/test/CodeGe

[PATCH] D34449: [clang-tidy] Enable constexpr definitions in headers.

hokein added a comment. BTW, could you please also update the `docs/clang-tidy/checks/misc-definitions-in-headers.rst`? Comment at: test/clang-tidy/misc-definitions-in-headers-1z.hpp:5 +class CE { + constexpr static int i = 5; +}; Could you follow the way of

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

rsmith accepted this revision. rsmith added a comment. LGTM, thanks. Do you need someone to commit for you? https://reviews.llvm.org/D34198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D34444: Teach codegen to work in incremental processing mode.

rjmccall added a comment. What's the relationship between these llvm::Modules that you want to generate? Are you imagining them as separate translation units, or are the subsequent modules more like addenda to the original? Repository: rL LLVM https://reviews.llvm.org/D3 ___

[PATCH] D34444: Teach codegen to work in incremental processing mode.

v.g.vassilev added a comment. We use them as separate translation units due to the fact that we need to survive multiple calls to `HandleEndOfTranslationUnit`. This 'finalizes' the module, and we cannot write to it anymore. Even though we could write to it (this was the case when we were using

[PATCH] D34329: [clang-diff] Initial implementation.

johannes updated this revision to Diff 104249. johannes added a comment. - pass Options as a const reference instead of a pointer - rename TreeComparator -> ASTDiff::Impl, rename Comparator -> DiffImpl - move declaration of ASTDiff::Impl from the header to the source file so that Options does not

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang created this revision. Herald added subscribers: kristof.beyls, aemerson. This is the clang part of the initial implementation to support Windows ARM64 COFF format. https://reviews.llvm.org/D34706 Files: lib/Basic/Targets.cpp test/Preprocessor/predefined-macros.c Index: test/Prepr

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

mgrang added a comment. Here is the llvm part of this patch: https://reviews.llvm.org/D34705 https://reviews.llvm.org/D34706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34706: [COFF, ARM64] Add support for Windows ARM64 COFF format

ruiu added inline comments. Comment at: lib/Basic/Targets.cpp:6553 +class MicrosoftARM64leTargetInfo +: public WindowsTargetInfo { I cannot imagine there will be MicrosoftARM64beTargetInfo, so I wonder if we should name this MicrosoftARM64TargetInfo. htt

[PATCH] D32332: Add support for transparent overloadable functions in clang

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D32332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

RE: r306149 - Emit warning when throw exception in destruct or dealloc functions which has a

Hi Richard: I’m not sure if you noticed this, but my coworker did submit a review here: https://reviews.llvm.org/D34671 with the changes you suggested. Thanks, Erich From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith Sent: Monday, June 26, 2017 2:25 PM To: Keane, Erich

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

rsmith added a comment. In https://reviews.llvm.org/D30946#754103, @schroedersi wrote: > As an alternative to the current solution, the above-mentioned member > functions could each be extended by a "PrintingContext" argument, which then > contains the variable states. I'd be interested to se

[PATCH] D34091: Support for querying the exception specification type through libclang

ajbennieston added a comment. Jon, by all means go ahead! https://reviews.llvm.org/D34091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306467 - [Sema] Allow unmarked overloadable functions.

Author: gbiv Date: Tue Jun 27 14:31:31 2017 New Revision: 306467 URL: http://llvm.org/viewvc/llvm-project?rev=306467&view=rev Log: [Sema] Allow unmarked overloadable functions. This patch extends the `overloadable` attribute to allow for one function with a given name to not be marked with the `o

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv added a comment. Woohoo! Thanks again to both of you. https://reviews.llvm.org/D32332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32332: Add support for transparent overloadable functions in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL306467: [Sema] Allow unmarked overloadable functions. (authored by gbiv). Changed prior to commit: https://reviews.llvm.org/D32332?vs=103448&id=104277#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D33278: [LLVM][x86][Inline Asm] - Enum support for MS syntax

coby added inline comments. Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1310 } - -bool X86AsmParser::ParseIntelExpression(IntelExprStateMachine &SM, SMLoc &End) { +bool X86AsmParser::ParseIntelExpression(IntelExprStateMachine &SM, SMLoc &End, +

  1   2   >