ahatanak accepted this revision.
ahatanak added a comment.
This revision is now accepted and ready to land.
This looks correct to me. The commit log of the original commit (r163266)
doesn't say that CFIndex has been dropped intentionally, so this should be fine.
Repository:
rL LLVM
https://r
djasper added inline comments.
Comment at: include/clang/Format/Format.h:993
+ /// inside ``IncludeCategories``.
+ bool IncludeRegexCaseInsensitive;
+
Do we really need a flag here? Shouldn't we just always do this?
https://reviews.llvm.org/D33932
Typz added a comment.
I don't know if some style would want different styles, and I agree with you on
principle; but since the brace wrapping is already configured for each kind of
record, I choose to keep things consistent and have flags for each kind of
record.
But I can merge the options, an
djasper added a comment.
Yes merge them into those two, please. I think we introduced the others because
of some linux style, but generally lets try not to introduce options that
people aren't going to use.
https://reviews.llvm.org/D34395
___
cfe-
Serge_Preis added a comment.
Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't
knwo what this configuration mean) - I tested on Linux that I have at my
desposal and tesing passes.
Repository:
rL LLVM
https://reviews.llvm.org/D32439
__
chapuni added a comment.
In https://reviews.llvm.org/D32439#790248, @Serge_Preis wrote:
> Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't
> knwo what this configuration mean) - I tested on Linux that I have at my
> disposal and tesing passes.
It's cross-compiling.
Author: petarj
Date: Mon Jun 26 02:58:01 2017
New Revision: 306280
URL: http://llvm.org/viewvc/llvm-project?rev=306280&view=rev
Log:
[mips] Enable IAS by default for Android 64-bit MIPS target (N64)
IAS is already used for MIPS64 in majority of Android projects.
Android MIPS64 uses N64 ABI. Set I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306280: [mips] Enable IAS by default for Android 64-bit MIPS
target (N64) (authored by petarj).
Changed prior to commit:
https://reviews.llvm.org/D34514?vs=103574&id=103912#toc
Repository:
rL LLVM
h
arphaman added a comment.
I don't think the new warning is ideal, e.g.:
#import
__attribute__((visibility("default")))
__attribute__((availability(macosx,introduced=10_10)))
@interface Test : NSObject
@end
Test *testVar;
E.g.:
test.m:13:1: warning: 'Test' is partial: intr
Serge_Preis added a comment.
In https://reviews.llvm.org/D32439#790252, @chapuni wrote:
> In https://reviews.llvm.org/D32439#790248, @Serge_Preis wrote:
>
> > Is there any meaning in 'test-clang-msc-x64-on-i686-linux-RA' (I just don't
> > knwo what this configuration mean) - I tested on Linux th
chapuni added a comment.
In https://reviews.llvm.org/D32439#790302, @Serge_Preis wrote:
> Thank you for clarifications, would you explain how may I reproduce failure
> locally or remotely. I'd like to see c-index-test output before clang-check
> to understand what's going on.
Just change LLVM
johannes added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:730
+
+Mapping TreeComparator::matchTopDown() const {
+ PriorityList L1(T1);
johannes wrote:
> arphaman wrote:
> > Johannes, it seems to me that your implementation of the top-down porti
alexfh added a comment.
In https://reviews.llvm.org/D34206#783673, @hokein wrote:
> In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote:
>
> > It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
> > llvm::make_unique.
>
>
> +1. See https://reviews.llvm.org/D34334,
2017-06-26 4:05 GMT+07:00 David Blaikie :
> Ah, I see now then.
>
> I have a symlink from the root of my source directory pointing to the
> compile_commands.json in my build directory.
>
> I have this so that the vim YouCompleteMe plugin (& any other clang tools)
> can find it, as they usually sho
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D34091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
Typz updated this revision to Diff 103935.
Typz added a comment.
Complete refactor to make the processing much more generic
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Format/Fo
Typz updated this revision to Diff 103937.
Typz added a comment.
Fix typo
https://reviews.llvm.org/D33440
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
lib/Format/FormatTokenLexer.h
lib/Format/NamespaceEndComments
coby abandoned this revision.
coby added a comment.
superseded by https://reviews.llvm.org/rL302179
Repository:
rL LLVM
https://reviews.llvm.org/D32638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Typz updated this revision to Diff 103939.
Typz added a comment.
Merge `SplitEmptyClass/Struct/Union` options into a single `SplitEmptyRecord`
option.
https://reviews.llvm.org/D34395
Files:
include/clang/Format/Format.h
lib/Format/Format.cpp
lib/Format/FormatToken.h
lib/Format/Unwrappe
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D34395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
filcab added a comment.
In https://reviews.llvm.org/D34299#788427, @vsk wrote:
> I hope I've cleared this up, but: we need to store the source location
> constant _somewhere_, before we emit the return value check. That's because
> we can't infer which return location to use at compile time.
Serge_Preis added a comment.
In https://reviews.llvm.org/D32439#790323, @chapuni wrote:
> Just change LLVM_DEFAULT_TARGET_TRIPLE, build and run check-clang. You may
> use ccmake for it.
> Or, modify RUN line locally like
>
> RUN: c-index-test (snip) %s -Xclang -triple -Xclang x86_64-pc-win32
aaron.ballman added a comment.
In https://reviews.llvm.org/D33470#789791, @Prazek wrote:
> In https://reviews.llvm.org/D33470#764846, @aaron.ballman wrote:
>
> > Once you fix the typo in the check, can you run it over some large C++ code
> > bases to see if it finds any results?
>
>
> I tried it
RKSimon closed this revision.
RKSimon added a comment.
https://reviews.llvm.org/rL305551
https://reviews.llvm.org/D33406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek added a reviewer: rsmith.
klimek added a comment.
Richard (added as reviewer) usually owns decisions around clang itself. Writing
an email to cfe-dev with the numbers and wait for whether others have concerns
would probably also be good.
https://reviews.llvm.org/D30691
__
xazax.hun added a comment.
In https://reviews.llvm.org/D34506#787971, @joerg wrote:
> I don't think it is a good idea to make this function non-transitive.
I think this is a good point. However, I am not entirely sure that it is
transitive right now. Check the "Both are in built-in buffers, bu
hokein added a comment.
In https://reviews.llvm.org/D34206#790406, @alexfh wrote:
> In https://reviews.llvm.org/D34206#783673, @hokein wrote:
>
> > In https://reviews.llvm.org/D34206#780455, @Eugene.Zelenko wrote:
> >
> > > It'll be good idea to run modernize-make-unique on LLVM/Clang/etc for
>
Author: axel
Date: Mon Jun 26 08:06:40 2017
New Revision: 306291
URL: http://llvm.org/viewvc/llvm-project?rev=306291&view=rev
Log:
Improve const-correctness.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
Modified: cfe/trunk/include/clang/Parse/Parser.h
URL:
http://llvm.org/viewvc/llvm-pr
djasper added a comment.
Can you create a more interesting test case where the map definition spans
multiple lines? Possibly use qualified names for the field types.
https://reviews.llvm.org/D34623
___
cfe-commits mailing list
cfe-commits@lists.llv
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: test/CodeGenObjCXX/arc-indirect.mm:19
+// CHECK-DARWIN: define internal void @"\01-[C object:struct:]"(<{ %0*, i8*,
i8*, %struct.S, [3 x i8] }>* inalloca)
+// CHE
krasimir updated this revision to Diff 103962.
krasimir added a comment.
- Add map declarations spanning multiple lines
https://reviews.llvm.org/D34623
Files:
unittests/Format/FormatTestProto.cpp
Index: unittests/Format/FormatTestProto.cpp
===
rnk added inline comments.
Comment at: test/CodeGen/x86-ms-inline-asm-enum_feature.cpp:12
+ const int a = 0;
+ // CHECK-NOT: mov eax, [$$0]
+ __asm mov eax, [a]
rnk wrote:
> mharoush wrote:
> > rnk wrote:
> > > Use CHECK-LABEL, CHECK, and CHECK-SAME the way th
erik.pilkington updated this revision to Diff 103958.
erik.pilkington added a comment.
Make the diagnostic reference the context declaration instead of the offending
decl if no enclosing decl is found, fixing the diagnostic bug @arphaman pointed
out.
https://reviews.llvm.org/D33816
Files:
i
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:23
+ const LangOptions &Lang) {
+ return clang::Lexer::getSourceText(
+ clang::CharSou
Author: myatsina
Date: Mon Jun 26 08:55:51 2017
New Revision: 306297
URL: http://llvm.org/viewvc/llvm-project?rev=306297&view=rev
Log:
[inline asm][gcc-compatiblity] "=i" output constraint support
Ignore ‘i’,’n’,’E’,’F’ as output constraints in inline assembly (gcc
compatibility)
Differential R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306297: [inline asm][gcc-compatiblity] "=i" output
constraint support (authored by myatsina).
Changed prior to commit:
https://reviews.llvm.org/D31383?vs=97602&id=103967#toc
Repository:
rL LLVM
http
arphaman added inline comments.
Comment at: test/SemaObjC/unguarded-availability.m:243
+
+ struct { new_int mem; } anon; // expected-warning{{'new_int' is partial}}
expected-note{{annotate '' with an availability attribute}}
+};
We should never have something l
Author: myatsina
Date: Mon Jun 26 09:09:55 2017
New Revision: 306301
URL: http://llvm.org/viewvc/llvm-project?rev=306301&view=rev
Log:
[inline asm] dot operator while using imm generates wrong ir + asm - clang part
Inline asm dot operator while using imm generates wrong ir and asm
This is the tes
bruno marked an inline comment as done.
bruno added inline comments.
Comment at: include/__config:234-235
+// a MS compatibility version is specified.
# ifndef __MINGW32__
-#define _LIBCPP_MSVCRT // Using Microsoft's C Runtime library
+#ifdef _MSC_VER
+# define _LI
bruno updated this revision to Diff 103975.
bruno added a comment.
Update patch after reviewer suggestions!
https://reviews.llvm.org/D34588
Files:
include/__config
Index: include/__config
===
--- include/__config
+++ include/__
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D34556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
compnerd updated this revision to Diff 103981.
compnerd added a comment.
__ptr64 mangling, add tests for 32-bit.
Repository:
rL LLVM
https://reviews.llvm.org/D34523
Files:
lib/AST/MicrosoftMangle.cpp
test/CodeGenCXX/msabi-blocks.cpp
Index: test/CodeGenCXX/msabi-blocks.cpp
==
yawanng created this revision.
yawanng added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, JDevlieghere.
Handle a case when the function is passed as an argument of a function-like
macro. Plus fix a format that was forgotten to commit last time.
Repository:
rL LLVM
https
Author: ahatanak
Date: Mon Jun 26 10:39:48 2017
New Revision: 306310
URL: http://llvm.org/viewvc/llvm-project?rev=306310&view=rev
Log:
[libcxx] Annotate c++17 aligned new/delete operators with availability
attribute.
This is needed because older versions of libc++ do not have these
operators. If
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306310: [libcxx] Annotate c++17 aligned new/delete operators
with availability (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D34556?vs=103883&id=103992#toc
Repository:
rL
kastiglione updated this revision to Diff 103994.
kastiglione added a comment.
CHECK load and call
https://reviews.llvm.org/D34580
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenObjCXX/arc-indirect.mm
Index: test/CodeGenObjCXX/arc-indirect.mm
===
hokein updated this revision to Diff 103995.
hokein marked 2 inline comments as done.
hokein added a comment.
Herald added a subscriber: JDevlieghere.
Address review comments.
https://reviews.llvm.org/D34286
Files:
clang-tidy/modernize/MakeSmartPtrCheck.cpp
test/clang-tidy/modernize-make-un
kastiglione added a comment.
Thanks @rnk.
I don't have commit access; @compnerd, @rnk would either of you mind committing
this? Thanks in advance!
https://reviews.llvm.org/D34580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
Looks good to me but I definitely want to hear what @efriedma has to say.
Repository:
rL LLVM
https://reviews.llvm.org/D34523
___
cfe-comm
omtcyfz created this revision.
This patch introduces cosmetic changes while making ClangD code slightly more
LLVM Coding Standards-compliant by
- Convert names of struct fields in Protocol.h from `camelCase` to `CamelCase`
- Enclose code in .cpp implementation files in appropriate namespaces ins
Author: ahatanak
Date: Mon Jun 26 11:46:12 2017
New Revision: 306317
URL: http://llvm.org/viewvc/llvm-project?rev=306317&view=rev
Log:
[Sema] Fix a crash-on-invalid when a template parameter list has a class
definition or non-reference class type.
The crash occurs when there is a template paramet
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306317: [Sema] Fix a crash-on-invalid when a template
parameter list has a class (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D33606?vs=100465&id=104000#toc
Repository:
r
efriedma added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:988
+ if (const auto *RD = dyn_cast(DC))
+mangleName(RD);
+ else
The call to mangleName() looks a little weird... I would have expected a call
to mangleUnqualifiedName or s
Author: rsmith
Date: Mon Jun 26 12:39:25 2017
New Revision: 306320
URL: http://llvm.org/viewvc/llvm-project?rev=306320&view=rev
Log:
When preprocessing with -frewrite-imports and -fmodule-file=, do not pass all
modules to preprocessing of nested .pcm files.
Making those module files available res
NoQ added a comment.
In a perfect world, the analyzer's report would work like a debugger: jumping
through stack frames, or even through diagnostic pieces, and printing symbolic
values of variables at every piece would be really great.
I'm not entirely understanding the behavior you intend to h
Author: rsmith
Date: Mon Jun 26 13:15:21 2017
New Revision: 306325
URL: http://llvm.org/viewvc/llvm-project?rev=306325&view=rev
Log:
Remove some redundant setup when preprocessing .pcm files.
Both of these steps are immediately overwritten by the FrontendAction setup.
Modified:
cfe/trunk/lib
Author: rsmith
Date: Mon Jun 26 13:33:42 2017
New Revision: 306327
URL: http://llvm.org/viewvc/llvm-project?rev=306327&view=rev
Log:
Check that the initializer of a non-dependent constexpr variable is constant
even within templates.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
cfe/trunk/tes
akyrtzi added a comment.
Comparing SourceLocations from different translation units is not meaningful
and my concern is that treating source locations like this can very easy lead
to errors where by mistake the code is resolving a SourceLocation with the
wrong translation unit and not the trans
rsmith added a comment.
What's the status of this patch? https://reviews.llvm.org/D34510 is touching on
a related issue, and we need to resolve how we're going to deal with ODR-like
issues in C to determine how to address the issue that it is tackling.
https://reviews.llvm.org/D31778
__
akyrtzi added a comment.
`FullSourceLoc` could be useful, it wraps the SourceManager that the
SourceLocation come from.
Repository:
rL LLVM
https://reviews.llvm.org/D34506
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rsmith added a comment.
https://reviews.llvm.org/D31778 is related. We need to have a design for how
ODR-like issues in C will be resolved before we'll know what the right fix is
here. Prior to https://reviews.llvm.org/D31778 my intention had been to
implement C's structural typing ("compatible
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good, thanks!
https://reviews.llvm.org/D34059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
rsmith added a comment.
This makes sense to me, but I'd like John's input on whether this is a
reasonable facility for CodeGen to have, and whether this is sufficient for
(for example) inline function definitions to be emitted at the right times into
the right `Module`s. (The tests for this app
zaks.anna added a comment.
> @dcoughlin As a reviewer of both patches - could you tell us what's the
> difference between them? And how are we going to resolve this issue?
Unfortunately, @dcoughlin is on vacation this week; should be back next week.
Repository:
rL LLVM
https://reviews.llvm.
ahatanak added a comment.
Duncan and I had a discussion on this.
We are thinking about adding a warning that tells users that aligned allocation
/deallocation operators are being called but they are not defined in the
library. If the users haven't defined their own aligned allocation /
dealloc
kuang_he updated this revision to Diff 104018.
https://reviews.llvm.org/D33833
Files:
lib/AST/DeclCXX.cpp
test/SemaTemplate/destructor-template.cpp
Index: test/SemaTemplate/destructor-template.cpp
===
--- test/SemaTemplate/dest
dexonsmith added a comment.
In https://reviews.llvm.org/D34574#791124, @ahatanak wrote:
> Duncan and I had a discussion on this.
>
> We are thinking about adding a warning that tells users that aligned
> allocation /deallocation operators are being called but they are not defined
> in the libra
rsmith added a comment.
So the driver would pass a flag to the frontend to indicate "this target
probably doesn't have aligned allocation support", and Sema would produce a
warning if it selects an aligned allocation function when that flag is
specified? That makes sense to me.
Should we also
rsmith added a comment.
In https://reviews.llvm.org/D34574#791157, @dexonsmith wrote:
> Likely, something like `-Werror=aligned-allocation-availability` (by default).
An error by default seems OK if accompanied with a "use -faligned-allocation if
you supply your own aligned allocation function
dexonsmith added a comment.
In https://reviews.llvm.org/D34574#791158, @rsmith wrote:
> Should we also remove the recently-added availability attributes in libc++
> too? If I'm using a recent libc++ and providing my own aligned allocation
> functions, we shouldn't reject attempts to call those
On 23 June 2017 at 13:22, Erich Keane via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: erichkeane
> Date: Fri Jun 23 15:22:19 2017
> New Revision: 306149
>
> URL: http://llvm.org/viewvc/llvm-project?rev=306149&view=rev
> Log:
> Emit warning when throw exception in destruct or dealloc
Hello everyone,
I took few builders off-line for maintenance. Builders:
llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
clang-with-lto-ubuntu
clang-with-thin-lto-ubuntu
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@li
compnerd marked 2 inline comments as done.
compnerd added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:988
+ if (const auto *RD = dyn_cast(DC))
+mangleName(RD);
+ else
efriedma wrote:
> The call to mangleName() looks a little weird..
Sorry Richard, I thought I gave you enough time before committing this for Jen.
Adding her so she can respond to your comments and fix these.
Thanks,
Erich
From: meta...@gmail.com [mailto:meta...@gmail.com] On Behalf Of Richard Smith
Sent: Monday, June 26, 2017 2:25 PM
To: Keane, Erich
Cc: cfe-
efriedma added inline comments.
Comment at: test/CodeGenCXX/msabi-blocks.cpp:90
+}
+
compnerd wrote:
> efriedma wrote:
> > The Itanium ABI document lists five cases where the mangling is externally
> > visible. I think this is missing a testcase for the "initia
compnerd marked 2 inline comments as done.
compnerd added inline comments.
Comment at: lib/AST/MicrosoftMangle.cpp:988
+ if (const auto *RD = dyn_cast(DC))
+mangleName(RD);
+ else
compnerd wrote:
> efriedma wrote:
> > The call to mangleName() lo
compnerd updated this revision to Diff 104028.
compnerd added a comment.
Handle unnamed parameters, improve mangling for NSDMis. The one case that we
dont handle currently causes an assertion even in itanium mode.
https://reviews.llvm.org/D34523
Files:
lib/AST/MicrosoftMangle.cpp
test/Cod
jasonliu created this revision.
Creating a function pointer with proper parameters pointing to std::next() or
std::prev() should work.
This change moves the invented paramater for enable_if over to the return type
to resolve this QoI issue.
https://reviews.llvm.org/D34649
Files:
include/ite
Quuxplusone added inline comments.
Comment at: include/iterator:619
template
inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_AFTER_CXX14
Might fix the spelling error in "BidirectionalIter" while you're here.
https://reviews.llvm.org/D34649
__
efriedma added a comment.
LGTM (with the caveat that I don't know anything about Microsoft mangling).
https://reviews.llvm.org/D34523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
johannes updated this revision to Diff 104032.
johannes added a comment.
refactor
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
include/clang/Tooling/ASTDiff/ASTDiffInternal.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
lib/Tooli
Author: alexshap
Date: Mon Jun 26 16:02:27 2017
New Revision: 306343
URL: http://llvm.org/viewvc/llvm-project?rev=306343&view=rev
Log:
[clang] Enable printf check for CFIndex
According to
https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecifiers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306343: [clang] Enable printf check for CFIndex (authored by
alexshap).
Changed prior to commit:
https://reviews.llvm.org/D34496?vs=103536&id=104038#toc
Repository:
rL LLVM
https://reviews.llvm.org/
ruiu added a comment.
I'd copy what Hal mentioned in other review thread for other GSoC project. You
don't want to tag your patches with "[GSoC]" because it doesn't describe
anything about patch contents and many other unrelated patches could have been
tagged as single "[GSoC]" tag. Instead, yo
Author: rsmith
Date: Mon Jun 26 16:19:32 2017
New Revision: 306346
URL: http://llvm.org/viewvc/llvm-project?rev=306346&view=rev
Log:
Revert r301742, which caused us to try to evaluate all full-expressions.
Also add testcases for a bunch of expression forms that cause our evaluator to
crash. See P
Author: compnerd
Date: Mon Jun 26 16:28:42 2017
New Revision: 306347
URL: http://llvm.org/viewvc/llvm-project?rev=306347&view=rev
Log:
AST: enhance mangling for blocks with MS ABI
When generating the decorated name for a static variable inside a
BlockDecl, construct a scope for the block invocati
compnerd closed this revision.
compnerd added a comment.
SVN r306347
Thanks @efriedma and @majnemer!
https://reviews.llvm.org/D34523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe added a comment.
I can merge this for you Andrew.
https://reviews.llvm.org/D34091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
toddlipcon created this revision.
toddlipcon added a project: clang-tools-extra.
Herald added a subscriber: JDevlieghere.
This patch adds the ability to specify a regex of headers to exclude from
clang-tidy diagnostics. This is the inverse of the existing header regex.
In our project we want to
toddlipcon abandoned this revision.
toddlipcon added a comment.
Re-posted as https://reviews.llvm.org/D34654
Repository:
rL LLVM
https://reviews.llvm.org/D34415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
Author: rsmith
Date: Mon Jun 26 17:22:07 2017
New Revision: 306349
URL: http://llvm.org/viewvc/llvm-project?rev=306349&view=rev
Log:
Fix this test to use a construct that actually forces struct layout to happen
when testing -Wpadded.
Modified:
cfe/trunk/test/Modules/diag-flags.cpp
Modified:
efriedma resigned from this revision.
efriedma added a comment.
The check itself looks okay, but I'm not really familiar with the other ubsan
bits.
https://reviews.llvm.org/D34590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
Author: rsmith
Date: Mon Jun 26 17:29:32 2017
New Revision: 306350
URL: http://llvm.org/viewvc/llvm-project?rev=306350&view=rev
Log:
Remove redundant check.
Modified:
cfe/trunk/lib/Serialization/ASTReader.cpp
Modified: cfe/trunk/lib/Serialization/ASTReader.cpp
URL:
http://llvm.org/viewvc/ll
rnk added a comment.
I think there's something wrong with clang's implementation of __float128. It
seems fundamentally incompatible with libstdc++'s __is_floating_point_helper
mechanism. We can definitely take this patch to unblock things, but we should
file a bug about investigating this all t
rnk added inline comments.
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:1382
+if (const MCConstantExpr *CE =
+dyn_cast_or_null(Val)) {
+ StringRef ErrMsg;
rnk wrote:
> Please use clang-format here and elsewhere
not addressed
On Mon, Jun 26, 2017 at 5:31 AM Serge Pavlov wrote:
> 2017-06-26 4:05 GMT+07:00 David Blaikie :
>
>> Ah, I see now then.
>>
>> I have a symlink from the root of my source directory pointing to the
>> compile_commands.json in my build directory.
>>
>> I have this so that the vim YouCompleteMe plug
bcraig added a comment.
LGTM, but you should probably get approval from somebody a bit more senior with
the project.
Comment at: include/__config:234-235
+// a MS compatibility version is specified.
# ifndef __MINGW32__
-#define _LIBCPP_MSVCRT // Using Microsoft's C Runt
krytarowski added a comment.
Joerg declines to take this patch as it is, as there is no compiler-rt support
for __float128 on i386 in compiler-rt. GCC knows __float128 on i386, amd64,
i64, hppa, powerpc [some variations]; currently I focus on i386/amd64.
My proposal was to check if there is use
On Tue, Jun 20, 2017 at 2:06 PM Lang Hames via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: lhames
> Date: Tue Jun 20 16:06:00 2017
> New Revision: 305850
>
> URL: http://llvm.org/viewvc/llvm-project?rev=305850&view=rev
> Log:
> Preserve CXX method overrides in ASTImporter
>
> Summar
compnerd added a comment.
Thinking more about this, on Windows, is there a strong reason to default to a
different libc by default on Windows? @bruno would reusing `-ffreestanding`
work for you here? Or is there something else that we can identify about the
target environment that can indicat
1 - 100 of 105 matches
Mail list logo
