[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

hfinkel added a comment. In general, this patch seems to be missing tests (unless it is actually NFC, or you can't write tests yet, which, in either case, need to be explained). Comment at: lib/Driver/ToolChains/Cuda.cpp:217 + std::vector GPUArchNames; + // If this is an Ope

Re: r303322 - [modules] Switch from inferring owning modules based on source location to

On Wed, Jun 21, 2017 at 4:56 PM, Richard Smith wrote: > On 21 June 2017 at 16:55, Bruno Cardoso Lopes > wrote: >> >> On Wed, Jun 21, 2017 at 4:44 PM, Richard Smith >> wrote: >> > On 21 June 2017 at 14:51, Bruno Cardoso Lopes >> > wrote: >> >> >> >> Hi Richard, >> >> >> >> Somehow this commit ca

[PATCH] D29651: [OpenMP] Consider LIBRARY_PATH when selecting library paths for NVPTX targets in OpenMP mode.

hfinkel added a comment. In https://reviews.llvm.org/D29651#720179, @tstellar wrote: > Why is this necessary? To put it another way, what is special about LIBRARY_PATH in this regard? Do we already pass paths specified with `-L`? I'm also slightly concerned here with the custom parsing code.

[PATCH] D34494: fix determination of whether declarations are visible during ObjC lookups

rsmith created this revision. Herald added subscribers: javed.absar, sanjoy. Determining whether a declaration is visible or not requires knowledge of the context in which the question is asked: for instance, during template instantiation, additional modules might be visible, and with local subm

[PATCH] D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling

karies added a comment. For the record, here's what GCC does (from https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html#C_002b_002b-Dialect-Options which probably has a typo, the second -Wnoexcept is likely meant to be -Wnoexcept-type): "Enabled by -Wabi and -Wc++1z-compat." -Wc+

[PATCH] D34198: Fix __has_trivial_destructor crash when the type is incomplete with unknown array bounds.

puneetha updated this revision to Diff 103530. puneetha added a comment. Added test cases for all the affecting traits. https://reviews.llvm.org/D34198 Files: lib/Sema/SemaExprCXX.cpp test/SemaCXX/type-traits.cpp Index: test/SemaCXX/type-traits.cpp =

[PATCH v3] [PPC64]: Add support for Swift calling convention

For the tests I've extracted the int5 and int8 cases to cater for different alignments for different platform ABIs. For Linux on POWER the 5 and 8 element vectors must be naturally aligned with respect to the total "soft" vector size, despite being represented as an aggregate. Specifically, the pat

<    1   2