Author: chapuni
Date: Sat May 27 03:06:52 2017
New Revision: 304067
URL: http://llvm.org/viewvc/llvm-project?rev=304067&view=rev
Log:
ClangdTests.cpp: Fix a possible typo, it was "if (TmpDir2 != TmpDir2)"
It caused failures in unittests if TmpDir2 is not "/tmp" .
Modified:
clang-tools-extra/
chapuni added inline comments.
Comment at: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp:123
+ TmpDirs.push_back(TmpDir1.str());
+ if (TmpDir2 != TmpDir2)
+TmpDirs.push_back(TmpDir2.str());
Did you mean, "TmpDir1 != TmpDir2" ?
Fixed in r304067.
Hopefully fixed in r304067.
See also; https://reviews.llvm.org/D33416#766533
On Sat, May 27, 2017 at 6:12 AM Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Ilya,
>
> The unit test introduced by this commit hits an assertion failure on our
> bots. Could you please take a l
v.g.vassilev added inline comments.
Comment at: include/clang/Basic/DiagnosticGroups.td:631
// UnusedParameter, (matches GCC's behavior)
+// UnusedTemplate, (clean-up libc++ before enabling)
// UnusedMember
v.g.vassilev added a comment.
In https://reviews.llvm.org/D29877#766301, @rsmith wrote:
> In https://reviews.llvm.org/D29877#766196, @EricWF wrote:
>
> > No. But I can point you to `range-v3` which uses this pattern and I think
> > the idiom is somewhat appealing, but that's orthogonal to Clang
Prazek updated this revision to Diff 100530.
Prazek marked 3 inline comments as done.
Prazek added a comment.
- Addressing John's comments
https://reviews.llvm.org/D33437
Files:
include/clang/AST/VTableBuilder.h
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGen
Prazek added a comment.
Thanks for the comments :)
Comment at: include/clang/AST/VTableBuilder.h:160
+ "GlobalDecl can be created only from virtual function");
+if (getKind() == CK_FunctionPointer)
+ return GlobalDecl(getFunctionDecl());
rjmc
Prazek updated this revision to Diff 100533.
Prazek added a comment.
- changed to QualType, now it is much cleaner
https://reviews.llvm.org/D31830
Files:
lib/CodeGen/CGExpr.cpp
test/CodeGenCXX/strict-vtable-pointers.cpp
Index: test/CodeGenCXX/strict-vtable-pointers.cpp
Prazek marked 2 inline comments as done.
Prazek added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:3530
+ return false;
+}
+
rjmccall wrote:
> You need to recurse into base classes (to check their fields), and if you
> write this to take a QualType you w
sepavloff marked 2 inline comments as done.
sepavloff added a comment.
In https://reviews.llvm.org/D30170#761342, @rsmith wrote:
> Do we really need two different notions of "definition" and "odr definition"
> here? What goes wrong if we always treat the "instantiation of a friend
> function de
sepavloff updated this revision to Diff 100534.
sepavloff added a comment.
Updated patch
- Reduce number of added functions,
- Fixed some comments,
- Function `isOdrDefined` now checks uninstantiated bodies only for friend
functions.
https://reviews.llvm.org/D30170
Files:
include/clang/AST/
fowles created this revision.
Herald added a subscriber: klimek.
Makes the parser for clang-query auto close all open parens on EOF
https://reviews.llvm.org/D33623
Files:
lib/ASTMatchers/Dynamic/Parser.cpp
unittests/ASTMatchers/Dynamic/ParserTest.cpp
Index: unittests/ASTMatchers/Dynamic/P
GorNishanov created this revision.
It is time!
https://reviews.llvm.org/D33624
Files:
www/cxx_status.html
Index: www/cxx_status.html
===
--- www/cxx_status.html
+++ www/cxx_status.html
@@ -831,9 +831,9 @@
[DR
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
Drumroll.. Approved!
https://reviews.llvm.org/D33624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304081: [coroutines] Mark cxx_status.html of Coroutines TS
as (SVN) (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D33624?vs=100538&id=100539#toc
Repository:
rL LLVM
ht
Author: gornishanov
Date: Sat May 27 17:54:52 2017
New Revision: 304081
URL: http://llvm.org/viewvc/llvm-project?rev=304081&view=rev
Log:
[coroutines] Mark cxx_status.html of Coroutines TS as (SVN)
Summary: It is time!
Reviewers: GorNishanov, rsmith
Reviewed By: GorNishanov, rsmith
Subscribers
Author: chapuni
Date: Sat May 27 18:19:28 2017
New Revision: 304082
URL: http://llvm.org/viewvc/llvm-project?rev=304082&view=rev
Log:
ClangdTests.cpp: Use "clang/Config/config.h" instead of "llvm/Config/config.h".
Modified:
clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp
Modified: c
EricWF created this revision.
The expression `await_ready` is required to be contextually convertible to bool
and `await_suspend` must be a prvalue of either `void` or `bool`.
This patch adds diagnostics for when those requirements are violated.
It also correctly performs the contextual conversi
EricWF updated this revision to Diff 100541.
EricWF added a comment.
- Format changes
https://reviews.llvm.org/D33625
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cpp
==
Author: ismail
Date: Sun May 28 01:15:42 2017
New Revision: 304085
URL: http://llvm.org/viewvc/llvm-project?rev=304085&view=rev
Log:
baremetal.cpp: Fix tests where lib suffix is 64
Modified:
cfe/trunk/test/Driver/baremetal.cpp
Modified: cfe/trunk/test/Driver/baremetal.cpp
URL:
http://llvm.
20 matches
Mail list logo
