[clang-tools-extra] r304067 - ClangdTests.cpp: Fix a possible typo, it was "if (TmpDir2 != TmpDir2)"

2017-05-27 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat May 27 03:06:52 2017 New Revision: 304067 URL: http://llvm.org/viewvc/llvm-project?rev=304067&view=rev Log: ClangdTests.cpp: Fix a possible typo, it was "if (TmpDir2 != TmpDir2)" It caused failures in unittests if TmpDir2 is not "/tmp" . Modified: clang-tools-extra/

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-27 Thread NAKAMURA Takumi via Phabricator via cfe-commits
chapuni added inline comments. Comment at: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp:123 + TmpDirs.push_back(TmpDir1.str()); + if (TmpDir2 != TmpDir2) +TmpDirs.push_back(TmpDir2.str()); Did you mean, "TmpDir1 != TmpDir2" ? Fixed in r304067.

Re: [clang-tools-extra] r303977 - [clangd] Allow to use vfs::FileSystem for file accesses.

2017-05-27 Thread NAKAMURA Takumi via cfe-commits
Hopefully fixed in r304067. See also; https://reviews.llvm.org/D33416#766533 On Sat, May 27, 2017 at 6:12 AM Vedant Kumar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Ilya, > > The unit test introduced by this commit hits an assertion failure on our > bots. Could you please take a l

[PATCH] D29877: Warn about unused static file scope function template declarations.

2017-05-27 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:631 // UnusedParameter, (matches GCC's behavior) +// UnusedTemplate, (clean-up libc++ before enabling) // UnusedMember

[PATCH] D29877: Warn about unused static file scope function template declarations.

2017-05-27 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added a comment. In https://reviews.llvm.org/D29877#766301, @rsmith wrote: > In https://reviews.llvm.org/D29877#766196, @EricWF wrote: > > > No. But I can point you to `range-v3` which uses this pattern and I think > > the idiom is somewhat appealing, but that's orthogonal to Clang

[PATCH] D33437: Emit available_externally vtables opportunistically

2017-05-27 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek updated this revision to Diff 100530. Prazek marked 3 inline comments as done. Prazek added a comment. - Addressing John's comments https://reviews.llvm.org/D33437 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGVTables.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGen

[PATCH] D33437: Emit available_externally vtables opportunistically

2017-05-27 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added a comment. Thanks for the comments :) Comment at: include/clang/AST/VTableBuilder.h:160 + "GlobalDecl can be created only from virtual function"); +if (getKind() == CK_FunctionPointer) + return GlobalDecl(getFunctionDecl()); rjmc

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-05-27 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek updated this revision to Diff 100533. Prazek added a comment. - changed to QualType, now it is much cleaner https://reviews.llvm.org/D31830 Files: lib/CodeGen/CGExpr.cpp test/CodeGenCXX/strict-vtable-pointers.cpp Index: test/CodeGenCXX/strict-vtable-pointers.cpp

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-05-27 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek marked 2 inline comments as done. Prazek added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3530 + return false; +} + rjmccall wrote: > You need to recurse into base classes (to check their fields), and if you > write this to take a QualType you w

[PATCH] D30170: Function definition may have uninstantiated body

2017-05-27 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff marked 2 inline comments as done. sepavloff added a comment. In https://reviews.llvm.org/D30170#761342, @rsmith wrote: > Do we really need two different notions of "definition" and "odr definition" > here? What goes wrong if we always treat the "instantiation of a friend > function de

[PATCH] D30170: Function definition may have uninstantiated body

2017-05-27 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff updated this revision to Diff 100534. sepavloff added a comment. Updated patch - Reduce number of added functions, - Fixed some comments, - Function `isOdrDefined` now checks uninstantiated bodies only for friend functions. https://reviews.llvm.org/D30170 Files: include/clang/AST/

[PATCH] D33623: Make the parser close parens for you on EOF

2017-05-27 Thread Matt Kulukundis via Phabricator via cfe-commits
fowles created this revision. Herald added a subscriber: klimek. Makes the parser for clang-query auto close all open parens on EOF https://reviews.llvm.org/D33623 Files: lib/ASTMatchers/Dynamic/Parser.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp Index: unittests/ASTMatchers/Dynamic/P

[PATCH] D33624: [coroutines] Mark cxx_status.html of Coroutines TS as (SVN)

2017-05-27 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov created this revision. It is time! https://reviews.llvm.org/D33624 Files: www/cxx_status.html Index: www/cxx_status.html === --- www/cxx_status.html +++ www/cxx_status.html @@ -831,9 +831,9 @@ [DR

[PATCH] D33624: [coroutines] Mark cxx_status.html of Coroutines TS as (SVN)

2017-05-27 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. Drumroll.. Approved! https://reviews.llvm.org/D33624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D33624: [coroutines] Mark cxx_status.html of Coroutines TS as (SVN)

2017-05-27 Thread Gor Nishanov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL304081: [coroutines] Mark cxx_status.html of Coroutines TS as (SVN) (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D33624?vs=100538&id=100539#toc Repository: rL LLVM ht

r304081 - [coroutines] Mark cxx_status.html of Coroutines TS as (SVN)

2017-05-27 Thread Gor Nishanov via cfe-commits
Author: gornishanov Date: Sat May 27 17:54:52 2017 New Revision: 304081 URL: http://llvm.org/viewvc/llvm-project?rev=304081&view=rev Log: [coroutines] Mark cxx_status.html of Coroutines TS as (SVN) Summary: It is time! Reviewers: GorNishanov, rsmith Reviewed By: GorNishanov, rsmith Subscribers

[clang-tools-extra] r304082 - ClangdTests.cpp: Use "clang/Config/config.h" instead of "llvm/Config/config.h".

2017-05-27 Thread NAKAMURA Takumi via cfe-commits
Author: chapuni Date: Sat May 27 18:19:28 2017 New Revision: 304082 URL: http://llvm.org/viewvc/llvm-project?rev=304082&view=rev Log: ClangdTests.cpp: Use "clang/Config/config.h" instead of "llvm/Config/config.h". Modified: clang-tools-extra/trunk/unittests/clangd/ClangdTests.cpp Modified: c

[PATCH] D33625: [coroutines] Diagnose invalid result types for `await_resume` and `await_suspend` and add missing conversions.

2017-05-27 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. The expression `await_ready` is required to be contextually convertible to bool and `await_suspend` must be a prvalue of either `void` or `bool`. This patch adds diagnostics for when those requirements are violated. It also correctly performs the contextual conversi

[PATCH] D33625: [coroutines] Diagnose invalid result types for `await_resume` and `await_suspend` and add missing conversions.

2017-05-27 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 100541. EricWF added a comment. - Format changes https://reviews.llvm.org/D33625 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX/coroutines.cpp ==

r304085 - baremetal.cpp: Fix tests where lib suffix is 64

2017-05-27 Thread Ismail Donmez via cfe-commits
Author: ismail Date: Sun May 28 01:15:42 2017 New Revision: 304085 URL: http://llvm.org/viewvc/llvm-project?rev=304085&view=rev Log: baremetal.cpp: Fix tests where lib suffix is 64 Modified: cfe/trunk/test/Driver/baremetal.cpp Modified: cfe/trunk/test/Driver/baremetal.cpp URL: http://llvm.