Re: r303630 - Allow to use vfs::FileSystem for file accesses inside ASTUnit.

We test it in clangd (https://reviews.llvm.org/D33416). Logically, it's a single change, split into two part: for cfe and clang-tools-extra. On Wed, May 24, 2017 at 1:48 AM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Any specific reason why this doesn't contain a testcase? > > On Tu

[PATCH] D33483: [OpenCL] reserve_id_t cannot be used as argument to kernel function

echuraev created this revision. Herald added a subscriber: yaxunl. https://reviews.llvm.org/D33483 Files: lib/Sema/SemaDecl.cpp test/SemaOpenCL/invalid-pipes-cl2.0.cl Index: test/SemaOpenCL/invalid-pipes-cl2.0.cl === --- test/S

[PATCH] D33447: clang-format: add option to merge empty function body

Typz updated this revision to Diff 100053. Typz added a comment. Fix SFS_Empty & SFS_Inline merging of empty function when BraceWrapping.AfterFunction, and add missing test https://reviews.llvm.org/D33447 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLine

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

krasimir added inline comments. Comment at: unittests/clangd/ClangdTests.cpp:298 + const auto SourceContents = + R"cpp( +#include "foo.h" Move this to the previous line. Comment at: unittests/clangd/ClangdTests.cpp:336 + const auto Sourc

[PATCH] D33447: clang-format: add option to merge empty function body

djasper added a comment. Does anything speak against making this behavior happen with AllowShortFunctionsOnASingleLine = SFS_Empty and MergeEmptyOnly.BraceWrapping.AfterFunction = true? I mean without the extra style option? Comment at: unittests/Format/FormatTest.cpp:6067 +

[PATCH] D33447: clang-format: add option to merge empty function body

Typz added a comment. In https://reviews.llvm.org/D33447#763045, @djasper wrote: > Does anything speak against making this behavior happen with > AllowShortFunctionsOnASingleLine = SFS_Empty and > MergeEmptyOnly.BraceWrapping.AfterFunction = true? I mean without the extra > style option? Tha

[PATCH] D33447: clang-format: add option to merge empty function body

Typz updated this revision to Diff 100060. Typz added a comment. fix indent https://reviews.llvm.org/D33447 Files: include/clang/Format/Format.h lib/Format/Format.cpp lib/Format/UnwrappedLineFormatter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D33447: clang-format: add option to merge empty function body

djasper added a comment. As it currently stands, I am really not happy with the configuration space that this opens up. If we can't make the configuration of existing flags, what's the coding style encourages this behavior? https://reviews.llvm.org/D33447 ___

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! Comment at: lib/Format/ContinuationIndenter.cpp:196 + FormatStyle::BCIS_AfterColonAndComma) && + (State.Column + State.Line->Last->Tot

r303734 - Fix 'set but not used' [-Wunused-but-set-variable] warning

Author: rksimon Date: Wed May 24 05:38:09 2017 New Revision: 303734 URL: http://llvm.org/viewvc/llvm-project?rev=303734&view=rev Log: Fix 'set but not used' [-Wunused-but-set-variable] warning Modified: cfe/trunk/lib/Lex/LiteralSupport.cpp Modified: cfe/trunk/lib/Lex/LiteralSupport.cpp URL:

[PATCH] D33173: Modify test to look for patterns in stderr as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL303735: Modify test so that it looks for patterns in stderr as well (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D33173?vs=98928&id=100062#toc Repository: rL LLVM https

[clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

Author: sepavloff Date: Wed May 24 05:50:56 2017 New Revision: 303735 URL: http://llvm.org/viewvc/llvm-project?rev=303735&view=rev Log: Modify test so that it looks for patterns in stderr as well With the change https://reviews.llvm.org/D33013 driver will not build compilation object if command l

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

ilya-biryukov updated this revision to Diff 100065. ilya-biryukov added a comment. Minor refactoring to address @krasimir's comments https://reviews.llvm.org/D33416 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/ClangdUnit.cpp clangd/ClangdUnit.

[PATCH] D33489: [OpenCL] Added regression test on invalid vector initialization.

echuraev created this revision. Herald added a subscriber: yaxunl. This patch increases code coverage. https://reviews.llvm.org/D33489 Files: test/SemaOpenCL/vector_literals_invalid.cl Index: test/SemaOpenCL/vector_literals_invalid.cl

[libcxxabi] r303737 - __cxa_demangle: Fix constructor cv qualifier handling

Author: tberghammer Date: Wed May 24 06:21:34 2017 New Revision: 303737 URL: http://llvm.org/viewvc/llvm-project?rev=303737&view=rev Log: __cxa_demangle: Fix constructor cv qualifier handling Summary: Previously if we parsed a constructor then we set parsed_ctor_dtor_cv to true and never reseted

[PATCH] D33385: __cxa_demangle: Fix constructor cv qualifier handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL303737: __cxa_demangle: Fix constructor cv qualifier handling (authored by tberghammer). Changed prior to commit: https://reviews.llvm.org/D33385?vs=99694&id=100067#toc Repository: rL LLVM https://r

[PATCH] D33447: clang-format: add option to merge empty function body

Typz added a comment. Facebook's HHVM seems to use this for empty constructors: https://github.com/facebook/hhvm/blob/master/hphp/doc/coding-conventions.md This is also done systematically in Qt and QtCreator code. Personally, I don't care if this is an option or not; but I fear it would break

r303739 - clang-format: Introduce BreakConstructorInitializers option

Author: typz Date: Wed May 24 06:36:58 2017 New Revision: 303739 URL: http://llvm.org/viewvc/llvm-project?rev=303739&view=rev Log: clang-format: Introduce BreakConstructorInitializers option Summary: This option replaces the BreakConstructorInitializersBeforeComma option with an enum, thus intro

[PATCH] D32479: clang-format: Introduce BreakConstructorInitializers option

This revision was automatically updated to reflect the committed changes. Closed by commit rL303739: clang-format: Introduce BreakConstructorInitializers option (authored by Typz). Changed prior to commit: https://reviews.llvm.org/D32479?vs=99887&id=100068#toc Repository: rL LLVM https://re

[PATCH] D33447: clang-format: add option to merge empty function body

djasper added a comment. But that style specifically says that it is only done if the initializer list is wrapped: https://github.com/facebook/hhvm/blob/master/hphp/doc/coding-conventions.md#constructor-initializer-lists I.e. we would do the right thing for that style if we would set BraceWrapp

[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

djasper added a comment. clang-format already has logic to detect semicolon-less macro invocations an in fact this already does behave as I would expect. What are you fixing? https://reviews.llvm.org/D33440 ___ cfe-commits mailing list cfe-commits@

r303741 - Method loadFromCommandLine should be able to report errors

Author: sepavloff Date: Wed May 24 06:57:37 2017 New Revision: 303741 URL: http://llvm.org/viewvc/llvm-project?rev=303741&view=rev Log: Method loadFromCommandLine should be able to report errors Now FixedCompilationDatabase::loadFromCommandLine has no means to report which error occurred if it fa

[PATCH] D33272: Method loadFromCommandLine should be able to report errors

This revision was automatically updated to reflect the committed changes. Closed by commit rL303741: Method loadFromCommandLine should be able to report errors (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D33272?vs=99919&id=100069#toc Repository: rL LLVM https:

[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

Typz added a comment. Without this patch, macros with no trailing semicolon _in the body of a function_ are not handled properly, so I get: int foo(int a, int b) { Q_UNUSED(a) return b; } class Foo { void bar(int a, int b) { Q_UNUSED(a) Q_UNUSED(b) } } https://reviews.llvm.o

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek added inline comments. Comment at: docs/clang-tidy/checks/misc-default-numerics.rst:11 +Consider scenario: +1. Have `typedef long long BigInt` in source code +2. Use `std::numeric_limits::min()` Eugene.Zelenko wrote: > May be code-block will be better? Rig

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

Prazek updated this revision to Diff 100070. Prazek added a comment. - fixed docs https://reviews.llvm.org/D33470 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/DefaultNumericsCheck.cpp clang-tidy/misc/DefaultNumericsCheck.h clang-tidy/misc/MiscTidyModule.cpp docs/ReleaseNotes.

[PATCH] D33447: clang-format: add option to merge empty function body

Typz added a comment. I am fine with "removing" the options: I only fear it would incorrectly affect existing users/styles, which would possibly end up in the patch being reverted... I could not find the info in Mozilla coding style, but looking at the code it seems it should be done indeed, bu

r303742 - [clang-format] Remove unused using directive, NFC

Author: krasimir Date: Wed May 24 07:15:42 2017 New Revision: 303742 URL: http://llvm.org/viewvc/llvm-project?rev=303742&view=rev Log: [clang-format] Remove unused using directive, NFC Modified: cfe/trunk/unittests/Format/FormatTestObjC.cpp Modified: cfe/trunk/unittests/Format/FormatTestObjC

[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

djasper added a comment. I don't. Only if they start out to be on the same line. As long as I start with: class C { void foo(int a, int b) { Q_UNUSED(a) Q_UNUSED(a) return b; } }; clang-format leaves this alone. That's good enough I think and we don't want to add m

[PATCH] D33447: clang-format: add option to merge empty function body

djasper added a comment. No, I don't think it should be done this way and neither Facebook nor Mozilla coding styles say you should. Mozilla style has an explicit example: int TinyFunction() { return mVar; } Facebook style has an explicit example: MyClass::MyClass(uint64_t idx) : m_idx(id

[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

Typz added a comment. Digging back, it seem the issue was that I had this code: void foo(..) { Q_UNUSED(a) Q_UNUSED(b) } which got wrapped because the line was too long: void foo(..) { Q_UNUSED(a) Q_UNUSED(b) } I definitely understand your concern about introduceing special h

[PATCH] D33416: [clangd] Allow to use vfs::FileSystem for file accesses.

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Looks good. Make sure to watch the windows buildbots after submitting. https://reviews.llvm.org/D33416 ___ cfe-commits mailing list cfe-commits

[PATCH] D33328: [CodeGen] Pessimize aliasing for union members (and may-alias) objects

kparzysz added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1436 +if (BaseInfo.getMayAlias()) + TBAAInfo = CGM.getTBAAInfo(getContext().CharTy); llvm::MDNode *TBAAPath = CGM.getTBAAStructTagInfo(TBAABaseType, TBAAInfo, rjmccall wrote: > kparz

[PATCH] D33440: clang-format: properly handle Q_UNUSED and QT_REQUIRE_VERSION

djasper added a comment. I generally would not be opposed to such a patch. However, note that this might be hard to get right. We had significant performance problems in the past with ForEachMacros as we used to match every single identifier against the regex stored in there. For for loops you

[PATCH] D33447: clang-format: add option to merge empty function body

Typz added a comment. Right, I was not clear enough: this is indeed done only if everything does not fit on one line. There is an exemple in facebook's coding style: MyClass::MyClass(const Class* cls, const Func* func, const Class* ctx) : m_cls(cls) , m_func(func) , m_ctx(ctx)

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan created this revision. On Windows loading preamble and caching global completion takes a while. This is the way to improve it. Please comment if I misuse something. https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/A

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

yvvan updated this revision to Diff 100075. yvvan added a comment. fix member variable name, add comments https://reviews.llvm.org/D33493 Files: include/clang/Frontend/ASTUnit.h lib/Frontend/ASTUnit.cpp Index: lib/Frontend/ASTUnit.cpp ==

[PATCH] D33447: clang-format: add option to merge empty function body

Typz added a comment. Merging empty blocks is not allowed in webkit style: https://webkit.org/code-style-guidelines/#punctuation-member-init So it seems changing the behavior would actually fix mozilla style and break webkit style (as integrated in clang-format). https://reviews.llvm.org/D334

[PATCH] D33493: Speed up preamble loading, reduce global completion cache calls

arphaman added a comment. Please post the patch with full context `git diff -U`. https://reviews.llvm.org/D33493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r303748 - [coroutines] [NFC] Add tests for return_void, unhandled_exception and promise dtor

Author: gornishanov Date: Wed May 24 09:19:48 2017 New Revision: 303748 URL: http://llvm.org/viewvc/llvm-project?rev=303748&view=rev Log: [coroutines] [NFC] Add tests for return_void, unhandled_exception and promise dtor Summary: * Test that coroutine promise destructor is called. * Test that we

[PATCH] D33479: [coroutines] [NFC] Add tests for return_void, unhandled_exception and promise dtor

This revision was automatically updated to reflect the committed changes. Closed by commit rL303748: [coroutines] [NFC] Add tests for return_void, unhandled_exception and promise… (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D33479?vs=100034&id=100084#toc Reposi

r303751 - [index] The references to explicit class properties should be recorded

Author: arphaman Date: Wed May 24 09:23:40 2017 New Revision: 303751 URL: http://llvm.org/viewvc/llvm-project?rev=303751&view=rev Log: [index] The references to explicit class properties should be recorded rdar://32376363 Modified: cfe/trunk/lib/Index/IndexBody.cpp cfe/trunk/test/Index/C

r303752 - [coroutines] Improved diagnostics when unhandled_exception is missing in the promise_type

Author: gornishanov Date: Wed May 24 09:34:19 2017 New Revision: 303752 URL: http://llvm.org/viewvc/llvm-project?rev=303752&view=rev Log: [coroutines] Improved diagnostics when unhandled_exception is missing in the promise_type Summary: Now we helpfully provide a note pointing at the promise_typ

[PATCH] D33481: [coroutines] Improved diagnostics when unhandled_exception is missing in the promise_type

This revision was automatically updated to reflect the committed changes. Closed by commit rL303752: [coroutines] Improved diagnostics when unhandled_exception is missing in the… (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D33481?vs=100037&id=100086#toc Reposit

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

brycel created this revision. Herald added a subscriber: mgorny. Add a clang-tidy check for using __func__/__FUNCTION__ inside lambdas. This evaluates to the string `operator()`, which is almost never useful and almost certainly not what the author intended. https://reviews.llvm.org/D33497 Fi

r303753 - Generalize two diagnostic messages to take function name as parameter.

Author: jtony Date: Wed May 24 09:45:57 2017 New Revision: 303753 URL: http://llvm.org/viewvc/llvm-project?rev=303753&view=rev Log: Generalize two diagnostic messages to take function name as parameter. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/Sema

r303756 - Driver must return non-zero code on errors in command line

Author: sepavloff Date: Wed May 24 09:57:17 2017 New Revision: 303756 URL: http://llvm.org/viewvc/llvm-project?rev=303756&view=rev Log: Driver must return non-zero code on errors in command line This is recommit of r302775, reverted in r302777 due to a fail in clang-tidy. Original mesage is below

[PATCH] D33013: Driver must return non-zero code on errors in command line

This revision was automatically updated to reflect the committed changes. Closed by commit rL303756: Driver must return non-zero code on errors in command line (authored by sepavloff). Changed prior to commit: https://reviews.llvm.org/D33013?vs=99273&id=100090#toc Repository: rL LLVM https:

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

dtemirbulatov updated this revision to Diff 100089. dtemirbulatov added a comment. add _mm256_cmp_pd double version add comments in lib/CodeGen/CGBuiltin.cpp replaced 0xf to _CMP_TRUE_UQ in avx-builtins.c https://reviews.llvm.org/D33406 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx-buil

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

dtemirbulatov added a comment. > Should we handle the 'pd256' version the same way? > How about the 0xb ('false') constant? It should produce a zero here? > Can or should we deal with the signalling versions (0x1b, 0x1f) too? hm looks like 0xb(_CMP_FALSE_OQ) is ordered, so it is not possible and

r303760 - [PowerPC] Implement vec_xxpermdi builtin.

Author: jtony Date: Wed May 24 10:13:32 2017 New Revision: 303760 URL: http://llvm.org/viewvc/llvm-project?rev=303760&view=rev Log: [PowerPC] Implement vec_xxpermdi builtin. The vec_xxpermdi builtin is missing from altivec.h. This has been requested by developers working on libvpx for VP9 support

[PATCH] D33053: [PowerPC] Implement vec_xxpermdi builtin.

This revision was automatically updated to reflect the committed changes. jtony marked 2 inline comments as done. Closed by commit rL303760: [PowerPC] Implement vec_xxpermdi builtin. (authored by jtony). Changed prior to commit: https://reviews.llvm.org/D33053?vs=99966&id=100093#toc Repository

r303761 - Warn about uses of `@available` that can't suppress the

Author: arphaman Date: Wed May 24 10:15:29 2017 New Revision: 303761 URL: http://llvm.org/viewvc/llvm-project?rev=303761&view=rev Log: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings rdar://32306520 Differential Revision: https://reviews.llvm.org/D33450

[PATCH] D33450: Warn about uses of `@available` that can't suppress the -Wunguarded-availability warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rL303761: Warn about uses of `@available` that can't suppress the (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D33450?vs=99948&id=100094#toc Repository: rL LLVM https://re

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

lebedev.ri added a comment. 1. What about `__PRETTY_FUNCTION__` ? 2. Consider following generic error handling macro: (ThrowException is some template function) #undef STR #define STR(a) XSTR(a) #define ThrowExceptionHelper(CLASS, fmt, ...) ThrowException(__FILE__ ":" STR(__LINE__) ":

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

Typz updated this revision to Diff 100095. Typz added a comment. add new value to AlignOperands to support this mode. fix some corner cases. https://reviews.llvm.org/D32478 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndenter.h lib/For

[PATCH] D33498: [coroutines] Make generic lambda coroutines work

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D33498: [coroutines] Make generic lambda coroutines work

GorNishanov created this revision. Herald added a subscriber: EricWF. 1. Coroutine cannot be constexpr (added a check in SemaLambda.cpp not to mark coroutine as constexpr) 2. TransformCoroutineBodyStmt should transform ResultDecl and ReturnStmt https://reviews.llvm.org/D33498 Files: lib/Sema

[PATCH] D33499: [PPC] First approximation of PPC32/Darwin ABI info

kparzysz created this revision. Use the default implementation of EmitVAArg instead of the SVR4 one. This is meant to address PR33108. This is really just a scaffold. I don't know what exactly needs to be implemented for Darwin. The motivating testcase: void foo() { __builtin_va_list

r303764 - [coroutines] Make generic lambda coroutines work

Author: gornishanov Date: Wed May 24 10:44:57 2017 New Revision: 303764 URL: http://llvm.org/viewvc/llvm-project?rev=303764&view=rev Log: [coroutines] Make generic lambda coroutines work Summary: 1. Coroutine cannot be constexpr (added a check in SemaLambda.cpp not to mark coroutine as constexpr

[PATCH] D33498: [coroutines] Make generic lambda coroutines work

This revision was automatically updated to reflect the committed changes. Closed by commit rL303764: [coroutines] Make generic lambda coroutines work (authored by GorNishanov). Changed prior to commit: https://reviews.llvm.org/D33498?vs=100097&id=100102#toc Repository: rL LLVM https://revie

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

brycel added a comment. In https://reviews.llvm.org/D33497#763307, @lebedev.ri wrote: > 1. What about `__PRETTY_FUNCTION__` ? `__PRETTY_FUNCTION__` is a little more useful, it at least tells you which function the lambda is defined in: #include int main() { auto f = [] { pri

[PATCH] D33499: [PPC] First approximation of PPC32/Darwin ABI info

kparzysz updated this revision to Diff 100105. kparzysz added a comment. Add implementation of EmitVAArg and explicitly call emitVoidPtrVAArg in it. Repository: rL LLVM https://reviews.llvm.org/D33499 Files: lib/CodeGen/TargetInfo.cpp Index: lib/CodeGen/TargetInfo.cpp ===

r303766 - [PowerPC] Implement vec_xxsldwi builtin.

Author: jtony Date: Wed May 24 10:54:13 2017 New Revision: 303766 URL: http://llvm.org/viewvc/llvm-project?rev=303766&view=rev Log: [PowerPC] Implement vec_xxsldwi builtin. The vec_xxsldwi builtin is missing from altivec.h. This has been requested by developers working on libvpx for VP9 support f

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

lebedev.ri added a comment. In https://reviews.llvm.org/D33497#763376, @brycel wrote: > In https://reviews.llvm.org/D33497#763307, @lebedev.ri wrote: > > > 1. What about `__PRETTY_FUNCTION__` ? > > > I think `__PRETTY_FUNCTION__` inside a lambda is useful enough not to warn > about. Then that

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits wrote: > Author: akirtzidis > Date: Tue May 23 19:46:27 2017 > New Revision: 303712 > > URL: http://llvm.org/viewvc/llvm-project?rev=303712&view=rev > Log: > Enhance the 'diagnose_if' attribute so that we can apply it for ObjC met

[PATCH] D33448: [CodeGen] Add thumb-mode to function target-features for arm/thumb triples.

fhahn added a comment. In https://reviews.llvm.org/D33448#762410, @echristo wrote: > I probably would have added this as a feature in ARMTargetInfo similar to > CRC/soft-float/etc. > > Thoughts? Do you mean ARMTargetMachine::getSubtargetImpl (https://github.com/llvm-mirror/llvm/blob/master/li

r303768 - [OPENMP] Allow value of thread local variables in target regions.

Author: abataev Date: Wed May 24 11:00:02 2017 New Revision: 303768 URL: http://llvm.org/viewvc/llvm-project?rev=303768&view=rev Log: [OPENMP] Allow value of thread local variables in target regions. If the variable is marked as TLS variable and target device does not support TLS, the error is em

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

CaseyCarter added a comment. In https://reviews.llvm.org/D32671#762840, @mpark wrote: > @CaseyCarter: Do these changes pass with the current version? > Also, have you seen the tests in > `test/libcxx/utilities/variant/variant.variant`? > If yes, do those tests and the ones in this diff overlap

[PATCH] D33356: [Nios2] Changes in frontend to support Nios2 LLVM target

belickim updated this revision to Diff 100111. belickim added a comment. I implemented changes suggested by Joerg. In previous version there was also an additional macro with CPU name that I removed. It was not documented anywhere and is not even used by GCC. So there seems to be no prior usage

[PATCH] D30946: [ScopePrinting] Added support to print full scopes of types and declarations.

schroedersi added a comment. Ping :) https://reviews.llvm.org/D30946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

spatel added subscribers: scanon, andrew.w.kaylor. spatel added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:7932 break; case X86::BI__builtin_ia32_cmppd256: ID = Intrinsic::x86_avx_cmp_pd_256; dtemirbulatov wrote: > spatel wrote: > >

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: > > On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits > wrote: >> Author: akirtzidis >> Date: Tue May 23 19:46:27 2017 >> New Revision: 303712 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=303712&view=rev >> Log: >> Enh

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis wrote: > >> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: >> >> On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits >> wrote: >>> Author: akirtzidis >>> Date: Tue May 23 19:46:27 2017 >>> New Revision: 303712 >>> >>> URL: ht

[PATCH] D33497: clang-tidy check for __func__/__FUNCTION__ in lambdas

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). https://reviews.llvm.org/D33497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D33470: [clang-tidy] Add misc-default-numerics

aaron.ballman added inline comments. Comment at: clang-tidy/misc/DefaultNumericsCheck.cpp:37 +void DefaultNumericsCheck::check(const MatchFinder::MatchResult &Result) { + + const auto *MatchedDecl = Result.Nodes.getNodeAs("call"); Can remove the spurious newline

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

> On May 24, 2017, at 10:12 AM, Aaron Ballman wrote: > > On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis > wrote: >> >>> On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: >>> >>> On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via cfe-commits >>> wrote: >>>

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

jroelofs updated this revision to Diff 100131. jroelofs added a comment. implement feedback https://reviews.llvm.org/D33259 Files: cmake/caches/BaremetalARM.cmake lib/Driver/CMakeLists.txt lib/Driver/Driver.cpp lib/Driver/ToolChains/BareMetal.cpp lib/Driver/ToolChains/BareMetal.h li

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

mpark added a comment. Yes, you're right that fine-grained SMF triviality is implemented but LWG 2904 is not yet. I would love it if you can integrate the currently `libcxx` tests into `std` tests! Thank you :) https://reviews.llvm.org/D32671 ___

[PATCH] D33259: Don't defer to the GCC driver for linking arm-baremetal

jroelofs marked 2 inline comments as done. jroelofs added inline comments. Comment at: lib/Driver/ToolChains/BareMetal.cpp:110 + SmallString<128> Dir(SysRoot); + llvm::sys::path::append(Dir, "include", "c++", "v1"); + return Dir.str(); compnerd wrote: > Is thi

[PATCH] D33448: [CodeGen] Add thumb-mode to function target-features for arm/thumb triples.

echristo added a comment. In https://reviews.llvm.org/D33448#763411, @fhahn wrote: > In https://reviews.llvm.org/D33448#762410, @echristo wrote: > > > I probably would have added this as a feature in ARMTargetInfo similar to > > CRC/soft-float/etc. > > > > Thoughts? > > > Do you mean ARMTargetMa

[PATCH] D33507: [coroutines] Add support for coroutines with non-scalar parameters

GorNishanov created this revision. Simple types like int are handled by LLVM Coroutines just fine. But for non-scalar parameters we need to create copies of those parameters in the coroutine frame and make all uses of those parameters to refer to parameter copies. https://reviews.llvm.org/D335

Re: r303712 - Enhance the 'diagnose_if' attribute so that we can apply it for ObjC methods and properties as well

On Wed, May 24, 2017 at 1:37 PM, Argyrios Kyrtzidis wrote: > > On May 24, 2017, at 10:12 AM, Aaron Ballman wrote: > > On Wed, May 24, 2017 at 1:05 PM, Argyrios Kyrtzidis > wrote: > > > On May 24, 2017, at 8:59 AM, Aaron Ballman wrote: > > On Tue, May 23, 2017 at 8:46 PM, Argyrios Kyrtzidis via

Re: r303630 - Allow to use vfs::FileSystem for file accesses inside ASTUnit.

On Wed, May 24, 2017 at 12:18 AM, Ilya Biryukov wrote: > We test it in clangd (https://reviews.llvm.org/D33416). > Logically, it's a single change, split into two part: for cfe and > clang-tools-extra. I see, thanks! > > On Wed, May 24, 2017 at 1:48 AM, Bruno Cardoso Lopes > wrote: >> >> Any s

r303786 - Fix one test case faiulre in commit 303766.

Author: jtony Date: Wed May 24 13:12:11 2017 New Revision: 303786 URL: http://llvm.org/viewvc/llvm-project?rev=303786&view=rev Log: Fix one test case faiulre in commit 303766. It is clean when I build boostrap and run make checkall on my machine, I guess it could be I only build bootstrap with as

[PATCH] D33328: [CodeGen] Pessimize aliasing for union members (and may-alias) objects

rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1436 +if (BaseInfo.getMayAlias()) + TBAAInfo = CGM.getTBAAInfo(getContext().CharTy); llvm::MDNode *TBAAPath = CGM.getTBAAStructTagInfo(TBAABaseType, TBAAInfo, kparzysz wrote: > rjmcc

r303789 - Address follow-up feedback for r303712

Author: akirtzidis Date: Wed May 24 13:35:01 2017 New Revision: 303789 URL: http://llvm.org/viewvc/llvm-project?rev=303789&view=rev Log: Address follow-up feedback for r303712 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaDeclAttr.cpp cfe/trunk/

[PATCH] D33304: [WIP][clang-tidy] Add a new module Android and a new check for file descriptors.

Eugene.Zelenko added a comment. It's also necessary to mention new checks group in docs/clang-tidy/index.rst. Repository: rL LLVM https://reviews.llvm.org/D33304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

Anastasia added inline comments. Comment at: lib/Sema/SemaDecl.cpp:12449 // function declaration is going to be treated as an error. - if (Diags.getDiagnosticLevel(diag_id, Loc) >= DiagnosticsEngine::Error) { + if (!getLangOpts().OpenCL && + Diags.getDiagnosticLevel(dia

[PATCH] D33328: [CodeGen] Pessimize aliasing for union members (and may-alias) objects

kparzysz updated this revision to Diff 100142. kparzysz added a comment. Pass char TBAA directly to DecorateInstructionWithTBAA and pass true for ConvertTypeToTag in such cases. Repository: rL LLVM https://reviews.llvm.org/D33328 Files: lib/CodeGen/CGExpr.cpp test/CodeGen/union-tbaa1.c

[PATCH] D33353: [OpenCL] An error shall occur if any scalar operand has greater rank than the type of the vector element

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8307 "variable length arrays are not supported in OpenCL">; +def err_scalar_type_rank_greater_than_vector_type : Error< +"scalar operand type has greater rank than the type of the vecto

[PATCH] D33483: [OpenCL] reserve_id_t cannot be used as argument to kernel function

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Btw the same applies to the program scope declaration (s6.9.p), but could be done as a separate change. https://reviews.llvm.org/D33483

[PATCH] D33489: [OpenCL] Added regression test on invalid vector initialization.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D33489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

r303798 - For Microsoft compatibility, set fno_operator_names

Author: erichkeane Date: Wed May 24 14:31:19 2017 New Revision: 303798 URL: http://llvm.org/viewvc/llvm-project?rev=303798&view=rev Log: For Microsoft compatibility, set fno_operator_names There's a Microsoft header in the Windows SDK which won't compile with clang because it uses an operator na

Re: r303798 - For Microsoft compatibility, set fno_operator_names

Was this reviewed somewhere? Please make it so that this emits a warning. We want clang-cl to warn on invalid code (and in system headers warnings are suppressed). On Wed, May 24, 2017 at 3:31 PM, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Wed M

Re: r303798 - For Microsoft compatibility, set fno_operator_names

Reviewed here: https://reviews.llvm.org/D33505 Still, please make this warn. On Wed, May 24, 2017 at 3:42 PM, Nico Weber wrote: > Was this reviewed somewhere? > > Please make it so that this emits a warning. We want clang-cl to warn on > invalid code (and in system headers warnings are suppress

RE: r303798 - For Microsoft compatibility, set fno_operator_names

Adding Melanie, the author of the patch. From: tha...@google.com [mailto:tha...@google.com] On Behalf Of Nico Weber Sent: Wednesday, May 24, 2017 12:43 PM To: Keane, Erich Cc: cfe-commits ; rnk Subject: Re: r303798 - For Microsoft compatibility, set fno_operator_names Reviewed here: https://rev

[PATCH] D33497: [clang-tidy] check for __func__/__FUNCTION__ in lambdas

brycel updated this revision to Diff 100149. brycel added a comment. Herald added a subscriber: xazax.hun. Addressed the following review comments: - Added a test to make sure we don't warn on __PRETTY_FUNCTION__ - Suppressed warnings when in a macro that also uses __FILE__ and __LINE__ - Updated

RE: r303798 - For Microsoft compatibility, set fno_operator_names

Thanks for the feedback, working on it… From: Keane, Erich Sent: Wednesday, May 24, 2017 3:47 PM To: Nico Weber ; Blower, Melanie Cc: cfe-commits ; rnk Subject: RE: r303798 - For Microsoft compatibility, set fno_operator_names Adding Melanie, the author of the patch. From: tha...@google.com

[PATCH] D33507: [coroutines] Add support for coroutines with non-scalar parameters

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D33507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

  1   2   >