On Mon, May 22, 2017 at 12:00 PM, Simon Atanasyan wrote:
> On Mon, May 22, 2017 at 3:57 PM, Aaron Ballman wrote:
>> On Mon, May 22, 2017 at 8:47 AM, Simon Atanasyan via cfe-commits
>> wrote:
>>> Author: atanasyan
>>> Date: Mon May 22 07:47:43 2017
>>> New Revision: 303546
>>>
>>> URL: http://llv
aaron.ballman added a comment.
In https://reviews.llvm.org/D3#761126, @jyu2 wrote:
> In https://reviews.llvm.org/D3#760431, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D3#760419, @jyu2 wrote:
> >
> > > In https://reviews.llvm.org/D3#760149, @aaron.ballman wrote:
> > >
rnk added a comment.
Re: clang-tidy, I would rather implement this as a traditional compiler warning.
In https://reviews.llvm.org/D3#761208, @aaron.ballman wrote:
> In https://reviews.llvm.org/D3#761126, @jyu2 wrote:
>
> > As I said, I don't think checking throw type matching catch handl
faisalv updated this revision to Diff 99787.
faisalv added a comment.
Incorporated Aaron's feedback - thanks Aaron!
https://reviews.llvm.org/D31414
Files:
include/clang/Basic/TemplateKinds.h
include/clang/Sema/ParsedTemplate.h
lib/Parse/ParseExprCXX.cpp
lib/Parse/ParseTemplate.cpp
Inde
faisalv marked 2 inline comments as done.
faisalv added a comment.
mark aaron's feedback as done.
https://reviews.llvm.org/D31414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D3#761224, @rnk wrote:
> Re: clang-tidy, I would rather implement this as a traditional compiler
> warning.
>
> In https://reviews.llvm.org/D3#761208, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D3#761126, @jyu2 w
jyu2 added a comment.
In https://reviews.llvm.org/D3#761233, @aaron.ballman wrote:
> In https://reviews.llvm.org/D3#761224, @rnk wrote:
>
> > Re: clang-tidy, I would rather implement this as a traditional compiler
> > warning.
> >
> > In https://reviews.llvm.org/D3#761208, @aaron.bal
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D31414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:338
+ // In a coroutine, only co_return statements count as normal returns.
Remember
+ // if we are processing the coro
sepavloff marked an inline comment as done.
sepavloff added inline comments.
Comment at: lib/AST/DeclTemplate.cpp:292-311
+FunctionTemplateDecl *FunctionTemplateDecl::getDefinition() const {
+ for (auto *R : redecls()) {
+FunctionTemplateDecl *F = cast(R);
+if (F->isThis
sepavloff updated this revision to Diff 99789.
sepavloff edited the summary of this revision.
sepavloff added a comment.
Updated patch
https://reviews.llvm.org/D21508
Files:
include/clang/AST/DeclTemplate.h
lib/AST/Decl.cpp
lib/AST/DeclTemplate.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaT
rsmith added inline comments.
Comment at: lib/CodeGen/CGCoroutine.cpp:273
+
+// FIXME: There must be a cleaner way to do this!
+if (auto *Cleanup =
dyn_cast_or_null(&*CGF.EHStack.begin())) {
It doesn't seem safe to assume that a prior `EHCleanupScope` wo
rsmith added inline comments.
Comment at: include/clang/AST/StmtCXX.h:128
+struct CXXTryStmt::OnStack : CXXTryStmt {
+ alignas(CXXTryStmt) Stmt *Stmts[2];
+ OnStack(SourceLocation tryLoc, Stmt *tryBlock, Stmt *handler)
This makes more assumptions about record l
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D31608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
NoQ added a comment.
Thanks, this is great! Two more things:
- You have touched other code, unrelated to your patch, with clang-format;
we're usually trying to avoid that, because it creates merge conflicts out of
nowhere, and because some of that code actually seems formatted by hand
intentio
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Does it still make sense for us to have a `UO_Coawait` at all? As I recall, the
only purpose it ever had was to represent a dependent `co_await` expression
that couldn't yet be resolved to a `
GorNishanov updated this revision to Diff 99796.
GorNishanov added a comment.
Thank you very much for the review!
Merged with top of the trunk, implemented suggested changes, preparing to land
https://reviews.llvm.org/D31646
Files:
include/clang/AST/StmtCXX.h
include/clang/Basic/Diagnostic
GorNishanov added a comment.
In https://reviews.llvm.org/D31627#761320, @rsmith wrote:
> Does it still make sense for us to have a `UO_Coawait` at all? As I recall,
> the only purpose it ever had was to represent a dependent `co_await`
> expression that couldn't yet be resolved to a `CoawaitExp
Author: gornishanov
Date: Mon May 22 15:22:23 2017
New Revision: 303573
URL: http://llvm.org/viewvc/llvm-project?rev=303573&view=rev
Log:
[coroutines] Build GRO declaration and return GRO statement
Summary:
1. build declaration of the gro local variable that keeps the result of
get_return_object
This revision was automatically updated to reflect the committed changes.
GorNishanov marked an inline comment as done.
Closed by commit rL303573: [coroutines] Build GRO declaration and return GRO
statement (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D31646?vs=9
rsmith added a comment.
Do we really need two different notions of "definition" and "odr definition"
here? What goes wrong if we always treat the "instantiation of a friend
function definition" case as being a definition?
Comment at: include/clang/AST/Decl.h:1789
+ // fu
jroelofs added inline comments.
Comment at: cmake/caches/BaremetalARM.cmake:1
+set(LLVM_TARGETS_TO_BUILD ARM CACHE STRING "")
+
compnerd wrote:
> jroelofs wrote:
> > compnerd wrote:
> > > Please rename this file to `BareMetalARMv6.cmake`. (I'm interested in
> >
jyu2 updated this revision to Diff 99802.
jyu2 added a comment.
This is new version should address all @Aaron's commands, but CFG part.
I would not think we should go that far in the compiler for this.
Thanks.
https://reviews.llvm.org/D3
Files:
include/clang/Basic/DiagnosticSemaKinds.td
ruiu added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.h:42
+
+ const char *getDefaultLinker() const override { return "ld.lld"; }
+
jroelofs wrote:
> compnerd wrote:
> > jroelofs wrote:
> > > compnerd wrote:
> > > > I think that this really sho
bruno added a comment.
Any idea why we're hitting this issue in the first place? The error that gets
cleaned up is reported at some point before? Seems to me that we're going to
fail to update the timestamp but continue as nothing happened, I wonder how
many other issues this might trigger...
GorNishanov updated this revision to Diff 99814.
GorNishanov added a comment.
1. Heap allocate CxxTryStmt in CGCoroutine.
2. Merge with trunk
https://reviews.llvm.org/D31692
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGCoroutine.cpp
lib/Sema/SemaCoroutine.cpp
test/Cod
GorNishanov updated this revision to Diff 99815.
GorNishanov added a comment.
Fix misspelling in a comment.
@rsmith, Looks good now?
https://reviews.llvm.org/D31692
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGCoroutine.cpp
lib/Sema/SemaCoroutine.cpp
test/CodeGenCorou
Author: rnk
Date: Mon May 22 16:42:58 2017
New Revision: 303582
URL: http://llvm.org/viewvc/llvm-project?rev=303582&view=rev
Log:
Give files from #line the characteristics of the current file
This allows #line directives to appear in system headers that have code
that clang would normally warn on
rsmith added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:2329-2333
+ // __unaligned is not currently mangled in any way. This implies that it is
+ // not a relevant qualifier for substitutions (while CVR and maybe others
+ // are). This triggers an assertion when th
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D31692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
On 22 May 2017 at 14:42, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rnk
> Date: Mon May 22 16:42:58 2017
> New Revision: 303582
>
> URL: http://llvm.org/viewvc/llvm-project?rev=303582&view=rev
> Log:
> Give files from #line the characteristics of the current file
On Mon, May 22, 2017 at 3:17 PM, Richard Smith
wrote:
>// If the StrTok is "eod", then it wasn't present. Otherwise, it must
>> be a
>>// string followed by eod.
>> - if (StrTok.is(tok::eod))
>> -; // ok
>> - else if (StrTok.isNot(tok::string_literal)) {
>> + if (StrTok.is(tok::eo
t.p.northover created this revision.
Herald added a subscriber: mcrosier.
While looking into the regression tests' compatibility with C++14, many of the
failures were because that specification defined UDLs for imaginary constants,
specifically ones ending in 'i' and 'il'. This conflicted with t
Author: gornishanov
Date: Mon May 22 17:33:17 2017
New Revision: 303583
URL: http://llvm.org/viewvc/llvm-project?rev=303583&view=rev
Log:
[coroutines] Wrap the body of the coroutine in try-catch
Summary:
If unhandled_exception member function is present in the coroutine promise,
wrap the body of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303583: [coroutines] Wrap the body of the coroutine in
try-catch (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D31692?vs=99815&id=99827#toc
Repository:
rL LLVM
https:/
Author: gornishanov
Date: Mon May 22 17:41:28 2017
New Revision: 303584
URL: http://llvm.org/viewvc/llvm-project?rev=303584&view=rev
Log:
[coroutines] Fix coro-eh-cleanup.cpp test
Modified:
cfe/trunk/test/CodeGenCoroutines/coro-eh-cleanup.cpp
Modified: cfe/trunk/test/CodeGenCoroutines/coro-e
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D30837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 22 May 2017 at 15:22, Reid Kleckner via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, May 22, 2017 at 3:17 PM, Richard Smith
> wrote:
>
>>// If the StrTok is "eod", then it wasn't present. Otherwise, it must
>>> be a
>>>// string followed by eod.
>>> - if (StrTok.is(tok:
Author: rsmith
Date: Mon May 22 18:51:40 2017
New Revision: 303589
URL: http://llvm.org/viewvc/llvm-project?rev=303589&view=rev
Log:
Add option to include multiple lines in snippets.
When a diagnostic includes a highlighted range spanning multiple lines, clang
now supports printing out multiple l
rsmith added a comment.
Counterproposal: in `-std=*++14` onwards, treat this construct as a
user-defined literal, but fall back on the built-in interpretation if name
lookup doesn't find an `operator""i` function. (The two interpretations only
conflict if the source code explicitly does somethi
Author: tejohnson
Date: Mon May 22 19:35:09 2017
New Revision: 303593
URL: http://llvm.org/viewvc/llvm-project?rev=303593&view=rev
Log:
Adjust clang test for r303590
Forgot to commit this separately from the llvm change to use a new
module flag type for pic and pie levels. Should fix the bot erro
GorNishanov updated this revision to Diff 99837.
GorNishanov added a comment.
Remember old_top before emitting the cleanup and walk set Active on all emitted
cleanups.
I tried to add Active flag to Emission, but it ended up being very hairy, so I
went with the first option suggested.
https://r
GorNishanov marked an inline comment as done.
GorNishanov added a comment.
@rsmith, better now? :)
https://reviews.llvm.org/D31670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: faisalv
Date: Mon May 22 20:07:12 2017
New Revision: 303594
URL: http://llvm.org/viewvc/llvm-project?rev=303594&view=rev
Log:
[NFC, Refactor] Modernize TemplateIdAnnotation using TrailingObjects
A refactoring of TemplateIdAnnotation that uses TrailingObjects to create a
variably-sized ob
faisalv closed this revision.
faisalv added a comment.
Committed as https://reviews.llvm.org/rL303594
https://reviews.llvm.org/D31414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gornishanov
Date: Mon May 22 20:13:17 2017
New Revision: 303596
URL: http://llvm.org/viewvc/llvm-project?rev=303596&view=rev
Log:
[coroutines] Add support for allocation elision
Summary:
We wrap allocation code so that backend can elide it if necessary.
llvm.coro.alloc intrinsic returns t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL303596: [coroutines] Add support for allocation elision
(authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D31584?vs=93805&id=99838#toc
Repository:
rL LLVM
https://reviews.
chh created this revision.
Herald added a subscriber: xazax.hun.
Check BaseType before dereference.
Simplified test case is derived from Android Open Source code.
https://reviews.llvm.org/D33430
Files:
clang-tidy/misc/ForwardingReferenceOverloadCheck.cpp
test/clang-tidy/misc-forwarding-refe
GorNishanov updated this revision to Diff 99843.
GorNishanov added a comment.
merged with top of the trunk. preparing to land
https://reviews.llvm.org/D31586
Files:
lib/CodeGen/CGCoroutine.cpp
test/CodeGenCoroutines/coro-alloc.cpp
test/CodeGenCoroutines/coro-await.cpp
test/CodeGenCorout
Author: gornishanov
Date: Mon May 22 22:46:59 2017
New Revision: 303598
URL: http://llvm.org/viewvc/llvm-project?rev=303598&view=rev
Log:
[coroutines] Replace all coro.frame builtins with an SSA value of coro.begin
SemaCoroutine forms expressions referring to the coroutine frame of the
enclosing
GorNishanov accepted this revision.
GorNishanov added a comment.
This revision is now accepted and ready to land.
Committed: r303598 = cd8cc3ea48a887f846b3cbfc6dcb546a7b4de3af
https://reviews.llvm.org/D31586
___
cfe-commits mailing list
cfe-commits@
compnerd added inline comments.
Comment at: lib/Driver/ToolChains/BareMetal.cpp:68
+ SmallString<128> Dir(getDriver().ResourceDir);
+ llvm::sys::path::append(Dir, "lib", "baremetal");
+ return Dir.str();
jroelofs wrote:
> compnerd wrote:
> > jroelofs wrote:
>
compnerd added inline comments.
Comment at: src/cxa_demangle.cpp:3036
break;
-if (db.names.size() < 2)
+if (k1 <= k0)
return first;
erik.pilkington wrote:
> compnerd wrote:
GorNishanov accepted this revision.
GorNishanov added a comment.
LGTM
https://reviews.llvm.org/D31590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gornishanov
Date: Mon May 22 23:21:27 2017
New Revision: 303599
URL: http://llvm.org/viewvc/llvm-project?rev=303599&view=rev
Log:
[coroutines] Add support for deallocation elision
Wrap deallocation code with:
if (auto *mem = coro.free()) Deallocate
When backend decides to elide alloca
GorNishanov added a comment.
Commited: r303599 = abbd4f85db96b0ed1478e2ee52e9f1eec7404131
https://reviews.llvm.org/D31590
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: gornishanov
Date: Tue May 23 00:04:01 2017
New Revision: 303603
URL: http://llvm.org/viewvc/llvm-project?rev=303603&view=rev
Log:
[coroutines] Add emission of initial and final suspends
https://reviews.llvm.org/D31608
Modified:
cfe/trunk/lib/CodeGen/CGCoroutine.cpp
cfe/trunk/test
GorNishanov closed this revision.
GorNishanov added a comment.
r303603 = 12cdab350043e7ff931af5f13d3e3afe85b76628
https://reviews.llvm.org/D31608
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: gkistanova
Date: Tue May 23 00:17:49 2017
New Revision: 303604
URL: http://llvm.org/viewvc/llvm-project?rev=303604&view=rev
Log:
Added LLVM_FALLTHROUGH to address gcc warning: this statement may fall through.
Modified:
cfe/trunk/lib/Driver/ToolChains/Myriad.cpp
Modified: cfe/trunk/li
Author: gornishanov
Date: Tue May 23 00:25:31 2017
New Revision: 303605
URL: http://llvm.org/viewvc/llvm-project?rev=303605&view=rev
Log:
[coroutines] Skip over passthrough operator co_await
https://reviews.llvm.org/D31627
Modified:
cfe/trunk/lib/CodeGen/CGCoroutine.cpp
cfe/trunk/test/Co
GorNishanov closed this revision.
GorNishanov added a comment.
r303605 = b026b234d55d6b9fab849389b2085204f530af5d
https://reviews.llvm.org/D31627
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
dexonsmith added a reviewer: erik.pilkington.
dexonsmith added inline comments.
Comment at: src/cxa_demangle.cpp:3078-3079
++t1;
-db.names.back().first.insert(db.names.back().first.begin()+7,
t0, t1);
+if (db.names.back().firs
marcel added inline comments.
Comment at: src/cxa_demangle.cpp:3078-3079
++t1;
-db.names.back().first.insert(db.names.back().first.begin()+7,
t0, t1);
+if (db.names.back().first.length() > 7)
+ db.names.back()
marcel updated this revision to Diff 99850.
marcel added a comment.
Fixing off-by-one. Passes `make check-cxxabi` for LLVM in trunk on my machine
(x86-64, Ubuntu 16.04).
https://reviews.llvm.org/D33393
Files:
CREDITS.TXT
src/cxa_demangle.cpp
test/test_demangle.pass.cpp
Index: test/test
erik.pilkington added a comment.
Could you please add more context lines in any future patches? Makes it easier
to review!
I think we fixed the same problem at the same time, I have
https://reviews.llvm.org/D33368 that also fixes this! The reason that inserting
into db.names.back() sometimes r
marcel added a comment.
In https://reviews.llvm.org/D33393#761679, @erik.pilkington wrote:
> Do you agree that this is the right approach here?
Sure. As long as it fixes PR32890.
You could append my test case as a quick-check.
So, I'll go ahead and abandon this revision?
https://reviews.llvm
101 - 166 of 166 matches
Mail list logo
