This revision was automatically updated to reflect the committed changes.
Closed by commit rL302727: [libc++] Refactor Windows support headers. (authored
by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D32988?vs=98528&id=98530#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: bion
Date: Wed May 10 15:58:30 2017
New Revision: 302728
URL: http://llvm.org/viewvc/llvm-project?rev=302728&view=rev
Log:
Fix bad #endif in msvc_stdlib_force_include.hpp.
Modified:
libcxx/trunk/test/support/msvc_stdlib_force_include.hpp
Modified: libcxx/trunk/test/support/msvc_stdli
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D33013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Author: ericwf
Date: Wed May 10 16:30:04 2017
New Revision: 302731
URL: http://llvm.org/viewvc/llvm-project?rev=302731&view=rev
Log:
Don't interfere with the __builtin_foo namespace under MSVC
This patch follows up on feedback received in the review for
D32988. Specifically that libc++ should not
Author: rsmith
Date: Wed May 10 16:32:16 2017
New Revision: 302732
URL: http://llvm.org/viewvc/llvm-project?rev=302732&view=rev
Log:
Improve diagnosis of unknown template name.
When an undeclared identifier in a context that requires a type is followed by
'<', only look for type templates when ty
Author: ericwf
Date: Wed May 10 16:34:58 2017
New Revision: 302734
URL: http://llvm.org/viewvc/llvm-project?rev=302734&view=rev
Log:
Fix MinGW build to use Pthread when the header is available.
Some MinGW configurations use WinPThread instead of the native
threading interfaces. When this happens
Author: ericwf
Date: Wed May 10 16:40:58 2017
New Revision: 302736
URL: http://llvm.org/viewvc/llvm-project?rev=302736&view=rev
Log:
Remove usages of _LIBCPP_MSVC which is never defined
Modified:
libcxx/trunk/include/__config
libcxx/trunk/include/__undef_min_max
libcxx/trunk/include/e
Author: rsmith
Date: Wed May 10 16:47:30 2017
New Revision: 302737
URL: http://llvm.org/viewvc/llvm-project?rev=302737&view=rev
Log:
Changes missed from r302732.
Modified:
cfe/trunk/include/clang/Parse/Parser.h
cfe/trunk/lib/Parse/ParseDeclCXX.cpp
cfe/trunk/lib/Parse/ParseExprCXX.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302738: [Myriad] Pass -Xclang and -mllvm flags to
moviCompile (authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D33020?vs=98369&id=98538#toc
Repository:
rL LLVM
https://revie
Author: jyknight
Date: Wed May 10 16:48:13 2017
New Revision: 302738
URL: http://llvm.org/viewvc/llvm-project?rev=302738&view=rev
Log:
[Myriad] Pass -Xclang and -mllvm flags to moviCompile
Patch by Walter Lee.
Differential Revision: https://reviews.llvm.org/D33020
Modified:
cfe/trunk/lib/Dr
smeenai added a comment.
Confirmed that there are no ABI changed on both Linux and macOS.
https://reviews.llvm.org/D32329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: smeenai
Date: Wed May 10 16:52:39 2017
New Revision: 302739
URL: http://llvm.org/viewvc/llvm-project?rev=302739&view=rev
Log:
[libc++abi] Disable libc++ extern templates project-wide
libc++abi can't depend on libc++, so disable extern templates in libc++
headers project-wide. This was pre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302739: [libc++abi] Disable libc++ extern templates
project-wide (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D32329?vs=96061&id=98540#toc
Repository:
rL LLVM
https://rev
bruno accepted this revision.
bruno added a comment.
Hi Sean,
LGTM! One comment below.
Comment at: tools/clang-import-test/clang-import-test.cpp:263
+AddExternalSource(*CI, Imports);
+ }
No need for the curly braces here
https://reviews.llvm.org/D3298
ddcc added a comment.
It's been a while since I looked at the code, but I don't believe that all of
the new constraints are necessarily unsupported by the current range constraint
manager. Rather, they were just not being generated by the SimpleSValBuilder.
The changes pass the testsuite for bo
Author: adrian
Date: Wed May 10 17:14:23 2017
New Revision: 302740
URL: http://llvm.org/viewvc/llvm-project?rev=302740&view=rev
Log:
Partially revert r302685 and swith Apple-style full LTO builds to
-gline-tables-only. The memory consumption is apparently still too
much for some of the green drago
ddcc updated this revision to Diff 98545.
ddcc added a comment.
Rebase
https://reviews.llvm.org/D28953
Files:
include/clang/StaticAnalyzer/Checkers/SValExplainer.h
lib/StaticAnalyzer/Core/SValBuilder.cpp
lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp
test/Analysis/bitwise-ops.c
test/An
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D32977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
Author: chapuni
Date: Wed May 10 17:30:44 2017
New Revision: 302741
URL: http://llvm.org/viewvc/llvm-project?rev=302741&view=rev
Log:
clang/lib/Tooling/RefactoringCallbacks.cpp: Avoid std::errc::bad_message.
Modified:
cfe/trunk/lib/Tooling/RefactoringCallbacks.cpp
Modified: cfe/trunk/lib/Too
EricWF created this revision.
Herald added a subscriber: krytarowski.
This patch improves how libc++ handles min/max macros within the headers.
Previously libc++ would undef them and emit a warning.
This patch changes libc++ to use `#pragma push_macro` to save the macro before
undefining it, an
EricWF updated this revision to Diff 98561.
EricWF added a comment.
- Remove failing test. This patch cannot be easily tested because the system's
libc might also mess with the definitions of `min` and `max`.
https://reviews.llvm.org/D33080
Files:
include/__bit_reference
include/__config
ahatanak added a comment.
In https://reviews.llvm.org/D33030#751187, @mehdi_amini wrote:
> Something still isn't clear to me: the issue IIUC is not with the
> `unwindHeader` itself, but with the misaligned thrown object that is
> allocated right after the __cxa_exception itself. Isn't it?
>
> T
Author: ericwf
Date: Wed May 10 18:29:13 2017
New Revision: 302743
URL: http://llvm.org/viewvc/llvm-project?rev=302743&view=rev
Log:
Workaround -W#warnings on Windows until the correct fixes can land
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/
EricWF updated this revision to Diff 98562.
EricWF added a comment.
- Fix unterminated preprocessor directive.
https://reviews.llvm.org/D33080
Files:
include/__bit_reference
include/__config
include/__hash_table
include/__mutex_base
include/__split_buffer
include/__std_stream
incl
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33030#751723, @ahatanak wrote:
> If field unwindHeader is annotated with the aligned attribute, both the field
> and struct __cxa_exception are aligned.
Author: rsmith
Date: Wed May 10 19:17:17 2017
New Revision: 302750
URL: http://llvm.org/viewvc/llvm-project?rev=302750&view=rev
Log:
PR22877: When constructing an array via a constructor with a default argument
in list-initialization, run cleanups for the default argument after each
iteration of t
george.burgess.iv added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:2921
+ const auto *NewOvl = New->getAttr();
+ if (NewOvl->isTransparent() != OldOvl->isTransparent()) {
+assert(!NewOvl->isImplicit() &&
aaron.ballman wrote:
> Can `NewOv
george.burgess.iv updated this revision to Diff 98569.
george.burgess.iv marked 7 inline comments as done.
george.burgess.iv added a comment.
- Addressed all feedback
- Now we emit a warning when `transparently_overloadable` "overrides"
`overloadable`, rather than an error
https://reviews.llvm.
EricWF created this revision.
This patch corrects the build errors I encountered when building on MinGW64.
https://reviews.llvm.org/D33082
Files:
include/__locale
include/locale
include/stdio.h
include/support/win32/locale_win32.h
include/wchar.h
src/new.cpp
src/support/win32/loca
rsmith added a comment.
I'd like to suggest an alternative design: don't add a new attribute., and
instead change the semantics of `__attribute__((overloadable))` to permit at
most one non-overloadable function in an overload set. That one function would
implicitly get the `transparently_overlo
george.burgess.iv added a comment.
I'd be happy with that approach. Do you like it, Aaron?
FWIW, I did a bit of archaeology, and it looks like the commit that added the
requirement that all overloads must have `overloadable` (r64414) did so to keep
users from "trying to be too sneaky for their
zaks.anna added a comment.
Thank you for the patch! Could you please re-submit the patch with context?
Instructions on how to do that can be found here:
http://llvm.org/docs/Phabricator.html
Repository:
rL LLVM
https://reviews.llvm.org/D32449
__
Author: ericwf
Date: Wed May 10 21:00:25 2017
New Revision: 302754
URL: http://llvm.org/viewvc/llvm-project?rev=302754&view=rev
Log:
Apply libc++ MinGW CMake fix to libc++abi
Modified:
libcxxabi/trunk/cmake/config-ix.cmake
Modified: libcxxabi/trunk/cmake/config-ix.cmake
URL:
http://llvm.org
Author: ericwf
Date: Wed May 10 21:01:05 2017
New Revision: 302755
URL: http://llvm.org/viewvc/llvm-project?rev=302755&view=rev
Log:
Don't use posix_memalign under MinGW
Modified:
libcxxabi/trunk/src/stdlib_new_delete.cpp
Modified: libcxxabi/trunk/src/stdlib_new_delete.cpp
URL:
http://llvm.
Author: chapuni
Date: Wed May 10 21:39:30 2017
New Revision: 302757
URL: http://llvm.org/viewvc/llvm-project?rev=302757&view=rev
Log:
clang/test/CodeGenCXX/array-default-argument.cpp: Satisfy targets that have
x86_thiscallcc.
Modified:
cfe/trunk/test/CodeGenCXX/array-default-argument.cpp
Mo
Author: chapuni
Date: Wed May 10 21:43:47 2017
New Revision: 302758
URL: http://llvm.org/viewvc/llvm-project?rev=302758&view=rev
Log:
Prune unused \param(s) of clang::Parser::ParseTemplateIdAfterTemplateName() in
r302737. [-Wdocumentation]
Modified:
cfe/trunk/lib/Parse/ParseTemplate.cpp
Mod
Author: ericwf
Date: Wed May 10 22:18:29 2017
New Revision: 302759
URL: http://llvm.org/viewvc/llvm-project?rev=302759&view=rev
Log:
Rename c++abi.a on Windows to libc++abi to avoid name conflicts
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/src/CMakeLists.txt
URL:
Author: ericwf
Date: Wed May 10 22:29:59 2017
New Revision: 302760
URL: http://llvm.org/viewvc/llvm-project?rev=302760&view=rev
Log:
Fix Libc++abi linking under MinGW64
Modified:
libcxxabi/trunk/cmake/config-ix.cmake
libcxxabi/trunk/src/CMakeLists.txt
Modified: libcxxabi/trunk/cmake/conf
ahatanak updated this revision to Diff 98578.
ahatanak added a comment.
Rebase.
https://reviews.llvm.org/D25001
Files:
lib/Serialization/ASTReaderDecl.cpp
test/Modules/Inputs/merge-non-prototype-fn/header2.h
test/Modules/Inputs/merge-non-prototype-fn/module.map
test/Modules/merge-non-pr
Author: ericwf
Date: Wed May 10 22:49:48 2017
New Revision: 302761
URL: http://llvm.org/viewvc/llvm-project?rev=302761&view=rev
Log:
Allow undefined symbols when linking libc++abi.dll on Windows
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/CMakeLists.txt
URL:
http://ll
Author: ericwf
Date: Thu May 11 00:05:06 2017
New Revision: 302762
URL: http://llvm.org/viewvc/llvm-project?rev=302762&view=rev
Log:
Revert "Rename c++abi.a on Windows to libc++abi to avoid name conflicts"
This reverts commit r302759
Modified:
libcxxabi/trunk/src/CMakeLists.txt
Modified: li
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
One nit, otherwise looks good.
Comment at: lib/Format/UnwrappedLineFormatter.cpp:368
// We don't merge short records.
- if (Line.First->isOneOf(tok::kw_class, t
Author: ahatanak
Date: Thu May 11 00:58:52 2017
New Revision: 302763
URL: http://llvm.org/viewvc/llvm-project?rev=302763&view=rev
Log:
[libcxxabi] Align unwindHeader on a double-word boundary.
r276215 made a change to annotate _Unwind_Exception with attribute
"aligned" so that an exception object
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302763: [libcxxabi] Align unwindHeader on a double-word
boundary. (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D33030?vs=98401&id=98583#toc
Repository:
rL LLVM
https://r
smeenai added a comment.
@EricWF and I discussed this on IRC a bit. I'm not a fan of overloading
`_LIBCPP_WIN32API` for this purpose, since to me that macro is meant for
guarding Windows API functions, not for CRT functions. Eric suggested adding a
new macro `_LIBCPP_MSVCRT_LIKE`, which I'd be
echuraev added a comment.
So, I think that we have to do some decision about this patch. @Anastasia, What
do you think about it? Please see my commentary above. What should we do with
this patch?
https://reviews.llvm.org/D27334
___
cfe-commits mai
Author: ahatanak
Date: Thu May 11 01:17:49 2017
New Revision: 302764
URL: http://llvm.org/viewvc/llvm-project?rev=302764&view=rev
Log:
Revert "[libcxxabi] Align unwindHeader on a double-word boundary."
This reverts commit r302763.
The commit caused bot failures.
Removed:
libcxxabi/trunk/tes
Author: bruno
Date: Thu May 11 01:20:07 2017
New Revision: 302765
URL: http://llvm.org/viewvc/llvm-project?rev=302765&view=rev
Log:
[Sema] Improve redefinition errors pointing to the same header
Diagnostics related to redefinition errors that point to the same header
file do not provide much info
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302765: [Sema] Improve redefinition errors pointing to the
same header (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D28832?vs=95369&id=98584#toc
Repository:
rL LLVM
https:/
jdoerrie added a comment.
Ping, please take a look at this.
https://reviews.llvm.org/D32788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 150 of 150 matches
Mail list logo
