[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:22 +void ThrowWithNoexceptCheck::registerMatchers(MatchFinder *Finder) { + if (!getLangOpts().CPlusPlus11) +return; If we handle throw() then it should be CPlusPlus ==

[PATCH] D32425: [mips] Make checks in CodeGen/mips-varargs.c less fragile

arichardson updated this revision to Diff 98059. arichardson retitled this revision from "[mips] Make N32 checks in CodeGen/mips-varargs.c less fragile" to "[mips] Make checks in CodeGen/mips-varargs.c less fragile". arichardson edited the summary of this revision. arichardson added a comment. He

Re: [PATCH] D32696: More detailed docs for UsingShadowDecl

Ping! Any takers? Thanks, - Kim On Mon, May 1, 2017 at 10:27 AM, Kim Gräsman via Phabricator wrote: > kimgr created this revision. > > I couldn't make sense of the docs before, so I sent a question to cfe-dev. > Richard was gracious enough to fill in the blanks: > http://lists.llvm.org/pipermai

[PATCH] D32759: Fix errored return value in CheckFunctionReturnType and add a fixit hint

efriedma added a comment. The difference between returning true and false here is just the way error recovery works: when we return true, we know the type is invalid, so we suppress it, and subsequent errors involving the declaration. Example (Objective-C++) where we currently print two errors

[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

kuhar updated this revision to Diff 98073. kuhar added a comment. Herald added a subscriber: xazax.hun. I updated the patch against the current trunk. I also run the modernize-use-emplace check on llvm and verified that there are no new regressions after applying fixits. https://reviews.llvm.o

[libcxx] r302362 - Ensure showbase does not overflow do_put buffers

Author: dim Date: Sat May 6 15:58:50 2017 New Revision: 302362 URL: http://llvm.org/viewvc/llvm-project?rev=302362&view=rev Log: Ensure showbase does not overflow do_put buffers Summary: In https://bugs.freebsd.org/207918, Daniel McRobb describes how using std::showbase with ostreams can cause t

[PATCH] D32927: [libc++] Implement exception_ptr on Windows

bcraig added inline comments. Comment at: test/std/language.support/support.exception/except.nested/rethrow_if_nested.pass.cpp:12 + +// This test fails due to a stack overflow // XFAIL: LIBCXX-WINDOWS-FIXME EricWF wrote: > BillyONeal wrote: > > FWIW it does not

[PATCH] D32927: [libc++] Implement exception_ptr on Windows

EricWF added inline comments. Comment at: test/std/language.support/support.exception/propagation/current_exception.pass.cpp:10-11 -// exception_ptr has not been implemented on Windows +// This test needs to be rewritten for the Windows exception_ptr semantics +// which copy t

r302364 - Update LanguageExtensions doc to refer to C++14 instead of C++1y

Author: ericwf Date: Sat May 6 18:26:04 2017 New Revision: 302364 URL: http://llvm.org/viewvc/llvm-project?rev=302364&view=rev Log: Update LanguageExtensions doc to refer to C++14 instead of C++1y Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rs

[PATCH] D32948: [C++1z] Add speculative SD-6 feature test macro for pack expansions in using declarations

EricWF created this revision. This patch adds the `__cpp_variadic_using` feature test macro suggested in P0195r2. Note that this macro is not yet listed by SD-6. https://reviews.llvm.org/D32948 Files: lib/Frontend/InitPreprocessor.cpp test/Lexer/cxx-features.cpp Index: test/Lexer/cxx-fea

[PATCH] D32949: [Lexer] Make __has_extension ignore -pedantic-errors inside system headers

EricWF created this revision. Libc++ needs to be able to detect and use certain language extensions inside the STL headers. However `__has_extension` currently return `0` when `-pedantic-errors` is specified. However libc++ can still safely use these extensions since `-pedantic-errors` is ignor

[PATCH] D32950: Support C++1z features in `__has_extension`

EricWF created this revision. This patch updates `__has_extension` to report the C++1z extensions Clang offers https://reviews.llvm.org/D32950 Files: docs/LanguageExtensions.rst lib/Lex/PPMacroExpansion.cpp test/Lexer/has_extension_cxx.cpp test/Lexer/has_feature_cxx0x.cpp test/SemaCXX

[PATCH] D32927: [libc++] Implement exception_ptr on Windows

bcraig added a comment. libstdc++ and the Visual Studio C++ runtime have very different compatibility expectations. libstdc++ is generally bundled with the operating system. It maintains binary compatibility over very long stretches of time. In most systems, there can only be one libstdc++ l

[PATCH] D32950: Support C++1z features in `__has_extension`

EricWF updated this revision to Diff 98087. EricWF added a comment. - Improve documentation https://reviews.llvm.org/D32950 Files: docs/LanguageExtensions.rst lib/Lex/PPMacroExpansion.cpp test/Lexer/has_extension_cxx.cpp test/Lexer/has_feature_cxx0x.cpp test/SemaCXX/cxx1z-extensions.c

[PATCH] D32950: Support C++1z features in `__has_extension`

EricWF updated this revision to Diff 98088. EricWF added a comment. - Correctly report that structured bindings, inline variables, and fold expressions are available in C++03. https://reviews.llvm.org/D32950 Files: docs/LanguageExtensions.rst lib/Lex/PPMacroExpansion.cpp test/Lexer/has_e

[PATCH] D32945: clang-tidy: add IgnoreMacros option to modernize-use-default-member-init

malcolm.parsons added a subscriber: cfe-commits. malcolm.parsons added a comment. Should this option be shared? https://reviews.llvm.org/D32945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf