[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

alexfh added a comment. In https://reviews.llvm.org/D32294#732986, @Prazek wrote: > In https://reviews.llvm.org/D32294#732861, @kuhar wrote: > > > After thinking about Piotr's comment, I think that a better way to perform > > the check would be te invoking clang-apply-replacements with `--versio

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

alexfh added inline comments. Comment at: clang-tidy/tool/run-clang-tidy.py:226 +print('Applying fixes ...') +successfully_applied = True + ` = False` here and ` = True` after `apply_fixes()` inside `try`. https://reviews.llvm.org/D32294

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you! Repository: rL LLVM https://reviews.llvm.org/D32328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

zaks.anna added a comment. Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D32328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

alexshap added a comment. Thanks, i do. Repository: rL LLVM https://reviews.llvm.org/D32328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24892: [clang-tidy] Add option "LiteralInitializers" to cppcoreguidelines-pro-type-member-init

alexfh added a comment. In https://reviews.llvm.org/D24892#732243, @malcolm.parsons wrote: > In https://reviews.llvm.org/D24892#732217, @alexfh wrote: > > > In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote: > > > > > Is there any way for multiple checks to share an option? > > >

[libcxx] r300934 - Fix 'verify-support' available feature

Author: ericwf Date: Thu Apr 20 19:43:07 2017 New Revision: 300934 URL: http://llvm.org/viewvc/llvm-project?rev=300934&view=rev Log: Fix 'verify-support' available feature Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL: http://llvm.

r300936 - [analyzer] Fix assert in ExprEngine::processSwitch

Author: alexshap Date: Thu Apr 20 20:05:26 2017 New Revision: 300936 URL: http://llvm.org/viewvc/llvm-project?rev=300936&view=rev Log: [analyzer] Fix assert in ExprEngine::processSwitch This diff replaces getTypeSize(CondE->getType())) with getIntWidth(CondE->getType())) in ExprEngine::processSw

[PATCH] D32328: [analyzer] Fix assert in ExprEngine::processSwitch

This revision was automatically updated to reflect the committed changes. Closed by commit rL300936: [analyzer] Fix assert in ExprEngine::processSwitch (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D32328?vs=96060&id=96070#toc Repository: rL LLVM https://reviews.

[libcxx] r300937 - Resolve unused local typedef warning in test.

Author: bion Date: Thu Apr 20 20:10:04 2017 New Revision: 300937 URL: http://llvm.org/viewvc/llvm-project?rev=300937&view=rev Log: Resolve unused local typedef warning in test. Modified: libcxx/trunk/test/std/strings/basic.string/string.cons/T_size_size.pass.cpp Modified: libcxx/trunk/test/

[PATCH] D32307: [libcxx] [test] Resolve everyone's favorite warning, unused local typedef

BillyONeal closed this revision. BillyONeal added a comment. Committed r300937 https://reviews.llvm.org/D32307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300938 - [modules] Properly look up the owning module for an instantiation of a merged template.

Author: rsmith Date: Thu Apr 20 20:15:13 2017 New Revision: 300938 URL: http://llvm.org/viewvc/llvm-project?rev=300938&view=rev Log: [modules] Properly look up the owning module for an instantiation of a merged template. When looking for the template instantiation pattern of a templated entity,

Re: r300650 - [modules] Properly look up the owning module for an instantiation of a merged template.

Re-committed with fix in r300938. On 20 April 2017 at 17:06, Richard Smith wrote: > On 18 April 2017 at 22:41, Chandler Carruth wrote: > >> Reverted in r300658. >> > > For posterity, the above has an off-by-one error, the revert was r300659. > > >> On Tue, Apr 18, 2017 at 8:30 PM Chandler Carru

[PATCH] D32332: Add support for transparent overloadable functions in clang

george.burgess.iv created this revision. One of the common use-cases for the `overloadable` attribute is to create small wrapper functions around an existing function that was previously not overloadable. For example: // C Library v1 void foo(int i); // C Library v2 // Note the __as

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added a comment. Hmm... presumably, this test should pass: $ ./bin/clang -nostdinc -isystem ./lib/clang/5.0.0/include -std=c++1z -fsyntax-only t.cpp t.cpp:3:1: error: static_assert failed static_assert(__is_same(intptr_t, __INTPTR_TYPE__)); ^ ~~

[libcxx] r300941 - XFAIL Windows test failures under test/libcxx

Author: ericwf Date: Thu Apr 20 20:48:02 2017 New Revision: 300941 URL: http://llvm.org/viewvc/llvm-project?rev=300941&view=rev Log: XFAIL Windows test failures under test/libcxx This patch XFAIL's a number of tests under test/libcxx when on Windows. These failures need more investigation or patc

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith updated this revision to Diff 96078. dexonsmith added a comment. Here's an updated patch that uses `__SIZE_MAX__` and also handles the other pointer-like integers. However, the first three static asserts fail, because `intptr_t` and `__INTPTR_TYPE__` are different types (same for `ui

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini wrote: > > On Apr 20, 2017, at 12:30 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini > wrote: > >> >> On Apr 20, 2017, at 12:39 AM, Eric Fiselier wrote: >> >> >> >> On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini >> wro

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno marked 6 inline comments as done. bruno added inline comments. Comment at: lib/Parse/ParseDecl.cpp:4236-4237 Sema::SkipBodyInfo SkipBody; + Sema::CheckCompatTagInfo CheckCompatTag; if (!Name && TUK == Sema::TUK_Definition && Tok.is(tok::l_brace) &&

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno updated this revision to Diff 96080. bruno marked 2 inline comments as done. bruno added a comment. Update the patch after Richard's suggestions https://reviews.llvm.org/D31778 Files: include/clang/AST/ASTStructuralEquivalence.h include/clang/Basic/DiagnosticASTKinds.td include/clan

[PATCH] D31856: Headers: Make the type of SIZE_MAX the same as size_t

dexonsmith added a comment. It looks like `__INTPTR_TYPE__` was introduced in r64495 in order to help define `intptr_t`, and then they diverged in r89237. Changing `intptr_t` would change the mangling of symbols in libcxx, so that doesn't seem safe. Is it safe to change `__INTPTR_TYPE__`? ht

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 7:03 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini > wrote: > >> On Apr 20, 2017, at 12:30 PM, Eric Fiselier > > wrote: >> >> >> >> On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini >

[libcxx] r300942 - Mark exception_ptr tests as XFAIL on Windows for now

Author: ericwf Date: Thu Apr 20 21:13:33 2017 New Revision: 300942 URL: http://llvm.org/viewvc/llvm-project?rev=300942&view=rev Log: Mark exception_ptr tests as XFAIL on Windows for now Modified: libcxx/trunk/test/std/language.support/support.exception/except.nested/assign.pass.cpp libc

[PATCH] D32333: [clang-tidy] Update IdentifierNamingCheck to remove extra leading/trailing underscores

jtbandes created this revision. The goal of this change is to fix the following suboptimal replacements currently suggested by clang-tidy: // with MemberPrefix == "_" int __foo; // accepted without complaint // with MemberPrefix == "m_" int _foo; ^~ m__foo I fixed this

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 96084. xiangzhai added a comment. Further reduce redundant code. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c ==

[libcxx] r300944 - update XFAIL comments with more details

Author: ericwf Date: Thu Apr 20 22:09:40 2017 New Revision: 300944 URL: http://llvm.org/viewvc/llvm-project?rev=300944&view=rev Log: update XFAIL comments with more details Modified: libcxx/trunk/test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp libcxx/trunk/test/libcxx/localiza

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

xiangzhai updated this revision to Diff 96088. xiangzhai added a comment. Hi Richard, Thanks for your review! I updated my patch as you suggested: add some test coverage for these triples, and I run `make check-clang-driver` for verification, please point out my fault, thanks! Regards, Leslie

[PATCH] D30805: [OpenCL] Add intel_reqd_sub_group_size attribute support

pxli168 added a comment. @Anastasia is this test added OK? https://reviews.llvm.org/D30805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32147: [PR32479] Avoid newlib vasprintf, since it requires gnu extensions

EricWF resigned from this revision. EricWF added a comment. The bug relating to this patch was closed as WONTFIX. This review should be closed. https://reviews.llvm.org/D32147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D32111: [modules] Attempt to fix PR31905 - #include "stddef.h" breaks module map search paths; causes redefinitions.

EricWF planned changes to this revision. EricWF added a comment. I've got a better, actually correct, solution incoming. https://reviews.llvm.org/D32111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D31739: Add markup for libc++ dylib availability

mehdi_amini marked 5 inline comments as done. mehdi_amini added inline comments. Comment at: utils/libcxx/test/config.py:289 +def configure_availability(self): +# FIXME doc +self.with_availability = self.get_lit_bool('with_availability', False) ---

[PATCH] D32294: [clang-tidy] run-clang-tidy.py: check if clang-apply-replacements succeeds

kuhar updated this revision to Diff 96097. kuhar added a comment. Minor change to success detection logic. https://reviews.llvm.org/D32294 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py === ---

r300948 - [index] For 'transparent' tag typedefs, ignore their tag reference

Author: akirtzidis Date: Fri Apr 21 00:42:40 2017 New Revision: 300948 URL: http://llvm.org/viewvc/llvm-project?rev=300948&view=rev Log: [index] For 'transparent' tag typedefs, ignore their tag reference Modified: cfe/trunk/lib/Index/IndexDecl.cpp cfe/trunk/test/Index/Core/index-source.m

r300949 - [index] Take advantage of 'external_source_symbol' attribute for indexing purposes

Author: akirtzidis Date: Fri Apr 21 00:42:46 2017 New Revision: 300949 URL: http://llvm.org/viewvc/llvm-project?rev=300949&view=rev Log: [index] Take advantage of 'external_source_symbol' attribute for indexing purposes - Ignore decls marked as 'generated_declaration' - Include the 'defined_in'

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki added a comment. I don't have further comments except that I would personally rewrite: // Get the value of the size argument. SVal TotalSize = State->getSVal(Arg1, LCtx); if (SuffixWithN) { const Expr *Arg2 = CE->getArg(2); TotalSize = evalMulForBufferSize(C, Arg1, A

[PATCH] D32298: [clang-format] Turn IncompleteFormat into a string

djasper added inline comments. Comment at: include/clang/Format/Format.h:1527 +/// non-recoverable syntax error. tooling::Replacements reformat(const FormatStyle &Style, StringRef Code, ArrayRef Ranges, This is a public interface

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 96101. xiangzhai added a comment. Further reduce redundant code. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c ==

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki added a comment. you can ignore my comment ... LGTM I don't want to accept this revision. Hopefully NoQ or somebody else can do that. Repository: rL LLVM https://reviews.llvm.org/D30771 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added a comment. Never mind :) Repository: rL LLVM https://reviews.llvm.org/D30771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2