r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions are

2017-04-17 Thread Yaron Keren via cfe-commits
Author: yrnkrn Date: Mon Apr 17 03:51:20 2017 New Revision: 300443 URL: http://llvm.org/viewvc/llvm-project?rev=300443&view=rev Log: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

2017-04-17 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300443: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace… (authored by yrnkrn). Changed prior to commit: https://reviews.llvm.org/D31540?vs=94961&id=95425#toc Repository:

[PATCH] D32113: Add path from clang to doxygen document include header

2017-04-17 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added a comment. Woops, my bad, seems like I tested just before you fixed it. Because I read in the documentation that we could also pass include paths here, we could also try something like this: STRIP_FROM_INC_PATH= @abs_srcdir@/.. STRIP_FROM_INC_PATH+= @abs_srcdir@/../i

[PATCH] D32113: Add path from clang to doxygen document include header

2017-04-17 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi updated this revision to Diff 95434. yamaguchi added a comment. It worked, and this code generates #include "Sema/Sema.h". https://reviews.llvm.org/D32113 Files: docs/doxygen.cfg.in Index: docs/doxygen.cfg.in === ---

[PATCH] D32113: Add path from clang to doxygen document include header

2017-04-17 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev added inline comments. Comment at: docs/doxygen.cfg.in:158 +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang-c We should be stripping `@abs_srcdir@/../include` because in reality the w

[PATCH] D32113: Add path from clang to doxygen document include header

2017-04-17 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi added inline comments. Comment at: docs/doxygen.cfg.in:158 +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang-c v.g.vassilev wrote: > We should be stripping `@abs_srcdir@/../include` becau

[libcxx] r300449 - Mark LWG#2853 as complete. No code changes required, but added a couple of extra tests

2017-04-17 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 17 08:19:14 2017 New Revision: 300449 URL: http://llvm.org/viewvc/llvm-project?rev=300449&view=rev Log: Mark LWG#2853 as complete. No code changes required, but added a couple of extra tests Modified: libcxx/trunk/test/std/containers/sequences/vector/vector.mo

[PATCH] D32113: Add path from clang to doxygen document include header

2017-04-17 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added inline comments. Comment at: docs/doxygen.cfg.in:158 +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang +STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang-c yamaguchi wrote: > v.g.vassilev wrote: > > We should be stripping `@abs_srcd

[PATCH] D32113: Add path from clang to doxygen document include header

2017-04-17 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi updated this revision to Diff 95436. yamaguchi added a comment. This will generate #include "clang/Sema/Sema.h" . https://reviews.llvm.org/D32113 Files: docs/doxygen.cfg.in Index: docs/doxygen.cfg.in === --- docs/doxy

[libcxx] r300451 - Sigh. Once again forgot about the 'no exceptions' bots.

2017-04-17 Thread Marshall Clow via cfe-commits
Author: marshall Date: Mon Apr 17 09:18:44 2017 New Revision: 300451 URL: http://llvm.org/viewvc/llvm-project?rev=300451&view=rev Log: Sigh. Once again forgot about the 'no exceptions' bots. Modified: libcxx/trunk/test/std/containers/sequences/vector/vector.modifiers/erase_iter.pass.cpp

[PATCH] D29827: [AVR] Add -mmcu option to the driver

2017-04-17 Thread Jonathan Roelofs via Phabricator via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Driver/Options.td:1613 def mcpu_EQ : Joined<["-"], "mcpu=">, Group; +def mmcu_EQ : Joined<["-"], "mmcu=">, Group; def mdynamic_no_pic : J

[PATCH] D31717: CodeGen: Let lifetime intrinsic use alloca address space

2017-04-17 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. LGTM. https://reviews.llvm.org/D31717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300454 - [ObjC] Mark loads from __NSArray0 and __NSDictionary0 as invariant.load.

2017-04-17 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Mon Apr 17 10:21:55 2017 New Revision: 300454 URL: http://llvm.org/viewvc/llvm-project?rev=300454&view=rev Log: [ObjC] Mark loads from __NSArray0 and __NSDictionary0 as invariant.load. Also, simplify code by calling MakeNaturalAlignAddrLValue. This is a follow-up to r30039

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-04-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3517 +CGM.getCodeGenOpts().StrictVTablePointers && +CGM.getCodeGenOpts().OptimizationLevel > 0) + addr = Address(Builder.CreateInvariantGroupBarrier(addr.getPointer()), Checki

[PATCH] D31646: [coroutines] Build GRO declaration and return GRO statement

2017-04-17 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. Melodic ping https://reviews.llvm.org/D31646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Canonical param types and restrict array index qualifiers

2017-04-17 Thread Aaron Ballman via cfe-commits
I've run into a case where I am calling ASTContext::getFunctionType() and getting a failed assertion because a parameter we thought we canonicalized isn't actually canonical. The function is declared as: extern int regexec (int __pmatch[__restrict]); When we call getCanonicalParamType() on that p

Re: r300145 - ExternalASTMerger.cpp: Silence another warning. [-Wunused-lambda-capture]

2017-04-17 Thread David Blaikie via cfe-commits
I'll change this to [&] capture - any lambda that doesn't escape it's scope should generally use [&] & that'll avoid the need for explicitly discarding conditionally unused captures, etc. On Wed, Apr 12, 2017 at 5:45 PM NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-04-17 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3517 +CGM.getCodeGenOpts().StrictVTablePointers && +CGM.getCodeGenOpts().OptimizationLevel > 0) + addr = Address(Builder.CreateInvariantGroupBarrier(addr.getPointer()), rjmccall

r300461 - Use default ref capture to simplify local lambdas, use a template to avoid std::function overhead, other cleanup

2017-04-17 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Mon Apr 17 12:16:19 2017 New Revision: 300461 URL: http://llvm.org/viewvc/llvm-project?rev=300461&view=rev Log: Use default ref capture to simplify local lambdas, use a template to avoid std::function overhead, other cleanup Modified: cfe/trunk/lib/AST/ExternalASTMerge

Re: Canonical param types and restrict array index qualifiers

2017-04-17 Thread Richard Smith via cfe-commits
C11 6.7.6.3p15: "In the determination of type compatibility and of a composite type, each parameter declared with function or array type is taken as having the adjusted type and each parameter declared with qualified type is taken as having the unqualified version of its declared type." So "int f(

Re: Canonical param types and restrict array index qualifiers

2017-04-17 Thread Aaron Ballman via cfe-commits
On Mon, Apr 17, 2017 at 2:14 PM, Richard Smith wrote: > C11 6.7.6.3p15: "In the determination of type compatibility and of a > composite type, each parameter declared with function or array type is taken > as having the adjusted type and each parameter declared with qualified type > is taken as ha

[PATCH] D32084: AMDGPU/GFX9: Set +fast-fmaf for >=gfx900 unless -cl-denorms-are-zero is set

2017-04-17 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl added a comment. Ping. https://reviews.llvm.org/D32084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

2017-04-17 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 95461. gtbercea added a comment. Merge IF statements. Repository: rL LLVM https://reviews.llvm.org/D32035 Files: lib/Frontend/CompilerInvocation.cpp test/OpenMP/target_messages.cpp Index: test/OpenMP/target_messages.cpp ===

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

2017-04-17 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D32035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D32132: [AArch64][clang] Pass cpu/arch information to assembler for AArch64.

2017-04-17 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta created this revision. Herald added subscribers: rengolin, aemerson. Pass Cpu/Arch options to assembler for AArch64 with no-integrated-as. This fixes PR20019. https://reviews.llvm.org/D32132 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/linux-as.c Index: test/Driver/linux-as

[PATCH] D32043: [Driver] Load all necessary default sanitizer blacklists

2017-04-17 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. This seems reasonable to me, although it's unfortunate that the design of the sanitizer blacklist feature does not (at present) allow different blacklists for different sanitizers. @eugenis what do you think? https://reviews.llvm.org/D32043

[PATCH] D32043: [Driver] Load all necessary default sanitizer blacklists

2017-04-17 Thread Evgeniy Stepanov via Phabricator via cfe-commits
eugenis added a comment. Looks fine. https://reviews.llvm.org/D32043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31869: Register isStaticStorageClass matcher

2017-04-17 Thread Dave Lee via Phabricator via cfe-commits
kastiglione added a comment. thanks @aaron.ballman :) https://reviews.llvm.org/D31869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-04-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3517 +CGM.getCodeGenOpts().StrictVTablePointers && +CGM.getCodeGenOpts().OptimizationLevel > 0) + addr = Address(Builder.CreateInvariantGroupBarrier(addr.getPointer()), Prazek

[PATCH] D32133: CodeGen: Let byval parameter use alloca address space

2017-04-17 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. https://reviews.llvm.org/D32133 Files: lib/CodeGen/CGCall.cpp test/CodeGenOpenCL/byval.cl Index: test/CodeGenOpenCL/byval.cl === --- /dev/null +++ test/CodeGenOpenCL/byval.cl @@ -0,0 +1,18 @@ +// R

[PATCH] D32133: CodeGen: Let byval parameter use alloca address space

2017-04-17 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D32133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r300485 - CodeGen: Let lifetime intrinsic use alloca address space

2017-04-17 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Mon Apr 17 15:03:11 2017 New Revision: 300485 URL: http://llvm.org/viewvc/llvm-project?rev=300485&view=rev Log: CodeGen: Let lifetime intrinsic use alloca address space Differential Revision: https://reviews.llvm.org/D31717 Added: cfe/trunk/test/CodeGenOpenCL/lifetime.cl

[PATCH] D31717: CodeGen: Let lifetime intrinsic use alloca address space

2017-04-17 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300485: CodeGen: Let lifetime intrinsic use alloca address space (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D31717?vs=94980&id=95477#toc Repository: rL LLVM https://revi

r300487 - CodeGen: Let byval parameter use alloca address space

2017-04-17 Thread Yaxun Liu via cfe-commits
Author: yaxunl Date: Mon Apr 17 15:10:44 2017 New Revision: 300487 URL: http://llvm.org/viewvc/llvm-project?rev=300487&view=rev Log: CodeGen: Let byval parameter use alloca address space Differential Revision: https://reviews.llvm.org/D32133 Added: cfe/trunk/test/CodeGenOpenCL/byval.cl Modif

[PATCH] D32133: CodeGen: Let byval parameter use alloca address space

2017-04-17 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300487: CodeGen: Let byval parameter use alloca address space (authored by yaxunl). Changed prior to commit: https://reviews.llvm.org/D32133?vs=95473&id=95478#toc Repository: rL LLVM https://reviews

[libcxx] r300488 - [optional] Update synopsis for LWG2934

2017-04-17 Thread Casey Carter via cfe-commits
Author: caseycarter Date: Mon Apr 17 15:15:16 2017 New Revision: 300488 URL: http://llvm.org/viewvc/llvm-project?rev=300488&view=rev Log: [optional] Update synopsis for LWG2934 (comment-only change) Modified: libcxx/trunk/include/optional libcxx/trunk/test/std/utilities/optional/optional

[libcxx] r300489 - Fix passing incorrectly value-category when constructing unique_ptr's deleter

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 17 15:20:27 2017 New Revision: 300489 URL: http://llvm.org/viewvc/llvm-project?rev=300489&view=rev Log: Fix passing incorrectly value-category when constructing unique_ptr's deleter Modified: libcxx/trunk/include/memory libcxx/trunk/test/std/utilities/smartpt

[PATCH] D32110: Emit invariant.group loads with empty group md

2017-04-17 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. Repository: rL LLVM https://reviews.llvm.org/D32110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF reopened this revision. EricWF added a comment. This revision is now accepted and ready to land. I have to revert this commit due to test failures. I think I uploaded an incorrect patch or bad merge because the tests passed on my machine. https://reviews.llvm.org/D31487 __

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-04-17 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3517 +CGM.getCodeGenOpts().StrictVTablePointers && +CGM.getCodeGenOpts().OptimizationLevel > 0) + addr = Address(Builder.CreateInvariantGroupBarrier(addr.getPointer()), rjmccall

r300497 - Revert "Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definit

2017-04-17 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Mon Apr 17 15:57:40 2017 New Revision: 300497 URL: http://llvm.org/viewvc/llvm-project?rev=300497&view=rev Log: Revert "Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

2017-04-17 Thread Benjamin Kramer via cfe-commits
This broke our internal build of libc++ with modules. Reduced test case attached, courtesy of Richard Smith! With your patch it doesn't compiler anymore: While building module 'x': In file included from :2: In file included from ./c.h:1: ./a.h:3:32: error: inline declaration of 'f' follows non-inl

[PATCH] D32138: clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680)

2017-04-17 Thread Hans Wennborg via Phabricator via cfe-commits
hans created this revision. It sounds like MSVC is adding support for two-phase name lookup in a future version, enabled by this flag (see bug). https://reviews.llvm.org/D32138 Files: include/clang/Driver/CLCompatOptions.td test/Driver/cl-options.c Index: test/Driver/cl-options.c ===

[PATCH] D32138: clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680)

2017-04-17 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. We could wait until a version of MSVC ships with this, in case they decide to change the name, or we could just land it now. https://reviews.llvm.org/D32138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

2017-04-17 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D32064#726861, @pcc wrote: > I think it would be better to move this logic to the driver and have it pass > in an `-mllvm` flag. The sanitizer passes should really be taking no > arguments in the constructor like the other passes, so I don't want

[PATCH] D32138: clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680)

2017-04-17 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Let's add it now. If we don't add this, some user will run into it first and have to wait for a fix. If we add it and get the meaning wrong, we'll still need to fix it and push a new release, so we'

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

2017-04-17 Thread Yaron Keren via cfe-commits
Thanks, I will look into this. ‫בתאריך יום ג׳, 18 באפר׳ 2017 ב-0:11 מאת ‪Benjamin Kramer‬‏ <‪ benny@gmail.com‬‏>:‬ > This broke our internal build of libc++ with modules. Reduced test > case attached, courtesy of Richard Smith! > > With your patch it doesn't compiler anymore: > While buildin

r300501 - clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680)

2017-04-17 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Apr 17 16:28:36 2017 New Revision: 300501 URL: http://llvm.org/viewvc/llvm-project?rev=300501&view=rev Log: clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680) It sounds like MSVC is adding support for two-phase name lookup in a future version, enabled by th

[PATCH] D32138: clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680)

2017-04-17 Thread Hans Wennborg via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL300501: clang-cl: Support the /Zc:twoPhase[-] command-line option (PR32680) (authored by hans). Changed prior to commit: https://reviews.llvm.org/D32138?vs=95489&id=95494#toc Repository: rL LLVM htt

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

2017-04-17 Thread Vassil Vassilev via cfe-commits
+ Richard Thanks for the example. We've seen similar issue with inlines (without the reverted patch). My guess this patch exposed it. It is not clear to me why we think the declaration is a definition there... On 17/04/17 23:10, Benjamin Kramer via cfe-commits wrote: This broke our internal b

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

2017-04-17 Thread Evgeniy Stepanov via Phabricator via cfe-commits
eugenis added inline comments. Comment at: lib/Driver/SanitizerArgs.cpp:636 + case llvm::Triple::COFF: +return DataSections; + case llvm::Triple::ELF: rnk wrote: > We can return true for COFF here. By adding a comdat during asan > instrumentation, we effec

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

2017-04-17 Thread Josh Zimmerman via Phabricator via cfe-commits
joshz updated this revision to Diff 95488. joshz marked an inline comment as done. joshz edited the summary of this revision. joshz added a comment. Resolved the bug, with a slightly modified version of Aaron's suggestion. (It will suggest parens for anything that wasn't just a DeclRefExpr, which

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 95501. EricWF added a comment. - Upload new, hopefully correct, diff. https://reviews.llvm.org/D31487 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/SemaCXX/coroutines.cpp Inde

r300504 - [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 17 17:06:13 2017 New Revision: 300504 URL: http://llvm.org/viewvc/llvm-project?rev=300504&view=rev Log: [coroutines] Fix rebuilding of implicit and dependent coroutine statements. Summary: Certain implicitly generated coroutine statements, such as the calls to 'retur

r300508 - [ubsan] Skip null checks on pointers to the start of an alloca

2017-04-17 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Mon Apr 17 17:26:07 2017 New Revision: 300508 URL: http://llvm.org/viewvc/llvm-project?rev=300508&view=rev Log: [ubsan] Skip null checks on pointers to the start of an alloca Pointers to the start of an alloca are non-null, so we don't need to emit runtime null checks for th

r300509 - [ubsan] Skip null checks if they are constant-folded away

2017-04-17 Thread Vedant Kumar via cfe-commits
Author: vedantk Date: Mon Apr 17 17:26:10 2017 New Revision: 300509 URL: http://llvm.org/viewvc/llvm-project?rev=300509&view=rev Log: [ubsan] Skip null checks if they are constant-folded away The IR builder can constant-fold null checks if the pointer operand points to a constant. If the "is-non-

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

2017-04-17 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: lib/Driver/SanitizerArgs.cpp:636 + case llvm::Triple::COFF: +return DataSections; + case llvm::Triple::ELF: eugenis wrote: > rnk wrote: > > We can return true for COFF here. By adding a comdat during asan > > instrume

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

2017-04-17 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added a comment. In https://reviews.llvm.org/D32064#728629, @rnk wrote: > In https://reviews.llvm.org/D32064#726861, @pcc wrote: > > > I think it would be better to move this logic to the driver and have it > > pass in an `-mllvm` flag. The sanitizer passes should really be taking no > > ar

[libcxx] r300510 - Work around GCC 4.9 bug regarding default initialization of const variables

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 17 17:32:02 2017 New Revision: 300510 URL: http://llvm.org/viewvc/llvm-project?rev=300510&view=rev Log: Work around GCC 4.9 bug regarding default initialization of const variables Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL: h

r300511 - Revert r300504 - [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 17 17:40:44 2017 New Revision: 300511 URL: http://llvm.org/viewvc/llvm-project?rev=300511&view=rev Log: Revert r300504 - [coroutines] Fix rebuilding of implicit and dependent coroutine statements. I have no idea what's happening here. The tests that fail on all of th

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

2017-04-17 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno added a comment. Ping! https://reviews.llvm.org/D31778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

2017-04-17 Thread Richard Smith via cfe-commits
On 17 April 2017 at 14:41, Vassil Vassilev wrote: > + Richard > > Thanks for the example. We've seen similar issue with inlines (without the > reverted patch). My guess this patch exposed it. > > It is not clear to me why we think the declaration is a definition there... > Well, the declaration

r300513 - Rename coroutine warning when unhandled_exception() is missing

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 17 18:28:02 2017 New Revision: 300513 URL: http://llvm.org/viewvc/llvm-project?rev=300513&view=rev Log: Rename coroutine warning when unhandled_exception() is missing Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td cfe/trunk/include/clang/Basic/Dia

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF reopened this revision. EricWF added a comment. This revision is now accepted and ready to land. re-opening because I had to revert the changes again. The tests are passing on my local machine but they're failing on the bots. I'm not exactly sure what's going on. Perhaps its UB caused by

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 95506. EricWF added a comment. - Update against trunk. https://reviews.llvm.org/D31487 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/SemaCXX/coroutines.cpp Index: test/SemaCXX

r300515 - Fix mishandling of escaped newlines followed by newlines or nuls.

2017-04-17 Thread Richard Smith via cfe-commits
Author: rsmith Date: Mon Apr 17 18:44:51 2017 New Revision: 300515 URL: http://llvm.org/viewvc/llvm-project?rev=300515&view=rev Log: Fix mishandling of escaped newlines followed by newlines or nuls. Previously, if an escaped newline was followed by a newline or a nul, we'd lex the escaped newline

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF reopened this revision. EricWF added a comment. This revision is now accepted and ready to land. Re-opening since the last commit had to be reverted. https://reviews.llvm.org/D31562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D31487: [coroutines] Fix rebuilding of implicit and dependent coroutine statements.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF closed this revision. EricWF added a comment. Woops, I've been updating the wrong patch. These updates should have been for https://reviews.llvm.org/D31562. https://reviews.llvm.org/D31487 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 95511. EricWF added a comment. - Update so it merges against master. https://reviews.llvm.org/D31562 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/SemaCXX/coroutines.cpp Index

[PATCH] D32144: [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679)

2017-04-17 Thread Vedant Kumar via Phabricator via cfe-commits
vsk created this revision. The coverage implementation marks functions which won't be emitted as 'deferred', so that it can emit empty coverage regions for them later (once their linkages are known). Functions in dependent contexts are an exception: if there isn't a full instantiation of a functi

[libcxx] r300516 - Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions.

2017-04-17 Thread Billy Robert O'Neal III via cfe-commits
Author: bion Date: Mon Apr 17 19:19:50 2017 New Revision: 300516 URL: http://llvm.org/viewvc/llvm-project?rev=300516&view=rev Log: Allow a standard library to implement conditional noexcept for optional and unique_ptr hash functions. These tests were unconditionally asserting that optional and u

[PATCH] D32146: PR32476: __nop_locale_mgmt.h not needed with newlib 2.5+

2017-04-17 Thread Ben Craig via Phabricator via cfe-commits
bcraig created this revision. newlib 2.5 added the locale management functions, and so our stub __nop_locale_mgmt.h shouldn't be included, as it conflicts with newlibs definitions. newlib 2.4 and earlier still need the header though. Patch by Martin J. O'Riordan https://reviews.llvm.org/D321

[PATCH] D32147: [PR32479] Avoid newlib vasprintf, since it requires gnu extensions

2017-04-17 Thread Ben Craig via Phabricator via cfe-commits
bcraig updated this revision to Diff 95520. bcraig added reviewers: jyknight, mclow.lists, EricWF. bcraig added a subscriber: cfe-commits. https://reviews.llvm.org/D32147 Files: include/__bsd_locale_fallbacks.h include/__config Index: include/__config ===

r300523 - Debug Info: Remove special-casing of indirect function argument handling.

2017-04-17 Thread Adrian Prantl via cfe-commits
Author: adrian Date: Mon Apr 17 20:22:01 2017 New Revision: 300523 URL: http://llvm.org/viewvc/llvm-project?rev=300523&view=rev Log: Debug Info: Remove special-casing of indirect function argument handling. LLVM has changed the semantics of dbg.declare for describing function arguments. After thi

[PATCH] D32147: [PR32479] Avoid newlib vasprintf, since it requires gnu extensions

2017-04-17 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Why are GNU extensions not turned on? AFAIK Libc++ doesn't compile against any C library without GNU extensions enabled, including glibc and apple-libc. https://reviews.llvm.org/D32147 ___ cfe-commits mailing list cfe-commit

r300524 - [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Mon Apr 17 22:12:48 2017 New Revision: 300524 URL: http://llvm.org/viewvc/llvm-project?rev=300524&view=rev Log: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present. Summary: This patch implements [dcl.fct.def.coroutin

r300528 - Speculatively attempt to fix bot failures caused by recent coroutine changes.

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 18 00:08:08 2017 New Revision: 300528 URL: http://llvm.org/viewvc/llvm-project?rev=300528&view=rev Log: Speculatively attempt to fix bot failures caused by recent coroutine changes. Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp Modified: cfe/trunk/lib/Sema/SemaC

r300529 - Assert that a valid operator new/delete signature is always found by the coroutine body

2017-04-17 Thread Eric Fiselier via cfe-commits
Author: ericwf Date: Tue Apr 18 00:30:39 2017 New Revision: 300529 URL: http://llvm.org/viewvc/llvm-project?rev=300529&view=rev Log: Assert that a valid operator new/delete signature is always found by the coroutine body Modified: cfe/trunk/lib/Sema/SemaCoroutine.cpp Modified: cfe/trunk/lib

[PATCH] D31830: Emit invariant.group.barrier when using union field

2017-04-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:3517 +CGM.getCodeGenOpts().StrictVTablePointers && +CGM.getCodeGenOpts().OptimizationLevel > 0) + addr = Address(Builder.CreateInvariantGroupBarrier(addr.getPointer()), Prazek

Re: r259901 - [modules] Separately track whether an identifier's preprocessor information and

2017-04-17 Thread Bruno Cardoso Lopes via cfe-commits
Hi Richard, FTR, this caused http://bugs.llvm.org/show_bug.cgi?id=32693 Any suggestions on how to approach this? On Fri, Feb 5, 2016 at 11:03 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Fri Feb 5 13:03:40 2016 > New Revision: 259901 > > URL: http://llvm.org/viewvc/llvm-pr

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

2017-04-17 Thread Yaron Keren via Phabricator via cfe-commits
yaron.keren reopened this revision. yaron.keren added a comment. reverted in r300497 Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co