pcc added a comment.
I think it would be better to move this logic to the driver and have it pass in
an `-mllvm` flag. The sanitizer passes should really be taking no arguments in
the constructor like the other passes, so I don't want us to add another
argument here.
Repository:
rL LLVM
ht
yamaguchi added a comment.
I don't have a commit access. Can you commit?
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: kuba.brecka
Date: Thu Apr 13 19:32:43 2017
New Revision: 300287
URL: http://llvm.org/viewvc/llvm-project?rev=300287&view=rev
Log:
[ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt
CodeGenFunction::EmitObjCForCollectionStmt currently emits lifetime markers for
the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL300287: [ObjC] Fix lifetime markers of loop variable in
EmitObjCForCollectionStmt (authored by kuba.brecka).
Changed prior to commit:
https://reviews.llvm.org/D32029?vs=95157&id=95251#toc
Repository:
Author: kuba.brecka
Date: Thu Apr 13 20:00:03 2017
New Revision: 300290
URL: http://llvm.org/viewvc/llvm-project?rev=300290&view=rev
Log:
Revert r300287.
Modified:
cfe/trunk/lib/CodeGen/CGObjC.cpp
cfe/trunk/test/CodeGenObjC/arc-foreach.m
cfe/trunk/test/CodeGenObjC/arc-ternary-op.m
M
eugenis updated this revision to Diff 95254.
eugenis retitled this revision from "[asan] Disable ASan global-GC depending on
the target and CGOpts" to "[asan] Disable ASan global-GC depending on the
target and compiler flags".
Repository:
rL LLVM
https://reviews.llvm.org/D32064
Files:
lib/
dexonsmith added reviewers: hfinkel, rsmith.
dexonsmith added a comment.
+Hal and Richard, a couple of possible reviewers.
https://reviews.llvm.org/D31856
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
Author: vedantk
Date: Thu Apr 13 20:59:44 2017
New Revision: 300295
URL: http://llvm.org/viewvc/llvm-project?rev=300295&view=rev
Log:
[docs] UBSan: Mention that print_stacktrace=1 is unsupported on Darwin
Printing out stack traces along with UBSan diagnostics is unsupported on
Darwin. That's beca
Author: rsmith
Date: Thu Apr 13 21:04:44 2017
New Revision: 300296
URL: http://llvm.org/viewvc/llvm-project?rev=300296&view=rev
Log:
Remove empty test directory for nonexistent standard clause.
Removed:
cfe/trunk/test/CXX/garbage.collection/
___
cf
Does anyone know what it would take to get the slow unwinder to work on Darwin?
thanks,
vedant
> On Apr 13, 2017, at 6:59 PM, Vedant Kumar via cfe-commits
> wrote:
>
> Author: vedantk
> Date: Thu Apr 13 20:59:44 2017
> New Revision: 300295
>
> URL: http://llvm.org/viewvc/llvm-project?rev=3002
Author: davidxl
Date: Thu Apr 13 22:01:25 2017
New Revision: 300301
URL: http://llvm.org/viewvc/llvm-project?rev=300301&view=rev
Log:
Remove unused function /nfc
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
URL:
http://llvm.or
Author: chapuni
Date: Thu Apr 13 22:16:48 2017
New Revision: 300303
URL: http://llvm.org/viewvc/llvm-project?rev=300303&view=rev
Log:
clang/test/CoverageMapping/unused_names.c: Relax an expression for targeting
PECOFF.
Modified:
cfe/trunk/test/CoverageMapping/unused_names.c
Modified: cfe/tr
Could you confirm if it is right fix?
On Fri, Apr 14, 2017 at 12:29 PM NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date: Thu Apr 13 22:16:48 2017
> New Revision: 300303
>
> URL: http://llvm.org/viewvc/llvm-project?rev=300303&view=rev
> Log:
> clang/tes
Author: davidxl
Date: Thu Apr 13 23:14:29 2017
New Revision: 300304
URL: http://llvm.org/viewvc/llvm-project?rev=300304&view=rev
Log:
Fix use after free error
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
URL:
http://llvm.org/v
kubamracek reopened this revision.
kubamracek added a comment.
This revision is now accepted and ready to land.
Reverted because this fails for-in.m by crashing the compiler when compiling:
void t2(NSArray *array) {
for (NSArray *array in array) { // expected-warning {{collection expression
hokein updated this revision to Diff 95269.
hokein marked an inline comment as done.
hokein added a comment.
Explicit the type.
https://reviews.llvm.org/D31757
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientVectorOperationCheck.cpp
clang-tidy/performance/In
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the cleanup ;)
Repository:
rL LLVM
https://reviews.llvm.org/D32063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
hokein added inline comments.
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:109-111
+ auto AllVectorVarRefs = utils::decl_ref_expr::allDeclRefExprs(
+ *VectorVarDecl, *LoopParent, *Result.Context);
+ for (const auto *Ref : AllVectorVarRefs) {
-
Author: kzhuravl
Date: Fri Apr 14 00:33:57 2017
New Revision: 300306
URL: http://llvm.org/viewvc/llvm-project?rev=300306&view=rev
Log:
[AMDGPU][GFX9] Set +fp32-denormals for >=gfx900 unless -cl-denorms-are-zero is
set
Differential Revision: https://reviews.llvm.org/D31482
Added:
cfe/trunk/t
This revision was automatically updated to reflect the committed changes.
kzhuravl marked 2 inline comments as done.
Closed by commit rL300306: [AMDGPU][GFX9] Set +fp32-denormals for >=gfx900
unless -cl-denorms-are-zero is… (authored by kzhuravl).
Changed prior to commit:
https://reviews.llvm.o
kzhuravl added inline comments.
Comment at: lib/Basic/Targets.cpp:2114
+ static bool hasFullSpeedFMA(StringRef GPUName) {
+return parseAMDGCNName(GPUName) >= GK_GFX9;
arsenm wrote:
> arsenm wrote:
> > FMAF32?
> Actually this also needs to specify full spee
kubamracek updated this revision to Diff 95271.
kubamracek added a comment.
Trying a different approach: Keeping the loop variable alive for the whole
loop by extending ForScope and registering the cleanup function inside
EmitAutoVarAlloca.
https://reviews.llvm.org/D32029
Files:
lib/CodeGe
rjmccall added a comment.
Those test changes are smaller than I thought they might be; great.
https://reviews.llvm.org/D32029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chenwj added a comment.
Ping? :-)
https://reviews.llvm.org/D32014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xiangzhai updated this revision to Diff 95273.
xiangzhai added a comment.
Hi All,
I have updated my patch as your suggestion, please review it, thanks a lot!
Regards,
Leslie Zhai
Repository:
rL LLVM
https://reviews.llvm.org/D31868
Files:
lib/StaticAnalyzer/Checkers/CStringChecker.cpp
t
101 - 125 of 125 matches
Mail list logo
