[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

NoQ updated this revision to Diff 95082. NoQ added a comment. Remove accidentally added braces in unrelated code. https://reviews.llvm.org/D31982 Files: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp lib/StaticAnalyzer/Core/Store.cpp test/Analysis/explain-svals.cpp test/Analysis/inlini

r300178 - [analyzer] Simplify values in binary operations a bit more aggressively.

Author: dergachev Date: Thu Apr 13 02:20:04 2017 New Revision: 300178 URL: http://llvm.org/viewvc/llvm-project?rev=300178&view=rev Log: [analyzer] Simplify values in binary operations a bit more aggressively. SValBuilder tries to constant-fold symbols in the left-hand side of the symbolic express

[PATCH] D31886: [analyzer] Simplify values in binary operations more aggressively

This revision was automatically updated to reflect the committed changes. Closed by commit rL300178: [analyzer] Simplify values in binary operations a bit more aggressively. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D31886?vs=94955&id=95084#toc Repository: rL

[PATCH] D31167: Use FPContractModeKind universally

mehdi_amini added a comment. I believe considering the goal of moving to using per-instruction FMF and kills the global backend option, this leads to a bitcode upgrade issue: OpenCL (or other) bitcode that were generated bitcode don't have the right FMF and will be upgraded conservatively. Perf

Re: r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

I’m afraid I have to revert this to turn the bots green again. > On Apr 12, 2017, at 10:41 PM, Akira Hatanaka via cfe-commits > wrote: > > I think this broke some of the bots. > > http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/30152/ >

r300181 - Revert "[clang-cl] Make all sanitizer flags available in clang-cl"

Author: ahatanak Date: Thu Apr 13 03:02:29 2017 New Revision: 300181 URL: http://llvm.org/viewvc/llvm-project?rev=300181&view=rev Log: Revert "[clang-cl] Make all sanitizer flags available in clang-cl" This reverts commit 47979b20b475664013d19382fc6875b5b9f3ed9d. This was causing a couple of bot

r300187 - [analyzer] Add numerous assertions to SVal, SymExpr, and MemRegion classes.

Author: dergachev Date: Thu Apr 13 04:48:05 2017 New Revision: 300187 URL: http://llvm.org/viewvc/llvm-project?rev=300187&view=rev Log: [analyzer] Add numerous assertions to SVal, SymExpr, and MemRegion classes. Clean up vtable anchors (remove anchors for regions that have regular out-of-line vir

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300187: [analyzer] Add numerous assertions to SVal, SymExpr, and MemRegion classes. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26837?vs=79538&id=95092#toc Repository:

r300189 - [analyzer] Enforce super-region classes for various memory regions.

Author: dergachev Date: Thu Apr 13 04:56:07 2017 New Revision: 300189 URL: http://llvm.org/viewvc/llvm-project?rev=300189&view=rev Log: [analyzer] Enforce super-region classes for various memory regions. We now check the type of the super-region pointer for most SubRegion classes in compile time;

[PATCH] D26838: [analyzer] Enforce super-region classes for various memory regions through compile-time and run-time type checks.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300189: [analyzer] Enforce super-region classes for various memory regions. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26838?vs=79537&id=95093#toc Repository: rL LLVM

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:975 + if (Op->getOpcode() == UO_AddrOf) +if (Op->getSubExpr()->isLValue()) { + Ex = Op->getSubExpr()->IgnoreParenCasts(); Maybe you could move this

[libcxx] r300191 - Add TEST_NOEXCEPT_FALSE to support D31738

Author: ericwf Date: Thu Apr 13 05:17:23 2017 New Revision: 300191 URL: http://llvm.org/viewvc/llvm-project?rev=300191&view=rev Log: Add TEST_NOEXCEPT_FALSE to support D31738 Modified: libcxx/trunk/test/support/test_macros.h Modified: libcxx/trunk/test/support/test_macros.h URL: http://llvm

[PATCH] D28670: [ObjC] Disallow vector parameters and return values in Objective-C methods on older X86 targets

arphaman updated this revision to Diff 95099. arphaman marked an inline comment as done. arphaman added a comment. Add an assertion as requested by Bruno. Repository: rL LLVM https://reviews.llvm.org/D28670 Files: include/clang/AST/DeclBase.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

NoQ added a comment. This looks correct! Thanks for taking this up. One of the possible improvements for future work here would be to actually bind the second argument value to the buffer instead of just invalidating it. Like, after `memset(buf, 0, sizeof(buf))` the analyzer should know that al

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, Thanks for your review! I will update my patch tomorrow :) Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D31541: [analyzer] MisusedMovedObjectChecker: Add a printState() method.

NoQ added a comment. Hmm, i've been thinking of writing a test for this via `ExprInspection`'s `clang_analyzer_printState()`, however `printState()` functionality is only enabled in debug builds, and i'm not seeing how to enable the test only on debug builds (there's `REQUIRES:` but it only see

[PATCH] D31126: Do not run tests for crash recovery if libstdc++ safe mode is enabled

sepavloff added a comment. The problem solved by the fix is still actual. https://reviews.llvm.org/D31126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25866: [Sema] Support implicit scalar to vector conversions

sdardis updated this revision to Diff 95109. sdardis marked 2 inline comments as done. sdardis added a comment. Addressed review comments. I've highlighted the relevant places with FIXME:s where we don't support GCC vector operations. https://reviews.llvm.org/D25866 Files: include/clang/Basi

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

krasimir added a comment. Seems that we're starting to hit some YAML/JSON mismatches, or is it that your YAML string support is lacking? Repository: rL LLVM https://reviews.llvm.org/D31992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D31992: [clangd] Escape only necessary characters in JSON output

sorry, is it that *our* YAML string support is lacking? On Thu, Apr 13, 2017 at 2:38 PM, Krasimir Georgiev via Phabricator < revi...@reviews.llvm.org> wrote: > krasimir added a comment. > > Seems that we're starting to hit some YAML/JSON mismatches, or is it that > your YAML string support is lac

[PATCH] D32010: [indexer] Record class template specializations using a new 'SpecializationOf' relationship

arphaman created this revision. This patch extends the set of relationships that are recorded by the indexer by adding support for the 'SpecializationOf' relationship. Repository: rL LLVM https://reviews.llvm.org/D32010 Files: include/clang/Index/IndexSymbol.h lib/Index/IndexDecl.cpp

[PATCH] D31562: [coroutines] Fix building of new/delete expressions when get_return_object_on_allocation_failure() is present.

GorNishanov added inline comments. Comment at: lib/Sema/CoroutineBuilder.h:1 +//===- CoroutineBuilder.h - Coroutine Semantic checking -*- C++ -*-===// +// This file is called: CoroutineStmtBuilder.h in trunk Comment at: lib/Sema/Co

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

malaperle-ericsson added a comment. In https://reviews.llvm.org/D31992#725866, @krasimir wrote: > Seems that we're starting to hit some YAML/JSON mismatches, or is it that > your YAML string support is lacking? I don't think so. It seems like JSON and YAML are not completely aligned on escape

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

joerg added a comment. I'm strongly against this patch. Can you give an actual test case for the problematic behavior? Repository: rL LLVM https://reviews.llvm.org/D31992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D31976: Avoid assert when a non-static member function is qualified with __unaligned

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This seems reasonable to me, but you should wait for confirmation before committing (I'm not as familiar with the mangler as others are). Comment at: test/Code

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

malaperle-ericsson added a comment. In https://reviews.llvm.org/D31992#725913, @joerg wrote: > I'm strongly against this patch. Can you give an actual test case for the > problematic behavior? Sure I can add a test. If you meant more real work scenario, you can juste type "é" in VS Code and i

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

klimek added inline comments. Comment at: clangd/Protocol.cpp:26-50 + for (llvm::StringRef::iterator i = Input.begin(), e = Input.end(); i != e; ++i) { +if (*i == '\\') + EscapedInput += ""; +else if (*i == '"') + EscapedInput += "\\\""; +// bell +

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

aaron.ballman added inline comments. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:81 + hasLoopInit(LoopVarInit), + hasCondition(binaryOperator(hasOperatorName("<"), + hasLHS(RefersToLoopVar), ---

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

klimek added a comment. In https://reviews.llvm.org/D31992#725912, @malaperle-ericsson wrote: > In https://reviews.llvm.org/D31992#725866, @krasimir wrote: > > > Seems that we're starting to hit some YAML/JSON mismatches, or is it that > > your YAML string support is lacking? > > > I don't think

[PATCH] D32014: Remove unused varible

chenwj created this revision. Herald added subscribers: rengolin, aemerson. The Result variable is unused both in Sema::CheckARMBuiltinFunctionCall and Sema::CheckAArch64BuiltinFunctionCall, remove it. https://reviews.llvm.org/D32014 Files: lib/Sema/SemaChecking.cpp Index: lib/Sema/SemaChe

[PATCH] D31167: Use FPContractModeKind universally

yaxunl added a comment. In https://reviews.llvm.org/D31167#725705, @mehdi_amini wrote: > I believe considering the goal of moving to using per-instruction FMF and > kills the global backend option, this leads to a bitcode upgrade issue: > OpenCL (or other) bitcode that were generated bitcode do

[libcxx] r300197 - Refactor throw_with_nested. NFC.

Author: marshall Date: Thu Apr 13 09:41:45 2017 New Revision: 300197 URL: http://llvm.org/viewvc/llvm-project?rev=300197&view=rev Log: Refactor throw_with_nested. NFC. Modified: libcxx/trunk/include/exception Modified: libcxx/trunk/include/exception URL: http://llvm.org/viewvc/llvm-project/

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

gtbercea updated this revision to Diff 95126. gtbercea added a comment. Fix. Repository: rL LLVM https://reviews.llvm.org/D29660 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

Hahnfeld added a comment. Is there a way to actually test the changed code? The current test changes seem unrelated... Comment at: include/clang/Basic/DiagnosticDriverKinds.td:165-166 "The target '%0' is not a supported OpenMP host target.">; +def err_drv_omp_device_target_

[PATCH] D32020: [indexer] The relationship between the declarations in template specializations that 'override' declarations in the base template should be recorded

arphaman created this revision. This is useful for "go to definition" feature for an IDE like Xcode. Consider the following example: template struct Traits { using EncodedAs = void; // 1 }; template<> struct Traits { using EncodedAs = int; // 2 }; This change will allow

[PATCH] D32014: Remove unused varible

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good https://reviews.llvm.org/D32014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Yay! This is going to fix some really confusing false positives.LGTM with Gabor's comments addressed. One note. I am not a big fan of using clang_analyzer_explain() in tests for functio

[PATCH] D31860: Add more examples to clang tidy checkers

alexfh added inline comments. Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15 + + void a(int /*i*/) {} + sylvestre.ledru wrote: > alexfh wrote: > > nit: two spaces before the comment. > I believe it is the case ? > I stole this from the unit t

[PATCH] D25157: [compiler-rt] [cmake] Respect COMPILER_RT_BUILD_* for libs, headers and tests

mgorny abandoned this revision. mgorny added a comment. https://reviews.llvm.org/D31864 covered all that was needed for Gentoo, and I lack the knowledge to push the full split properly forward. https://reviews.llvm.org/D25157 ___ cfe-commits mailin

[libcxx] r300206 - [libc++] Explicitly set output directory for DLL

Author: smeenai Date: Thu Apr 13 11:27:38 2017 New Revision: 300206 URL: http://llvm.org/viewvc/llvm-project?rev=300206&view=rev Log: [libc++] Explicitly set output directory for DLL DLLs on Windows are treated as runtime targets. Explicitly set the output directory for them, to be consistent wit

r300209 - Re-land "[clang-cl] Make all sanitizer flags available in clang-cl"

Author: rnk Date: Thu Apr 13 11:32:26 2017 New Revision: 300209 URL: http://llvm.org/viewvc/llvm-project?rev=300209&view=rev Log: Re-land "[clang-cl] Make all sanitizer flags available in clang-cl" Adding RUN lines with %clang_cl was causing these tests to fail on Mac because absolute paths there

r300214 - Use the clang-cl recognized spelling of --target=

Author: rnk Date: Thu Apr 13 11:36:28 2017 New Revision: 300214 URL: http://llvm.org/viewvc/llvm-project?rev=300214&view=rev Log: Use the clang-cl recognized spelling of --target= This fixes a warning. The test was passing without this change. Modified: cfe/trunk/test/Driver/fsanitize.c Mod

Re: r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

Fixed in r300209. Was the -Wslash-u-filename warning not explanatory enough to suggest the solution? Maybe we could add a note like "escape source paths starting with /U by passing them at the end of the command line after --". /Users/buildslave/jenkins/sharedspace/phase1@2/llvm/tools/clang/test/D

[PATCH] D31982: [analyzer] Improve suppression for inlined defensive checks when operator& is involved.

zaks.anna added a comment. Thanks!!! Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:965 + +// Performing operator `&' on an lvalue expression is essentially a no-op. +// Then, if we are taking addresses of fields or elements, these are also

[libcxx] r300218 - Implement LWG#2855 - made easy by previous refactoring

Author: marshall Date: Thu Apr 13 11:57:42 2017 New Revision: 300218 URL: http://llvm.org/viewvc/llvm-project?rev=300218&view=rev Log: Implement LWG#2855 - made easy by previous refactoring Modified: libcxx/trunk/include/exception libcxx/trunk/test/std/language.support/support.exception/

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

kubamracek created this revision. kubamracek added a project: Sanitizers. CodeGenFunction::EmitObjCForCollectionStmt currently emits lifetime markers for the loop variable in an inconsistent way: `lifetime.start` is emitted before the loop is entered, but `lifetime.end` is emitted inside the lo

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

jacobly added a comment. Ping. https://reviews.llvm.org/D27263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300223 - clang-format-vs: Use a separate license.txt copy

Author: hans Date: Thu Apr 13 12:37:17 2017 New Revision: 300223 URL: http://llvm.org/viewvc/llvm-project?rev=300223&view=rev Log: clang-format-vs: Use a separate license.txt copy The regular file used to display very poorly in the VSIX installer due to long lines, wrapping etc. Added: cfe/t

r300225 - Warning-free clang-format plugin install for VS 15.0

Author: hans Date: Thu Apr 13 12:42:45 2017 New Revision: 300225 URL: http://llvm.org/viewvc/llvm-project?rev=300225&view=rev Log: Warning-free clang-format plugin install for VS 15.0 With the new release of VS, it's required that all plugins migrate to the new VSIX manifest format. The new forma

r300226 - Follow-up to r300225: update ClangFormat.sln to VS2017

Author: hans Date: Thu Apr 13 12:47:47 2017 New Revision: 300226 URL: http://llvm.org/viewvc/llvm-project?rev=300226&view=rev Log: Follow-up to r300225: update ClangFormat.sln to VS2017 This got lost in the previous patch somehow. Modified: cfe/trunk/tools/clang-format-vs/ClangFormat.sln Mo

[PATCH] D29658: [OpenMP] Customize CUDA-based tool chain selection

gtbercea updated this revision to Diff 95171. gtbercea added a comment. Remove tests which belong into a different patch. Repository: rL LLVM https://reviews.llvm.org/D29658 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

gtbercea created this revision. Herald added a subscriber: rengolin. Throw an error when offloading is unsupported for a particular target architecture. Repository: rL LLVM https://reviews.llvm.org/D32035 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Frontend/CompilerInvocatio

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein updated this revision to Diff 95174. hokein marked 11 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D31757 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/InefficientVectorOperationCheck.cpp clang-tidy/perform

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

hokein added a comment. Thanks for the comments. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:81 + hasLoopInit(LoopVarInit), + hasCondition(binaryOperator(hasOperatorName("<"), + hasLHS(RefersToLoo

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 95175. gtbercea added a comment. Use the rename() utility function of LLVM for renaming the PTXAS output before invoking NVLINK. Repository: rL LLVM https://reviews.llvm.org/D29654 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D25383: [libcxx][modules] Add a submodule for math.h

bruno abandoned this revision. bruno added a comment. This isn't needed anymore. https://reviews.llvm.org/D25383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea marked 4 inline comments as done. gtbercea added inline comments. Comment at: test/Driver/openmp-offload.c:594 +/// Check cubin file generation and usage by nvlink +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -no-canonical-pref

r300231 - Follow-up to r300225: update ClangFormat.csproj too

Author: hans Date: Thu Apr 13 13:15:00 2017 New Revision: 300231 URL: http://llvm.org/viewvc/llvm-project?rev=300231&view=rev Log: Follow-up to r300225: update ClangFormat.csproj too Modified: cfe/trunk/tools/clang-format-vs/ClangFormat/ClangFormat.csproj Modified: cfe/trunk/tools/clang-form

[PATCH] D31717: CodeGen: Let lifetime intrinsic use alloca address space

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGenOpenCL/lifetime.cl:14 +// AMDGIZ: @llvm.lifetime.start.p5i + helper_no_markers(); +} Check line for the end as well? https://

[libcxx] r300232 - Remove the binders from C++17. Reviewed as https://reviews.llvm.org/D31769

Author: marshall Date: Thu Apr 13 13:25:32 2017 New Revision: 300232 URL: http://llvm.org/viewvc/llvm-project?rev=300232&view=rev Log: Remove the binders from C++17. Reviewed as https://reviews.llvm.org/D31769 Added: libcxx/trunk/test/libcxx/depr/depr.function.objects/ libcxx/trunk/test/l

[PATCH] D31769: Remove the binders `bind1st`, `bind2nd`, `men_fun`, etc from C++17

mclow.lists closed this revision. mclow.lists added a comment. committed as revision 300232 https://reviews.llvm.org/D31769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29001: [Modules] Fallback to building the module if a timeout occurs

bruno closed this revision. bruno added a comment. Updating: already done in r298175 https://reviews.llvm.org/D29001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

joerg added a comment. In https://reviews.llvm.org/D31992#725963, @klimek wrote: > If I understand correctly, that's " and \ for JSON and ", \ and all > non-printable characters (which unfortunately requires understanding of > unicode to solve this fully correctly) in YAML. I'd modify that sl

Re: r300122 - [clang-cl] Make all sanitizer flags available in clang-cl

> On Apr 13, 2017, at 9:50 AM, Reid Kleckner wrote: > > Fixed in r300209. Was the -Wslash-u-filename warning not explanatory enough > to suggest the solution? Maybe we could add a note like "escape source paths > starting with /U by passing them at the end of the command line after —". Ah, I

[PATCH] D13117: [DarwinDriver] Use -lto_library to specify the path for libLTO.dylib

bruno closed this revision. bruno added a comment. Done way back in r248932 Repository: rL LLVM https://reviews.llvm.org/D13117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27429: [Chrono][Darwin] On Darwin use CLOCK_UPTIME_RAW instead of CLOCK_MONOTONIC

bruno closed this revision. bruno added a comment. r291466 & r291517 https://reviews.llvm.org/D27429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27546: [ASTReader] Sort RawComments before merging

bruno closed this revision. bruno added a comment. Done in r290134 https://reviews.llvm.org/D27546 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

bruno added a comment. @rsmith ping! https://reviews.llvm.org/D31778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27546: [ASTReader] Sort RawComments before merging

rsmith added inline comments. Comment at: lib/Serialization/ASTReader.cpp:8487 +std::sort(Comments.begin(), Comments.end(), + BeforeThanCompare(SourceMgr)); Context.Comments.addDeserializedComments(Comments); Does this cause us to deserializ

r300245 - clang-format-vs licence.txt: drop svn:executable

Author: hans Date: Thu Apr 13 15:09:18 2017 New Revision: 300245 URL: http://llvm.org/viewvc/llvm-project?rev=300245&view=rev Log: clang-format-vs licence.txt: drop svn:executable Not sure how it ended up with that property in the first place. Modified: cfe/trunk/tools/clang-format-vs/ClangF

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

smeenai updated this revision to Diff 95189. smeenai added a comment. Add documentation https://reviews.llvm.org/D31725 Files: docs/UsingLibcxx.rst include/__config Index: include/__config === --- include/__config +++ include

[libcxx] r300246 - [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

Author: smeenai Date: Thu Apr 13 15:13:32 2017 New Revision: 300246 URL: http://llvm.org/viewvc/llvm-project?rev=300246&view=rev Log: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option When the libc++ extern template macros were added, the intent was for it to be possible for consumers of

[PATCH] D31725: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

This revision was automatically updated to reflect the committed changes. Closed by commit rL300246: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D31725?vs=95189&id=95190#toc Repository: rL LLVM https://r

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

erichkeane abandoned this revision. erichkeane added a comment. I don't really see a good solution for this, and haven't tried in a while, so I'll see if I can prep another version of this in the future. https://reviews.llvm.org/D29401 ___ cfe-comm

[PATCH] D32035: [OpenMP] Error when trying to offload to an unsupported architecture

gtbercea updated this revision to Diff 95198. gtbercea added a comment. Re-use an already existing flag rather than creating a new one. Repository: rL LLVM https://reviews.llvm.org/D32035 Files: lib/Frontend/CompilerInvocation.cpp test/OpenMP/target_messages.cpp Index: test/OpenMP/targ

[PATCH] D32043: [Driver] Load all necessary default sanitizer blacklists

vsk created this revision. This patch removes a limitation which causes us to load at most one default sanitizer blacklist when multiple sanitizers are enabled. E.g if asan + cfi are enabled, and default blacklists for both sanitizers are present, we would only load one of the blacklists. The new

[PATCH] D31757: [clang-tidy] Add a clang-tidy check for possible inefficient vector operations

aaron.ballman added inline comments. Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:95-96 +const MatchFinder::MatchResult &Result) { + if (Result.Context->getDiagnostics().hasUncompilableErrorOccurred()) +return; + hokein wrote: >

[PATCH] D32047: [Driver] Add support for default UBSan blacklists

vsk created this revision. Clang should look for a default UBSan blacklist in its resource dir. Depends on https://reviews.llvm.org/D32043. https://reviews.llvm.org/D32047 Files: lib/Driver/SanitizerArgs.cpp test/Driver/Inputs/resource_dir/ubsan_blacklist.txt test/Driver/fsanitize-blackl

[PATCH] D30837: [libcxx] Support for shared_ptr

erik.pilkington updated this revision to Diff 95210. erik.pilkington added a comment. This new patch includes @EricWF's static_assert & test. Thanks, Erik https://reviews.llvm.org/D30837 Files: include/memory test/libcxx/utilities/memory/util.smartptr/util.smartptr.shared/function_type_def

[PATCH] D30837: [libcxx] Support for shared_ptr

erik.pilkington added inline comments. Comment at: include/memory:3606 +template <> +class _LIBCPP_TEMPLATE_VIS allocator<__shared_ptr_dummy_rebind_allocator_type> +{ EricWF wrote: > I would prefer using an entirely different allocator type, not a > specializati

[PATCH] D31591: Fix a bug which access nullptr and cause segmentation fault

v.g.vassilev accepted this revision. v.g.vassilev added a comment. LGTM. https://reviews.llvm.org/D31591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300257 - [CMake] Support building Fuchsia toolchain on Darwin

Author: phosek Date: Thu Apr 13 16:09:42 2017 New Revision: 300257 URL: http://llvm.org/viewvc/llvm-project?rev=300257&view=rev Log: [CMake] Support building Fuchsia toolchain on Darwin This is already supported on Linux but on Darwin it requires some extra flags. Differential Revision: https://

[libcxx] r300261 - [libcxx] Direct support for Fuchsia

Author: phosek Date: Thu Apr 13 16:29:21 2017 New Revision: 300261 URL: http://llvm.org/viewvc/llvm-project?rev=300261&view=rev Log: [libcxx] Direct support for Fuchsia Fuchsia's libc was forked from musl, but has evolved sufficiently since then so it no longer makes sense to pretend it's musl. T

[PATCH] D31885: Remove TBAA information from LValues representing union members

kparzysz updated this revision to Diff 95217. kparzysz edited the summary of this revision. kparzysz added a reviewer: hfinkel. kparzysz added a comment. Fixed the testcases (forgot to use FileCheck). Repository: rL LLVM https://reviews.llvm.org/D31885 Files: lib/CodeGen/CGExpr.cpp lib/C

r300262 - PR32185: Revert r291512 and add a testcase for PR32185.

Author: rsmith Date: Thu Apr 13 16:37:24 2017 New Revision: 300262 URL: http://llvm.org/viewvc/llvm-project?rev=300262&view=rev Log: PR32185: Revert r291512 and add a testcase for PR32185. This reverts an attempt to check that types match when matching a dependently-typed non-type template parame

[PATCH] D32014: Remove unused varible

chenwj added a comment. I don't have commit access, need someone's help. :-) https://reviews.llvm.org/D32014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r300264 - Diagnose attempt to take address of bitfield members in anonymous structs.

Author: rsmith Date: Thu Apr 13 16:49:46 2017 New Revision: 300264 URL: http://llvm.org/viewvc/llvm-project?rev=300264&view=rev Log: Diagnose attempt to take address of bitfield members in anonymous structs. Patch by Jacob Young! Differential Revision: https://reviews.llvm.org/D27263 Modified:

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300264: Diagnose attempt to take address of bitfield members in anonymous structs. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D27263?vs=79759&id=95222#toc Repository: rL

r300266 - Add test for anonymous struct containing an implicitly private data member.

Author: rsmith Date: Thu Apr 13 16:51:04 2017 New Revision: 300266 URL: http://llvm.org/viewvc/llvm-project?rev=300266&view=rev Log: Add test for anonymous struct containing an implicitly private data member. Patch by Jacob Young! Modified: cfe/trunk/test/SemaCXX/anonymous-struct.cpp Modifi

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

rsmith added a comment. The change to test/SemaCXX/anonymous-struct.cpp appeared to be unrelated to the rest of the patch, so I committed it separately as r300266. Thank you! Repository: rL LLVM https://reviews.llvm.org/D27263 ___ cfe-commits m

r300270 - [docs] Fix a couple of typos in command line flag help text and regenerate documentation.

Author: rsmith Date: Thu Apr 13 17:39:49 2017 New Revision: 300270 URL: http://llvm.org/viewvc/llvm-project?rev=300270&view=rev Log: [docs] Fix a couple of typos in command line flag help text and regenerate documentation. Modified: cfe/trunk/docs/ClangCommandLineReference.rst cfe/trunk/

r300271 - [docs] Regenerate diagnostics reference.

Author: rsmith Date: Thu Apr 13 17:44:22 2017 New Revision: 300271 URL: http://llvm.org/viewvc/llvm-project?rev=300271&view=rev Log: [docs] Regenerate diagnostics reference. Modified: cfe/trunk/docs/DiagnosticsReference.rst Modified: cfe/trunk/docs/DiagnosticsReference.rst URL: http://llvm.

r300272 - [IR] Make getParamAttributes take argument numbers, not ArgNo+1

Author: rnk Date: Thu Apr 13 18:12:13 2017 New Revision: 300272 URL: http://llvm.org/viewvc/llvm-project?rev=300272&view=rev Log: [IR] Make getParamAttributes take argument numbers, not ArgNo+1 Add hasParamAttribute() and use it instead of hasAttribute(ArgNo+1, Kind) everywhere. The fact that th

[PATCH] D32063: [clang-move] cleanup: create ClangMoveActionFactory on the stack

alexshap created this revision. alexshap created this object with visibility "All Users". This diff removes unnecessary using of unique_ptr with ClangMoveActionFactory (pico cleanup). NFC Repository: rL LLVM https://reviews.llvm.org/D32063 Files: tool/ClangMoveMain.cpp Index: tool/Clang

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

kubamracek added a comment. Note that C++ foreach loops also generate lifetime.start and lifetime.end inside of the loop body. Repository: rL LLVM https://reviews.llvm.org/D32029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

eugenis created this revision. The linux part is a bit ahead of time - the instrumentation code where this matters have not landed yet. But when it does, this would be the right condition, and for now ELF instrumentation simply ignores this setting. Repository: rL LLVM https://reviews.llvm.

r300279 - [Profile] PE binary coverage bug fix

Author: davidxl Date: Thu Apr 13 18:37:21 2017 New Revision: 300279 URL: http://llvm.org/viewvc/llvm-project?rev=300279&view=rev Log: [Profile] PE binary coverage bug fix PR/32584 Differential Revision: https://reviews.llvm.org/D32023 Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and CGOpts

eugenis added a comment. From a quick look at the code, it seems like -fno-data-sections on COFF would suppress GC of globals the same as on ELF. Is that true? Repository: rL LLVM https://reviews.llvm.org/D32064 ___ cfe-commits mailing list cfe-

[PATCH] D32029: [ObjC] Fix lifetime markers of loop variable in EmitObjCForCollectionStmt

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, looks good to me. Repository: rL LLVM https://reviews.llvm.org/D32029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

r300283 - Fix PR31934: forming refs to functions with enable_if attrs.

Author: gbiv Date: Thu Apr 13 18:47:08 2017 New Revision: 300283 URL: http://llvm.org/viewvc/llvm-project?rev=300283&view=rev Log: Fix PR31934: forming refs to functions with enable_if attrs. Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/SemaCXX/enable_if.cpp Modified: cfe/tru

  1   2   >