r299983 - [ExternalASTMerger] Removed a move constructor to address MSVC build failure

2017-04-11 Thread Sean Callanan via cfe-commits
Author: spyffe Date: Tue Apr 11 15:51:21 2017 New Revision: 299983 URL: http://llvm.org/viewvc/llvm-project?rev=299983&view=rev Log: [ExternalASTMerger] Removed a move constructor to address MSVC build failure Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: cfe/trunk/lib/AST/Exte

r299987 - Modular Codegen: Support homing debug info for types in modular objects

2017-04-11 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Tue Apr 11 16:13:37 2017 New Revision: 299987 URL: http://llvm.org/viewvc/llvm-project?rev=299987&view=rev Log: Modular Codegen: Support homing debug info for types in modular objects Matching the function-homing support for modular codegen. Any type implicitly (implicit te

r299989 - [ODRHash] Improve handling of hash values

2017-04-11 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Tue Apr 11 16:31:00 2017 New Revision: 299989 URL: http://llvm.org/viewvc/llvm-project?rev=299989&view=rev Log: [ODRHash] Improve handling of hash values Calculating the hash in Sema::ActOnTagFinishDefinition could happen before all sub-Decls were parsed or processed, which w

r299992 - [Sema][ObjC] Check whether a variable has a definition, rather than

2017-04-11 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Tue Apr 11 17:01:33 2017 New Revision: 22 URL: http://llvm.org/viewvc/llvm-project?rev=22&view=rev Log: [Sema][ObjC] Check whether a variable has a definition, rather than checking its storage class, when determining whether casting a C pointer to an ObjC pointer is

[PATCH] D31673: Allow casting C pointers declared using extern "C" to ObjC pointer types

2017-04-11 Thread Akira Hatanaka via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL22: [Sema][ObjC] Check whether a variable has a definition, rather than (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D31673?vs=94686&id=94899#toc Repository: rL LLVM

[PATCH] D7573: [libc++] Fix PR20084 - std::is_function failed.

2017-04-11 Thread Eric Niebler via Phabricator via cfe-commits
eric_niebler added a comment. I just ran into this problem while trying to get range-v3 working on clang-3.6. This `is_function` implementation //probably// instantiates fewer templates than the version currently shipping with libc++. Disclaimer: I haven't tested it exhaustively yet. templat

r300001 - Revert r298824 & r298816, recommit r298742 & r298754

2017-04-11 Thread Richard Trieu via cfe-commits
Author: rtrieu Date: Tue Apr 11 17:32:03 2017 New Revision: 31 URL: http://llvm.org/viewvc/llvm-project?rev=31&view=rev Log: Revert r298824 & r298816, recommit r298742 & r298754 r299989 fixes the underlying issue by waiting long enough to late parsed arguments to be processed before doing

Re: r298816 - Revert 298754 and 298742.

2017-04-11 Thread Richard Trieu via cfe-commits
r299989 should prevent the build breakages. I have recommited my changes in r31. On Sun, Mar 26, 2017 at 11:32 AM, Vassil Vassilev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vvassilev > Date: Sun Mar 26 13:32:53 2017 > New Revision: 298816 > > URL: http://llvm.org/viewvc/

Re: r298824 - Revert r298742 "[ODRHash] Add error messages for mismatched parameters in methods."

2017-04-11 Thread Richard Trieu via cfe-commits
r299989 should prevent the build breakages. I have recommited my changes in r31. On Sun, Mar 26, 2017 at 2:39 PM, Vassil Vassilev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vvassilev > Date: Sun Mar 26 16:39:16 2017 > New Revision: 298824 > > URL: http://llvm.org/viewvc/l

r300006 - Silence unused variable warning in release builds.

2017-04-11 Thread Benjamin Kramer via cfe-commits
Author: d0k Date: Tue Apr 11 18:06:49 2017 New Revision: 36 URL: http://llvm.org/viewvc/llvm-project?rev=36&view=rev Log: Silence unused variable warning in release builds. Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp URL: http:

[libcxx] r300009 - Add some FAIL constexpr tests for optional's copy/move ctors.

2017-04-11 Thread Marshall Clow via cfe-commits
Author: marshall Date: Tue Apr 11 19:07:29 2017 New Revision: 39 URL: http://llvm.org/viewvc/llvm-project?rev=39&view=rev Log: Add some FAIL constexpr tests for optional's copy/move ctors. Added: libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/copy.fail.

[PATCH] D31839: make -Winteger-overflow find overflows in function arguments

2017-04-11 Thread Nick Lewycky via Phabricator via cfe-commits
nlewycky added a comment. In https://reviews.llvm.org/D31839#722763, @ahatanak wrote: > Is it possible to fix ObjCMessageExpr too while you are in here? I looked into this, but it turns out to be different enough to belong in a separate patch. An ObjCMessageExpr has void type which means that

[PATCH] D31966: [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp.

2017-04-11 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Avoid Clang's -Wunused-const-variable in is_constructible.pass.cpp. This happens when using Clang with MSVC's STL, so there are no actual uses of this variable. https://reviews.llvm.org/D31966 Files: test/std/utilities/meta/meta.unary/meta.un

r300014 - [IR] Add AttributeSet to hide AttributeSetNode* again, NFC

2017-04-11 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Apr 11 19:38:00 2017 New Revision: 300014 URL: http://llvm.org/viewvc/llvm-project?rev=300014&view=rev Log: [IR] Add AttributeSet to hide AttributeSetNode* again, NFC Summary: For now, it just wraps AttributeSetNode*. Eventually, it will hold AvailableAttrs as an inline bits

Re: r300001 - Revert r298824 & r298816, recommit r298742 & r298754

2017-04-11 Thread Richard Smith via cfe-commits
Either this or your other ODR hash change seems to have broken the modules buildbot: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/6274/steps/compile.llvm.stage2/logs/stdio On 11 April 2017 at 15:32, Richard Trieu via cfe-commits < cfe-commits@lists.llvm.org> wrot

[libunwind] r300020 - Reland "[CMake][libunwind] Use -nodefaultlibs for CMake checks"

2017-04-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Tue Apr 11 21:28:07 2017 New Revision: 300020 URL: http://llvm.org/viewvc/llvm-project?rev=300020&view=rev Log: Reland "[CMake][libunwind] Use -nodefaultlibs for CMake checks" This is a reland of commit r299796. Turned out that we need gcc_s or compiler-rt on ARM when checki

r300021 - Serialization: Skip check in WritePragmaDiagnosticMappings, NFC

2017-04-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Apr 11 21:31:17 2017 New Revision: 300021 URL: http://llvm.org/viewvc/llvm-project?rev=300021&view=rev Log: Serialization: Skip check in WritePragmaDiagnosticMappings, NFC The record is never empty, since we always serialize the initial state. Skip the check. Modifie

r300024 - Serialization: Emit the final diagnostic state last, almost NFC

2017-04-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Apr 11 22:45:32 2017 New Revision: 300024 URL: http://llvm.org/viewvc/llvm-project?rev=300024&view=rev Log: Serialization: Emit the final diagnostic state last, almost NFC Emit the final diagnostic state last to match source order. This also prepares for a follow-up

r300025 - Serialization: Simulate -Werror settings in implicit modules

2017-04-11 Thread Duncan P. N. Exon Smith via cfe-commits
Author: dexonsmith Date: Tue Apr 11 22:58:58 2017 New Revision: 300025 URL: http://llvm.org/viewvc/llvm-project?rev=300025&view=rev Log: Serialization: Simulate -Werror settings in implicit modules r293123 started serializing diagnostic pragma state for modules. This makes the serialization work

[PATCH] D30954: Modules: Simulate diagnostic settings for implicit modules

2017-04-11 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith closed this revision. dexonsmith marked an inline comment as done. dexonsmith added a comment. And committed in: r297770 c0c27f3 Modules: Optimize bitcode encoding of diagnostic state r300021 5e5be8e Serialization: Skip check in WritePragmaDiagnosticMappings, NFC r300024 91f051f Seriali

[PATCH] D31839: make -Winteger-overflow find overflows in function arguments

2017-04-11 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. OK, thanks for looking into it. Warnings for ObjCMessageExpr can probably be implemented in a separate patch. It looks like clang still doesn't issue overflow warnings when the called functions have a void return. Should we try to fix it in this patch too? void foo(

r300027 - [Modules] Remove darwin specific code to check for SystemVersion.plist

2017-04-11 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Tue Apr 11 23:49:00 2017 New Revision: 300027 URL: http://llvm.org/viewvc/llvm-project?rev=300027&view=rev Log: [Modules] Remove darwin specific code to check for SystemVersion.plist This isn't need anymore and modules options -fbuild-session-file and -fmodules-validate-once-p

[PATCH] D31839: make -Winteger-overflow find overflows in function arguments

2017-04-11 Thread Nick Lewycky via Phabricator via cfe-commits
nlewycky added a comment. In https://reviews.llvm.org/D31839#724551, @ahatanak wrote: > OK, thanks for looking into it. Warnings for ObjCMessageExpr can probably be > implemented in a separate patch. > > It looks like clang still doesn't issue overflow warnings when the called > functions have

<    1   2