[PATCH] D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver.

gtbercea updated this revision to Diff 93559. gtbercea added a comment. Change prefix name in test. Repository: rL LLVM https://reviews.llvm.org/D29644 Files: lib/Driver/ToolChains/Cuda.cpp test/Driver/openmp-offload.c Index: test/Driver/openmp-offload.c ===

r299127 - fixup: use CHECK for non-atttribute sets

Author: dberris Date: Thu Mar 30 17:46:49 2017 New Revision: 299127 URL: http://llvm.org/viewvc/llvm-project?rev=299127&view=rev Log: fixup: use CHECK for non-atttribute sets Modified: cfe/trunk/test/CodeGen/xray-instruction-threshold.cpp Modified: cfe/trunk/test/CodeGen/xray-instruction-thr

r299126 - [XRay][clang] Fix the -fxray-instruction-threshold flag processing

Author: dberris Date: Thu Mar 30 17:46:45 2017 New Revision: 299126 URL: http://llvm.org/viewvc/llvm-project?rev=299126&view=rev Log: [XRay][clang] Fix the -fxray-instruction-threshold flag processing Summary: The refactoring introduced a regression in the flag processing for -fxray-instruction-t

[PATCH] D31491: [XRay][clang] Fix the -fxray-instruction-threshold flag processing

dberris added inline comments. Comment at: test/CodeGen/xray-instruction-threshold.cpp:11 + +// CHECK-DAG: define i32 @_Z3foov() #[[THRESHOLD:[0-9]+]] { +// CHECK-DAG: define i32 @_Z3barv() #[[NEVERATTR:[0-9]+]] { rnk wrote: > Any reason to use -DAG on the decls?

[PATCH] D31491: [XRay][clang] Fix the -fxray-instruction-threshold flag processing

This revision was automatically updated to reflect the committed changes. dberris marked an inline comment as done. Closed by commit rL299126: [XRay][clang] Fix the -fxray-instruction-threshold flag processing (authored by dberris). Changed prior to commit: https://reviews.llvm.org/D31491?vs=93

[PATCH] D31502: [libc++abi] Delete config.h

smeenai added a comment. In https://reviews.llvm.org/D31502#714341, @EricWF wrote: > Thanks. I'm surprised this wasn't done earlier. I removed the `unistd.h` include this morning (r299087 ), which is what made the file empty. https://reviews.llvm.org/D31502

[libcxxabi] r299129 - [libc++abi] Delete config.h

Author: smeenai Date: Thu Mar 30 18:31:33 2017 New Revision: 299129 URL: http://llvm.org/viewvc/llvm-project?rev=299129&view=rev Log: [libc++abi] Delete config.h Summary: It's now completely empty, so we can remove it entirely. Reviewers: mclow.lists, EricWF Subscribers: cfe-commits Differenti

[PATCH] D31502: [libc++abi] Delete config.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL299129: [libc++abi] Delete config.h (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D31502?vs=93496&id=93565#toc Repository: rL LLVM https://reviews.llvm.org/D31502 Files:

[PATCH] D31508: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D31508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D31518: Try to fix the libcxx build with mingw64

rnk created this revision. Herald added a subscriber: mgorny. mingw64 has lots of default libs that libc++ and its test programs should link against. With this patch, cmake now runs successfully with GCC on Windows. https://reviews.llvm.org/D31518 Files: libcxx/cmake/config-ix.cmake Index:

[PATCH] D31518: Try to fix the libcxx build with mingw64

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. CMake's behavior here is unfortunate but this seems like a reasonable workaround. https://reviews.llvm.org/D31518 ___ cfe-commits mailing

[libcxxabi] r299143 - [libc++abi] Remove missed use of config.h

Author: smeenai Date: Thu Mar 30 19:29:25 2017 New Revision: 299143 URL: http://llvm.org/viewvc/llvm-project?rev=299143&view=rev Log: [libc++abi] Remove missed use of config.h Modified: libcxxabi/trunk/src/cxa_noexception.cpp Modified: libcxxabi/trunk/src/cxa_noexception.cpp URL: http://llv

[libcxx] r299144 - Try to fix the libcxx build with mingw64

Author: rnk Date: Thu Mar 30 19:34:05 2017 New Revision: 299144 URL: http://llvm.org/viewvc/llvm-project?rev=299144&view=rev Log: Try to fix the libcxx build with mingw64 Summary: mingw64 has lots of default libs that libc++ and its test programs should link against. With this patch, cmake now r

[PATCH] D31518: Try to fix the libcxx build with mingw64

This revision was automatically updated to reflect the committed changes. Closed by commit rL299144: Try to fix the libcxx build with mingw64 (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D31518?vs=93568&id=93570#toc Repository: rL LLVM https://reviews.llvm.org/D31518

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good to me Comment at: lib/Sema/SemaDecl.cpp:6710-6711 + + // Return false if warning is ignored. + if (Diags.isIgnored(diag::warn_decl_shadow, R.getNameLoc())) +re

RE: [clang-tools-extra] r299119 - [clang-tidy] Reuse FileID in getLocation

Hi, this change seems to be causing the test clang-tidy/llvm-include-order.cpp to fail with a crash on the PS4 Windows bot: (From http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/7487) TEST 'Clang Tools :: clang-tidy/llvm-include-ord

Re: [clang-tools-extra] r299119 - [clang-tidy] Reuse FileID in getLocation

I don't know why this test failed only on Windows, but will revert my change soon. On Thu, Mar 30, 2017 at 6:07 PM, Yung, Douglas wrote: > Hi, this change seems to be causing the test clang-tidy/llvm-include-order.cpp > to fail with a crash on the PS4 Windows bot: > > (From http://lab.llvm.org:

[clang-tools-extra] r299146 - [clang-tidy] Revert D31406 (Reuse FileID in getLocation)

Author: chh Date: Thu Mar 30 20:11:11 2017 New Revision: 299146 URL: http://llvm.org/viewvc/llvm-project?rev=299146&view=rev Log: [clang-tidy] Revert D31406 (Reuse FileID in getLocation) Somehow the change failed test clang-tidy/llvm-include-order.cpp on Windows platform. Differential Revision:

r299148 - Fix typo, defind -> defined.

Author: echristo Date: Thu Mar 30 20:45:39 2017 New Revision: 299148 URL: http://llvm.org/viewvc/llvm-project?rev=299148&view=rev Log: Fix typo, defind -> defined. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/include/clang/B

r299151 - Update x86-64 ABI link with the one from linuxbase.org since the other

Author: echristo Date: Thu Mar 30 20:59:40 2017 New Revision: 299151 URL: http://llvm.org/viewvc/llvm-project?rev=299151&view=rev Log: Update x86-64 ABI link with the one from linuxbase.org since the other seems to be down. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h Modified: cfe/t

r299152 - [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends

Author: tejohnson Date: Thu Mar 30 21:05:15 2017 New Revision: 299152 URL: http://llvm.org/viewvc/llvm-project?rev=299152&view=rev Log: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends Summary: This involved refactoring out pieces of EmitAssemblyHelper::CreateTargetMachine fo

[PATCH] D31508: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends

This revision was automatically updated to reflect the committed changes. Closed by commit rL299152: [ThinLTO] Set up lto::Config properly for codegen in ThinLTO backends (authored by tejohnson). Changed prior to commit: https://reviews.llvm.org/D31508?vs=93536&id=93577#toc Repository: rL LL

r299170 - Add triple to new test

Author: tejohnson Date: Thu Mar 30 21:36:47 2017 New Revision: 299170 URL: http://llvm.org/viewvc/llvm-project?rev=299170&view=rev Log: Add triple to new test Attempt to fix bot errors from r299152 by using clang_cc1 and specifying target triple to compile step. Modified: cfe/trunk/test/Code

r299173 - Fix new compile command in test

Author: tejohnson Date: Thu Mar 30 21:55:31 2017 New Revision: 299173 URL: http://llvm.org/viewvc/llvm-project?rev=299173&view=rev Log: Fix new compile command in test My previous attempt to fix bot failures from r299152 didn't add the necessary option to get bitcode out of the cc1 step. Modifie

r299174 - [asan] Turn -fsanitize-address-use-after-scope on by default [clang part]

Author: kuba.brecka Date: Thu Mar 30 22:00:09 2017 New Revision: 299174 URL: http://llvm.org/viewvc/llvm-project?rev=299174&view=rev Log: [asan] Turn -fsanitize-address-use-after-scope on by default [clang part] AddressSanitizer has an optional compile-time flag, -fsanitize-address-use-after-sco

r299176 - Add more target triples to test

Author: tejohnson Date: Thu Mar 30 22:27:47 2017 New Revision: 299176 URL: http://llvm.org/viewvc/llvm-project?rev=299176&view=rev Log: Add more target triples to test Third and hopefully final fix to test for r299152 that is causing bot failures: make sure the target triple specified for the Thi

r299178 - Add target-cpu

Author: tejohnson Date: Thu Mar 30 22:49:52 2017 New Revision: 299178 URL: http://llvm.org/viewvc/llvm-project?rev=299178&view=rev Log: Add target-cpu Sigh, another follow-on fix needed for test in r299152 causing bot failures. We also need the target-cpu for the ThinLTO BE clang invocation. Mod

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

ahmedasadi added a comment. Thanks for reviewing. Would you be able to commit this patch for me, as I do not have commit access? https://reviews.llvm.org/D31235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D31235: Enhance -Wshadow to warn when shadowing typedefs or type aliases

ahmedasadi updated this revision to Diff 93583. ahmedasadi marked an inline comment as done. ahmedasadi added a comment. Re-ordered the checks in shouldWarnIfShadowedDecl as suggested by rnk. https://reviews.llvm.org/D31235 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sem

r299181 - Revert test added in r299152

Author: tejohnson Date: Thu Mar 30 23:29:07 2017 New Revision: 299181 URL: http://llvm.org/viewvc/llvm-project?rev=299181&view=rev Log: Revert test added in r299152 Removing the test until I can figure out how to get the ThinLTO backend invocation of clang to use the correct target. Modified:

[PATCH] D31404: [OpenCL] Allow alloca return non-zero private pointer

yaxunl added a comment. In https://reviews.llvm.org/D31404#714244, @Anastasia wrote: > I can't see clearly why the alloca has to be extended to accommodate the > address space too? Couldn't the address space for alloca just be taken > directly from the data layout? > > In fact is seems from th

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc updated this revision to Diff 93587. ddcc marked 4 inline comments as done. ddcc added a comment. Use direct bitcasting instead of string conversion for APFloat casting, add reference counting for Z3_sort, eliminate some duplicate code https://reviews.llvm.org/D28952 Files: CMakeLists.t

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. Thanks for the feedback! My main constraint is that the results from the floating-point analysis weren't very interesting (see #652894 <#652894>), so I'm not actively working on further development. > FYI I've been working on floating point support in KLEE and have extende

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc updated this revision to Diff 93588. ddcc added a comment. Fix erroneous comment https://reviews.llvm.org/D28952 Files: CMakeLists.txt cmake/modules/FindZ3.cmake include/clang/Config/config.h.cmake include/clang/StaticAnalyzer/Core/Analyses.def include/clang/StaticAnalyzer/Core/P

[PATCH] D28953: [analyzer] Eliminate analyzer limitations on symbolic constraint generation

ddcc updated this revision to Diff 93589. ddcc added a comment. Rebase https://reviews.llvm.org/D28953 Files: include/clang/StaticAnalyzer/Checkers/SValExplainer.h lib/StaticAnalyzer/Core/SValBuilder.cpp lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp test/Analysis/bitwise-ops.c test/An

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

ddcc updated this revision to Diff 93590. ddcc added a comment. Rebase, update tests, fix bugs https://reviews.llvm.org/D28954 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnalyzer/Core/Pat

[PATCH] D28955: [analyzer] Enable support for symbolic extension/truncation

ddcc updated this revision to Diff 93591. ddcc added a comment. Rebase https://reviews.llvm.org/D28955 Files: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h lib/StaticAnalyzer/Checkers/BoolAssignmentChecker

[PATCH] D29642: [OpenMP] Make OpenMP generated code for the NVIDIA device relocatable by default

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM after fixing the check-prefix Comment at: test/Driver/openmp-offload.c:595 +// RUN: %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda -save-temps -

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru added a comment. Daniel, wdyt? :) https://reviews.llvm.org/D31408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver.

Hahnfeld added a comment. Just noticed that this isn't specific to OpenMP. Could you move the test to `Driver/cuda-external-tools.cu` where the rest of `ptxas` is tested? Repository: rL LLVM https://reviews.llvm.org/D29644 ___ cfe-commits mailin

[PATCH] D31408: Add more examples to clang-format configuration

djasper added a comment. Generally please upload diffs with more contexts. For some here it's not even clear to which option they refer ;) Comment at: docs/ClangFormatStyleOptions.rst:941 + ContinuationIndentWidth: 2 + ColumnLimit: 15 + You could force

<    1   2